- 11 Apr, 2018 40 commits
-
-
https://skia.googlesource.com/skia.git/+log/1eeeae0491ba..ff7fa50f0c95 $ git log 1eeeae049..ff7fa50f0 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 egdaniel Add ctor to GrVkImageInfo. 2018-04-10 liyuqian Merge drawDevice and respect ctm for the paint 2018-04-10 mtklein skcms→dff16bc express ApproximateCurve error in input units 2018-04-10 csmartdalton ccpr: Clip quadratic hulls more efficiently 2018-04-10 mtklein allow rolling from anywhere 2018-04-10 jvanverth Add initial support for simple concave shadows. 2018-04-10 mtklein skcms→9ff49a5 use GaussNewton for 7-parameter approx 2018-04-06 liyuqian Do not use CTM for drawDevice or drawSprite 2018-04-10 csmartdalton ccpr: Improve CPU checks for collinear points 2018-04-10 csmartdalton ccpr: Remove fCurrAnchorPoint from GrCCGeometry 2018-04-10 mtklein give skcms rolls a helpful commit msg 2018-04-08 update-skps Update SKP version 2018-04-10 robertphillips Remove extra Vulkan submitCommandBuffer from deleteTestingOnlyBackendTexture 2018-04-10 mtklein hard-roll skcms into Skia 2018-04-10 egdaniel Update getBackendInfo calls on GrBackendTexture to support VkImageLayout better. 2018-04-10 caryclark one more path is rect bug 2018-04-09 caryclark fix path to rect when missing close verb 2018-04-09 benjaminwagner Omit skbug6653 on internal device. 2018-04-09 brianosman Remove SkDEBUGFAIL for non-invertible XYZ matrix 2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 6c59e4a15..0ce016c1b (2 commits) 2018-04-06 reed identify interesting cubic points Created with: roll-dep src/third_party/skia BUG=chromium:824145,chromium:824145,chromium:819192 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: If3760ced34d61fa366b7363a499b2fe04a8a450a Reviewed-on: https://chromium-review.googlesource.com/1005807Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549839}
-
Henrik Lundin authored
These two new histograms are calculated inside of WebRTC. Both relate to the packet-loss concealment that happens when audio packets are lost or late for decoding, and the jitter buffer (NetEq) must resort to extrapolating audio from the previously decoded data. Bug: webrtc:9126 Change-Id: Id3f9362974e4fc4dc1c141f8fddb56ba1e98376d Reviewed-on: https://chromium-review.googlesource.com/1002172Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Henrik Lundin <hlundin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549838}
-
Hans Wennborg authored
Official builds remove the strings passed to CHECKs, causing the expected string to not show up and breaking this test. Removing the expectation strings to unbreak the test for now. As Nico commented on https://crrev.com/c/999481 perhaps a better fix would be to not use a death test at all. TBR=jdoerrie Bug: 831494 Change-Id: Ic9e2ca4cfe4f5f05d47c00fb4727ea37d6fadcfc Reviewed-on: https://chromium-review.googlesource.com/1006582Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#549837}
-
David 'Digit' Turner authored
This CL performs a little cleanup of the content of third_party/android_platform/development/scripts/: - Add ToolPath() and GetAaptPath() methods to pylib.constants.host_paths, and remove the old versions from symbol.py, adjusting all callers. Note that ToolPath() now takes a second argument to specify the target CPU architecture, instead of relying on a hidden global variable. + Add new unit-test (host_paths_unittest.py). - Remove a few unused global variables in symbol.py, and document the few remaining one (especially that they are liberally modified from elsewhere!). Also make a few functions private by adding an underscore prefix to them. Remove Uname() which was completely unused. Remove FindToolchain() since its result was completely ignored. Add an optional cpu_arch parameter to SymbolInformationForSet(), and make asan_symbolize.py, its only user, pass a corresponding argument. - Cleanup asan_symbolize.py a little, and add an optional command-line argument --arch=ARCH to specify the target CPU architecture (default is 'arm', as in the previous implementation). - Remove CallCppFilt() from symbol.py and rewrite it directly into tools/cygprofile/symbol_extractor.py, its only user. Also run the unit tests correctly. BUG=NONE R=agrieve@chromium.org,lizeb@chromium.org,egeunis@chromium.org Change-Id: If172662461a2047d7485eedd4658149283fd1ca7 Reviewed-on: https://chromium-review.googlesource.com/1004635Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#549836}
-
Dean Liao authored
Data member output_mode_ is initialized in V4L2VideoDecodeAccelerator::Initialize(). However, SetupFormats(), which accesses output_mode_, is called before the assignment. The fix is trivial: initialize output_mode_ before calling SetupFormats(). BUG=b:73327993 TEST=run video_decode_accelerator_unittest /usr/local/autotest/deps/chrome_test/test_src/out/Release/video_decode_accelerator_unittest \ --test_video_data=/usr/local/autotest/deps/chrome_test/test_src/\ media/test/data/test-25fps.vp8:320:240:250:250:35:150:11 \ --thumbnail_output_dir=/usr/local/autotest/results/default/video_VideoDecodeAccelerator/results \ --ozone-platform=gbm \ --rendering_fps=0 Change-Id: Ib8afeb4e37aeb35213d6487ec233583f22f594f5 Reviewed-on: https://chromium-review.googlesource.com/1002348Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#549835}
-
Alan Cutter authored
This CL enables the following keyboard shortcuts for hosted app windows: - Shift-Alt-T: Focus window frame toolbar buttons - Alt-E and Alt-F: Open app menu - F6: Cycle focus between frame buttons and web contents. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=330498&signed_aid=BFJfbOWHFSLjA4dEetB3SA==&inline=1 Bug: 822146 Change-Id: Ieb00735dc92c914cb2eb2022bdbd7d72e9c3b603 Reviewed-on: https://chromium-review.googlesource.com/977521 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#549834}
-
Eric Seckler authored
Some tests are flaky, let's see if this helps. Bug: 830823 Change-Id: I48f0c8284ee8f94518bb4cc4c955fae3edddcdf4 TBR: alexclarke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1005006Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#549833}
-
Eliot Courtney authored
BUG=b/72806943 Change-Id: I6326cc8806984264011b807456fa45164f59d187 Reviewed-on: https://chromium-review.googlesource.com/956667 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#549832}
-
Yoshifumi Inoue authored
This patch changes "4922367.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "4922367.html" to "delete_paragraph_before_table.html" to provide a hint what this file tests. Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia151ea3c821e63784f374b8d74db60208c11a7ae Reviewed-on: https://chromium-review.googlesource.com/1004885Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549831}
-
Yue Li authored
Currently WebDialogDelegate cannot hide the dialog title by setting ShouldShowDialogTitle. Bug: 828574 Test: Local Build Change-Id: I2d9abc21ef108ccd97dc4667c2d4b311f6ec3501 Reviewed-on: https://chromium-review.googlesource.com/993756Reviewed-by:
-
John Z Wu authored
Change-Id: I2cdbd0e9d721f7f2326f0d59b994607a45c96c4d Reviewed-on: https://chromium-review.googlesource.com/1005722 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549829}
-
Morten Stenshorne authored
Make sure everything fits in the screenshot (we were essentially testing only half of the test), and corrected a pass condition: In some of the tests a vertical gap is expected between the float and the block with 'clear'. However, it should be 20px, not 30px. The height of the float is 30px. The margin-top in front of the block with 'clear' is 50px. So the margin is 20px taller than the float. Change-Id: Ie182061a219a323ba2c674243d0be8b41236bb20 Reviewed-on: https://chromium-review.googlesource.com/1005182Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#549828}
-
Jun Choi authored
Add support for register/sign with CTAP2.0 tokens behind a feature flag. Bug: 780078 Change-Id: I3b0fe7ce2eaf48304300e4fed5d722cd5f87c6da Reviewed-on: https://chromium-review.googlesource.com/974796 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549827}
-
Koji Ishii authored
This patch implements LayoutNG inline fragment support for InspectorCSSAgent::CollectPlatformFontsForLayoutObject(). This function is used for Inspector to show rendered fonts. Also some font fallback tests rely on this mechanism. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7e43fe1b50eef831fb77f6e4a4b2dc59b34569e9 Reviewed-on: https://chromium-review.googlesource.com/1003016Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#549826}
-
James Darpinian authored
UnmapBufferHelper assumed that the mapped buffer was still bound to the same binding point that it was first bound to, which isn't guaranteed. This fixes the WebGL conformance test transform_feedback/switching-objects.html Bug: 696345 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia06b8e3b2b4a7a7f1a38c4bcdb241a039dc36a80 Reviewed-on: https://chromium-review.googlesource.com/998845 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549825}
-
https://chromium.googlesource.com/catapult.git/+log/2c59f678c7ed..a22719853354 $ git log 2c59f678c..a22719853 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 tiborg [vr] Increase VR Response UE to 1s Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I3183053fe518d238b1105805932b7e4218bcd674 Reviewed-on: https://chromium-review.googlesource.com/1006040Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549824}
-
Alexandr Ilin authored
This CL implements the CheckPlatformHandlePermissionsCorrespondToMode() function on Windows. There is no documented API to get the current access mask on a handle. To understand whether a handle has write access, we check the success status of the ::DuplicateHandle(dwDesiredAccess=FILE_MAP_WRITE) call. Bug: 825177 Change-Id: I6863e9ead390972601539c23f6e12674ee3b7736 Reviewed-on: https://chromium-review.googlesource.com/1005343Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL changes the search button, modifying the icon and adding a light grey background. Bug: 829769 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibeb8537cf1e6cf817668a528266d6dbfdcfa552e Reviewed-on: https://chromium-review.googlesource.com/1005064Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#549822}
-
Alexei Filippov authored
Change-Id: I15f5cc61fb956d2be00887eccad96af09c441a44 Reviewed-on: https://chromium-review.googlesource.com/1003833 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549821}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/871e7778ef8b..a6818c5b704d $ git log 871e7778e..a6818c5b7 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 mikenichols Removing git retry logic 2018-04-09 mortonm Adjust tester for debugfs-access group. Created with: roll-dep src/third_party/chromite BUG=chromium:825370,chromium:649417 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I29f963f82c2e6af780e4eab40e528b3f960c75b1 Reviewed-on: https://chromium-review.googlesource.com/1006477Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549820}
-
A Olsen authored
Bug: 829329 Change-Id: Ib76b6c80c1a2e1966d916d0a684d1ebecf0b0656 Reviewed-on: https://chromium-review.googlesource.com/1000857 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#549819}
-
Dmitry Skiba authored
This CL overhauls the way memory pressure is sensed and reported for the browser process. Main changes are: * ActivityManager.getMyMemoryStat() is used to poll pressure. * Pressure signals are throttled. * CRITICAL->MODERATE pressure changes are always reported. See MemoryPressureMonitor.java comments for details. Bug: 813909 Change-Id: I6fb5395b175cf8ca4ac40fac021125dd9d7fbc9f Reviewed-on: https://chromium-review.googlesource.com/953166 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/4027887ee29a..6bebd2e3cfb7 $ git log 4027887ee..6bebd2e3c --date=short --no-merges --format='%ad %ae %s' 2018-04-11 hnakashima Avoid stack overflow when loading CPDF_Function. 2018-04-10 thestig Add static_asserts for FX_RECT and FX_COLORREF. 2018-04-10 thestig Load CIDToGIDMap stream for CID fonts if it exists. 2018-04-10 rharrison Roll DEPS for Clang and build 2018-04-10 rharrison Add an assert to make sure all code is included in static lib 2018-04-10 thestig Remove CFX_Rect. 2018-04-10 thestig Change CFX_RenderDevice::FillRect() to take FX_RECT by const-ref. 2018-04-10 thestig Change FillRectWithBlend methods to take FX_RECT by const-ref. 2018-04-10 hnakashima Implement CPDFSDK_XFAWidgetHandler::OnKillFocus. 2018-04-10 hnakashima Break down CXFA_FFWidget::On{L|R}ButtonDown() into two steps. Created with: roll-dep src/third_party/pdfium BUG=chromium:830221,chromium:813705,chromium:820256,chromium:820256 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iae9f069e452471eac037e59354fa106060058af5 Reviewed-on: https://chromium-review.googlesource.com/1005962Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549817}
-
wutao authored
This cl makes the internal app configurable in the launcher search result. 1. For each app, we can provide additional searchable text for search query. 2. The app can be configured to be shown as a suggested app (Settings) or not (KSH). Bug: 824437 Test: manual Change-Id: Ib6db4eff415ac6be1ee319b9bcf545bb84eff39b Reviewed-on: https://chromium-review.googlesource.com/1000839 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549816}
-
Mohamed Amir Yosef authored
Before this CL: Data are loaded in ClientTagBasedModelTypeProcessor on startup. Data are kept in memory until they are committed which can never happen (if the client is offline for example). After this CL: Only metadata are loaded at startup, and only after the Sync engine asks for local changes, data are loaded in memory. As a result, GetLocalChanges method in the processor is called asynchronously because the required data are not necessarily available in memory. Bug: 740757 Change-Id: I8a11ddc0c8136775f0075697ba6b8ee3975685fa Reviewed-on: https://chromium-review.googlesource.com/825562 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#549815}
-
Donna Wu authored
This CL: 1) Introduces 2 Mojo interfaces: device::mojom::MtpManager and device::mojom::MtpManagerClient. The current implementation just forwards MTP device access requests to the existing MediaTransferProtocolManager.. 2) Makes Device Service expose the above 2 Mojo interfaces. 3) Create stubs to connect these 2 interfaces with the main user, storage_monitor::StorageMonitor. More Mojo methods will be added to MtpManager and all users will be converted to use Mojo interfaces in subsequent CLs. BUG=769630 Change-Id: Ibfffb2a45d13014ec3984ae9e242f49492e8b16a Reviewed-on: https://chromium-review.googlesource.com/972668 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#549814}
-
Jay Civelli authored
Initializing the media library entails getting information about the CPU for the libyuv and ffmep libraries. Retrieving that information might access the file system (/cpu/procinfo). The extension handler code would initialize the media library before the sandbox is turned on. As part of the effort to move process launching to the service manager where the service process is always sandboxed, this CL adds a new InitializeMediaLibraryInSandbox method that lets callers specify the CPU info so the initialization can be done inside the sandbox. The client library of the media gallery util service which was the reason why extension handlers would need to initialize the media library, now do it explicitly and provide the CPU info. As a result, extension handlers related files can be removed. Bug: 823931 Change-Id: Ie1630f3ff04c94901224750ffdea4423bd1b3186 Reviewed-on: https://chromium-review.googlesource.com/966925Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#549813}
-
Christopher Lam authored
This CL makes all buttons in the title bar separated by 8px. It also hides the BrowserActionsContainer when no actions are showing, and forces the AppMenuButton to be 24x24. Bug: 814535 Change-Id: Ibfa3a87d8889f36b9e4c969f6b263d1cd48e05e5 Reviewed-on: https://chromium-review.googlesource.com/994933 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549812}
-
Wenzhao Zang authored
Create mojo API and move the tests in 'wallpaper_private_api_unittest.cc' to //ash, because: 1) They're only testing wallpaper_window_state_manager. 2) We want to remove //ash dependency in chrome wallpaper code. (IIUC)|MultiUserWindowManagerChromeOS| under //chrome is responsible for tracking the window ownership under multi-profile session. The wallpaper_window_state_manager is only checking if the window is visible. So if we move the tests to //ash, they only need to test that the minimize/restore functions are no-op for invisible windows. Why the windows are visible/invisible is beyond its scope. Bug: 827062 Test: --enable-features=Mash Change-Id: Ib7573e8911a6979f598f85cbb0b059be1c77b389 Reviewed-on: https://chromium-review.googlesource.com/967885 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
-
KongQun Yang authored
This helps diagnose playback problems, like jittering, stalls, which are often caused by dropped frames. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6c835a6e40b94d1a36824e182bcb9aff71d9502b Reviewed-on: https://chromium-review.googlesource.com/994283 Commit-Queue: Kongqun Yang <kqyang@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549810}
-
jdoerrie authored
This change removes a GCC 4.8 work around the lack of std::vector::erase(const_iterator) from base::flat_tree. Bug: 682254, 677044 Change-Id: I8bd13851baa58c8cecd64c02c50bd999357afac4 Reviewed-on: https://chromium-review.googlesource.com/1005074Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#549809}
-
jdoerrie authored
This change implements base::as_bytes(base::span), base::as_writable_bytes(base::span) and base::span::size_bytes() as specified in the C++20 draft [1, 2]. As opposed to the standard as_bytes() and as_writable_bytes() return spans of uint8_t due to the lack of std::byte in C++14. [1] http://eel.is/c++draft/views.span#span.obs-itemdecl:2 [2] http://eel.is/c++draft/views.span#span.objectrep Bug: 828324 Change-Id: Ie7c4e759e81caa6dfb2b3583b36dc8923a430b55 Reviewed-on: https://chromium-review.googlesource.com/1004956Reviewed-by:
-
Christopher Cameron authored
Add methods on RWHNSViewClient to call into the static speech methods of TextServicesContextMenu. Add a call to RWHNSViewClient to query if there exists a RenderViewHost for the current view's RenderWidgetHost, since that query is the only piece left missing to allow -[RWHVCocoa validateUserInterfaceItem] to not depend on RWHVMac. Make RWHVCocoa query the BrowserAccessibilityManager via the RHWNSViewClient interface, to eliminate another source of direct calls into RWHVMac. This is explicitly temporary, as we will need to come up with an accessibility solution for the AppShim process. Bug: 821651 Change-Id: I568ed06a0bcbc0384702f494e06238fa635139e4 Reviewed-on: https://chromium-review.googlesource.com/1004444Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#549807}
-
Ramin Halavati authored
The initial path is set for SelectFileDialogImpl::RunOpenMultiFileDialog. Bug: 831097 Change-Id: I0de503f148efc8cda2677c907e78b8da6ce09101 Reviewed-on: https://chromium-review.googlesource.com/1005079 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#549806}
-
Mohamed Amir Yosef authored
Currently, entities are tracked in a map inside the ModelTypeWorker. This is a left over from the old arch. before introducing the poll model between the worker and the processor. The main motivation for this refactoring is the map is currently keyed by the client tag hash which bookmarks lack. After this CL, the map will be keyed on server ids to support all types of entities. And since the map is now used only when receiving remote updates, all entities should have sever ids. This is also in prepartion for migrating bookmarks. Bug: 516866 Change-Id: I1e8c8c7073a53e0c67b0da2551a20e2d4db93cb1 Reviewed-on: https://chromium-review.googlesource.com/982620 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549805}
-
Paul Dyson authored
Call the adaptive screen brightness manager from chrome_browser_main_chromeos.cc. Bug: 820883 Change-Id: I687bcba364a3f6a6fe3e5685288052e815e8c489 Reviewed-on: https://chromium-review.googlesource.com/967965 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549804}
-
https://chromium.googlesource.com/angle/angle.git/+log/4416247c9d91..568fc39ba45a $ git log 4416247c9..568fc39ba --date=short --no-merges --format='%ad %ae %s' 2018-04-09 lfy GLES1: glMultMatrix(f|x) 2018-04-09 lfy GLES1: glLoadIdentity / glLoadMatrix(f|x) 2018-04-10 jmadill D3D11: Add more debug names. 2018-04-10 ynovikov Skip RobustResourceInitTestES3.MaskedStencilClearBuffer on Mac NVIDIA. 2018-04-05 lucferron Vulkan: 3 Final bugfixes to enable all dEQP depth_stencil tests 2018-04-10 lucferron Vulkan: PointSprite suppress 3 tests that are failing the android tests Created with: roll-dep src/third_party/angle BUG=chromium:None The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I471db60f449d20cb42af870d525aa2295538c080 Reviewed-on: https://chromium-review.googlesource.com/1006514Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549803}
-
Sidney San Martín authored
There are two paths which lead to dragging a Mac app's window around: - The slow path is initiated by the app: some hit testing happens on mouse down, and something (most often the frame view) calls `[self.window performWindowDragWithEvent:theEvent]` to start server-side dragging. - The fast path involves the window submitting a map of draggable regions to the window server. A `mouseDown:` in those regions starts a drag without waiting for the app. AppKit uses both: it traverses the view hierarchy and reads the `mouseDownCanMoveWindow` property of each view (which defaults to NO if the view `isOpaque` and YES otherwise), and submits a map based on the views' frames. However, a view may still override `-hitTest:` to punt some events (say, if it's not rectangular, like a Chrome tab). If the title bar gets the event, it starts a drag on the slow path. This means that, if an app is hung, dragging still works, you just can't start drags from the transparent parts of non-rectangular views. One more complication: views that underlap the title bar in a window with a full size content view, even if the title bar is hidden, only cut a hole in the drag map if they override `-mouseDown:` *and* return YES for `acceptsFirstResponder`. That was an issue because `BridgedContentView` returns YES only if it's already first responder, so dragging was unpredictable. This change: - …makes BridgedContentView return nil when `-hitTest:` is passed a spot that should be draggable. The event ends up at the frame view, which could result in a drag or in a double-click miniaturizing or zooming the window. - …deals with the "one more complication" by overriding `-_copyDragRegion` in BrowserWindowFrame to return nil, which effectively opts the window out of the fast path. - …adds a custom frame view class for frameless app windows which uses `-[NSWindow performWindowDragWithEvent:]` (and an old undocumented version on 10.10) to start a drag on `mouseDown:`, because the `movableByWindowBackground` property on windows seems to only affect "fast path" dragging. Bug: 823770, 826477 Change-Id: I9b7d727776d45853d1160b4cec53baf678e70d93 Reviewed-on: https://chromium-review.googlesource.com/1000212Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549802}
-
Koji Ishii authored
Following bot results are included. 4700 4703 4704 4710 4715 4717 4724 4726 4730 4 lines were removed and 2 lines were deflaked by consecutive results since 4653. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I76fe9fd649b346f61a05e5d76c3913096d03cffd Reviewed-on: https://chromium-review.googlesource.com/1004878 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549801}
-
wutao authored
The Shortcuts window is not centered in screen when there is no context. This cl fix this bug. Bug: 831323 Test: KeyboardShortcutViewTest.CenterWindowInScreen Change-Id: I968450240ce2f69edc607a16aad1f48760138559 Reviewed-on: https://chromium-review.googlesource.com/1006066Reviewed-by:
-
