GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a2437c0a..22a88d89

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id026bb796349ecfddf061e53b0c7ebadb393c8d1
Reviewed-on: https://chromium-review.googlesource.com/1147937Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577481}

from the codebase, now that we're using Manifest::ImageResource instead.

Bug: 860507
Change-Id: Ie8ac76ebe4e4ed1ab8a6b6a090dbf05b28d17f5c
TBR: peter
Reviewed-on: https://chromium-review.googlesource.com/1146656
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577480}

https://webrtc.googlesource.com/src.git/+log/dcff0bd78e26..25cc8ad19873


git log dcff0bd78e26..25cc8ad19873 --date=short --no-merges --format='%ad %ae %s'
2018-07-24 david@porter.me Fixed issue with BGRA RTCCVPixelBuffer scale and crop


Created with:
  gclient setdep -r src/third_party/webrtc@25cc8ad19873

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic681b4f800d4634e1e9bbe1117764deee5ed3147
Reviewed-on: https://chromium-review.googlesource.com/1147902Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577479}

It will be enabled again after the next import.

Bug: 866802
Change-Id: Id2f4198b7699be1bdf185758401fdb74413a1f21
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1148208Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577478}

When signed out:
  - personalized section should be collapsed
  - non-personalized should be expanded

When signed-in with no consent given:
  - personalized section should be expanded
  - non-personalized should be expanded

When signed-in with consent given:
  - personalized section should be collapsed
  - non-personalized should be collapsed

Bug: 849838, 863860
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4fa468253606c431684d0c8b19bcf4548dcf4ad7
Reviewed-on: https://chromium-review.googlesource.com/1133171
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577477}

Chrome's SQLite currently uses permissive (0644) POSIX access controls
for newly created databases, and //sql offers a method for opting into
restrictive (0600) permissions. This method is only used by the login
database. However, all Chrome databases are likely to have private data.
For example, the cookies database may contain long-lived OAuth tokens,
and can be just as valuable as the login database. The same argument
applies for the DOMStorage database.

This CL configures SQLite to use restrictive permissions by default, and
removes the method for opting into the restrictive permissions.

Change-Id: I5f0ce9e7f038081fad515cfc30c45ccccf7ff1b6
Reviewed-on: https://chromium-review.googlesource.com/1146295Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577476}

Before this CL, all the methods in sync_service.h seemed to be in a
totally arbitrary order. This CL attempts to reorder them to be grouped
in a logical way, and also updates some comments that were out of date.
No functional changes.

Bug: 865936
Change-Id: Ief7c8e8ac6f4eff0e1002dae54df1e96b5e7e00b
Reviewed-on: https://chromium-review.googlesource.com/1146646
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577475}

and add_cleanup

BUG=836871

Change-Id: I175e53f3466719403e5d61a68dc7125bf547e36e
Reviewed-on: https://chromium-review.googlesource.com/1140789
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577474}

Encryption options is placed last in the "Sync and personalization"
section to match the mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr664Bt8FBOxWEdg35-B8FaW0

Bug: 864751
Change-Id: I406708e8ea9e02e27a45f62ad9ca1ba67f7d3a36
Reviewed-on: https://chromium-review.googlesource.com/1146757Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577473}

Bug: webrtc:8366
Change-Id: Ieaa4bf30132708570ac76c0957248c1dbb22a611
Reviewed-on: https://chromium-review.googlesource.com/1146922Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Artem Titov <titovartem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577472}

CertVerifyProcInternalTest.EVVerificationMultipleOID uses a certificate
from trustcenter.websecurity.symantec.com, but the test fails with the
upcoming Symantec Legacy PKI distrust. This replaces the test
certificate with another that has the 2.23.140.1.1 OID before
2.16.840.1.113733.1.7.23.6 in X509v3 Certificate Policies extension.

Bug: 705285, 796230
Change-Id: I0ed5d50d727a712d7c38babdb9ecfdfd30d50cc5
Reviewed-on: https://chromium-review.googlesource.com/1147665
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577471}

After this CL, we can use ComPtr as the |this| pointer of base::BindOnce
and base::BindRepeating.

ComPtr doesn't have `operator*` nor `operator->*` that are needed to run
a method pointer. So we need a special handling for it to use it as a
receiver on base::Bind.

We currently use scoped_refptr to store COM instance on base::Bind, which
happens to work, but that looks fragile. This CL is a preparation to
convert these scoped_refptr to ComPtr.

Change-Id: I1fe31e23ac627050860fe2c81ead6807a17bb939
Reviewed-on: https://chromium-review.googlesource.com/1145153
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577470}

This CL changes the system of slots registration in HeapCompaction.
As preparing for HeapCompaction with IncrementalMarking, we change a timing of the registration on HashMap that related to slots, from during tracing to during atomic pause.
So, we add HashSet that registeres traced slots.

Bug: 864425
Change-Id: Ia63c36abbf160dfea115ebd6c6953c499d895770
Reviewed-on: https://chromium-review.googlesource.com/1145144Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Haruka Matsumura <harukamt@google.com>
Cr-Commit-Position: refs/heads/master@{#577469}

The direction is used if instead of the password generation we trigger the
standard password drop-down.

Bug: 865469
Change-Id: I3da15c0446753e69f84d352c7095c40d571030ce
Reviewed-on: https://chromium-review.googlesource.com/1145300Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577468}

While working on GaiaCookieManagerService, I noticed that
SigninClient::AddCookieChangeCallback() is unnecessary to call out to
the embedder for: the only embedder-specific parameterization of the
//components-level SigninCookieChangeSubscription is for the
URLRequestContextGetter, which is already available to the component
via SigninClient::GetURLRequestContext().

This CL eliminates that client method in favor of having
GaiaCookieManagerService construct SigninCookieChangeSubscription
directly. I verified that all production clients were supplying the same
URLRequestContextGetter that they return in their implementation of
SigninClient::GetURLRequestContext().

TBR=jzw@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic8a9d0c6e3e63cf531408eb6ab46db65bcf3e668
Reviewed-on: https://chromium-review.googlesource.com/1145312
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577467}

BUG=836871

Change-Id: I16e2419717601e3bb89e83df720eee31cc631edc
Reviewed-on: https://chromium-review.googlesource.com/1140781
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577466}

dbus::ObjectManager's reference count is zero at the beginning of its
constructor, and used to be incremented at base::Bind there implicitly.
However, if PostTaskAndReplyWithResult there failed, the reference
is gone and the reference count gets to 0 again. And as the result,
`new ObjectManager` may return a stale pointer.

This CL adds a static constructor to ObjectManager, and moves the
ref count manipulation part out from the constructor.

Bug: 866456
Change-Id: I5dd8947a5087359005cbcb75e1bb2a0a42ebeda8
Reviewed-on: https://chromium-review.googlesource.com/1148037
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577465}

There was very similar code, make it the same function.

This patch tries to maintain the same behavior as previous to minimize
changes.

Detailed changelog:
  - Move |need_to_update|. The point of this upfront was to choose whether
    to "unblock" association on early return. In the need_to_update case,
    we know we call an async function, so didn't want to unblock.
    It's easier to always to unblock upfront, and block before the async
    functions. RAII would improve this, but avoided that to minimize the
    diff.
  - Remove |status| from TRACE when it's already guaranteed to be kOk.
  - Previously we avoided calling AssociateRegistration until after
    trying to make the active worker transition ACTIVATING -> ACTIVATED.
    There shouldn't be a need for that: once there's an active worker,
    the provider host should "use" the registration. But to minimize the
    diff, I've maintained this old behavior. When the callback fires,
    we unassociate there if something failed.

Change-Id: I0d8a9bea5f516a42002ecb7e236a8f1e9eced678
Reviewed-on: https://chromium-review.googlesource.com/1143092
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577464}

This CL updates BoxLayout to avoid clipping the main axis alignment
point when there isn't enough main axis space.

This means for:
 - left aligned layouts the right most children will be clipped first
   (existing behaviour).
 - center aligned layouts the left and right most children will be
   clipped first.
 - right aligned layouts the left most children will be clipped first.
Where previously the right most children were always clipped first
regardless of the main axis alignment position.

This fixes hosted app titlebar icons such that they clip from the
left instead of clipping out the app menu button first.

Analysis of existing alignment use cases here:
https://bugs.chromium.org/p/chromium/issues/detail?id=862045#c3

Before:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=347613&signed_aid=Nst_-68AwDajlir_GX00cQ==&inline=1
After:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=349265&signed_aid=RgUQgRr8Udaf6_WsZG31ig==&inline=1

Bug: 862045
Change-Id: I073cadced4d9b9172f9c803506c2faadd11683ca
Reviewed-on: https://chromium-review.googlesource.com/1143115
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577463}

Bug: 866370
Test: PIP window no longer has top portion cut off
Change-Id: I6a4415162fd2697b49866bbe8698d306315fe074
Reviewed-on: https://chromium-review.googlesource.com/1146524
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577462}

We don't use ServiceWorkerContextRequestHandler
when S13nServiceWorker is enabled.

Bug: 860361
Change-Id: Ib0e73f84b0e014d652941e1d8b3292fc32005149
Reviewed-on: https://chromium-review.googlesource.com/1146138Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577461}

The spell-check toggle is updated to be a
settings-toggle-button because there is no link anymore
in the toggle description.

This also fixes the issue that the toggle didn't actually
turn on spellcheck when it was switched to on.

Bug: 857136
Change-Id: I8389bbc5a1d02b0cc849fa18494c4b09e0b3bc47
Reviewed-on: https://chromium-review.googlesource.com/1146571Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577460}

We don't get much out of this being a function.

TBR=blakeo@chromium.org

Change-Id: If29f63899374d91ab67ab91c9068d31eb0f82a3e
Reviewed-on: https://chromium-review.googlesource.com/1148096Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577459}

ServiceWorkerURLRequestJob is non-S13nServiceWorker specific
class and we don't use it when S13nServiceWorker is enabled.

This CL explicitly disable S13nServiceWorker in
ServiceWorkerURLRequestJobTest.

Bug: 860361
Change-Id: I9432b773b02cdee13ab877395f3d3ed3d5839c87
Reviewed-on: https://chromium-review.googlesource.com/1147897
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577458}

BUG=836871

Change-Id: Idd0495f538777469043fec30993f5e9399d62c68
Reviewed-on: https://chromium-review.googlesource.com/1140676Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#577457}

NotificationManager::SendNotifications takes an argument
|bounds_affect_layout|, but it's unclear from the name what type of
bounds it is. The sole caller of SendNotifications uses occluded bounds,
so we assume that that's the intention.

(occluded) |bounds_affect_layout| is used to determine what the
displaced bounds are. Our naming change exposes a "bug": if the
occluded bounds affect layout, we set the displaced bounds to the
visual bounds. This is not right; we should be using the occluded
bounds. This makes sense, because for future features like fullscreen
handwriting where the visual bounds fill the entire screen, we should
only displace what is actually occluded.

TBR=blakeo@chromium.org

Change-Id: Ie6a9d04294cba5b4bf23009f9300698e2946079f
Reviewed-on: https://chromium-review.googlesource.com/1146526Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577456}

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/?limit=200
The tests have been failing for a long time

TBR: hajimehoshi@chromium.org
Bug: 866785
Change-Id: Ia884e0aca4fcbb2c8ab47f38cf5ea48c2f22538f
Reviewed-on: https://chromium-review.googlesource.com/1148081Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577455}

They were accidentally messed up when copying
AudioInputController->audio::InputController.

Bug: 866452
Change-Id: I75eff9fae05bb510d3c5111bb2dad33dff422e1b
Reviewed-on: https://chromium-review.googlesource.com/1146732Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577454}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0f6c4505..a2437c0a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I32ce66b8d22258fdf98ca44913e2ea423cfb96a9
Reviewed-on: https://chromium-review.googlesource.com/1147925Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577453}

https://chromium.googlesource.com/catapult.git/+log/2edae10bfbfe..d7a1188a3b5a


git log 2edae10bfbfe..d7a1188a3b5a --date=short --no-merges --format='%ad %ae %s'
2018-07-24 dtu@chromium.org [pinpoint] Remove suffix from results2 tasks.


Created with:
  gclient setdep -r src/third_party/catapult@d7a1188a3b5a

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I7e7343442cf33f424afb29810fdc82b24e05844d
Reviewed-on: https://chromium-review.googlesource.com/1147941Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577452}

This reverts commit ce0157f4.

Reason for revert: This change breaks text input on ARC windows.
Bug: 866784

Original change's description:
> Cleanup IsArcAppWindow() in ArcWindowDelegateImpl.
> 
> Now aura::client::kAppType property is set for an ARC notification
> window. We can use it for check.
> 
> Change-Id: Id27f5ab83492a4c1a517b1350ae1fc30bfbf8fae
> Reviewed-on: https://chromium-review.googlesource.com/1146626
> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577422}

TBR=yusukes@chromium.org,yhanada@chromium.org

Change-Id: I9a58768a0ae0d84d13d9943674ed60954a9b39d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1148120Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577451}

Function String GetString(StringOrTrustedHTML, const Document*, ExceptionState&)
has been added to trusted_html.cc
All other callsites (setInnerHTML, setOuterHTML, setAttribute in element.cc,
parseFromString in dom_parser.cc and createContextualFragment in range.cc,
setInnerHTML in shadow_root.cc) have been updated to call this function

Bug: 739170
Change-Id: Ie84462cd233669e55f2b76e685d5d3545198ee59
Reviewed-on: https://chromium-review.googlesource.com/1142768
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577450}

Function String GetString(USVStringOrTrustedURL, const Document*, ExceptionState&)
has been added to trusted_url.cc
All other callsites (setAttribute in element.cc, open in local_dom_window.cc,
assign, replace and setHref in location.cc) have been updated to call this function
setHref in html_base_element.cc has been changed to call a different setAttribute
from element.cc (the one mentioned above), this way there was no need to call
GetString in there as well

Bug: 739170
Change-Id: I07b9fee53ea62aa706bb59814f147a394f214549
Reviewed-on: https://chromium-review.googlesource.com/1144927
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577449}

This CL adds an InProduct help to indicate to the user that it is
possible to long press on the toolbar buttons to have menus with
new options.
This in product help should only be displayed after the user opened a
new tab. It should also be displayed after having the InProductHelp for
the bottom toolbar displayed few days ago. This condition is handled
server side.

Bug: 849621
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I440cfe7cbf0b230454b1d2615e62d33d73c60b88
Reviewed-on: https://chromium-review.googlesource.com/1138243
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577448}

The ServiceWorkerNavigationPreload feature flag was removed in r494256.

Bug: 753230
Change-Id: Ie2fe09c477dbffe1bc19cc050f1e6f413b1a8358
Reviewed-on: https://chromium-review.googlesource.com/1148021Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577447}

This function is not used anywhere.

Change-Id: I4116ef0634a1db7b1aacfc5326e662ce3abfe136
Reviewed-on: https://chromium-review.googlesource.com/1144816Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577446}

This CL:
 - Renames FrameHeaderOriginText to HostedAppOriginText as it's not
   intended to be used for anything other than hosted app windows
   and for consistency with other HostedApp* views.
 - Moves HostedAppOriginText from ash/frame to
   chrome/browser/ui/views/frame.
 - Moves the animation timing logic from BrowserNonClientFrameViewAsh
   into HostedAppButtonContainer.

This is in preparation to add the origin text animation to
GlassBrowserFrameView (see https://chromium-review.googlesource.com/c/chromium/src/+/1136270).
There are no behavioural changes in this CL.

Bug: 854479
Change-Id: I69934e5b4595356d10e707011a231f9c095338db
Reviewed-on: https://chromium-review.googlesource.com/1134713
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577445}

The AccountTracker unittest currently plays fast-and-loose with the
notion of an "account ID", which can be either the Gaia ID or the
email address for a given account depending on the platform. This is a
blocker to porting AccountTracker to use IdentityManager, as the
IdentityManager test infrastructure deliberately makes a much more
explicit and enforced separation between email address, Gaia ID, and
account ID, reflecting how these elements are used in production.
In particular:
- Adding an account takes in the gaia ID and email and returns an
  account ID.
- Calls that interact with the token service take in the account ID.

This CL paves the way for that porting by changing the
AccountTracker unittest to be explicit about its usage of the
email address, Gaia ID, and account ID of a given account. The test now
adds accounts by passing the gaia ID/email, obtains the account IDs of
the added accounts, and interacts with the token service via those
account IDs.

Bug: 809923
Change-Id: Ia0bf7fc90c035976f8c578563e7d81c597d4d635
Reviewed-on: https://chromium-review.googlesource.com/1138082
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577444}

...instead of mojom::CORSError. Currently they return a mojom::CORSError
and callers need to compose a CORSErrorStatus from it. That requires
callers to know which specific errors are returned from the function,
which is not good.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5b0dfaf5b906e0203c9a72ebaef759a8fafa4ad3
Reviewed-on: https://chromium-review.googlesource.com/1147681Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577443}

Bug: 790547
Change-Id: I68d3afb4a8bce843eee9e3b5456ed3103c7d2914
Reviewed-on: https://chromium-review.googlesource.com/1147545Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577442}