- 14 Oct, 2019 40 commits
-
-
Thomas Tangl authored
- Move all incognito code to incognito_menu_view.cc (to avoid special casing for ChromeOS) - Add "Exit incognito" button - Re-enable browser tests Bug: 995720 Change-Id: I55674e9192065d4a185b712af391a56fdc56095a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859962Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#705544}
-
Michael Lippautz authored
https://crrev.com/695748 introduced an issue as the refactoring missed out on preserving a crucial null check for already destructed nodes. The problem is that we create a fast path by checking for whether a node is initialized already outside of the lock but forgot to recheck after we entered again. The check is put in FreeNode() to avoid repeated atomic loads. Bug: 1013915 Change-Id: Iffa5b982791ac8d239650499bcab355a3e2fa5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860022Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705543}
-
Clemens Arbesser authored
This CL adds support for additional user data form sections that can be configured from the backend. The additional sections are shown either above or below the set of existing sections. Two types of sections are supported: static text and text input sections. For text input sections, the result is stored in client memory, which in turn can be used in a subsequent SetFormFieldValue action. This CL also adds a usability improvement: while the soft keyboard is shown (which pushes the bottom shelf up), the close button on the shelf will close the keyboard instead of immediately closing autofill assistant. Finally, support for italic text spans is added to text sent from the backend. Bug: b/142113908 Change-Id: I8bd3758a33b1039b44c7bca5f8dabdfec05723ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840637 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#705542}
-
Arthur Hemery authored
With the recent addition of infinite bfcache storage for tests, we have two extra regressions on Linux that need to be filtered out. Change-Id: Id329c4fcd25e623d82c8dafac4df4678bbf79d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859956Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705541}
-
Hans Wennborg authored
This is a reland of 7196b2e0, plus a fix to cookie_controls_handler.cc. Original change's description: > Include bloat: reduce number of includes in profile.h > > This reduces the number of preprocessor tokens in profile.h from > 1,455,853 to 586,241 (or from 8,594,906 to 3,254,002 bytes). > > Bug: 1014009 > Change-Id: Ia52ef458f78b2e7c0fdfe341cd4e753be70eccb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857323 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705529} TBR=thakis Bug: 1014009 Change-Id: I025801140c505037ab5420e7a42db8b1c388cfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860021Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#705540}
-
Marc Treib authored
The flags "autofill-always-show-server-cards-in-sync-transport" and "fcm-invalidations" were already removed, so just remove the metadata entries as well. The flags "enable-sync-uss-nigori" and "enable-sync-uss-passwords" are still needed, so extend them to M80 for now. Bug: none Change-Id: I85e28c4d961d1b5ff0416be964714c880d22c26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859957 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705539}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f0640c4401d3..c7af59115ee3 git log f0640c4401d3..c7af59115ee3 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 dberris@chromium.org Implement performance bisection task+evaluators Created with: gclient setdep -r src/third_party/catapult@c7af59115ee3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:988912 Change-Id: I3f168e5070236a8a1f5a495a775588022d59bd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705538}
-
Sigurd Schneider authored
This CL adds a simple exponential back-off & retry strategy to the inspector's loadNetworkResource method. A retry is only attempted if the load failed with net::ERR_INSUFFICIENT_RESOURCES. Retrying ensures that the kMaxOutstandingRequestsPerProcess limit in the network component does not cause load failures to the front-end. Before this CL, bursty loads from the DevTools front-end, such as they occur during fetching of source maps for large webpages, could result in load failures of source maps, when in reality the problem was that too many source maps where loaded at once. The initial back-off delay was chosen to be 250ms, as the intention is to give the network stack some time to finish outstanding requests, which are expected to take some time if there are so many of them that the request limit triggers. The back-off delay is 250ms*1.3^n and retrying is aborted when the delay exceeds 10s (14 tries in total). Bug: chromium:1013124 Change-Id: I2759cfa035fc3952d960d43958536d5e9df613b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852212 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705537}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ffbe4873. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I7e4c44d798824e7e18ce1e8d575a91b5f6d2ec6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859835Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705536}
-
Oleg Davydov authored
Historically InstallationTracker was made to get a broad picture of what happens with force-installed extensions. So case "policy changed shortly after login so extension was not installed because it is not needed more" was ignored as something that happens rare. This CL support that case too. Note that if policy changed shortly after login, we still ignore new extensions. We do this intentionally: for such a new extension we may want to know "whether it is installed five minutes after it appear in policy", not "five minutes after login". Bug: 981891 Change-Id: If700a222d43504092bad8fb69f811fad0d54fd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853404 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705535}
-
Juan Antonio Navarro Perez authored
Add an integration tests for benchmark running and results processing. This includes writing traces and running metrics on them. The test can also serve as an example for writing other integration tests (e.g. for ad hoc measurements). This test is intended to replace the existing testTBM2ForSmoke: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py?rcl=0b1af463167af25923a31dd190b41a32841e05fe&l=99 Note: depends on landing first https://chromium-review.googlesource.com/c/catapult/+/1847392 Bug: 1012227 Change-Id: I784a0e08a495f3489e46ac4c8b9e83857ff8cc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847340 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#705534}
-
Morten Stenshorne authored
We need to report unbreakable block-size from the column layout algorithm, in cases where we have nested column balancing. Set up the fragment builder to be block-fragmented when inside a nested multicol that performs the initial column balancing pass, so that spanners report unbreakability (happens automatically via NGBoxFragmentBuilder::AddResult(), when set up correctly). When we fall back to legacy layout, we also need to set up the builder so that we report unbreakable block-size rather than space shortage (those two share data storage). We don't actually have to report any size, though, (0 is fine) since this is always monolithic content, which is taken care of by the parent algorithm (BreakBeforeChildIfNeeded() in NGBlockLayoutAlgorithm). Bug: 829028, 1013716 Change-Id: Ib507cbedbacf2ed05c1db5a58f7738c070f3ab79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859786Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#705533}
-
Findit authored
This reverts commit 7196b2e0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 705529 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzcxOTZiMmUwZmExYTVlOGY4ZjJhNGZhNmRkODZhZTk0OTY2NGZiYWUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/123404 Sample Failed Step: compile Original change's description: > Include bloat: reduce number of includes in profile.h > > This reduces the number of preprocessor tokens in profile.h from > 1,455,853 to 586,241 (or from 8,594,906 to 3,254,002 bytes). > > Bug: 1014009 > Change-Id: Ia52ef458f78b2e7c0fdfe341cd4e753be70eccb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857323 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705529} Change-Id: Ia9327842bcbd689175c179bad1ee05e948c3e029 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859938 Cr-Commit-Position: refs/heads/master@{#705532}
-
Francois Beaufort authored
This CL renames NDEFRecord methods "toText()" to "text()", "toJSON()" to "json()", and "toArrayBuffer()", to "arrayBuffer() as decided at https://github.com/w3c/web-nfc/pull/370 Change-Id: I8a540ee68b34863e09df562c2075e0d3c786462a Bug: 520391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855921Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#705531}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2a523eb..71bbf632 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3357f5d260b22e4a871fa6f08db309f7743c9f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859834Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705530}
-
Hans Wennborg authored
This reduces the number of preprocessor tokens in profile.h from 1,455,853 to 586,241 (or from 8,594,906 to 3,254,002 bytes). Bug: 1014009 Change-Id: Ia52ef458f78b2e7c0fdfe341cd4e753be70eccb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857323 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705529}
-
Javier Ernesto Flores Robles authored
Reenable undocking and docking the keyboard on iPad tests. Bug: 985977 Change-Id: I2744a197ee1d0592fd03229e61bc0ac651178afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814917 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#705528}
-
Yifan Luo authored
As discussed in https://github.com/w3c/webappsec-fetch-metadata/issues/45, We have decided to shift the model around nested navigations from exposure via the request's `mode` to its `destination`. This patch splits the existing `document` destination into three parts: - `document` for top-level navigations and, for the moment, <portals>. - `iframe` for <iframe> navigations. - `frame` for <frame> navigations. Subsequent patch will remove the `nested-document` mode when we're ready to ship `Sec-Fetch-Dest`. Bug: 1011724 Change-Id: I23f23922fb49523aa050f59cbf13aabc086600bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847295Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#705527}
-
Kamila authored
Experiment with blocking permission prompts if they are ignored often. Bug:9867373 Change-Id: I09741d18b303d575babf565c1d8e5ae6de1ecc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855840 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#705526}
-
David Roger authored
TBR=hiroshige Bug: 917554, 1013741, 1013742 Change-Id: I6af87bf1614d6ceb5744bf3afbe52d8f23ca8def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859782Reviewed-by:
-
Yang Guo authored
Change-Id: I4dd89cae3441f1da5ae4b2a393a3ff66a67f6451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859787 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#705524}
-
sandromaggi authored
Before element checkers used to report with a boolean whether or not the element was found - using only the ok() from the ClientStatus. Now the full status gets forwarded, such that it can be properly displayed if an error occurs. Bug: b/141906730 Change-Id: I483fdba95418f1a792ca0f20b7434a61be671c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835580 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#705523}
-
Juan Antonio Navarro Perez authored
These are blocking work to migrate benchmarks to ad hoc measurements. Bug: 1011787 Bug: 999484 Change-Id: I5cb3f8f5db137ec542321189506ae71bf43d7c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859774Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#705522}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1eefb86e4912..6529b908a53e git log 1eefb86e4912..6529b908a53e --date=short --no-merges --format='%ad %ae %s' 2019-10-14 fmayer@google.com Merge "Update test to check double mappings." Created with: gclient setdep -r src/third_party/perfetto@6529b908a53e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1188e98d7d80ea53017435fc9b5193df5539abf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859574Reviewed-by:
-
Jan Wilken Dörrie authored
This change disables triggering Touch To Fill on readonly passwords fields that wouldn't be able to be filled in. Bug: 1013119 Change-Id: Ie0425e8d2d30bf77fbb791f220b379071f12e766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852292 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705520}
-
Hans Wennborg authored
Reducing the preprocessed include size from 514,119 to 101 tokens. Bug: 1014009 Change-Id: I2eba8848545dd95dcd2da105580b45d6be0e21f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856964Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#705519}
-
Mike West authored
@annevk noted in https://github.com/whatwg/fetch/pull/948#discussion_r331921654 that it was possible to navigate an `<embed>` after it loads. In this case, it seems safest to ensure that this navigation shows up with a destination of `embed` and a mode of `no-cors`. That seems to be what we're sending today via Fetch Metadata, so let's lock it in via this patch's tests. I suspect it's not what the underlying `fetch()` API would show in a service worker, but we can deal with that in a separate patch. Bug: 1011763 Change-Id: I0156b2b1b467c914b15f6af50dfa37ce74db6c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844996 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#705518}
-
chrome://flagsPeter Beverloo authored
Remove two, extend some others Change-Id: Ib5eda27b552bea83f20f3e3c62703d8a66d8c9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856971 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705517}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0ec6fc5eab5d..f0640c4401d3 git log 0ec6fc5eab5d..f0640c4401d3 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 perezju@chromium.org [Telemetry] Add telemetry.testing.test_stories Created with: gclient setdep -r src/third_party/catapult@f0640c4401d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1012227 Change-Id: Ia68268de196f5e40598df6c229566ef47a1cdcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859674Reviewed-by:
-
Ingvar Stepanyan authored
Previously, auto-stepping experiment would only work when mapping is not found at all, that is, there is no source file associated with a particular byte offset. This is not ideal in situations where a file exists, but underlying JavaScript / Wasm instructions don't map 1:1 to the source language, which is usually the case for compiled languages. In this case trying to perform step-by-step debugging would lead to user visibly staying on the same line and column in the source file, while V8 is stepping over individual instructions / statements. The reason for this is that SourceMap.findEntry doesn't look for an exact match, but rather for a most suitable position in the source it can map a byte offset to. This is what you usually want when stopping on an exception, but not what you want when trying to step over some statement in the source code. This change enhances auto-stepping to detect such situations and continue until a precise match is found. Change-Id: I69ced14f0bdb219ec8f6b58864dbf23616a6230b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855967Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Jacobo Aragunde Pérez authored
Some unused references to old mojo types remained in the implementation of WaylandBufferManagerGpu from wayland_buffer_manager.mojom. Just removed them. Bug: 955171 Change-Id: I95afae400d0fbb37e81946bf557780815346b13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849377 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#705514}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bab55653bc83..1c834ea5451c git log bab55653bc83..1c834ea5451c --date=short --no-merges --format='%ad %ae %s' 2019-10-14 vapier@chromium.org build_dlc: read/write files as bytes 2019-10-14 vapier@chromium.org paygen_payload_lib: fix bytes/string handling in RunGeneratorCmd 2019-10-14 vapier@chromium.org paygen: download_cache: fix bytes & string handling Created with: gclient setdep -r src/third_party/chromite@1c834ea5451c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic6d6c2d7105794450437bb15006513bfdd76f55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858960Reviewed-by:
-
Jan Krcal authored
This CL extends two flags, animated-avatar-button and enable-history-favicons-google-server-query till M79. Bug: 967317 Change-Id: Ieb4c9b96bfd000a88e63490694b438d7c0cfcad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859614 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#705512}
-
Marc Treib authored
Since this is a histogram enum, the entries are commented out but left around, for historical purposes and to reduce the chances of reuse. Bug: 1012648, 1007293 Change-Id: Ic931270a50908e4977e2ca2fd7f6851fab3dcfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852253 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ProxyLookupClient from proxy_lookup_client.mojom to new Mojo types using PendingRemote, Receiver, and Remote. Bug: 955171 Change-Id: I1765ac683cc567bb2a5d7d31dc3b983ec2a18741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852527Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#705510}
-
Noel Gordon authored
The CSS switches on attribute {volume,root}-type-icon, but in practice there is no real system need for the distinction. Bug: 992819 Change-Id: Ieca58e2ce1e4bc211c2aea342b73e9f8f467549a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859415Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705509}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert last uses of base::Bind/base::Callback in components/prefs to the recommended methods/types. Bug: 1007719 Change-Id: I50ed50f2a419ef4b7afcc65756e8a4a0c08a8933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844784 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#705508}
-
Niels Möller authored
Bug: webrtc:8504,842613 Change-Id: I56f348087fdd5acb37c90cfe649d72890d985ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857327Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#705507}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74897164..a2a523eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46d738030f0223aa83a9fb38e2942b068f1a91f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858573Reviewed-by:
-
Kuo Jen Wei authored
Bug: None Test: Verify the switch device button is not shown on both photo/video intent reviewing page. Change-Id: I1575f4775690f12b4d28405f51226c877bab96a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859318 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#705505}
-
