- 01 Nov, 2017 40 commits
-
-
Xiaohui Chen authored
When assistant is started and triggered hiding animation, during a very short time window if the user lifted their finger, we would try to play end animation. We should avoid doing that. BUG=b:67496461 TEST=build and flash locally, see animation playing normally Change-Id: Idf52f692edd9d05b16ad48687384d291b208a42e Reviewed-on: https://chromium-review.googlesource.com/748268Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#513208}
-
Lei Zhang authored
They should not be called ChromeRenderViewTest, which is the name of the base test class. Change-Id: I7e25511b86d62c9c7bc480a97216c27aa2b42558 Reviewed-on: https://chromium-review.googlesource.com/749107Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#513207}
-
Xing Liu authored
This CL converts more tests in chrome download_browsertest to use embedded test server. Also moves test_download_http_respons and slow_download_http_response from content/browser/download to content/public/test to use them in chrome layer download_browsertest. Bug: 715630 Change-Id: Iae780fb16a3cd0e9f16fb82244491452b246002a Reviewed-on: https://chromium-review.googlesource.com/745728Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513206}
-
Philip Rogers authored
This file is unnecessary. It was added in [1] and should have been removed in [2]. No new tests pass. [1] https://chromium.googlesource.com/chromium/src/+/2ea3968e0c87432c0d759026fa4be13c6d54c82e [2] https://chromium.googlesource.com/chromium/src/+/ba16168ea9eeb941fb1c611aaa85f07392bfe43d Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I21ed169e7aa841b1511d12717b7473f2abff7cd8 Reviewed-on: https://chromium-review.googlesource.com/748121 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#513205}
-
Adrian Elder authored
Bug: 777967 Change-Id: I9a39f138ad0aa6624602002f2ccf4e6a97b95c07 Reviewed-on: https://chromium-review.googlesource.com/739473Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Adrian Elder <aelder@chromium.org> Cr-Commit-Position: refs/heads/master@{#513204}
-
Danyao Wang authored
Bug: 734150 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0cedb5439e35af401384a5a7e756bb9354059227 Reviewed-on: https://chromium-review.googlesource.com/742187 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#513203}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7ea09a47a11d6d8ed3a70d758f1b3a7b1de34360 Reviewed-on: https://chromium-review.googlesource.com/748704 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513202}
-
Jungshik Shin authored
The test is flaky/failing apparently because FromLocalExplode is flaky. Use FromUTCExplode and the fixed timezone (America/Los_Angeles) instead of the default timezone of wherever the test runs. Bug: 671429, 582915 Test: base_unittests --gtest_filter=TimeFormat* Change-Id: Ia7bd77dca5ef3712cc2516e59387f80899820dab Reviewed-on: https://chromium-review.googlesource.com/748220 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#513201}
-
Peter Collingbourne authored
This makes it possible to cross-build for Windows with is_asan=true (and soon, is_ubsan=true and use_cfi_diag=true). Bug: 778760 Change-Id: I6c49a690f11de299479bd17bb2e4588d1b55d9b1 Reviewed-on: https://chromium-review.googlesource.com/740570Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513200}
-
dpapad authored
It turns out that the usage of FocusOutlineManager was not necessary, and in fact seems to be causing the corner case. Bug: 779977 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id64851fd4bfadd13407a304cda11555db824d19a Reviewed-on: https://chromium-review.googlesource.com/747485Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#513199}
-
Xiaohan Wang authored
Change-Id: I23d8f573e596d7d9b1bdde9b84dec119828110c6 Reviewed-on: https://chromium-review.googlesource.com/747681Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#513198}
-
Nico Weber authored
We want to replace win_clang and WinClang64 (dbg) which currently do release MSVC builds on CQ and main waterfall respectively with win_msvc and win_msvc_dbg / WinMSVC64 and WinMSVC64 (dbg) to 1.) get both release and debug coverage 2.) have less confusing bot names at least on CQ and main waterfall. This adds mb configs for the new bot names. Bug: 777642,751220 Change-Id: I79aa4a41554e9961dfc3fdad5922c590bb603d38 Reviewed-on: https://chromium-review.googlesource.com/746535 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513197}
-
Peter Collingbourne authored
Bug: Change-Id: Iac682f729db5190258bf5024bbe25ae8ed8ec73c Reviewed-on: https://chromium-review.googlesource.com/749108Reviewed-by:
-
Philippe Hamel authored
Bug: 759161 Change-Id: I199c7604eb38fc5a1b8107710eeaa27f8e71b299 Reviewed-on: https://chromium-review.googlesource.com/743690 Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#513195}
-
Steve Kobes authored
Bug: 755401 Change-Id: Ica41e281b77f3b3625e65f883aedd394470c2a6d Reviewed-on: https://chromium-review.googlesource.com/740292Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#513194}
-
Weidong Guo authored
Changes: The gray ring is shown only when search box is selected and it is not active. BUG=779693 Change-Id: I10fdd7238361ea8320c4a74697a7d7015863d36e Reviewed-on: https://chromium-review.googlesource.com/748310Reviewed-by:
-
Weidong Guo authored
BUG=780355 TEST=AppListViewFocusTest.SetFocusOnSearchboxWhenActivated Change-Id: I257897049a58ffb93e55e6890ab6e3a7b533e4a1 Reviewed-on: https://chromium-review.googlesource.com/748561Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0b78a6912eba..206bda5b7931 $ git log 0b78a6912..206bda5b7 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 robertphillips Update the texture flip GM to include subsets & scales 2017-11-01 brianosman Plumb internal helper to enable more GPU GMs w/SkColorSpaceXformCanvas 2017-11-01 brianosman Fix bookmaker compile warning 2017-11-01 caryclark streamline doc menus 2017-10-31 egdaniel Update GrTextureMaker to handle mips when copying for npot 2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ e88ec8eed..206a58d1f (1 commit) 2017-10-31 jvanverth More attempts at clipping perf. 2017-11-01 mtklein fix typo in SkJpegCodec.cpp Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: If7bc90abbdb08177c172317ef2d9366ec40e3533 Reviewed-on: https://chromium-review.googlesource.com/749447Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513191}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3cc27b2b9fe91e561095bc8d87651ae44070b208 Reviewed-on: https://chromium-review.googlesource.com/749452 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513190}
-
Weidong Guo authored
Changes: Hitting Enter when search box is not active and search box is focused activates the search box. BUG=780339 TEST=AppListViewFocusTest.HittingEnterWhenFocusOnSearchBox Change-Id: I16d3b32d0d163badc11fc921926b2b174480c11e Reviewed-on: https://chromium-review.googlesource.com/748164Reviewed-by:
-
Philip Rogers authored
Based on a trybot run as well as Szager's test tool, 18 tests are failing and 8 tests are passing. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I04880039367d9896a87467f8196d5510d6aec7db Reviewed-on: https://chromium-review.googlesource.com/748703Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I632ceceb83fb1c8403e0dd58be5d1ebdcd5a6dd0 Reviewed-on: https://chromium-review.googlesource.com/748911 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513187}
-
Peter Kotwicz authored
This CL fixes NullPointerException when showing notifications in WebAPK. BUG=779960 Change-Id: Icc4721995b57503e74071d7a1ae92f875d5de649 Reviewed-on: https://chromium-review.googlesource.com/748802Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#513186}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I58cb3b0d31f8ffc3e28ce643b24db99b4ac4f77d Reviewed-on: https://chromium-review.googlesource.com/748915 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513185}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6c1f5f714a545acc62a0e056defcfeea24d90ef1 Reviewed-on: https://chromium-review.googlesource.com/749249 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513184}
-
Dominik Röttsches authored
And execute it for the set of previous UseCounter.cpp changes. Bug: 780487 Change-Id: I3fbf840d5693f18d55306efc440d3f9a2120fbd2 Reviewed-on: https://chromium-review.googlesource.com/749382Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#513183}
-
Scott Graham authored
TBR: wez@chromium.org Bug: 780508 Change-Id: Ib5325a3b0e7bb9fbbc9b1b8c9b18837b63dd0d95 Reviewed-on: https://chromium-review.googlesource.com/749247 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513182}
-
Caleb Rouleau authored
Remove legacy broken media_cns_cases. Also remove media measurements since media_cns_cases was the only user of it. Bug: 676345 Change-Id: If3659e3ba0d57f6ef1a73d55ef4022a3f5bf797f Reviewed-on: https://chromium-review.googlesource.com/747820Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#513181}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I283a52d5f0acef7f81363f340333c0a31b805445 Reviewed-on: https://chromium-review.googlesource.com/749248 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513180}
-
Eugene Ostroukhov authored
Moves refresh and clear button from the bottom toolbar to the top for consistency with other Application panel tabs. Bug: Change-Id: I942814bc93b2537223c3bb95f940b62d679762c4 Reviewed-on: https://chromium-review.googlesource.com/731580 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#513179}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5481e16c7cc340fdf92d649884f4df189f247f39 Reviewed-on: https://chromium-review.googlesource.com/748970 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513178}
-
Xing Liu authored
CancelDownload can be called before content layer persist the record in history db, the canceled download will be recognized as external and thus block all background download. This CL filtered the canceled download with an existing cache in download driver. TBR=phajdan.jr@chromium.org Bug: 776716 Change-Id: Ib6476180a4b7db728fa6750264f0893384eb6633 Reviewed-on: https://chromium-review.googlesource.com/738589 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#513177}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3fff90a670d8..a85e5ca5f2df $ git log 3fff90a67..a85e5ca5f --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Split JS methods out of CXFA_Object 2017-11-01 dsinclair Split JS code out of CXFA_Node. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib25ac8f53f4e968aa483657809402c2b7fdce8c2 Reviewed-on: https://chromium-review.googlesource.com/749445 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513176}
-
Donn Denman authored
The ContextualSearchManagerTest testSecondTapWithSmartSelection was just checking if the panel was closed rather than waiting for it to close after hiding the panel due to Smart Selection on the second tap. BUG=778693 Change-Id: Ib403321ec3ac5b4d7a0995bcbd2216bd86c3c9b6 Reviewed-on: https://chromium-review.googlesource.com/742124Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#513175}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/7172ea13c029..c4a14324e29c $ git log 7172ea13c..c4a14324e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I88fd4716ef5f70d011fd7020b2805a3b63ff6bf1 Reviewed-on: https://chromium-review.googlesource.com/749441Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513174}
-
Scott Chen authored
Bug: 722788 Change-Id: I3235f1245587720bea79ee91cd28aac5cfa60928 Reviewed-on: https://chromium-review.googlesource.com/739386Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513173}
-
Zijie He authored
This looks like a very common issue when using os.rename() on Windows. https://www.google.com/search?q=python+os.rename+cannot+create+a+file+when+that+file+already+exists&oq=python+os.rename+cannot+create+a+file+when&aqs=chrome.0.0j69i57.12521j0j7&sourceid=chrome&ie=UTF-8 Bug: chromium:778370 Change-Id: I7132a2614fe9361c6860ae9598e994d7dbd00c5b Reviewed-on: https://chromium-review.googlesource.com/748306Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#513172}
-
Kenneth Russell authored
Windows: conformance/limits/gl-max-texture-dimensions.html deqp/data/gles3/shaders/functions.html Linux: deqp/functional/gles3/fbocompleteness.html BUG=680754, 703779, 712469, 715001 TBR=jmadill@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2357bf311f49680a3a640c4645dfef8d1ab069dc Reviewed-on: https://chromium-review.googlesource.com/748918 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513171}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/206a58d1fbc7..63458a3ed819 $ git log 206a58d1f..63458a3ed --date=short --no-merges --format='%ad %ae %s' 2017-10-30 geofflang CopyTextureCHROMIUM: Validate the texture target enums first. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I35bfff7cdb3a47470bc0893f06bbef5384819eab Reviewed-on: https://chromium-review.googlesource.com/749446Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513170}
-
John Z Wu authored
It used to return a pointer to the base class SigninClient. Since this is a factory specific for //ios/web_view, it makes sense to return the //ios/web_view specific subclass. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I27d726d7dab7e5ef2193928a2ffd0796cee0351c Reviewed-on: https://chromium-review.googlesource.com/744738Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#513169}
-
