GitLab

wx build fix. Switching JSCore from a static lib to a dynamic lib to match the Apple build and fix symbol exports.


git-svn-id: svn://svn.chromium.org/blink/trunk@42860 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25337
        Move ThreadingQt.cpp under the qt directory.

        * JavaScriptCore.pri:
        * wtf/ThreadingQt.cpp: Removed.
        * wtf/qt/ThreadingQt.cpp: Copied from JavaScriptCore/wtf/ThreadingQt.cpp.



git-svn-id: svn://svn.chromium.org/blink/trunk@42858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25338
        Move ThreadingGtk.cpp under the gtk directory.

        * GNUmakefile.am:
        * wtf/ThreadingGtk.cpp: Removed.
        * wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.



git-svn-id: svn://svn.chromium.org/blink/trunk@42857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Gustavo Noronha.

        Fix braces to comply with style guidelines.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::getClipboard):
        (WebKit::PasteboardHelperGtk::getCopyTargetList):
        (WebKit::PasteboardHelperGtk::getPasteTargetList):

git-svn-id: svn://svn.chromium.org/blink/trunk@42856 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=17267
        [GTK] Primary selection/clipboard support

        Copy the link location to the primary selection as well as the
        clipboard selection when using the "copy link selection" context
        menu entry.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeURL):
        * platform/gtk/PasteboardHelper.h:

2009-04-24  Sergio García-Cuevas  <sergio_gcg@telefonica.net>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=17267
        [GTK] Primary selection/clipboard support

        Add a method for getting the primary selection.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::getPrimary):
        * WebCoreSupport/PasteboardHelperGtk.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=25383
        Changing SVG size via JS does not update CSS width/height

        Add an ugly hack to fix CSS width/height updates from JS.

        We can't easily call setAttribute when width/height changes
        as that would cause infinite recursion (as we'd try to set
        the animation storage from the attributes)

        For now, when we get notification that JS changed width/height
        we copy what parseMappedAttribute does and update the CSS values as well.

        A better fix for this would be:
        https://bugs.webkit.org/show_bug.cgi?id=25383

        * svg/SVGSVGElement.cpp:
        (WebCore::updateCSSForAttribute):
        (WebCore::SVGSVGElement::svgAttributeChanged):

git-svn-id: svn://svn.chromium.org/blink/trunk@42854 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam "Wesley" Weinig.

        Improve performance to YARR interpreter.
        (From about 3x slower than PCRE on regex-dna to about 30% slower).

        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::checkCharacter):
        (JSC::Yarr::Interpreter::checkCasedCharacter):
        (JSC::Yarr::Interpreter::backtrackPatternCharacter):
        (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
        (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
        (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
        (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
        (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
        (JSC::Yarr::Interpreter::matchDisjunction):
        (JSC::Yarr::Interpreter::interpret):
        (JSC::Yarr::ByteCompiler::atomPatternCharacter):
        (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
        (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
        (JSC::Yarr::ByteCompiler::closeAlternative):
        (JSC::Yarr::ByteCompiler::closeBodyAlternative):
        (JSC::Yarr::ByteCompiler::atomParenthesesEnd):
        (JSC::Yarr::ByteCompiler::regexBegin):
        (JSC::Yarr::ByteCompiler::regexEnd):
        (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction):
        (JSC::Yarr::ByteCompiler::alterantiveDisjunction):
        (JSC::Yarr::ByteCompiler::emitDisjunction):
        * yarr/RegexInterpreter.h:
        (JSC::Yarr::ByteTerm::):
        (JSC::Yarr::ByteTerm::ByteTerm):
        (JSC::Yarr::ByteTerm::BodyAlternativeBegin):
        (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
        (JSC::Yarr::ByteTerm::BodyAlternativeEnd):
        (JSC::Yarr::ByteTerm::AlternativeBegin):
        (JSC::Yarr::ByteTerm::AlternativeDisjunction):
        (JSC::Yarr::ByteTerm::AlternativeEnd):
        (JSC::Yarr::ByteTerm::SubpatternBegin):
        (JSC::Yarr::ByteTerm::SubpatternEnd):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
        * yarr/RegexPattern.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        We should not show the deletion UI for blockquotes in mail but they do 
        show now that we only check for one visible border.

        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):



git-svn-id: svn://svn.chromium.org/blink/trunk@42852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Mark Rowe.

        * wtf/CurrentTime.h: Fix a typo in a comment.

git-svn-id: svn://svn.chromium.org/blink/trunk@42851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * rendering/RenderLayer.cpp:
        (WebCore::performOverlapTests):
        (WebCore::RenderLayer::paintLayer):



git-svn-id: svn://svn.chromium.org/blink/trunk@42850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - fix https://bugs.webkit.org/show_bug.cgi?id=5909
          <rdar://problem/5863349> overlapping element leaves trail when
          scrolling iframe

        * WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.

        * page/FrameView.cpp:
        (WebCore::FrameView::reset): Initialize m_isOverlapped.
        (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped.
        (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints()
        so overlapping is taken into account.
        (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and
        enables or disables copy-on-scroll accordingly.

        * page/FrameView.h:
        Added setIsOverlapped() and m_isOverlapped.

        * rendering/OverlapTestRequestClient.h: Added. During foreground painting,
        an OverlapTestRequestClient can make a request to test if any subsequently-
        painted layers overlap a rect. The test result is delivered to the
        requestClient via setOverlapTestResult().
        (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to
        paintLayer(). When done painting, inform any remaining requestClients that
        they are not overlapped.

        (WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
        pass it down to child and reflection layers. Inform requestClients if this
        layer overlaps their requested rects.

        * rendering/RenderLayer.h:

        * rendering/RenderObject.h:
        (WebCore::RenderObject::PaintInfo::PaintInfo): Added an
        OverlapTestRequestMap member.

        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap
        to paintLayer().

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint): For FrameViews, request an overlap test
        with the frame.
        (WebCore::RenderWidget::setOverlapTestResult): Call
        FrameView::setIsOverlapped() with the result of the overlap test.

        * rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.



git-svn-id: svn://svn.chromium.org/blink/trunk@42849 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser

        https://bugs.webkit.org/show_bug.cgi?id=25380

        Fixed a race condition on the first 'played' attribute test start.

        Previously we were starting nearly right away to play, and probably
        before receiving the 'canplay' event. Now we ensure we'll wait for
        that 'canplay' event before attempting to play.

        * media/video-played-expected.txt: Updated
        * media/video-played.html:

git-svn-id: svn://svn.chromium.org/blink/trunk@42848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber stamped by Eric Seidel.
        
        Updated test to turn the buildbot green after Eric's last check-in.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser, Dan Bernstein.

        Speed up the PLT by devirtualizing the height() function on InlineBox.  virtualizing it in order to make the height() computation dynamic caused
        a ~0.5% slowdown.  This patch does the following to get the speed back:
        
        (a) Devirtualizes isText and forces inline box creators to set the bit as needed.  This actually resulted in simplified code, since ListMarkerBox could
        then be removed.
        (b) Reduces the height() call count.  In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
        member variable access.  The call sites have been patched to cut down on extra height() calls now that it is more expensive.
        (c) Devirtualize height() except on SVG boxes.  For all non-SVG, the height() function on InlineBox handles the computation.  For SVG boxes, a new bit has
        been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::height):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::isSVG):
        (WebCore::InlineBox::setIsSVG):
        (WebCore::InlineBox::isText):
        (WebCore::InlineBox::setIsText):
        (WebCore::InlineBox::svgBoxHeight):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        * rendering/InlineTextBox.h:
        * rendering/ListMarkerBox.cpp: Removed.
        * rendering/ListMarkerBox.h: Removed.
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::createInlineBox):
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::createFlowBox):
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::createTextBox):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::createRootBox):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::createInlineTextBox):
        * rendering/RootInlineBox.cpp:
        * rendering/RootInlineBox.h:
        * rendering/SVGInlineFlowBox.h:
        (WebCore::SVGInlineFlowBox::svgBoxHeight):
        * rendering/SVGInlineTextBox.h:
        (WebCore::SVGInlineTextBox::svgBoxHeight):
        * rendering/SVGRootInlineBox.h:
        (WebCore::SVGRootInlineBox::svgBoxHeight):



git-svn-id: svn://svn.chromium.org/blink/trunk@42846 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Add PrettyPatch support to run-webkit-tests

        * Scripts/run-webkit-tests:

git-svn-id: svn://svn.chromium.org/blink/trunk@42845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25370
        Introduce ScriptEventListener to refactor away direct references to
        JSLazyEventListener in WebCore code.

        * GNUmakefile.am: Added ScriptEventListener to project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
        * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
            to ScriptEventListener.
        * bindings/js/JSLazyEventListener.h: Ditto.
        * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
        * bindings/js/ScriptEventListener.cpp: Added.
        * bindings/js/ScriptEventListener.h: Added.
        * bindings/v8/ScriptEventListener.cpp: Added.
        * bindings/v8/ScriptEventListener.h: Added.
        * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
        * html/HTMLBodyElement.cpp: Ditto.
        * html/HTMLButtonElement.cpp: Ditto.
        * html/HTMLElement.cpp: Ditto.
        * html/HTMLFormElement.cpp: Ditto.
        * html/HTMLFrameElementBase.cpp: Ditto.
        * html/HTMLFrameSetElement.cpp: Ditto.
        * html/HTMLImageElement.cpp: Ditto.
        * html/HTMLInputElement.cpp: Ditto.
        * html/HTMLObjectElement.cpp: Ditto.
        * html/HTMLScriptElement.cpp: Ditto.
        * html/HTMLSelectElement.cpp: Ditto.
        * html/HTMLTextAreaElement.cpp: Ditto.
        * svg/SVGElement.cpp: Ditto.
        * svg/SVGSVGElement.cpp: Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@42843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion

Reviewed by Geoff Garen

We now track the maximum extent of the RegisterFile, and when we reach the final
return from JS (so the stack portion of the registerfile becomes empty) we see
if that extent is greater than maxExcessCapacity.  If it is we use madvise or
VirtualFree to release the physical pages that were backing the excess.

git-svn-id: svn://svn.chromium.org/blink/trunk@42842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.

        Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
        https://bugs.webkit.org/show_bug.cgi?id=25355
        rdar://problem/6823543

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): Added a null check.



git-svn-id: svn://svn.chromium.org/blink/trunk@42841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Fix RenderSVGImage to dump with full bounds and style information.
        https://bugs.webkit.org/show_bug.cgi?id=25377

        No functional changes, we're just now including more info in render tree dumps.

        * rendering/RenderObject.h:
        (WebCore::RenderObject::isSVGImage):
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::isSVGImage):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::write):
        * rendering/SVGRenderTreeAsText.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Fix <rdar://problem/6761635>.
        
        Make sure to keep an extra reference to the instance proxy in case the plug-in host crashes while
        we're waiting for a reply.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::destroy):



git-svn-id: svn://svn.chromium.org/blink/trunk@42839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by NOBODY (chromium build fix).

        Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        * bindings/v8/V8AbstractEventListener.h:
        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::add):
        (WebCore::V8EventListenerList::remove):
        (WebCore::V8EventListenerList::clear):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::virtualisAttribute):
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        * bindings/v8/custom/V8CustomEventListener.h:
        (WebCore::V8EventListener::create):
        (WebCore::V8EventListener::virtualisAttribute):

git-svn-id: svn://svn.chromium.org/blink/trunk@42838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25373
        Popup menu has the wrong size when popped up near the edge
        of the screen

        * webkit/webkitwebview.cpp:
        (webkit_web_view_forward_context_menu_event): Let GTK place
        the popup menu instead of trying to do better and failing

git-svn-id: svn://svn.chromium.org/blink/trunk@42837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser

        <rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit

        Use better mp4 test file for media tests. The original mp4 file had an unusual
        edit (non-zero start time) which is not supported by all media engines. The new
        movie should also give more useful pixel test results.

        * media/content/test.mp4: Update the movie.
        * media/progress-event-total-expected.txt: Update test results to match movie duration and
        content changes.
        * media/progress-event-total.html: Ditto.
        * media/video-currentTime-set-expected.txt: Ditto.
        * media/video-loop-expected.txt: Ditto.
        * platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
        * platform/mac/media/video-aspect-ratio-expected.png: Ditto.
        * platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
        * platform/mac/media/video-controls-rendering-expected.png: Ditto.
        * platform/mac/media/video-display-toggle-expected.checksum: Ditto.
        * platform/mac/media/video-display-toggle-expected.png: Ditto.
        * platform/mac/media/video-empty-source-expected.checksum: Ditto.
        * platform/mac/media/video-layer-crash-expected.checksum: Ditto.
        * platform/mac/media/video-layer-crash-expected.png: Ditto.
        * platform/mac/media/video-transformed-expected.checksum: Ditto.
        * platform/mac/media/video-transformed-expected.png: Ditto.
        * platform/mac/media/video-zoom-expected.checksum: Ditto.
        * platform/mac/media/video-zoom-expected.png: Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@42836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Installed browser location is written to a slightly different registry key in that case.
        
        * FindSafari/FindSafari.cpp:
        (getInstalledWebKitDirectory):



git-svn-id: svn://svn.chromium.org/blink/trunk@42835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        When I moved the files I forgot to update the location of the image!

        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25343
        Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
        ignores blur.

        * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
         (WebCore::GraphicsContext::setPlatformShadow): Add check against
         blur before clearing looper.

git-svn-id: svn://svn.chromium.org/blink/trunk@42833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - Build fix.  Removed this test until I can figure out why it's failing.

        * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@42832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-24  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Initialize TextIterator::m_textLength to 0.

        This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).

        <https://bugs.webkit.org/show_bug.cgi?id=25335>

        Test: editing/selection/doubleclick-whitespace-img-crash.html

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::TextIterator):

LayoutTests:

2009-04-24  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Add a test for <https://bugs.webkit.org/show_bug.cgi?id=25335>.

        To pass, this test must not access invalid memory when run (won't necessarily manifest as a crash for failures).

        * editing/selection/doubleclick-whitespace-img-crash-expected.txt: Added.
        * editing/selection/doubleclick-whitespace-img-crash.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Source changes reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=22242

        Update WebKitSystemInterface for Mac with fixes for video controller drawing.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: svn://svn.chromium.org/blink/trunk@42830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25329
        Add indexed access method in v8 binding of ClientRectList.

        * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Use null for unspecified event listener attributes of XMLHttpRequest
        and XMLHttpRequestUpload in v8 binding.

        cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
        An event handler attribute, unless otherwise specified, can either
        have the value null or be set to a Function object.
        Initially, an event handler attribute must be set to null.

        Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html

        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Ditto.

LayoutTests:

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Verify XMLHttpRequest has correct attribute value by default.

        * fast/xmlhttprequest/resources/xmlhttprequest-default-attributes.js: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes-expected.txt: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Gustavo Noronha.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the
        description of the enable-spell-checking property and correct the
        mentioning of the default language used.

git-svn-id: svn://svn.chromium.org/blink/trunk@42827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Speculative fix for leopard build-bot until I have a fix on leopard.

        * platform/mac-leopard/editing: Added.
        * platform/mac-leopard/editing/deleting: Added.
        * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        <rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException): Added a null check.



git-svn-id: svn://svn.chromium.org/blink/trunk@42825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein

        Currently working on a bug where a WebHistoryItem was being used after being dealloc'ed.
        I added this assertion to help catch the case as soon as it happens instead of random
        issues downstream.  Figured it's worth checking in by itself.

        * History/WebHistoryItem.mm:
        (core): ASSERT that the WebCore::HistoryItem inside this WebHistoryItem is supposed to have
          this WebHistoryItem as a wrapper.



git-svn-id: svn://svn.chromium.org/blink/trunk@42824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=23219

        Add support for transtions and animations of background-position, -webkit-background-size,
        -webkit-mask-position and -webkit-mask-size.

        Tests: transitions/background-transitions.html
               transitions/mask-transitions.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        Add a blend func for LengthSize.

        (WebCore::ensurePropertyMap):
        Add wrappers for the new properties.

        (WebCore::addShorthandProperties):
        Add a shorthand property for CSSPropertyBackgroundPosition to map to
        CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
        add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
        CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
        CSSPropertyWebkitMaskPositionY.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBackgroundXPosition):
        (WebCore::InheritedFlags::setBackgroundYPosition):
        (WebCore::InheritedFlags::setBackgroundSize):
        (WebCore::InheritedFlags::setMaskXPosition):
        (WebCore::InheritedFlags::setMaskYPosition):
        (WebCore::InheritedFlags::setMaskSize):
        Add setters for the properties that can be animated now.

git-svn-id: svn://svn.chromium.org/blink/trunk@42823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        Updating these pixel results to the generated results on Leopard.

        * platform/mac/editing/inserting/5510537-expected.checksum:
        * platform/mac/editing/inserting/5510537-expected.png:
        * platform/mac/editing/inserting/6703873-expected.checksum:
        * platform/mac/editing/inserting/6703873-expected.png:
        * platform/mac/editing/selection/select-all-iframe-expected.checksum:
        * platform/mac/editing/selection/select-all-iframe-expected.png:



git-svn-id: svn://svn.chromium.org/blink/trunk@42822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        Test: editing/pasteboard/paste-blockquote-after-blockquote.html

        When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
        But we should only merge here if the selection start was inside a mail blockquote.  This prevents against removing a 
        blockquote from newly pasted quoted content that was pasted into an unquoted position.  If that unquoted position happens 
        to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
        (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
        * editing/ReplaceSelectionCommand.h:

LayoutTests:

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        * editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42821 bbb929c8-8fbe-4397-9dbb-9b2b20218538