GitLab

Previously if you had an empty lambda, Android Studio would insert a
new line, and then git cl format would remove the newline, and the two
would fight forever. This makes them both agree that no newline is
better.

git cl format and new Android Studio format:
obj.foo(ignored -> {});

old Android Studio format:
obj.foo(ignored -> {
});

Bug: 852962
Change-Id: I785e3264454efbf0118d5fcc36c43ca88076a624
Reviewed-on: https://chromium-review.googlesource.com/1101715Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567469}

BUG=

Change-Id: I88dd7bada07824769b07d71b8669d7ba2ebe6e69
Reviewed-on: https://chromium-review.googlesource.com/1101702Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567468}

This CL replaces setPaddingRelative, getPaddingStart and getPaddingEnd
from ApiCompatibilityUtils with their ViewCompat equivalents.

Bug: 852891
Change-Id: I566d9dd8ae890611dfdd2223d5b4154a7278672d
Reviewed-on: https://chromium-review.googlesource.com/1098928Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567467}

DownloadCreateInfo contains both downloadId and Guid.
Since both can be used to find a download, there is no need to keep
DownloadId.
Passing Guid in DownloadUrlParameters should be enough for resuming a download.

BUG=851652

Change-Id: If7faa264b7e8b413eab932e76b65bfbaebf5e206
Reviewed-on: https://chromium-review.googlesource.com/1095777
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567466}

Previously we assume that LayerTreeHostImpl::InvalidatecontentOnImplSide
is called only when it's in the impl frame. Actually for devices with
synchronous compositor, e.g. Android Webview, that's not the case as it
may ask for a frame at any time. Updating the DCHECK to fix the crash.

Bug: 832072
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I96c88bf3589aa65eab02ff40bebb9a826cd0266b
Reviewed-on: https://chromium-review.googlesource.com/1101544Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567465}

In https://chromium-review.googlesource.com/c/1096489/, I added this line to
NonOverlappingStack#runSwitchAwayAnimation() to fix another bug (tabs getting
stuck in a partially-discarded state):

startAnimation(0, OverviewAnimationType.UNDISCARD);

It turns out that if this is called while the tabs are scrolling, StackScroller
subtracts the scroller start time from 0 and ends up looking up a negative value
in the SPLINE_POSITION array.

This CL fixes this crash by passing the correct time here.

Bug: 852995,831359
Change-Id: I0186cb9180ef4fff84bf1440acdfd87bc63c47f2
Reviewed-on: https://chromium-review.googlesource.com/1101906Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567464}

Was previously defaulted to voice input modality.
Later there will be a user preference that we defer to.

Bug: b:110174827
Change-Id: I1a0eac49f76a53145589c0095df82b4a2d673d03
Reviewed-on: https://chromium-review.googlesource.com/1100300Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#567463}

Finishes up a few left behind works from the first cl.

1. Handles window items that are still alive but only for animation
purposes by ignoring them in PositionWindows. Previously had some
indexing errors and the windows would bounce around if swipe was used
too quickly.

2. Handles one more case where nudge should not occur - when an item
from the previous row drops down to the nudging row, which looks funny.

3. Use the nudging function described in the bug instead of just linear
interpolation.

Test: added tests
Bug: 843273
Change-Id: I9d2088083a71779fc78f72309b5674f35bc162c7
Reviewed-on: https://chromium-review.googlesource.com/1100389
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567462}

This log is not informative, and spams hundreds of lines in the logs.

TBR=jhawkins@chromium.org

Bug: 824568, 752273
Change-Id: I7dbce85d6b0bd7f9a4389466dad79af5299085e5
Reviewed-on: https://chromium-review.googlesource.com/1101932Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567461}

- Creates TableViewTextLinkItem, which is a text item with link support.
- Uses this item on HistoryTableVC and re-writes updateEntriesStatusMessage to reflect this.

Screenshot:
https://drive.google.com/open?id=1r6hQfWx_Yu8QC32F3hH7_TDq6ZkumHUh

Bug: 805200
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8ac8ad0329f9e0a6e38f9ef7b8f72d5bf0a1c899
Reviewed-on: https://chromium-review.googlesource.com/1094557
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567460}

https://chromium.googlesource.com/catapult.git/+log/78a0b0424642..42e9609fc92e


git log 78a0b0424642..42e9609fc92e --date=short --no-merges --format='%ad %ae %s'
2018-06-14 eyaich@google.com Telemetry tests output SKIP when telemetry fails to run them
2018-06-14 benjhayden@chromium.org Update soundwave and benchmark_health_report to use the new /api/alerts.
2018-06-14 dtu@chromium.org [pinpoint] Pull values comparison out to a separate folder.


Created with:
  gclient setdep -r src/third_party/catapult@42e9609fc92e

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:850503
TBR=sullivan@chromium.org

Change-Id: I6aaa2a1bd056ed30634641d5d314340efdbbe2a1
Reviewed-on: https://chromium-review.googlesource.com/1101658Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567459}

Bug: 852920
Change-Id: Icb2e276b25d51958cb1da4865b267212114b41ab
Reviewed-on: https://chromium-review.googlesource.com/1101680
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567458}

Part of a larger effort to use Fuchsia native zx::channel objects
for smoother integration with FIDL types and API calls.


Bug: 852541
Change-Id: I421819558de9a20fe9e5fa24f083b103b46bd654
Reviewed-on: https://chromium-review.googlesource.com/1101461
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567457}

Bug: 846694
Change-Id: Ib34a6256bbd7bc5358497101968839d26b5051ff
Reviewed-on: https://chromium-review.googlesource.com/1100821
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567456}

Bug: 831648
Change-Id: Ibfc47c24b658a40f7a8f1586a88c5bd2093abed9
Reviewed-on: https://chromium-review.googlesource.com/1091113Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567455}

Inject SecureChannelClient into TetherService, but not TetherComponent yet.
Injection into TetherComponent and subsequent SecureChannelClient usage will come
in subsequent CLs.

This change has allowed me to manually verify that SecureChannelService is correctly
registered at the login screen.

This CL features a small change to FakeSecureChannelClient needed to fix a build
error -- somehow it slipped by before.

Bug: 824568, 752273
Change-Id: I9ba2c35f2ed05ebc3c92b1817e54e8161512f6a8
Reviewed-on: https://chromium-review.googlesource.com/1100481
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567454}

This allows us to reuse dispatching on a custom channel talking
to some DevTools backend.

This needs follow up to remove ExternalHost and unnecessary methods
in HeadlessDevToolsTarget once clients migrate away from it.

Change-Id: Ia32d8feef4dc3f9d85db75b556242f0fbd9428ff
Reviewed-on: https://chromium-review.googlesource.com/1097951Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567453}

* Changes usages of "test" to "[".
* Removes interactive prompts
  * Most developers don't need debug symbols (as indicated by the message that
    used to get printed out).  Now --syms must be passed.  This follows the
    convention of all of the other options, like --lib32, --arm, --nacl, etc.
  * A message is printed out to rerun the script with --add-deb-cross-tool-repo
    if the host machine is Debian Jessie.
* Adds libstdc++ debugging symbols for more versions of gcc including 4.7, 5,
  7, and 8.

BUG=None
R=dpranke

Change-Id: Ia6e941b4f78c3fc4540bcfa23c45885dc402db98
Reviewed-on: https://chromium-review.googlesource.com/1100131
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567452}

We have landed several patches with refactoring and new logic in order
to integrate the baseline alignment into the track sizing algorithm. We
need to run this new logic both during layout and intrinsic size.

Additionally, the CSS WG resolved that when the baseline alignment cause
a cyclic sizing dependency, such items should not participate in such
baseline alignment.

One of the pre-conditions for the above mentioned cyclic dependency is
the need of a synthesized baseline. There are several scenarios that
may lead to this pre-condition, but most of them can be detected by
calling FirstLineBoxBaseline() on the item under evaluation; if we get
-1 as result it means that the item has no baseline and it needs to
synthesize it.

However, the FirstLineBoxBaseline always returns -1 if the item was not
laid out yet. The bug we are trying resolve has its root cause in this
scenario. We are working assuming that an item doesn't participate,
while we request for its Baseline Context during layout, since the
result of the FirstLineBaseline call is different during this phase.

This CL ensures the item is laid our before it's evaluated to
participate in the baseline alignment.

Bug: 850510
Change-Id: I94823f08c8268e36926b074e9f84e67fb9c49baa
Reviewed-on: https://chromium-review.googlesource.com/1096041
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567451}

Refresh implies that Harmony is enabled, so these tests began failing.
They can be safely skipped, as there are equivalent tests for Harmony.

Bug: 846410
Change-Id: I6c6211d4ea99b6df0a4ba9620217574760ba723c
Reviewed-on: https://chromium-review.googlesource.com/1100390Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567450}

By default, keep lines for tests that have no results;
Add a flag to turn on the removal of tests that have
no results.

Reason: For Android-only expectations for tests that
aren't in the SmokeTests file, we probably usually want
to keep the lines.

But for lines for tests that actually don't exist anymore,
we may want to actually remove the lines, so I wanted
to keep the option of possibly trying to remove such lines
(added a flag --remove-missing).

Bug: 850204
Change-Id: I2eabca25ef59373aedb84ec2165271302ddd50a2
Reviewed-on: https://chromium-review.googlesource.com/1089642
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567449}

This covers both enabling it, and enabling DNS over HTTPS.

DNS over HTTPS requires a global URLRequestContext. To handle that, DNS
over HTTPS now also uses the "use_to_validate_certs" NetworkContext,
which has been renamed the "primary" NetworkContext.

Bug: 846883
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idff65040dd67853efd6aa98fdfbeb06b6bd86778
Reviewed-on: https://chromium-review.googlesource.com/1093158
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567448}

Bug: 827648
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie5ada63305913f3a0c8fe1986390ae80db253e4c
Reviewed-on: https://chromium-review.googlesource.com/1092079Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567447}

BUG=none
R=gab@chromium.org

Change-Id: Iad412f446261c0d14867079f60ce553c72a0849f
Reviewed-on: https://chromium-review.googlesource.com/1101328
Commit-Queue: Greg Thompson <grt@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567446}

Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
[4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
fix a use-after-free.

Fontconfig also now requires libuuid as a dependency, so whitelist it as a
dependency since we statically link fontconfig.

[1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
[2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
[3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
[4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
[5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
[6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde

BUG=831146,822737,787020,829890,847323
TBR=thestig,dnicoara

Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
Reviewed-on: https://chromium-review.googlesource.com/1095538
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567445}

Bug: 827404
Change-Id: I30e9c4d44aa3c6583fbe26743dab964e99011d28
Reviewed-on: https://chromium-review.googlesource.com/1101642Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567444}

On Mac, confirm-to-quit is a feature that is enabled with a menu item
in the global menu bar.  On Windows and Linux, this menu bar doesn't
exist, so instead it's put in the settings menu, above the "Exit"
entry.

There's still some debate about whether the setting should go in the
settings menu or in chrome://settings [1], so this may end up not being
the final place for it.  But either way, most of these changes are
still necessary.

In addition, this CL also
* Adds localized strings for Win/Linux
  - The Mac ones won't work due to the difference in the shortcut
    (Cmd+Q vs Ctrl+Shift+Q) and terminology (quit vs exit).
* Moves chrome/browser/ui/cocoa/confirm_quit.h to chrome/browser/ui so
  that some constants etc can be shared between Mac and Win/Linux.
* Adds metrics for the Win/Linux impl.
* Changes PrefNameRegistrar to unregister observers when PrefService
  is destroyed.  This was necessary to prevent a crash when the user
  presses Ctrl+Shift+Q and then closes Chrome using the close button
  while the bubble was showing.  This also fixes some log spam like
  "Pref observer found at shutdown" that used to get printed out in
  all debug builds during browser shutdown.

[1] https://docs.google.com/presentation/d/1JDRUtKAXSON_13Ef9VbURk3L7yonzH9dDCj90BZDA6w/edit?usp=sharing

BUG=243164
R=sky

Change-Id: I671276a41b7878531ea216281f7c994914e1ddf3
Reviewed-on: https://chromium-review.googlesource.com/1099689Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567443}

When I added the incognito toggle button in
https://chromium-review.googlesource.com/1060560, I inadvertently removed some
code from ChromeTabbedActivity#toggleOverview() for reasons I don't recall. This
is now resulting in odd behavior occurring if you tab the tab switcher button
immediately after selecting the "close all tabs" menu item.

This CL re-adds the code I inadvertently removed and fixes this bug.

Bug: 851971
Change-Id: I9c2e5a713c9528f05b7d12938246d44c406ad3d7
Reviewed-on: https://chromium-review.googlesource.com/1101819Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567442}

The ModuleDatabase is the replacement for the EnumerateModulesModel
that is now needed for the IncompatibleApplicationsWarning and
ThirdPartyModulesBlocking features. It has been enabled on all channels
via the experimentation for the incompatible applications warning.

This CL removes the enumerate_modules_model.* files and remove the
ModuleDatabase feature flag. This means that it will now be permanently
enabled.

Bug: 751136
Change-Id: Id49e49ec213dd1a81021346cdd8084ee407f8229
Reviewed-on: https://chromium-review.googlesource.com/1098016
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567441}

Reuse the progress overlay (Throbber with "Confirming card...") to
display a permanent error. The Throbber is changed into an error icon,
and the error is shown in red.

Test is changed to use a long string, for easier UI regression testing.

Bug: 850571
Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError  --test-launcher-interactive
Change-Id: I4d92ce0a8535e92f8707edf6f4444c53e80eea3e
Reviewed-on: https://chromium-review.googlesource.com/1100336
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567440}

Added overrides for GetTopControlsHeight, GetBottomControlsHeight, and
DoBrowserControlsShrinkBlinkSize to
InterstitalPageImpl::InterstitialPageRVHDelegateView. The lack of those
overrides was causing hit testing errors on Android for interstitials.

Bug: 825765
Change-Id: If88506529a8eb3a8cb665edaa6416eeb4e3f8281
Reviewed-on: https://chromium-review.googlesource.com/1101397Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567439}

net::HttpServer is being deprecated. This CL puts them into a separate target
with limited visibility and adds comments.

TBR=dgozman@chromium.org

Bug: 721401

Change-Id: Id2a5be800ec0ceccb94d3a9987adc96d14e7f8b7
Reviewed-on: https://chromium-review.googlesource.com/1076498
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567438}

Specifically fixing the following tests:
MaterialBookmarksActionsTest.All
MaterialBookmarksAppTest.All
MaterialBookmarksCommandManagerTest.All
MaterialBookmarksFolderNodeTest.All
MaterialBookmarksItemTest.All
MaterialBookmarksListTest.All
MaterialBookmarksPolicyTest.All
MaterialBookmarksReducersTest.All
MaterialBookmarksToastManagerTest.All
MaterialBookmarksToolbarTest.All
MaterialBookmarksUtilTest.All

Remaining bookmarks tests will be fixed in a follow up.

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I62bd58f80208e024953b7f44a110a28db07d7cb4
Reviewed-on: https://chromium-review.googlesource.com/1100108
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567437}

Bug: 852159
Change-Id: I6b6f9c3ed2c8117405923d19d1e2b6ffee3e681d
Reviewed-on: https://chromium-review.googlesource.com/1098140Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567436}

This issue did not show up earlier because the old wallpaper picker
only contained jpeg images.

Also changes |shrink_to_fit| to true.

Bug: 852844
Change-Id: Ia26a091ee38a6de43454eda0243ff24386e77da8
Reviewed-on: https://chromium-review.googlesource.com/1101400Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567435}

We currently explicitly add the keyboard container to the root window
in each test case. We might as well do it in SetUp.

We also clean up the tests a bit. This will be helpful when we remove
the keyboard container.

Bug: 849995
Change-Id: I9c188b215bca62f3fd5fddc5478d898106a05a53
Reviewed-on: https://chromium-review.googlesource.com/1098741Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567434}

Recent versions of Widevine support 'cbcs' encrypted files, so add a query
test to verify that it is supported. As well, on systems where Widevine is
not component updated, indicate that the bundled Widevine does support
'cbcs' decryption.

BUG=835009
TEST=new browser_tests pass

Change-Id: Icc4294cca4ac9ba97c2a22816217c57e2262d30a
Reviewed-on: https://chromium-review.googlesource.com/1101405Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567433}

1. BlockSwiftShader() and SwiftShaderAllowed() don't need to be publicly
   exposed.
2. UnlockedSession is just a copy of AutoUnlock at this point. The added
   functionality for |owner_| being null was removed. Replace usage with
   AutoUnlock.
3. GpuDataManagerPrivateImpl::Create() isn't needed. Delete it and use
   std::make_unique<> instead.
4. GpuDataManagerPrivateImpl initialize variables at definition instead
   of in constructor initializer list.
5. Remove UnlockedSession before doing something that might notify
   GpuDataManagerObservers. Observers are already in a
   ThreadSafeObserverList and are notified by PostTask.
6. GpuDataManagerImplPrivate::ProcessCrashed() doesn't need to run on
   browser UI thread. The observers are already notified by PostTask.
7. ScopedGpuDataManagerImpl[Private] doesn't need to hold a raw pointer.
8. Use base::NoDestructor<> instead of base::Singleton<>.

Bug: none
Change-Id: I8bd0829c9fb3b6c11c935872d81bca0971f31629
Reviewed-on: https://chromium-review.googlesource.com/1100974Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567432}

The retry-without-patch recipe flow is currently broken (whoops!!)
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/25559

Bug: 840967
Change-Id: I0beeb5657f79475089fd6bb355263d7b8543796c
Reviewed-on: https://chromium-review.googlesource.com/1101316Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567431}

In the WebVR 1.1 spec, the blink code was informed about devices then sent requests
for pipelines to those devices via the mojo interfaces. In the WebXR spec, the
decision about which device to use is left up to the browser, and not decided
until the pipline request has been made. This CL moves the blink<->device interface
pointers from being call parameters to being return parameters to better align
with WebXR.
As WebVR is being deprecated, as much of the old VR code as is possible
has been cleaned out.

Bug: 842042
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr
Change-Id: I67da418829c05479eb3b2a6c5ef1633d8da92564
Reviewed-on: https://chromium-review.googlesource.com/1080967
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567430}