- 22 Jun, 2018 40 commits
-
-
sebsg authored
Was causing failures on MSAN bots. Change-Id: Icbffe8066bed645404fa792992f84e62ed1e83ca Reviewed-on: https://chromium-review.googlesource.com/1112064Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569769}
-
Mathieu Perreault authored
The chrome-search://ntpicon source will always return an image that is 40dp: either the local favicon (16dp) drawn in the middle of a circle, or a fallback letter in a circle. This simplifies the css and addresses a potential privacy concern. Bug: 853780 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1eccb79f79ce03434e5af78b48a4ae1ed6fe836f Reviewed-on: https://chromium-review.googlesource.com/1111912Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569768}
-
mark a. foltz authored
A spec change requires that URLs with unknown schemes be ignored by the PresentationRequest ctor, to improve interoperability for vendor-specific schemes. This updates the implementation and adds tests for Blink-specific custom schemes. Bug: 825927 Change-Id: I15c72e54c1c44fa1a12139b6c01e2e460d079310 Reviewed-on: https://chromium-review.googlesource.com/1100488Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569767}
-
Dmitry Guketlev authored
String.fromCharCode function fails on long buffers, so it's better to use TextDecoder api here, which can handle long buffers easely. Bug: 480099 Change-Id: I80ce5f39924def4c81577abb5032bdee15b6567d Reviewed-on: https://chromium-review.googlesource.com/1082991 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569766}
-
Kyle Horimoto authored
The SetAccountStatusChangeDelegate() function previously fired a callback after the delegate was set, but that was unnecessary. All of the clients of the function simply passed base::DoNothing() anyway. This CL removes that unnecessary callback. Bug: 824568 Change-Id: Iea3e6e0c85eedb6e3cfcb0147b81e433cc5babac Reviewed-on: https://chromium-review.googlesource.com/1110600 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569765}
-
Lei Zhang authored
Change-Id: I4a325218a3db80731e1a110e1beab38ecc071530 Reviewed-on: https://chromium-review.googlesource.com/1111678Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#569764}
-
Orin Jaworski authored
When multiple tabs are selected, tabs other than the active selected tab are made more opaque to mark selection, but the old opacity of 0.3 was virtually unnoticeable so is here increased. Bug: 848416 Change-Id: I3b833808a77a11b29c00f69f3827c1a60d3f0eb9 Reviewed-on: https://chromium-review.googlesource.com/1112433Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#569763}
-
Mustafa Emre Acer authored
This CL moves decoding code for preloaded data (e.g. HSTS) under net/extras/preload_data so that it can be reused. A future CL will use the net::extras::PreloadDecoder class to extract top 10K domain information from a preloaded data set. Bug: 843361 Change-Id: I3026feaa9034f9c5d09232ea1d43cf1e69c48939 Reviewed-on: https://chromium-review.googlesource.com/1098311Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#569762}
-
Kevin McNee authored
This is to investigate why |last_mouse_move_target_ != last_mouse_move_root_view_| does not guarantee that |last_mouse_move_target_| is a child. Bug: 851958 Change-Id: Ibe2f7aed89d83fa55dbc26af8bf995cd4fce049f Reviewed-on: https://chromium-review.googlesource.com/1112478Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#569761}
-
Quan Nguyen authored
Bug: 836861 Change-Id: I6ac30f0e187750b55cd7f14bd39f5d477497c003 Reviewed-on: https://chromium-review.googlesource.com/1109208 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569760}
-
Ryan Tseng authored
Theres's a working theory that it's just a bad bot. run 2 bots concurrently and check results. Bug: 855396 Change-Id: I44da7322a5302b7d571eff3eb768f926c5cad9c7 Reviewed-on: https://chromium-review.googlesource.com/1112065Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569759}
-
Sebastien Marchand authored
Bug: 773383 Change-Id: Ib67d9922a1fa05074c4036e92c3feddbb00849ce Reviewed-on: https://chromium-review.googlesource.com/1103791 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569758}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a49103801e3..9fff1c76c108 git log 0a49103801e3..9fff1c76c108 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 tsepez@chromium.org Avoid some duplicate const/non-const getters. 2018-06-22 hnakashima@chromium.org Fix overflow in CFX_RenderDevice::DrawFillStrokePath(). Created with: gclient setdep -r src/third_party/pdfium@9fff1c76c108 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853430 TBR=dsinclair@chromium.org Change-Id: I80e5560f05738ff3bc26b3d9d6783621908fe281 Reviewed-on: https://chromium-review.googlesource.com/1112218Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569757}
-
W. James MacLean authored
This CL contains a mitigation for the null pointer dereference that is at the root of the associated bug. Once this mitigation is confirmed, we'll request a merge to M-68. TBR=bokan@chromium.org Bug: 845097 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfffdbe95c5d3b0e340c053f71056d88d75af3ac Reviewed-on: https://chromium-review.googlesource.com/1112483Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#569756}
-
Nico Weber authored
Bug: 855584 Change-Id: I855566a5a9db76b68f2b182ca95b9617c81a6822 Reviewed-on: https://chromium-review.googlesource.com/1112476Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569755}
-
Kyle Horimoto authored
This CL: (1) Initializes the SetupFlowCompletionRecorder and AccountStatusChangeDelegateNotifier classes when the service starts up. Previously, they were not actually integrated into the service. (2) Adds a MultiDeviceSetupInitializer class which initializes the service by waiting until the DeviceSyncClient has loaded the local remote device before continuing. This task must complete before AccountStatusChangeDelegateNotifier is created as that class assumes that the client has been fully initialized. (3) Adjusts ProfileImpl to pass various parameters to the service which are required for the initialization described above. Bug: 824568 Change-Id: I09240f00d29cd44e2768e3068b3284abe16b3801 Reviewed-on: https://chromium-review.googlesource.com/1110953Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569754}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ibbb0b3e981bb7c21a7022ca7b72f2c28e6b70f06 Reviewed-on: https://chromium-review.googlesource.com/1112349Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#569753}
-
Alexei Svitkine authored
Previously, it would clobber state when going out of scope, which is undesirable. Bug: 854812 Change-Id: I2fd2859b28eed5e8247361da3b105068b348813b Reviewed-on: https://chromium-review.googlesource.com/1112481Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#569752}
-
Scott Violet authored
And this also changes ws2 to only stop cancelable events. To do otherwise triggers a CHECK in Event. BUG=837686 TEST=covered by tests Change-Id: I6bc3d8b6a02eda1ecf7b7aecec6729a9ef7b1a2e Reviewed-on: https://chromium-review.googlesource.com/1111268 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#569751}
-
Jennifer Apacible authored
These strings will be used for the dialog that appears when the user: - is closing the tab or window that initiated a Picture-in-Picture session, or - is navigating away from a page that initiated a Picture-in-Picture session. Dialog implementation is in progress. Bug: 809982 TBR: grt@chromium.org Change-Id: I060fb2f21fc93361aeb11f4b605b5012d369e28c Reviewed-on: https://chromium-review.googlesource.com/1112304 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569750}
-
inglorion authored
Updates some commands to run try jobs that have moved to LUCI, and adds linux_chromium_chromeos_msan_rel_ng. Change-Id: I9048da9f6dcb897b5125183d3f66b5995e740de8 Reviewed-on: https://chromium-review.googlesource.com/1112347 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569749}
-
Bo Liu authored
There is evidence that android is oom killing strong binding processes while there are still processes with lower importance bindings. So add an UMA to explicit track this. Keep an int array of counts of each binding state in ChildProcessConnection. Also take this opportunity to properly add a lock for cross-thread access. Then pass the counts up through ChildProcessTerminationInfo and CrashDumpObserver::TerminationInfo. The new UMA only records the counts as bools, but can add a histogram of counts later if needed. Bug: 855037 Change-Id: I6c6fe8828d1e571b2fd8fb2404f124377bd19752 Reviewed-on: https://chromium-review.googlesource.com/1108750Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#569748}
-
Niklas Hambüchen authored
Before 0.5, render strings looked like this: Gallium 0.4 on llvmpipe (LLVM 4.0, 256 bits) now they look like this: llvmpipe (LLVM 5.0, 256 bits) Change the regex accordingly to avoid accidentally not matching the llvmpipe renderer string. Bug: 854437 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I14a7a7631880b2dcfcd3af5eeb6c01d5be32edb6 Reviewed-on: https://chromium-review.googlesource.com/1108216 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569747}
-
Eric Stevenson authored
Change-Id: I5fb983c8f31a1b548b4776588e46f49bf5d0aa80 Reviewed-on: https://chromium-review.googlesource.com/1112062Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569746}
-
Ran Ji authored
Bug: 831863 Change-Id: I7ac3dfbc5656b0aa71984571fa7c4791f0bacce2 TBR=yfriedman@chromium.org Change-Id: I7ac3dfbc5656b0aa71984571fa7c4791f0bacce2 Reviewed-on: https://chromium-review.googlesource.com/1110478 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#569745}
-
Eric Stevenson authored
This CL fixes a regression where gclient sync failures were causing the build step to be skipped. Also fixed a problem where the script would fail because of missing llvm bin tools. Now these tools are copied to the temporary dir we use for supersize. Bug: 855124 Change-Id: Iabc82938aec54f853a2631d107d7d1f8c57c3696 Reviewed-on: https://chromium-review.googlesource.com/1112487Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569744}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5a26a769e69..c48318a35b17 git log c5a26a769e69..c48318a35b17 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 ehmaldonado@chromium.org bot_update: Don't force solutions to be unmanaged. Created with: gclient setdep -r src/third_party/depot_tools@c48318a35b17 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812,chromium:853032 TBR=agable@chromium.org Change-Id: I854ba50b5081e06e1c192132a80c19db2a107e26 Reviewed-on: https://chromium-review.googlesource.com/1112222Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569743}
-
Daniel Murphy authored
Session was assuming that InitiateConnection() would always complete asynchronously. In tests, this doesn't happen. This fixes one case where a callback was registered after the call to InitiateConnection() Bug: 716490 Change-Id: I606446ba5e5ba5907c9c37ab440cc38bef2838d8 Reviewed-on: https://chromium-review.googlesource.com/1112486Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#569742}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic03d0c70bedfa019a587178bbe833890989b400f Reviewed-on: https://chromium-review.googlesource.com/1112490 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569741}
-
Ken Buchanan authored
The current behavior to allow mouse input in the browser process to be locked to a given RenderWidgetHost is to send all mouse input between a MouseDown and a MouseUp to the same target. This is not in accordance with spec, and causes some site breakage. Whether a MouseDown should cause capture depends on the node that the event hits. Drag-highlighting text or clicking the thumb part of a scrollbar require capture, for instance, while most elements do not. This change removes the implicit capture currently done in the browser, and replaces it in the case of scrollbars with an explicit signal from Blink to start capturing. Other cases requiring capture still need to be implemented. Bug: 647378, 849862 Change-Id: Ifc4b690c36927ed48edd2604d40742e130295dcf Reviewed-on: https://chromium-review.googlesource.com/1099183 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569740}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/694c8ff073d5..6ec076ceabc3 git log 694c8ff073d5..6ec076ceabc3 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 nya@chromium.org gs: Use Stainless log browser everywhere in chromite. Created with: gclient setdep -r src/third_party/chromite@6ec076ceabc3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1801a8453204639bf0683f2b2c61c779b886340b Reviewed-on: https://chromium-review.googlesource.com/1112221Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569739}
-
David 'Digit' Turner authored
Chrome currently crashes on startup on Android if the system locale is set to something that it doesn't support. For example, set the system locale to 'Furlan': regular Android applications will fallback to display English strings as a fallback, but Chrome crashes on startup immediately. This CL fixes the issue, by detecting which locale the Android framework uses to display strings effectively, then using this value to extract the corresponding .pak file, instead of trying to find one that matches the current system setting. + Move compressed locale file detection to background thread. Since this now requires I/O access when accessing the resources, this operation can no longer be performed on the UI thread. For more details, see associated bug entry. BUG=846633 R=agrieve@chromium.org,astevenson@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org Change-Id: If2db6136367081ad50b2b80c85b4cc0e1c2c276f Reviewed-on: https://chromium-review.googlesource.com/1088708 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#569738}
-
Mike Dougherty authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib34a317f87110d54572003bb1c1beca31b1cf9f1 Reviewed-on: https://chromium-review.googlesource.com/1108394 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569737}
-
Min Qin authored
This CL stops DownloadDBCache to immediately updating the DB. Instead, it caches the change and only update the DB when timer fires. Some of the updates are considered high priority and will thus flush to DB immediately. Bug: 850990 Change-Id: I124ac1c69e5c7e6bd609d656be3ac1a938f78c63 Reviewed-on: https://chromium-review.googlesource.com/1102084Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569736}
-
Xiaocheng Hu authored
When hit testing a list marker, we should hit the corresponding list item element. This patch implements the same behavior in LayoutNG. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d191098a444cf276b917451ae1f9ab4a0df2d88 Reviewed-on: https://chromium-review.googlesource.com/1111270Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
cathie chen <cathiechen@tencent.com> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#569735}
-
Kim Paulhamus authored
Removes the NOT_IMPLEMENTED placeholder. Bug: 678885 Change-Id: I4572dc2e6aad8019b383b93173b7962cc97ad60d Reviewed-on: https://chromium-review.googlesource.com/1109498 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569734}
-
Manuel Rego Casasnovas authored
In r543079 we added support for calc() in grid gutters. In that patch we modified LayoutGrid::GridGap() but we forgot to do the same in LayoutGrid::AvailableSpaceForGutters(). This patch just changes the IsPercent() call by IsPercentOrCalc() that way calc() gutters are considered too when looking for the available space. BUG=816300 TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002.html TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html Change-Id: I3237d5dc73f508cea6d904b9f1fd3822bb9efe55 Reviewed-on: https://chromium-review.googlesource.com/1112237Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#569733}
-
Sebastien Marchand authored
Bug: 773382 Change-Id: Ibaf68d29185611ffbd3563330ab7c3d23ca4f7e8 Reviewed-on: https://chromium-review.googlesource.com/1106053 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569732}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e3b12b3e7d98..fa74d9840634 git log e3b12b3e7d98..fa74d9840634 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 perezju@chromium.org [Telemetry] Should not "warn" when computing TBM 2018-06-22 perezju@chromium.org [Telemetry] Do not raise on missing devtools clients for clock sync Created with: gclient setdep -r src/third_party/catapult@fa74d9840634 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854212 TBR=sullivan@chromium.org Change-Id: I228ac2a4d7ae2ad4ae535d3dd69fe390b0c73c44 Reviewed-on: https://chromium-review.googlesource.com/1112119Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569731}
-
Ryan Tseng authored
Going to switch this to a larger bot and turn off Goma for the time being. Change-Id: Ia09d67b6acdb03ba1228ea3a73bc41da959d1dba Reviewed-on: https://chromium-review.googlesource.com/1112477Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569730}
-