- 06 Oct, 2020 40 commits
-
-
James Cook authored
Move the ChromeOS.* prefixed metrics into their own file/directory. Most of these metrics are not general Chrome browser metrics, and this will let us have a separate OWNERS file once we train up some reviewers. Bug: none Change-Id: If42613c021c44e0e0639ec68db6f012416046c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446519 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#814122}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 988a0b63. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ied524cd5922082cd36afb646f732ab9c96ce2eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451534Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814121}
-
Anders Hartvoll Ruud authored
We currently have several unit tests that check that some selector list containing :is or :where either fails or passes parsing. That's all well and good when selector lists are parsed the normal way, but with <forgiving-selector-list> [1] support (in a future CL), a simple selector :is(...) can't really fail parsing: it will just end up empty in the worst case. Hence, this CL makes preparations such that it's easier to write tests for these "partial" parse failures. While at it, tests are also converted to parametric tests. This makes it easier to run individual tests when something is failing. There should be no behavior change, nor any change in test coverage. [1] https://drafts.csswg.org/selectors/#typedef-forgiving-selector-list Bug: 568705 Change-Id: I81119599d378a5067cd3d08c5dbdc7e3de2f1ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450153Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#814120}
-
Takashi Sakamoto authored
AllocNewSlotSpan allocates kSuperPageSize memory if there is no available pages, but returns only 1 slot span. So AllocNewSlotSpan should make 1 slot span accessible. (the slot span size is provided by get_bytes_per_span()). This patch also fixes total_size_of_committed_pages. For normal buckets, total_size_of_committed_pages are updated in the following way: - PartitionBucket::AllocNewSlotSpan increases by get_pages_per_slot_span()*PartitionPageSize(). - PartitionBucket::SlowPathAlloc increases by get_bytes_per_span() when recommitting pages. - PartitionPage::Decommit decreases by get_bytes_per_span(). get_bytes_per_span() is not always equal to get_pages_per_slot_span()*PartitionPageSize(), because get_pages_per_slot_span() is a natural number of PartitionPages (calculated by get_system_pages_per_slot_span()). E.g. num_system_pages_per_span is 3 (0 < num_system_pages_per_span < MaxSystemPagesPerSlotSpan()). Change-Id: Ie46c9099086bd88afa6ee9f654cd98f21935d493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444671 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#814119}
-
Ce Chen authored
header into anonymous namespace. For simplicity I did not make any changes other than moving declarations, adjusting orders for these private functions/nested classes. Bug: 925072 Change-Id: Iafeaa2d71b18328061844721187e061bedeb32a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444674Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#814118}
-
Shakti Sahu authored
This CL 1 - Moves the top level Java code from chrome/android to chrome/android/app/video_tutorials 2 - Some other fixes from a previous CL Change-Id: I94ed7c3d97cfb537ff9c26c50b785fb7144defa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444131 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#814117}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org NOTRY=True Bug: 1134723, 1134724 Change-Id: I5e0cf1d84d01c37fbcaa47ea002179739b572880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451990Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814116}
-
Fergal Daly authored
It is no longer called. Only 1 real implementation existed. Delete SetAsInterstitial from ContentSettingsAgent, it's unused now. Change-Id: I995a6944115e192a4c213b8f3689130414458927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397110 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#814115}
-
Marko Ivanovich authored
The test ChildFrameCrashMetrics_ScrolledIntoView might fail if we wait for WidgetHostMsg_WaitForNextFrameForTests_ACK, because it is sent from compositor thread, almost independently from FrameHostMsg_UpdateViewportIntersection, which is sent from main thread. Problem can be reproduced deterministically if we put sleep in RenderFrameProxy::UpdateRemoteViewportIntersection, to simulate preemption by OS scheduler. What we really want to wait for in this test is viewport intersection update in UI thread. Only after that we can check histograms. If we wait for lifecycle update, that will guarantee that all IPCs are processed in browser, including FrameHostMsg_UpdateViewportIntersection. Change-Id: I1ff2e6632b2f1391a3dee82b2bc6667bb20bf71d Bug: 1115096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307373Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#814114}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/315b9a55a9b5..f76601902650 2020-10-06 kimanh@chromium.org Skip wasm stepping tests until naming is fixed in v8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134531 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I40c50dc7dd68070cf496c36b432e1e3c6bff179a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451427Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814113}
-
Aaron Leventhal authored
This will help online word processors such as Google Docs mark which elements in the page are repeated content. There are no specific ATK/IA2 role mappings currently. For now, ATs on Windows and Linux can use the xml-roles object attribute. See https://w3c.github.io/dpub-aria/#doc-pagefooter and https://w3c.github.io/dpub-aria/#doc-pageheader AX-Relnotes: Add new doc-pageheader and doc-pagefooter roles from DPUB-ARIA 1.1. Skip-Translation-Screenshots-Check: True Bug: 1134999 Change-Id: If360a51eb44c1cf2beb1315f1ba48134513dddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448689 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814112}
-
Ramin Halavati authored
Metrics are added to measure different code paths in off-the-record profile destruction, specifically when destruction is delayed due to delayed RPHs. Bug: 1033903 Change-Id: Ibc8c82c3f8c4d569c34e57aad1b508eff9eb32c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440625Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#814111}
-
Kent Tamura authored
Move the main logic of |LayoutTextControl:: ComputeIntrinsicLogicalWidths()| to TextAreaIntrinsicInlineSize() and TextFieldIntrinsicInlineSize() in layout_box.cc like other form controls' intrinsic sizes in order to share the code with LayoutNG. * CalculateMinMaxSizesIgnoringChildren() and |LayoutBlock:: ComputeIntrinsicLogicalWidths()| <textarea>'s intrinsic size should not depend on scrollbar existence. So we need to subtract the scrollbar thickness if a scrollbar exists. This CL has no behavior changes. Bug: 1040826 Change-Id: If864ca96c0cdc4409b465b90cb4be018dd0f14c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449673Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/347e5dc37127..fa5ff7d234b8 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ed3a93f690de to 326e14f34bb5 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I0c5b069efa5da017a9ee6583900a619a6ec1c454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451642Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fca083c57b5f..3a384ed186dd 2020-10-06 thestig@chromium.org Use DCHECK_IS_ON() in cfx_char.cpp. 2020-10-06 nigi@chromium.org Roll v8/ c577d027e..88d84cce1 (632 commits) 2020-10-05 nigi@chromium.org Roll buildtools/ ff93f3ea1..4be464e05 (3 commits) 2020-10-05 nigi@chromium.org Roll third_party/instrumented_libraries/ 3c52ccdd3..6ba978ccb (1 commit) 2020-10-05 nigi@chromium.org Roll third_party/skia/ d20e8e933..4c3486e6f (572 commits; 1 trivial rolls) 2020-10-05 nigi@chromium.org Disable embedder tests which fail with Skia/SkiaPaths enabled. 2020-10-05 nigi@chromium.org Roll third_party/libjpeg_turbo/ 9d4f8005b..d5148db38 (12 commits) 2020-10-05 nigi@chromium.org Roll third_party/zlib/ d53accfbd..26211a5a8 (6 commits) 2020-10-05 tsepez@chromium.org Pass spans of floats to CPDF_ColorSpace::GetRGB(). 2020-10-05 thestig@chromium.org Make variable naming consistent in CPDF_TextPage::GetRectArray(). 2020-10-05 thestig@chromium.org Replace ASSERT() with DCHECK() in various xfa dirs. 2020-10-05 nigi@chromium.org Roll third_party/icu/ 79326efe2..aba3f0dfe (8 commits) 2020-10-05 thestig@chromium.org Move FPDFText_GetLooseCharBox() logic into cpdf_textpage.cpp. 2020-10-05 nigi@chromium.org Roll third_party/depot_tools/ ed15af5c4..422c039e8 (82 commits; 44 trivial rolls) 2020-10-05 thestig@chromium.org Move CAgg_PathData out of fx_agg_driver.h. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I032363e1edfff4cdb5378ca692070f30fef64097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451889Reviewed-by:
-
Yusuf Sengul authored
Bug: 1133940 Change-Id: I814be90c998fbfae5f9456c00f62f82c5f518af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441297 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#814107}
-
Prashant Nevase authored
This patch adds enable-raster-side-dark-mode-for-images switch to enable raster side dark mode for images and initial functionality to enable RSDM for bitmap images. PaintFlags will carry the |use_dark_mode_for_image_| bit for specifying whether the compositor should use a dark mode filter when rasterizing images. Bug: 1094005 Change-Id: I424c9397235733fb07df4f1cad7bb758399fded9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445890Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#814106}
-
Gavin Williams authored
This change directly creates the WebApplicationInfo struct for the Print Management SWA installation. Replace existing SVG icon with the adaptive PNG icon. Fixed: 1126753 Change-Id: I5fb8c4b0e3c60f92dc4531083313aa6175aa0c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439427Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#814105}
-
rbpotter authored
NTP also adds its own custom grit define that is separate from the standard chrome grit defines, so modify preprocess_grit.gni to allow passing extra grit defines to preprocess_grit. This also enables the possibility of copying some mojo files to the new preprocessed folder for bundling in future (planned for a followup). Bug: 1128583 Change-Id: Iaa42fe3dab695c77c75f413e9b7a7a6fddb7cbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430584 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#814104}
-
Wei Lee authored
Extend it to milestone 89. Bug: 980846 Test: None Change-Id: I599339e61a5578ce25edeedffff2bbb86d76d7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450138 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814103}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.7-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7643d0cb24cdd7fac96b4009098feb3cd3af1967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451890Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da7feb74237d..1b5b5a87753a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sidereal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:894045 Tbr: sidereal@google.com Change-Id: I30f704c9bb27cc44490b866bdbe6e51e4521672d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451640Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814101}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.7-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9495e78b742b2b2f27804bfcd1d90e1de9898174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451643Reviewed-by:
-
Sophie Chang authored
Bug: 1112500 Change-Id: I86909b9361fa2d438a258a1fb03b65d40f277cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427206Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814099}
-
Yunke Zhou authored
Bug: 1132761 Change-Id: I7c1692e80bf6c593cb56f746245b5a2a25cf8bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438379Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#814098}
-
Christopher Cameron authored
This workaround is based on data gathered on Intel Macs. While it has a performance impact, it significantly reduces the GPU crash rate. The performance impact on ARM is more significant, and there is no evidence that this is needed (yet). Bug: 1131312 Change-Id: Ibd4b3940172820e17d0dc7607842118aba75c038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447044 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#814097}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.7-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If64f0b7796d3087c5c1814949fd2ed0e0ef0bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451949Reviewed-by:
-
Xing Liu authored
This CL starts to implement the glue code in bookmark_bridge.cc, it loads the reading list folder in bookmark root page. Bug: 1128074 Change-Id: Ib3259e8c799242f033cd5778876df9211c3f6cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441319 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#814095}
-
dpapad authored
Bug: 1132403 Change-Id: I43f2f0e7c35f72d2a34b50b56138b78a1a10609f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442377 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Fergus Dall authored
This reverts commit a358e673. Reason for revert: Breaks mojo_unittests on Chrome OS See first bad builds here at the following links: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8988 https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/9326 Original change's description: > Adds mojo_base.mojom.ReadOnlyFile > > Adds a mojo ReadOnlyFile that won't serialize if it can be written. > > The expectation is that this handle will then be sent to another process > which lacks the rights to add any write permissions to the handle. This > may not be true on all platforms but is useful where this holds. > > Code to check for readonly-ness is implemented within mojo rather than > base::File as it is (a) difficult to say in general what it means to be > readonly, and (b) not possible on every platform. > > Bug: 1130762 > Change-Id: I6f00934005da7e433af4fee94454dfcd28dfd3c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417549 > Commit-Queue: Alex Gough <ajgo@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813987} TBR=kinuko@chromium.org,rockot@google.com,mpdenton@chromium.org,ajgo@chromium.org Change-Id: I1af4a3ae23a86ee91a825243f74fd94fb0f26f53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451929Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#814093}
-
Peter Kotwicz authored
This CL changes the KNOWN_TYP_TEST_RUNNERS matching to occur against the script basename. BUG=11353980 Change-Id: I8556d1abb29bbcd1ce0494f55f3761e99dc08cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450492Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814092}
-
John Abd-El-Malek authored
This was propagated only on Android and not desktop because of tests that inadvertently depended on this. -history test said it wanted no user gesture, but ui_test_utils::NavigateToURL always enabled it -dice code was setting user gesture but this wasn't propagated so it wasn't necessary -download tests: I'm unsure if the tests were correct or if there are bugs to fix in the production code. For now setting user_gesture to false to simulate old behavior before this change -signin_view_controller: no-op change since this is a browser initiated navigation so the user_gesture was always ignored Fixes: Bug: 1132491 Change-Id: Ib3486090d4d18a66e0e76f9135b45a7abcbdaf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430451Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#814091}
-
Ian Kilpatrick authored
This patch moves the layout-overflow calculation "into" NG. It does several interconnected things: - Just before a fragment is created we calculate the layout-overflow for a fragment. This is more correct than doing it for the layout object as a whole, resulting in more multi-col passes. The additional regression was caused the layout-overflow calculation hiding a bug with large column gaps (which exceed the inline-size of the container). - Once this is calculated, we run the SetLayoutOverflowFromLayoutResults function which "joins" all the layout-overflow from the fragments into the layout-object, used for JS API calls. - Finally there is the LayoutNGMixin::RecalcLayoutOverflow which allows for recalculating of layout-overflow, and correctly rebuilding the fragment-tree. Bug: 1066616 Change-Id: I25987a32b0254eafc2d7aad90ef6a36b60f1e1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333083 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0ff24ae00769..da61c40e99c3 2020-10-06 kainino@chromium.org Revert "Work-around test runner & DebugAnnotator" 2020-10-06 jmadill@chromium.org Change shader compile failures into an info message. 2020-10-06 jmadill@chromium.org Test Runner: Pass dEQP args to child processes. 2020-10-06 jmadill@chromium.org Test Runner: More misc improvements. 2020-10-06 ianelliott@google.com Work-around test runner & DebugAnnotator 2020-10-05 jmadill@chromium.org KHR_debug: Fix off-by-one message length. 2020-10-05 jmadill@chromium.org Suppress failing Mac GL dEQP-GLES3 tests. 2020-10-05 vantablack@google.com Replaced allow_list with files_to_check 2020-10-05 jmadill@chromium.org Improve capture replay tests. 2020-10-05 jmadill@chromium.org Capture/Replay: Don't capture XFB 0 in MEC. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ib2806471c642f8dbb846c7a85b4d8736c7938746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451632Reviewed-by:
-
Findit authored
This reverts commit 325dbbc8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 814073 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMyNWRiYmM4NTkwM2M5NjUwMDFmNmI2NmI0MWE3YzNhMGE5NmU0OGUM Sample Failed Build: https://ci.chromium.org/b/8867218581185660560 Sample Failed Step: compile Original change's description: > [Feed v2] Allow setting feed stream data in feed internals page > > Bug: none > Change-Id: Iecc0cb44e239c1b4502e81bc50931230732af61a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429930 > Commit-Queue: Jian Li <jianli@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814073} Change-Id: Iddd3027f84e54727f4f0dc5f905a5e1e330b16d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450611 Cr-Commit-Position: refs/heads/master@{#814088}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d93ee76664c7..315b9a55a9b5 2020-10-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I18160df4c466834b64010a5aabb3df1ebccf4c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451638Reviewed-by:
-
Kuo-Hsin Yang authored
SystemMemoryPressureEvaluator::GetMarginFileParts is replaced by GetMemoryMarginsKB, such that SystemMemoryPressureEvaluator is not required to get the margins. BUG=b:149833548 Change-Id: I948e576b5a36ce24590c48a36e0416cfc679979e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418272Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#814086}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //storage. Bug: 1113033 Change-Id: I9be522584e795c85ed77ffeccace1a088d818233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451393 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#814085}
-
Minoru Chikamune authored
This CL adds CreateAgentGroupScheduler function to WebThreadScheduler so that it can be called from the content layer. Bug: 1105403, 1113102 Change-Id: I2449185c485b2d803a0f2eb5deebc2076cdac1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444620 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#814084}
-
Fergus Dall authored
TBR=dgozman@chromium.org TBR=pfeldman@chromium.org TBR=caseq@chromium.org TBR=yangguo@chromium.org Bug: 1046784, 1102964 Change-Id: I44c12d89054dc27ed43a2be06a4ac77249ce696d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449514Reviewed-by:
-
