- 27 Apr, 2018 40 commits
-
-
Mina Almasry authored
Currently this method seems to occasionally return invalid values, which causes following logic to lead to a crash. Until that is root caused, ignore obviously invalid values from GetCurrentPts. BUG= b/78592779 TEST= On device Change-Id: Ib3c93d66659507234ab7cbe5961cb4e6fc2ebae5 Reviewed-on: https://chromium-review.googlesource.com/1031870 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#554526}
-
Ian Clelland authored
When an image policy is violated, and the image is flagged for color inversion, recalc the style so that the change is actually rendered to screen. Bug: 837346 Change-Id: I2cb4f84432d03917435294af01c5b9ecc85a0fc2 Reviewed-on: https://chromium-review.googlesource.com/1033544 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#554525}
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //components. R=blundell@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I14f72dd481c02acdc8ea35d58d9fb4801140d353 Reviewed-on: https://chromium-review.googlesource.com/1031090 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554524}
-
Maks Orlovich authored
net-export is being moved to be NetworkContext-based as part of servification, so a NetworkContext object is needed for the URLRequestContext that the net-export UI on iOS uses. This is largely based on https://chromium-review.googlesource.com/952342, which added such wrappers for BrowserContext URLRequestContexts, and much of the CL is just moving out the NetworkContextOwner that added into its own file. Bug: 767450 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7c71b508c54389dc3aa30973cd1ea131b48d64d9 Reviewed-on: https://chromium-review.googlesource.com/1030053 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#554523}
-
Manuel Rego Casasnovas authored
In LayoutBox::ComputeLogicalHeight() we actually were using the right method because the border and padding were being added later. We could change it to use OverrideLogicalHeight() directly and add the border and padding only for replaced elements, because ComputeReplacedLogicalHeight() returns the content height (so it doesn't include border and padding). No new tests, covered by existent tests. Change-Id: I90112ee1d6e7a2332f61514f627dc10cf4a706b8 Reviewed-on: https://chromium-review.googlesource.com/1031350 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#554522}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie0b81bdd3c7f58fe8079368c2dfcf7b2c4a0b0d3 Reviewed-on: https://chromium-review.googlesource.com/1033826Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#554521}
-
https://chromium.googlesource.com/angle/angle.git/+log/467c15f970b9..f1bcd017c95c $ git log 467c15f97..f1bcd017c --date=short --no-merges --format='%ad %ae %s' 2018-04-27 geofflang Supress failures in BlitFramebufferTest.MultisampleDepth on Mac OpenGL 2018-04-26 oetuaho Add test coverage for BlitGL Created with: roll-dep src/third_party/angle BUG=chromium:837717 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ied90fe177b9021ac1401ffa9b7876aa7d504b220 Reviewed-on: https://chromium-review.googlesource.com/1033573Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554520}
-
Maksim Ivanov authored
Gather statistics on the number of cases when the fatal Chrome OS user policy initialization happens, which leads to termination of the user session. BUG=chromium:830654 TEST=none Change-Id: Iae8e2455e36e3daae5663b3ff2266199bd6283dd Reviewed-on: https://chromium-review.googlesource.com/1017124Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#554519}
-
Oksana Zhuravlova authored
Bug: 799482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr Change-Id: I976a9290ef77976187ce971e461814a887620ee2 Reviewed-on: https://chromium-review.googlesource.com/1028000 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#554518}
-
Sarah Hu authored
The requested keyboard layouts will be used in public session UI to populate a selection menu. (In a follow-up CL) Bug: 809635 Change-Id: I1154647d4bfdf3637ec37033f4452742c71ec377 Reviewed-on: https://chromium-review.googlesource.com/1020664Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554517}
-
Gabriel Charette authored
Patch set 1 changes were initially scripted as part of the effort to restrict exposure of the raw MessageLoop*. Further manual cleanup was done after identifying that MockLaunchd itself didn't need the full power of a MessageLoop*. Please CQ if LGTY This CL was uploaded by git cl split (initially). Bug: 825327 Change-Id: I6c250e0b44c27df6792fe0fbdad4a78608a98441 Reviewed-on: https://chromium-review.googlesource.com/1024453 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#554516}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1589d897. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16307 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mek@chromium.org: external/wpt/webmessaging TBR=foolip No-Export: true Change-Id: I52f68c0c3d5d6d3eec32886f8432d712290b3f28 Reviewed-on: https://chromium-review.googlesource.com/1033432 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554515}
-
Sebastien Marchand authored
Implement HistoryServiceObserver::OnURLsDeleted to remove all observations when the history gets cleared. BUG: 773382 Change-Id: I65026cfda256c252e33aea01d6c8db8fef30dd10 Reviewed-on: https://chromium-review.googlesource.com/1030853 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#554514}
-
lgcheng authored
Arc usb permission are not restores correctly. When detecting a non-matching package, we should skip rather than abort. Bug: 837292 Test: Manual test with reboot. Change-Id: Id66156dcee36873f8afccaab5a619bafffd3721a Reviewed-on: https://chromium-review.googlesource.com/1030785 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554513}
-
Elly Fong-Jones authored
This test doesn't pass when using Views browser windows on any platform, so skip the body on Mac when not using Cocoa windows. TBR=tapted@chromium.org Bug: 834754 Change-Id: I4c2d447ea5ef878eaf4e395195606be1951a0dae Reviewed-on: https://chromium-review.googlesource.com/1033439 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554512}
-
Eugene But authored
The implementation simply calls GetErrorPage. This method returns HTML for web based error page rendered in WKWebView. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie68e8e052d06f8106a9209f21f811dc323a5ab5e Reviewed-on: https://chromium-review.googlesource.com/1033023 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554511}
-
Morten Stenshorne authored
Whether an in-flow block-level box that establishes a new formatting context fits beside a float or not determines whether the float is adjoining with the new formatting context box or not. This matters if the box that establishes a new formatting context has a top margin. If the float turns out to be adjoining, it's affected by that margin, but not otherwise, i.e. if the new formatting context box needs to go below the float due to insufficient available width. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I66455845974cbcd5bef36927876512b05a15f435 Reviewed-on: https://chromium-review.googlesource.com/1032732Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#554510}
-
Stephen Martinis authored
This reverts commit aac2bcc1. Reason for revert: Windows path issues hopefully fixed Original change's description: > Revert "Re-add layout tests to win7 bot" > > This reverts commit d7a83cd8. > > Reason for revert: bots are still infra failing > > Original change's description: > > Re-add layout tests to win7 bot > > > > Bug: 831585 > > Change-Id: I3436ca3abe39a648a150d703173715f69756e508 > > Reviewed-on: https://chromium-review.googlesource.com/1028009 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553868} > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > Change-Id: I4d08d6e21a0ac4622d7a936ff92a5bd795d5af13 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 831585 > Reviewed-on: https://chromium-review.googlesource.com/1031530 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554165} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: I13aa35358d093b09b14125ffe62535ddc4c77ffd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831847 Reviewed-on: https://chromium-review.googlesource.com/1033792 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#554509}
-
Ehsan Chiniforooshan authored
Bug: 832981 Change-Id: I230384753592e4397d164460a9cc953c17b10daf Reviewed-on: https://chromium-review.googlesource.com/1033343Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554508}
-
Saman Sami authored
There has been a 50/50 finch trial on canary and dev going on for this feature and no issues has been reported. Bug: 813929 Change-Id: I79012e9cfa06dfac57c73479aa80d09a050c0395 Reviewed-on: https://chromium-review.googlesource.com/1032889Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#554507}
-
Xiaohui Chen authored
Bug: b:78589509 Test: locally build and run Change-Id: I862691a0bb5774e9761f5202cd2a23f08099061b Reviewed-on: https://chromium-review.googlesource.com/1031092Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#554506}
-
Pavol Marko authored
Introduce a new PolicyValidationReportRequest which will be used to upload the results of policy validation after policy fetches. BUG=794848, b:70641944 Change-Id: I21d9fc52c82ff865a0877254c3c09db61e410547 Reviewed-on: https://chromium-review.googlesource.com/913573 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#554505}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bec9b446c412..6b3c651c4ed2 $ git log bec9b446c..6b3c651c4 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 jkop chromite: Turn down stage-level VM test retries Created with: roll-dep src/third_party/chromite BUG=chromium:823832 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4bea87876cbf4c369ed68730fa7f378c4113fbd2 Reviewed-on: https://chromium-review.googlesource.com/1033025Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554504}
-
Sunny Sachanandani authored
The minidumps don't show anything out of the ordinary for the aliased variables when this hang happens. R=zmo BUG=823498 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic8f57f2249142ee720b07640c8b11c4af89648ff Reviewed-on: https://chromium-review.googlesource.com/1031522Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#554503}
-
Reilly Grant authored
This patch follows up on r547601 by adding the WebUsbAskForUrls and WebUsbBlockedForUrls policy settings which allow an administrator to either override a DefaultWebUsbGuardSetting of 'block' by allowing a particular set of URLs or override a setting of 'ask' by blocking a particular set of URLs. Bug: 771703 Change-Id: If562fc031eedaff7b0691810d8d1383ffbd5f824 Reviewed-on: https://chromium-review.googlesource.com/1026159Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#554502}
-
Ted Choc authored
BUG=837761 Change-Id: Ib256ba3133eae770167b5e06ae6c8ad9d0436658 Reviewed-on: https://chromium-review.googlesource.com/1033589Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#554501}
-
Ran Ji authored
We need to use the content in resources.pak in service manager, but at that time resource bundle has not been initialized. Create data pack to load resources.pak and append the data pack to resource bundle during the initialization. Move path FILE_RESOURCES_PACK from chrome_paths.h to ui_base_paths.cc. Bug: 729596, 815230 Change-Id: Iec3a9409cbd9c10775afb72944e66e26650f1181 Reviewed-on: https://chromium-review.googlesource.com/962679Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#554500}
-
Joy Ming authored
Remove references to jming on TODOs and add other members of the team for related histograms/UKM. Change-Id: I2ae4425b302cf472cbeb901ff98827d07c148c70 Reviewed-on: https://chromium-review.googlesource.com/1031127Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#554499}
-
https://skia.googlesource.com/skia.git/+log/a886544a7bf7..5cb5c74efdac $ git log a886544a7..5cb5c74ef --date=short --no-merges --format='%ad %ae %s' 2018-04-27 borenet Reland "[recipes] Use named caches for git and workdirs" 2018-04-27 reed use std::atomic in SkRegionPriv 2018-04-27 angle-skia-autoroll Roll third_party/externals/angle2/ 467c15f97..de279590a (1 commit) 2018-04-27 skcms-skia-autoroll Roll skia/third_party/skcms 5a327ce..dd901e0 (1 commits) 2018-04-27 ethannicholas workaround for Intel OpCompositeConstruct bug 2018-04-26 fmalita [skottie] Apply opaque masks as clips 2018-04-27 rmistry Revert "Remove Android compile bot from the CQ" 2018-04-26 benjaminwagner [infra] Specify machine_type dimension for Linux GCE bots. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ib9444275488575c786a1b6d5ac1841bb427a477a Reviewed-on: https://chromium-review.googlesource.com/1033487 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554498}
-
Chris Mumford authored
In commit #552430 a few struct members were renamed, but code comments were not updated. Bug: 823297 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I28c618291fe69e30d2695fb4a062972e64eb4bfa Reviewed-on: https://chromium-review.googlesource.com/1021658Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#554497}
-
sahel authored
On autoscroll start the mouse_wheel_phase_handler_ ends the current scrolling sequence(if such exists). While Autoscrolling wheel events in the mouse wheel event queue are ignored and once autoscrolling ends the mouse_wheel_event_queue resumes processing wheel events normally. This change is identical to giving priority to touchscreen scrolling over wheel scrolling and it is done to make sure that attempting to wheel scroll during a middle click autoscroll doesn't cause unwanted GSB /GSE generation. Bug: 835314 Test: *.TimerBasedLatchingBreaksWithAutoscrollStart Change-Id: Id568ee2676a6dafc2705c144ea4d92d46311b788 Reviewed-on: https://chromium-review.googlesource.com/1011457 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554496}
-
Varun Mohan authored
These metrics will record the number of occluded/visible/hidden native Chrome windows on Windows. This information will be polled and computed on a repeating timer. This information will be used to determine if occlusion tracking on Windows is worth pursuing going forward. This is a reland from reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1032858 (revert), https://chromium-review.googlesource.com/c/chromium/src/+/1025074 (original) The fix is the diff after patchset 1. Bug: 813093 Change-Id: I30635c4b978a210e496cc43e52470f3b3b9f03d3 Reviewed-on: https://chromium-review.googlesource.com/1033272Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Varun Mohan <varunmohan@google.com> Cr-Commit-Position: refs/heads/master@{#554495}
-
Filip Gorski authored
* This is accomplished by adding a PageViewTimer class, which uses a TabObserver and a TabModelObserver to measure time spent viewing pages Bug: 824186 Change-Id: I14fc98112d254f44be969307a5c9b74f7969f93a Reviewed-on: https://chromium-review.googlesource.com/1023054 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#554494}
-
Daniel Nicoara authored
To simplify naming, update the parameters for SetGeometry(). Once all call sites are updated, remove SetGeometryGfx(). Bug: None Test: Compiled Change-Id: I6ec82851883271732c029586017ddf8394a85295 Reviewed-on: https://chromium-review.googlesource.com/1024190Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#554493}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bdb814e9..df1d991f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I01a7d36286623ffcafa44cba0490dd286f7fb97f Reviewed-on: https://chromium-review.googlesource.com/1032753Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554492}
-
Elly Fong-Jones authored
It looks quite bad. This was an unintended regression from the fixed-width look. Adding a test for this regression is unfortunately difficult - mocking out the MenuController used by a single MenuItemView is complex to do. Bug: 837158 Change-Id: Ie2e094a69c1d25bbcf8b53cfd66da4dec51e0f1b Reviewed-on: https://chromium-review.googlesource.com/1030038 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#554491}
-
Charlie Harrison authored
These APIs are not being used. Bug: None Change-Id: Iae36aba550cb117baaa1b8cce677f63c5a652178 Reviewed-on: https://chromium-review.googlesource.com/1032761Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#554490}
-
Elly Fong-Jones authored
This setup needs to be done earlyish in the browser's lifetime so that the error badging can be shown and so that the global error bubble can appear. This fixes GlobalErrorBubbleTest.InvokeUi_RecoveryInstallGlobalError. Bug: 834754 Change-Id: I2b61beb1123436fd15c36d265d1eabbf6d9ded2f Reviewed-on: https://chromium-review.googlesource.com/1033437Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554489}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia6ed918de4495d0938c6400413aee6d8683ce18a Reviewed-on: https://chromium-review.googlesource.com/949822 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#554488}
-
chaopeng authored
On Thinkpad X1 with libinput or synaptics driver, touchpad scroll event report as ScrollClassEvent not ScrollEvent. For touchpad report with high precision scroll deltas, we add a event source check when receive ScrollClassEvent. Bug: 599497 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4c6b5d763275caa98c56f86ec0de0c5aeed9dca2 Reviewed-on: https://chromium-review.googlesource.com/988748 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554487}
-