- 06 Nov, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00e405553245..70f80e7066ba Created with: gclient setdep -r src-internal@70f80e7066ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: Id57dc6860421bcb0d2a52e7f99506240d686b281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712917}
-
Curtis McMullan authored
We want to create a prototype of a resizable floating virtual keyboard. This flag will be used to enable / disable the prototype. Bug: 1019990 Change-Id: I6194b024842ee177bca2180c74e69836d26897bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882256Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712916}
-
nancy authored
Design doc: go/app-service-instance-registry-design-doc go/appservice-for-per-app-time-limit-design-doc This CL adds the App Service Instance classes: Instance InstanceUpdate InstanceRegistry InstanceRegistry depends on Instance and InstanceUpdate to calculate the instance updates to notify the client. BUG=1011235 Change-Id: Ife2a25c1ae24b3a5c8e1ef67540ba49939126174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896484Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712915}
-
Hajime Hoshi authored
This CL is a pure refactoring. After this change, BackForwardCacheMetrics can take the full information about storing a document into the cache. Bug: 1004676 Change-Id: Ie56dfde2f2d5e0cb6d8507607dfd38f61837a358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899630 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#712914}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df4f939b5506..f798ed2acd8a git log df4f939b5506..f798ed2acd8a --date=short --no-merges --format='%ad %ae %s' 2019-11-06 lamontjones@chromium.org paygen: more logging when download fails. Created with: gclient setdep -r src/third_party/chromite@f798ed2acd8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I21b4d7ca226a7159a2d16db6d1d88ab517f5d330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899188Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712913}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdc0c23f1a2e..e127e9f93079 git log cdc0c23f1a2e..e127e9f93079 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader aaa64b76c0b4..215bc7949b35 (2 commits) Created with: gclient setdep -r src/third_party/skia@e127e9f93079 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: I0537ddbf590e457227f1d6477ab011ef20b45810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712912}
-
Mike West authored
Currently, we're sending `Sec-Fetch-Dest: unknown` for PPAPI-driven requests. We ought to be sending `embed` or `object`. This patch adds some tests to ensure that we're setting the context for PPAPI requests to PLUGIN, and changes Blink's behavior to report PLUGIN as `embed`. We ought to be distinguishing between `embed` and `object`, but don't currently have the context when creating the request to make that possible (and "embed" is strictly better than "unknown" :) ). Bug: 1021432 Change-Id: Ie0d2dff1dee85e34c2fab6f7ea2e542fede644e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899446Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#712911}
-
Matt Amert authored
The average_lag_tracker assumes that all events have nondecreasing timestamps. However, the assumption breaks when the main thread takes a long time to handle a scroll update and the compositor thread starts a new scroll in the meantime. This CL removes the invalid DCHECK and instead ignores the out-of-order event. Bug: 1015492 Change-Id: I3dcee2be9c0ba9b6e295d391b4c114f7ef05510b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869378Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712910}
-
Yoshifumi Inoue authored
This patch introduces |NGInlineCursor::CurrentBidiLevel()| with helper functions for prepration of utilizing |NGInlineCursor| to |AbstractInlineTextBox|[1]. [1] http://crrev.com/c/1888242 Utilize NGInlineCursor for inline box traversal Bug: 982194 Change-Id: I92f5aa918f27274cfd97dd2726bf95086d0b9ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899240 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712909}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9b94ee446d9c..b54d7ad71425 git log 9b94ee446d9c..b54d7ad71425 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 shwali@microsoft.com Make FPDFAnnot_SetAP() generate PDF standard compliant AP stream Created with: gclient setdep -r src/third_party/pdfium@b54d7ad71425 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I9eb65784a316dd8585d1d77329b73f9a40648153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900334Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712908}
-
Jiewei Qian authored
SystemWebAppManager::NeedsUpdate() will check whether current locale is consistent with the locale that system web apps were installed with. If not (i.e. when user changes it), request to reinstall apps in order to keep their launcher localization (title, icons, etc.) synchronized to current locale. - Add a preference kSystemWebAppLastInstalledLocale to store locale at installation time. - Check install results of apps before storing locale Fixes: 1020442 Change-Id: I16f99a81fb5a06a634078914ff4fd9d745f5f73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898887Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#712907}
-
Mei Liang authored
This CL adds the following: * End to end tests for TabSelectionEditor * Some customized RecyclerViewMatchers * A TabSelectionEditorTestingRobot that allows others to perform and verify action within the TabSelectionEditor. Change-Id: Ic7283772374a0c0ed2a3aca84d4e4d245118fd04 Bug: 983170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894413 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712906}
-
Hajime Hoshi authored
This change is pure refactoring. This is preparation for letting RenderFrameHostImpl::MarkNotRestoredWithReason accept CanStoreDocumentResult. We'd like to pass not only multiple reasons and blocklisted features but also disallowed reasons at MarkNotRestoredWithReason. As CanStoreDocumentResult is an inner class, forward declaration is impossible, then this CL moves the class to an independent file. Bug: 1004676 Change-Id: I80a59f8035bc0093f87840b0b85ef7f6c31441d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877502 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712905}
-
Yoshifumi Inoue authored
Following bot results are included. 186 A large number of new failures are probably due to r712444 crrev.com/c/1869076 . TBR=kojii@chromium.org NOTRY=true Change-Id: I9456d6b4ea4f4e6cfd7ff96d27eaeba1a5bff99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900525Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712904}
-
Sammie Quon authored
Do not repaint to 1.f opacity if the blur is already 0. Also fix a bug with the cross fading animation being darker in the middle than the end. This is caused by the how the layers with different opacities stacked ontop of each other work. With both tweens linear the combined opacity near the gets to like .2. Changed to use tweens where the combined opacity stays close to .9 ish. Bug: 1009971, 1016267 Test: manual Change-Id: I9cb00afa869a8b83369ae871862700a2df864ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898147Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712903}
-
Fergal Daly authored
This reverts commit 29392d00. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add CanCommitOriginAndUrl() exception for 'no access' URLs. > > Temporary fix that creates an exception for 'no access' URLs like > chrome-native://history. These URLs can cause a origin mismatch in the > commit code because of slight differences between how url::Origin and > blink::SecurityOrigin handle 'no access' URLs. This is intended as a > low risk change that can be easily merged to the M79 branch. > > Bug: 1016711 > Change-Id: I20734fe68b6919c06849a1ce1439624d6332898c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896863 > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712415} TBR=acolwell@chromium.org,alexmos@chromium.org Change-Id: I6ac033436b2719090e9fd198c90c410f509c845c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016711,1021779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900513Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712902}
-
Chris Lu authored
This change move the 7 second delay dismiss call into presentInfobarBannerAnimated:. This will be helpful now that Translate will be presenting the banner multiple times, allowing the 7 second delay to reset every time the banner is displayed. Bug: 1014959 Change-Id: I0c11f0221bfc08be9e6bb4b119bdad09b67fcfe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900294 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#712901}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/edf176c888c1..00e405553245 Created with: gclient setdep -r src-internal@00e405553245 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I957722487090a867510d1859c368744320978c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900590Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712900}
-
Joel Hockey authored
Terminal System app will call chrome.terminalPrivate.getCroshSettings to get the current settings used by crosh in order to migrate any settings. This migration code will be removed after M83. Terminal System app will add some local storage to indicate that migration has been done, so this function should only be called once ever by Terminal System App. This code reads from the crosh extension sync storage where settings are currently stored. It is a close copy of extensions/browser/api/storage/storage_api code. https://cs.chromium.org/chromium/src/extensions/browser/api/storage/storage_api.cc?l=71-83&rcl=115bc01b385b57e8f96c4fa0b117e887a26cd55e TBR=benwells@chromium.org Bug: 1019021 Change-Id: I5287e804ac2c2a8c1eaf2fe7f14c8012f88b1c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899626 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#712899}
-
Xianzhu Wang authored
During paint, for a non-custom scrollbar, instead of recording drawing display items, we record a ScrollbarDisplayItem which contains cc::Scrollbar and other information. In PaintArtifactCompositor, if the we decide to composite a ScrollbarDisplayItem, we create a cc::Layer whose type is one of cc::SolidColorScrollbarLayer, cc::PaintedScrollbarLayer and cc::PaintedOverlayScrollbarLayer according to the scrollbar information. If we don't composite it, we call cc::Scrollbar::PaintPart to generate the draw record like the other drawings. Bug: 931486 Change-Id: I451ddff4231c5e5937e6b04334c95a99ad47bca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897127Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712898}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3c0e86a87d08..bf053b6f3c73 git log 3c0e86a87d08..bf053b6f3c73 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9f06b2ef..aa7c1e25 (712714:712817) 2019-11-05 alessiob@webrtc.org Revert "RNN VAD: prepare for SIMD optimization" 2019-11-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4186f99f..9f06b2ef (712562:712714) Created with: gclient setdep -r src/third_party/webrtc@bf053b6f3c73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I3f1a8c373174440715b05f4a51fc2b592c5f7977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900587Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712897}
-
Yutaka Hirano authored
Bug: 1018081 Change-Id: I7e852df70868ef52650918e1fccda6b2047b6240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886273Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#712896}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/14c3436191d3..9b94ee446d9c git log 14c3436191d3..9b94ee446d9c --date=short --no-merges --format='%ad %ae %s' 2019-11-05 tsepez@chromium.org Use 64-bit arithmetic in sha1 length calculations. 2019-11-05 tsepez@chromium.org Use unsigned indices in sha1 computations. 2019-11-05 tsepez@chromium.org Beef up tests for fdrm/ hashes. Created with: gclient setdep -r src/third_party/pdfium@9b94ee446d9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1020899 Change-Id: I7961c53c34597bcb0d0b63a20e89ff5dadfb937b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712895}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2150a694c71f..d39c0496a168 git log 2150a694c71f..d39c0496a168 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 vadimsh@chromium.org [lucicfg] Update from v1.11.5 to v1.11.6. Created with: gclient setdep -r src/third_party/depot_tools@d39c0496a168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1021520 Change-Id: I4a930f8e516cf6a823c200938b1d682c40cf41c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900589Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712894}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e7ebfec8c01c..df4f939b5506 git log e7ebfec8c01c..df4f939b5506 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 philipchen@google.com trogdor: Add new paladin 2019-11-06 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@df4f939b5506 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If6999e3d3f668250564a8d05701dc8732851d0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712893}
-
Khushal authored
This reverts commit f7de2bf8. Reason for revert: b/143771201 Original change's description: > Re-enable AImageReader on ARM GPUs. > > Re-enable AImageReader on ARM GPUs since few bug fixes related to > memory regressions have been landed and we expect those fixes > might have also fixed the crashes we were seeing with ARM GPUs. > > Will need to revert this CL if it causes crashes. Since the crashes are > not reproducible locally, there is no other way to test this expect > removing the GPU family from the blacklist and hence enabling it on > ToT. > > Bug: 1013797 > Change-Id: I3402d049e06824284c3b9836fd05ebe03754b43a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873393 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708306} TBR=zmo@chromium.org,liberato@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013797,1021797 Change-Id: I95a0fa4b10b76fd3b355292622144866969d58ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899837Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#712892}
-
Bao-Duy Tran authored
for Spanish keyboard. Prior to this patch, only "es" is specified, thus the "Spanish keyboard" only shows up in "input methods" settings when (generic) "Spanish" is selected, but not for "Spanish-Spain". There doesn't seem to be locale fallback logic in place. Many other entries already specify both generic and country-specific variants of languages when necessary. We're fixing this for both Chrome OS and open-source Chromium OS, although the bug only concerns Chrome OS. Bug: 1021222 Change-Id: I99fe160a89f4dc774c88104e62c8214e75a83737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898897Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#712891}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f16e793858c4..2dfba53b8214 git log f16e793858c4..2dfba53b8214 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 9856269+sarahM0@users.noreply.github.com Add unit test for spvcir parser (#866) Created with: gclient setdep -r src/third_party/shaderc/src@2dfba53b8214 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I8616ba2e19d2b02f248ff50aedde7888f20f0dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712890}
-
Matt Menke authored
Also pass the NIK to SocksConnectJob through its parameters. This only affects the DNS resolution of the destination's hostname, not the SOCKS4 proxy's hostname, which continues to not use the NIK. Bug: 997049 Change-Id: If0cc74bb28d82f4f6929ccb12f15691e22c40589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898389 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#712889}
-
Gyuyoung Kim authored
This CL converts remained old Mojo types of DnsConfigChangeManager interface to new Mojo types. Major changes are as below, - Convert mojom::DnsConfigChangeManagerPtr to mojo::PendingRemote|Remote<mojom::DnsConfigChangeManager> - Convert mojo::DnsConfigChangeManagerRequest to mojo::PendingReceiver<mojom::DnsConfigChangeManager> - Convert mojo::Binding to mojo::Receiver Bug: 955171 Change-Id: Iea32edc6bc502514792114d2adf71cdffb5f8c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896490 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#712888}
-
Kurt Horimoto authored
Bug: 987646 Change-Id: I8cb241950b86772c78ea6fdb9d1e8345b512161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890004 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712887}
-
Matt Falkenhagen authored
This adds a test for the fix in r711622. Bug: 1020082 Change-Id: I2caed1e0135844757fb648f183da1c2cf6e6f377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895093Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712886}
-
Xiaohan Wang authored
This test was added in the early days of mojo and has long been disabled while mojo and media/mojo evolved. Now media/mojo and the mojo Renderer path are covered by various other tests and there's no plan to revive this test. Therefore this CL removes this test. Bug: 597904 Change-Id: I3adde9430f2601eacca67d8bdde338c37a30e3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896054Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712885}
-
Alex Danilo authored
Bug: 1014771 Change-Id: Ie8cb8a929d8273faae6f13d31193ed433fc093ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900518 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712884}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Ib4f721bb596ec50d85bff4c026049d979c85699a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900747Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712883}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 73e55d76. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 40c01af7 "[Chromedriver] Fix PerformAction to support multi touch points cases" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/visual-viewport NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4e0628ec82b668b4f2ed8e0fa18b3673956ce84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899801Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712882}
-
Haiyang Pan authored
This reverts commit 13908ddd. Reason for revert: It prevents uploading a new patchset for an internal CL which does not change any xml file Original change's description: > [Snowflake] Prevent from adding hex color values outside color_palette.xml > > Moved some semantic names in color_palette.xml to semantic_colors.xml. > And added some presubmit checks to prevent from adding more hex argb > values in color resource files except color_palette.xml. > > Bug: 775198 > Change-Id: Ie27dd8dc0e4fa6506ed192c6f5f9c4b5b5f88566 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896241 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712462} TBR=twellington@chromium.org,jbudorick@chromium.org,lazzzis@google.com Change-Id: Ib41c469abd121a3003bdd1b7047ff6dac9f0b93f Bug: 775198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900657Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712881}
-
Jeevan Shikaram authored
This CL adds UMA to the App Management page. It records: - The actions a user takes in an app detail view. - How a user accesses App Management. Bug: 963326 Change-Id: Ib4b40cd372993263c8601cc2caf46abb50487e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893599Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#712880}
-
Nate Fischer authored
This increases the sample rate for pre-stable channels (the stable channel sample rate is still 2%). This change is not expected to have a significant impact on total UMA volume, due to the relatively small size of WebView's pre-stable channels. This addresses privacy concerns (regarding fingerprint-ability for low-usage applications) by limiting the package name field to 10% of the population. When sample rate < 10%, we'll upload package name with all UMA logs (this is the status quo). When sample rate > 10%, we'll only upload package name for the clients which fall within a 10% group (using similar logic to our existing sampling logic). This continues to maintain the requirement that we only upload the package name for system apps or Play Store-installed apps (ex. This will not log the package name for sideloaded apps, even if the client falls within the 10% package-name-logging group). Bug: 969803 Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* Test: build with android_channel="beta", manually observe metrics are logged 99% of the time Test: build with android_channel="stable", manually observe metrics are logged 2% of the time Change-Id: I611c76b21f790251ab08de3f72cd0807f9a88f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898711 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712879}
-
Anastasia Helfinstein authored
Previously, the accessibility component extensions did not follow the bracket conventions for conditionals Chromium style guide, primarily due to the history of the ChromeVox screen reader. This led to some confusion, as well as competing requests from different reviewers. This change modifies all of the accessibility component extensions to use braces for all conditional statements. This change is a pure refactor, there is no change to function or logic. Bug: 706981 Change-Id: Iba6f4922332de7c4c09a0bc8fb14cbd3e45ba37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898434Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#712878}
-