- 18 Mar, 2020 40 commits
-
-
Oriol Brufau authored
r745834 enabled LayoutNG for listbox SELECTs and updated the expectation of select-popup-appearance-basic.html since it's different in LayoutNG. But then it started failing in legacy layout. Bug: 1040826 Change-Id: I5f6a816fd9f40bb2625dbbfa462742e3dbf09f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107590Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#751327}
-
Yuly Novikov authored
This reverts commit b8530cca. Reason for revert: breaks compilation on ANGLE CQ https://luci-milo.appspot.com/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20dEQP%20Builder/52743 Original change's description: > Roll src/third_party/glslang/src f368dcbb7d8a..c7910056825a (1 commits) > > https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f368dcbb7d8a..c7910056825a > > git log f368dcbb7d8a..c7910056825a --date=short --first-parent --format='%ad %ae %s' > 2020-03-18 johnkslang@users.noreply.github.com Merge pull request #2130 from dgkoch/EXT_ray_tracing > > Created with: > gclient setdep -r src/third_party/glslang/src@c7910056825a > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/glslang-chromium-autoroll > Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com > Change-Id: Iaaa4eb244b12c3c8c56dc7ed62e95b1791f2d7be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108078 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#751320} TBR=courtneygo@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com,radial-bots+chrome-roll@google.com Change-Id: Icbebdee259a668a896b56f29501e5d4873dc0b5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106384Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#751326}
-
Hyunjune authored
This patch fixes up incorrect sizing of SVG Image with referred SVG image without the intrinsic size. So when referred image is SVG, it currently checks that referred image has aspect-ratio. If referred svg image doesn't have the aspect-ratio, set the concrete object size from the 'default object size'. Bug: 1045932 Change-Id: If979b3a9a7980bde9e2bee38ba2863cf223b4f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094055Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#751325}
-
Fredrik Söderqvist authored
The generic cycle solver should find (and break) these cycles as well. Bug: 1028063 Change-Id: Ic3773ae49f41b3c7e84f6aabe52d954cdf009374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#751324}
-
Liquan (Max) Gu authored
Before Change: The javadoc said the types "mirror" those in mojom, which is not precise. After Change: The javadoc says the types "correspond" to those in mojom, with minimally required fields. Change-Id: I5fd70662d7575f84cab63b1cad39ba94f3218b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105670Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751323}
-
Andrew Grieve authored
This reverts commit 0b8c0e6a. Reason for revert: Fixed runtime deps Original change's description: > Revert "Make java_deobfuscate not require being built first" > > This reverts commit 962e7030. > > Reason for revert: Failing on swarming > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747 > > Original change's description: > > Make java_deobfuscate not require being built first > > > > Makes the tool easier to use, and easier to document how to use by not > > requiring it to be built first. We have only a single non-prebuilt .java > > file, so it's easy enough to just check in the .class file for it. Bug: 995290 Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#751322}
-
Hiroki Sato authored
AccessibilityNodeInfoDataWrapper::PopulateAXRole assigns a Chrome role to each node, and the last logic to decide a role is using an Android class name. Some Android app disguise its class name to control what TalkBack announces. This is sometimes helpful, but may break ChromeVox navigation. Gmail has a header which ax tree looks like below: ++ textField [Search mail] ++++ button [Open navigation drawer] ++++ genericContainer [Compose] ++++ genericContainer [Open account menu] The root of this is assigned textField role from its className. Clicking the node opens the input field, so that role should not be textField. (Note that these four nodes are all clickable.) This change deletes EditText from the map of className to Chrome role. Even after changing this, as normal textFields have editable property, their role is populated correctly. Bug: b/150827734 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open Gmail, and OpenSearchBar is correctly focused. Change-Id: I7d0f867ba842585d7c222b9f96edfd958e5ad90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104743Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#751321}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f368dcbb7d8a..c7910056825a git log f368dcbb7d8a..c7910056825a --date=short --first-parent --format='%ad %ae %s' 2020-03-18 johnkslang@users.noreply.github.com Merge pull request #2130 from dgkoch/EXT_ray_tracing Created with: gclient setdep -r src/third_party/glslang/src@c7910056825a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Iaaa4eb244b12c3c8c56dc7ed62e95b1791f2d7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751320}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f297c2cef4e4..64472dfcc5d1 Created with: gclient setdep -r src-internal@64472dfcc5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010568 Tbr: jbudorick@google.com Change-Id: I8f544a9b6eb291ad38dbc0daecb7304924007a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108585Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751319}
-
Maxim Kolosovskiy authored
client The field should be initialized with nullptr. Bug: 1057608 Change-Id: I6d5eb00858f4998f0b67f87ab219646c3eaa9681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106069 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751318}
-
David Van Cleve authored
This change gives URLLoader an optional std::unique_ptr<TrustTokenRequestHelper> argument. This will be provided by URLLoaderFactory whenever the request at hand has been configured for a Trust Tokens operation (see design doc, below). - A TrustTokenRequestHelper is responsible for executing two parts (outbound, via |Begin|, and inbound, via |Finalize|) of a single protocol operation. - Each request will have at most one associated protocol operation. In the long run, perhaps a handful of requests per page load will have associated protocol operations. (Initially, this number will be lower, as the current version of the API is a prototype to be used for limited experimentation.) The outcomes of a protocol operation are: - Begin (executed on outbound request) fails -> the entire request should fail immediately with ERR_TRUST_TOKEN_OPERATION_FAILED - Begin finds that the protocol operation's desired result is already stored locally -> the request should fail immediately with ERR_TRUST_TOKEN_OPERATION_CACHE_HIT - Begin succeeds, Finalize ("inbound" operation executed on the response) fails -> the request should fail with ERR_TRUST_TOKEN_OPERATION_FAILED - Begin and Finalize both succeed -> the request should succeed if it would otherwise succeed This change also adds a TrustTokenOperationStatus field to URLLoaderCompletionStatus; this will subsequently be used to propagate operation results back to the corresponding Trust Token API method return value in Blink. Trust Tokens design doc: https://docs.google.com/document/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit Bug: 1042962 Change-Id: I402a2d8c63cf726a9f27b135c7df575a94d77afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062869Reviewed-by:Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751317}
-
Mark Cogan authored
As part of preparing for multi-window, the URLLoadingService needs to be migrated to be a BrowserAgent instead of a KeyedService. That change is itself fairly large, but as an additional complication URLLoadingService is used in downstream code. This CL is the sixth in a series of changes needed to complete this refactor: 1. (crrev.com/c/2089687) Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. (crrev.com/c/2089785) Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. (crrev.com/c/2105314) Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). Delete the now-unused provider API that was removed downstream in step 4. 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Have the old shimmed API call the new shimless one. 8. Upstream, call only the new shimless API. Remove the shim implementation in calling code. 9. Downstream, remove the shimmed API. 10.Upstream, remove the shimmed API, including the shim definition. Bug: 1046374 Change-Id: I12874b8c0d6674b03cee22141b67bc32788fa4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106182 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751316}
-
David Van Cleve authored
Blink will want to be able to interpret TrustTokenOperationStatus values since it will be providing them to Trust Token API clients; mojoifying the status enum makes this easier, and also allows sending the status values for Trust Tokens operations executed via Mojo (like "hasTrustToken," which is currently being implemented). R=asanka Bug: 1042962 Change-Id: I2b04de491b212208bd76f501f5b9e8225f9439b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102633Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751315}
-
Aya ElAttar authored
1. Added Host permissions to trigger the full warning 2. Switched the login screen warning of the managed-guest session to be decided using ExtensionsPermissionsTracker 3. Modified 3 browser tests related to the old logic Bug: 1015378 Change-Id: Icd8cf9a72a6a2cbed58e4d72260e2f62bc79c30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090418 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751314}
-
Hiroki Sato authored
Currently WebView nodes are explicitly not ignored and not sorted in ARC accessibility. This rule should be applied to nodes from AccessibilityNodeProvider, too. This CL adds is_virtual_node in accessibility_helper.mojom and AccessibilityInfoData.IsVirtualView(), replacing current IsWebViewNode(). Bug; b:145262470 Bug: b:151130475 Bug: crbug:1053397 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Nodes from WebViews, Pickers, and Amazon Kindle app are correctly populated, works with Android side change (http://ag/10662400). Change-Id: I216bf6f26cb8e911ce0fe899400d503db6073be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102288Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
The tests now check every policy values of BlockLargeFileTransfer, AllowPasswordProtectedFiles and BlockUnsupportedFiletypes to catch more accidental regressions. Change-Id: I51b0f8f36655f8d4972e5cc2740cbfb287f78fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105615Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751312}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/56015e01150e..d7e0131c7edc git log 56015e01150e..d7e0131c7edc --date=short --first-parent --format='%ad %ae %s' 2020-03-18 reed@google.com remove old experimental apis 2020-03-18 egdaniel@google.com Revert "Set up eGPU/discrete support for MacOS." 2020-03-17 csmartdalton@google.com Remove FixedDynamicState from GrProgramInfo and GrPipeline 2020-03-17 jvanverth@google.com Set up eGPU/discrete support for MacOS. 2020-03-17 herb@google.com Arrange instruction to reduce register pressure Created with: gclient setdep -r src/third_party/skia@d7e0131c7edc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I4bf3ac112387d57765946da995d2a30231078d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108584Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a30b7bd35b10..30d08dd0e3c1 git log a30b7bd35b10..30d08dd0e3c1 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 sque@google.com Roll out new goma client binary VERSION=195 2020-03-18 huangs@chromium.org [Presubmit] Allow GetUnitTestsRecursively() to restrict Python versions. Created with: gclient setdep -r src/third_party/depot_tools@30d08dd0e3c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9bec5513ced650decb6cf4d3c7b0a4890297791e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108076Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/570330361a17..e5c9f6d10689 git log 570330361a17..e5c9f6d10689 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f71e417d..0fe8f345 (750950:751074) Created with: gclient setdep -r src/third_party/webrtc@e5c9f6d10689 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9b8885eb712970524fc27fc0d40909a104c896c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108583Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/56686c32e743..1d34dc592fc1 git log 56686c32e743..1d34dc592fc1 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 dhoss@chromium.org Support non-standard trailers in fixup_pdf_template.py 2020-03-18 ankk@microsoft.com Add FORM_GetFocusedAnnot and FORM_SetFocusedAnnot APIs Created with: gclient setdep -r src/third_party/pdfium@1d34dc592fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1023284 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I20560d52b9640b2b36c7423bb4d60798475b6cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108588Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29781ded1b6f..02d03f4ef2db git log 29781ded1b6f..02d03f4ef2db --date=short --first-parent --format='%ad %ae %s' 2020-03-18 jacktfranklin@chromium.org Revert "Add tsickle as a node dep" 2020-03-18 szuend@chromium.org Make LiveLocation#uiLocation and LiveLocation#isBlackboxed async 2020-03-18 szuend@chromium.org [cleanup] Remove awaitPromise argument from evaluateCommandInConsole 2020-03-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-03-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-18 jalyn@microsoft.com Ensure that all actions have categories 2020-03-17 khamu@microsoft.com High contrast support for Layers Created with: gclient setdep -r src/third_party/devtools-frontend/src@02d03f4ef2db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1021921,chromium:1032016,chromium:1048378,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5a973b2208ba5b85389117e82ff45c57ff6c129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108586Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1045456 Change-Id: I2c204fb5c53b2df69453a782eada76f81c5ec759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108021 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751306}
-
Clark DuVall authored
CLIPBOARD_READ and CLIPBOARD_WRITE were removed in https://crrev.com/c/1895749 but the corresponding change was not made in GetAllPermissionTypes(). Bug: 897289, 1025609 Change-Id: I63c6a7381bbdf2d1a27f5107524d13aacd995238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103551 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#751305}
-
Dominique Fauteux-Chapleau authored
This refactor is a preparation in order to use the same validation logic in other test files. Change-Id: Ibffc81edd8822989bc3bf21eb185df9f2a9102f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105736Reviewed-by:
-
Robbie Gibson authored
The text zoom option should only be enabled on pages with HTML content, as the zoom mechanism uses Javascript. Bug: 1062101 Change-Id: Ia2285d73adf5b82fb28c348e49c16b4453a707c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106191 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#751303}
-
Omer Katz authored
Bug: 986235 Change-Id: I90985578846a64c0da4900b0f600f5ef53720391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106156Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751302}
-
Oriol Brufau authored
r751059 changed the test but the legacy expectation wasn't updated. Bug: 1061846 Change-Id: Idbcd54355ffb339eae86b47896853ee80c1786ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108542Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#751301}
-
Jan Wilken Dörrie authored
This change removes the TOO_MANY_PASSWORDS error case from the password check and deletes relevant logic. The strings will be removed in a follow-up CL to simplify merging. Bug: 1061927 Change-Id: I73574316020de364cc76487191983cea94a54a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105319Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751300}
-
Anders Hartvoll Ruud authored
Consider a rule such as: a:visited { background-color: green !important; } If 'background-color' on 'a' is currently undergoing a @keyframes animation, and 'a' is a visited link, the -internal-visited-background- color (i.e. what we paint) must be 'green', but the 'background-color' as seen from JS must be the interpolated color. Since unvisited and visited colors are applied together by the interpolations machinery, we need to work around this manually. Whenever we apply an interpolated color, we check the priority of the -internal- visited- counterpart, and apply that again if its priority is higher. Note that despite CSSCascade being enabled for stable at the moment, this does not (yet) constitute a web-facing change, as the standard property animations are still using their own StyleCascade object (see ApplyAnimatedStandardProperties), and -internal-visited- properties are never added to that cascade. Bug: 1062217, 552085 Change-Id: Ic65b4986d41d7ada62fc5a857fdce8e08077609d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106186 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#751299}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e8ce957aec8c..33e164438ff9 git log e8ce957aec8c..33e164438ff9 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 taylori@google.com perfetto-ui: Color summarized userspace slices Created with: gclient setdep -r src/third_party/perfetto@33e164438ff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148446682 Tbr: perfetto-bugs@google.com Change-Id: Ie1cd1f76e5de6429240aefa97b1de1d08dd13cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108074Reviewed-by:
-
Patrick Monette authored
Also remove duplicate header file to fix lint warning. Change-Id: Ia16ff2af7c5bf144365769276a8072863806a46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106563 Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751297}
-
Mihai Sardarescu authored
Sign-in UI code went through a massive architectural change which seems to have fixed the test. Bug: 962847 Change-Id: I1a37f8000a6792bce5f75a842376a1d30ff129f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106586Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#751296}
-
Yoav Weiss authored
This implements PR #80 [1] and exposes userAgentData in workers. [1] https://github.com/WICG/ua-client-hints/pull/80 Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093220 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751295}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I26c5f7ccf95203ad9eaf1f3caae2d97a721f717f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108580Reviewed-by:
-
Aya ElAttar authored
Bug: 1015378 Change-Id: I8e50b5f2dde2f8b7825f53520ccc87a0383f6e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089844 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
-
Mikhail Khokhlov authored
Now that trace_processor_shell built from Chrome supports windows functions, we can take advantage of them. Bug: b/150125501 Change-Id: I7e6c93b7b570003c1fc97fda7bbb63cbb388b419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107483 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751292}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4079.0-1584355719-benchmark-82.0.4085.8-r1 to 82-4079.0-1584355719-benchmark-82.0.4085.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5fb762137876f246e847fe08b14b81d3fcddb591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108068Reviewed-by:
-
Mark Cogan authored
Major changes: UrlLoadingService -> UrlLoadingBrowserAgent, all call sites updated. TestUrlLoadingService -> FakeUrlLoadingBrowserAgent, to more clearly state what kind of test double it is. UrlLoadingServiceDelegate -> URLLoadingDelegate, to not couple the protocol name to the nature of the delegating object. FakeUrlLoadingBrowserAgent gets an explicit 'InjectForBrowser' to be used instead of 'CreateForBrowser', which hijacks the superclass UserDataKey() so it will be fetched like the normal instance when used. Bug: 1046374 Change-Id: Ie0229f387fef24b791bf70fc2aab91d5fe9e0662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105314 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Andy Paicu authored
This reverts commit ceaafd48. Reason for revert: likely cause of clusterfuzz crash Original change's description: > Launch the `navigate-to` directive > > The directive has been behind a flag for a year and we have received > no [negative] feedback. > > Spec: https://w3c.github.io/webappsec-csp/#directive-navigate-to > > I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EJ4xF_DwZyk > > Bug: 805886 > Change-Id: I746aed4032149b86a5f9974246e2ec35bf8eb356 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856100 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Auto-Submit: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750183} TBR=mkwst@chromium.org,andypaicu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=mkwst@chromium.org Bug: 805886 Change-Id: I03090af2eaee38c57084b4f0d8d0307e9d8e72aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107486 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751289}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4079.0-1584354054-benchmark-82.0.4085.8-r1 to 82-4079.0-1584354054-benchmark-82.0.4085.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I88471ed66220b0cb80aa2661faf71326f9715d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108069Reviewed-by:
-
