GitLab

During browser fullscreen transition, we have been avoiding doing layout
to prevent jankiness. On Mac, during such fullscreen transition,
CA transaction updates thus full re-paint still happen due to window resize.
This results in transient paint with obsolete layout. For example, if
Chrome is entering content fullscreen mode such as trying to play a video
in fullscreen, BrowserView::IsTabStripVisible() would return false since the
tabstrip should not be shown, but the tab strip is still being painted.

To solve the above problem, and also avoid unnecessary operations, this
CL suppresses CA transaction updates during fullscreen transition. Since
after the fullscreen transition, Chrome will immediately re-layout and
re-paint, the updates during the transition are not needed. This CL also
enables the tests that previously failed due to the state discrepancy
problem.

BUG=875707

Change-Id: I89510fcf55afc47e407d78bdf60a0c5a03ad9e57
Reviewed-on: https://chromium-review.googlesource.com/1188035
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586003}

R=jsbell@chromium.org

Bug: 720919
Change-Id: I192aaba2b58ac7edd9b59212dd48f4fa0cb16379
Reviewed-on: https://chromium-review.googlesource.com/1188850Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586002}

This CL moves the logic of ignoring client resolution of a portrait mode
phone screen into ChromotingSession, so that the Android client can get
this for free.

Bug: 874626
Change-Id: I0bf946c8a2ba5ce52e70b54b06517a3334f5727e
Reviewed-on: https://chromium-review.googlesource.com/1187802
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586001}

This also removes window_manager_constants as it was not used.

BUG=876924
TEST=covered by tests
TBR=msw@chromium.org,tsepez@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie9cd86ddc5c9a64b3a36b854b515988c52292758
Reviewed-on: https://chromium-review.googlesource.com/1188865
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586000}

Revert "[Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland)."

This reverts commit d88c3ec1.

Reason for revert: PlatformThreadTest.SetCurrentThreadPriorityWithThreadModeBackground is Flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=base_unittests&tests=SetCurrentThreadPriorityWithThreadModeBackground

Original change's description:
> [Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland).
>
> Relanding a CL that was reverted because of a variable that was
> unused in non-DCHECK builds and caused a compile failure.
> Original CL: Reviewed-on: https://chromium-review.googlesource.com/1171482
>
> This CL adds a feature to use THREAD_MODE_BACKGROUND_BEGIN instead of
> THREAD_PRIORITY_LOWEST for ThreadPriority::BACKGROUND threads. This
> lowers the disk and network I/O priority of the thread in addition to
> the CPU scheduling priority. MSDN recommends using this setting for
> threads that perform background work.
> https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-setthreadpriority
>
> TBR=gab@chromium.org
>
> Bug: 872820
> Change-Id: I212fb77bb035088595b4944ce145a74d333c38eb
> Reviewed-on: https://chromium-review.googlesource.com/1185529
> Commit-Queue: François Doray <fdoray@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585272}

TBR=gab@chromium.org,fdoray@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 872820, 877628
Change-Id: I6cf6625fc1f01106e8fff1e206a6a256f3a6160a
Reviewed-on: https://chromium-review.googlesource.com/1188644
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585999}

AppCacheNamespaceVector is std::vector<AppCacheNamespace>.
AppCacheResourceInfoVector is std::vector<AppCacheResourceInfo>. These
aliases don't hold their weight, because the noise saved is outweighed
by the reader having to figure out / remember if they represent special
data types, or just std::vector.

kEnableExecutableHeaders is unused.

Change-Id: I19a32054dd0d08e7026e9aaf8a2b19e0c48d51ed
Reviewed-on: https://chromium-review.googlesource.com/1188383Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585998}

Bug: 868068
Change-Id: I55bed5a6a35bec88b76066eb477914eb571104c7
Reviewed-on: https://chromium-review.googlesource.com/1167902
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585997}

Apply the tab selected state color into account in order to calculate the
proper contrast for the tab's text and icons.

Bug: 876794
Change-Id: Ie0db7e6eb5cd93c7b7d34098c88e9f06ff355d4d
Reviewed-on: https://chromium-review.googlesource.com/1188434
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585996}

On receiving 0 byte from the network,
network::TCPConnectedSocket::ShutdownReceive closes the producer side of the
receive pipe. When this happens, MojoDataPump::ReceiveMore
will get result != MOJO_RESULT_OK and invoke the read callback with
net::ERR_FAILED.

This broke a CrOS app that uses the TCP socket API.

The fix is to not error out when mojo pipe is closed, and consider all read
errors to be connection close.

BUG=877167

Change-Id: I9ec8eb58110b3f255d8ef380f111eec278797fcb
Reviewed-on: https://chromium-review.googlesource.com/1187076Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585995}

If neither space has exclusions, the two spaces are equal.

exclusions_ is a scoped_refptr, so operator== only compares pointer values.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iea67f268f9a537a27f267441f2afda860d641950
Reviewed-on: https://chromium-review.googlesource.com/1188847
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585994}

Original CLs:

- https://chromiumcodereview.appspot.com/12093035

  TCMalloc: support userland ASLR on Linux and Chrome OS

  On Linux and Chrome OS, we implement user-land ASLR in TCMalloc
  on 64 bits Intel architecture.

  In this configuration, we are not constrained by the address space
  and we don't mind fragmentation.
  But to be on the safe side, we only ever fragment half of the
  address space.

  BUG=170133
  NOTRY=true

  Committed:
  https://src.chromium.org/viewvc/chrome?view=rev&revision=179776

- https://chromiumcodereview.appspot.com/12192024

  Linux: grow a unique random mapping in ASLR

  We loosen ASLR by only growing one random mapping. The previous
  version
  had security benefits but had a negative performance impact.
  This change aims to be performance neutral in respect to the pre-ASLR
  era.
  At a later date, we may try to strike a good balance between
  performance and
  security.

  This is a re-land of https://chromiumcodereview.appspot.com/12090112/

  BUG=170133, 173371
  NOTRY=true
  TBR=jar

  Committed:
  https://src.chromium.org/viewvc/chrome?view=rev&revision=180556

- https://codereview.chromium.org/237673002

  remove redundant ifdefs

  OS_CHROMEOS implies OS_LINUX, so OS_LINUX || OS_CHROMEOS can be
  simplified to OS_LINUX

  BUG=none

  Committed:
  https://src.chromium.org/viewvc/chrome?view=rev&revision=263993

BUG=724399,b:70905156

Change-Id: Ic9da3524439312252f0f14d4c55ad882d67ebfed
Reviewed-on: https://chromium-review.googlesource.com/1130791Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585993}

New logic:
- Cache screen context on UI launch.
- Start screen context interaction using cached data on chip press.
- Start metalayer (screenshot only) interaction with stylus.

Bug: b:113069944
Change-Id: Iea4089ac2411a8000bc7ebaa16e90e12fcb6a151
Reviewed-on: https://chromium-review.googlesource.com/1186160
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585992}

Allow the error notification content to be customized by the caller,
and moved the error notification handler from custom_backgrounds.js to
local_ntp.js (the notification will be reused for custom link errors).

Also adjusted the notification styling to better match spec.

Screenshots:
https://screenshot.googleplex.com/BN02EbSSKLM.png
https://screenshot.googleplex.com/KpxwyZJ4N3T.png

Bug: 874188
Change-Id: Ibf4ebed906fd36916a4f0ddb2170a2dbe8870ab3
Reviewed-on: https://chromium-review.googlesource.com/1182787
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585991}

This CL adds OobeDialogHostBehavior::propagateUpdateLocalizedContent to
notify multilayer oobe-dialog structures of the locale change.

Bug: 828999
Change-Id: I86432fc41a12ddf50f94228aaab27e23332eb982
Reviewed-on: https://chromium-review.googlesource.com/1188487Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585990}

The ICU-based converter and the ICU-based IDNA logic use different
datasets from ICU.  This allows external embedders that only need IDNA
to avoid depending on huge (over 2 MiB) character set conversion
dataset.

Change-Id: I9e61208051d9553ddf93ec517ea07a7e54410e5e
Reviewed-on: https://chromium-review.googlesource.com/1185215Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585989}

Revert "[RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion"

This reverts commit c492203d.

Reason for revert: Broke browser tests on Linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29

Specific example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/52302

It also caused problems on the linux_chromium_rel_ng trybot.

Original change's description:
> [RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion
> 
> This is a second take on
> https://chromium-review.googlesource.com/c/chromium/src/+/754299
> 
> It's under an experiment to (1) be able to see the side-effects and (2)
> make merge to M69 easier. Intentionally kept old (and buggy) behavior
> intact under the non-experimental branch for comparison.
> 
> This fixes all aspects of crbug.com/560446:
>  1) Fixes the OP better than r385608 did.
>  2) Fixes the side-effect of r385608 which was to default all tabs
>     created backgrounded to run at foreground priority until visiblity
>     was toggle on/off again.
>  3) Fixes a major priority inversion on foreground navigation which
>     could cause them to background their associated renderer while
>     navigation (which reintroduced the OP but worse since all background
>     tabs were running foregrounded per r385608)...
>     See https://crbug.com/560446#c74 for details.
> 
> Updated ChildProcessLauncherPriority::is_background() to consistently
> reflect backgrounding decision to all callers and renamed
> |ChildProcessLauncherPriority::foreground| to
> |ChildProcessLauncherPriority::visible| to better reflect that it's a
> property but not the resulting foreground/background state.
> 
> See in code comment on ShouldBoostPriorityForPendingViews() for more
> details.
> 
> TBR=haraken@chromium.org (side-effect in third_party/blink)
> 
> Bug: 560446
> Change-Id: I901b702506a44704b53c007bcdd498fb60824e94
> Reviewed-on: https://chromium-review.googlesource.com/1142593
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585918}

TBR=creis@chromium.org,nasko@chromium.org,gab@chromium.org,thestig@chromium.org,boliu@chromium.org,haraken@chromium.org

Change-Id: I825381f67da071373ff2b2a3e620a979703d1579
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 560446
Reviewed-on: https://chromium-review.googlesource.com/1188963Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585988}

Bug: 864384
Change-Id: I23845a183196ce7e2d9dd4cd50fbfc63f0d9f289
Reviewed-on: https://chromium-review.googlesource.com/1182199
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585987}

This patch adds an NG version to DirectionAt(), so that SelectionModifier
can get the correct selection direction in bidi text laid out by LayoutNG.

We currently don't have layout test verifying the behavior. This patch
adds one, and makes it pass with EditingNG flag enabled.

Bug: 877263
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: If28b9735818d835bdb5ccbae50aa6fc2d75bff58
Reviewed-on: https://chromium-review.googlesource.com/1187719
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585986}

With this change it will be possible to build //ui/views on Fuchsia.

Bug: 829980, 877264
Change-Id: I9fb7be4a76f942ffc9945f87c4430a6457cd6f87
Reviewed-on: https://chromium-review.googlesource.com/1187649Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585985}

Change-Id: I8b37e7e0ad2228f3354808d39f4e6167371846bb
Reviewed-on: https://chromium-review.googlesource.com/1187578Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585984}

No change to production logic, only changes tests.

This adds a new annotation for running tests in either single-process or
multi-process only: @OnlyRunIn(SINGLE_PROCESS|MULTI_PROCESS). This CL
updates tests to use this annotation instead of the old mechanisms to
specify the same behavior (e.g., @SkipCommandLineParameterization).

The motivation is that this annotation is much clearer than
@SkipCommandLineParameterization.

This removes @SkipSingleProcessTests. While this annotation was better
than @SkipCommandLineParameterization, @OnlyRunIn(MULTI_PROCESS) is
easier to reason about (positive booleans are recommended over negative
booleans).

This adds a PRESUBMIT to enforce we do not add
@SkipCommandLineParameterization under //android_webview/javatests/.

Proposed on: http://shortn/_OS7nGlyaOn

      @SkipCommandLineParameterization

Test: manually test presubmit by re-introducing
Test: run selected tests, observe annotations work as expected
Change-Id: Iffd7bf5fbb045ac0aa77e9a317d108eb7be06b7f
Reviewed-on: https://chromium-review.googlesource.com/1187895
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585983}

This patch optimizes NGOffsetMappingBuilder so that it constructs
an offset mapping faster. The change is basically:
- Before: maintains the mapping function as a plain array, and converts
  it into mapping units and ranges in Build()
- After: maintains the mapping units and ranges directly

Design doc: https://goo.gl/QAn57A

This patch also adds a performance test, which forces offset mapping
creation by setting selection, to measure the improvement:
- Before: 18.5 runs/s
- After: 24.9 runs/s

Bug: 699017
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9cd0aa0c4b42320ae0812b460dc374433bac4119
Reviewed-on: https://chromium-review.googlesource.com/1149150Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585982}

There are a number of fields returned in the response of a OAuth access
token refresh, such as "access_token", "expires_in", "id_token", "scope",
and "token_type". Among which, only "access_token" and "expires_in" fields
are exposed to downstream consumers because other fields are not used
by Chrome so far.

This CL exposes the "id_token" field to consumers too. Since certain user
status (e.g if user is under advanced protection, a.k.a Titanium) is
included in this id_token field, safe browsing service would like to be
informed of this information.

This CL also creates a new struct TokenResponse to hold access token
related information together, such that downstream consumer only need
to take in one parameter. And it also makes exposing other information
much easier in the future.

go/at-risk-in-chrome

Bug: 866620
Change-Id: I20417ac6bf7e8f25db171e4127a6a826022f6755
Reviewed-on: https://chromium-review.googlesource.com/1176461
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585981}

- Rename the global binary/tri-state toogles.
- Clean up the flow in configureGlobalToggles().

Bug: 854737
Test: Manually tested
Change-Id: Ib55910e7c48b670cebb2c8b17df25ac36919b2a1
Reviewed-on: https://chromium-review.googlesource.com/1185883Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585980}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ia8a2bd7156e7fafd0471fb4ff7cc3a223c6dcb96
Reviewed-on: https://chromium-review.googlesource.com/1188781
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585979}

The methods return rects in physical coordinates, instead of
"physical coordinates in flipped block-flow direction" like most of the
other LayoutBox methods without "Physical" and "Logical" prefixes.

This doesn't fix the cases that the methods are mistakenly used where
"physical coordinates in flipped block-flow direction" is expected.
The bug will be left open for the fix.

R=eae@chromium.org
TBR=wangxianzhu@chromium.org # for passive changes outside of renderer/core.

Bug: 877518
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id5fd12bd5f30f309ed32818378334dab633f536e
Reviewed-on: https://chromium-review.googlesource.com/1188742
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585978}

This makes memory management easier.

While doing this, change PDFiumMemBufferFileWrite to use a std::vector
as well. Give PDFiumMemBufferFileWrite the ability to detach its buffer
to avoid a copy operation. This is based on the work in
https://chromium-review.googlesource.com/1101200

Change-Id: If63428996ccd94e90672709baa865d21119d2ae5
Reviewed-on: https://chromium-review.googlesource.com/1188027
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585977}

This depends on https://chromium-review.googlesource.com/c/chromium/src/+/1188679

Bug: 797991
Change-Id: I81f648d269152eafbb6208d0c831e2d14511fc0c
Reviewed-on: https://chromium-review.googlesource.com/1187160
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585976}

Added myself to all directories triaged by storage-dev@chromium.org.

Replaced explicit lists with file:// pointers for features spanning
content/browser and other directories.

Moved a long owner list from
//third_party/blink/renderer/modules/quota/OWNERS to
//storage/browser/quota/OWNERS.

Change-Id: Id87b34dbd45e1a4f1bd89d4f3432b17ae2b08bff
Reviewed-on: https://chromium-review.googlesource.com/1166024Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585975}

In tablet mode, we only allow dragging on a browser window's caption area.
Other windows dragging on non-caption area should be handled by
TabletModeAppDragController.

Bug: 823769
Change-Id: I3da88ad7a88c8a39e576aa268331af0e09045def
Reviewed-on: https://chromium-review.googlesource.com/1187732Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585974}

It's not used in any configuration. Ash creates
ImmersiveHandlerFactoryAsh and the client (Chrome) creates
ImmersiveHandlerFactoryMus.

Bug: 624157
Change-Id: I123e28a46d14c0dfbb931144b4edebb9ea02eaa2
Reviewed-on: https://chromium-review.googlesource.com/1187635Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585973}

Bug: 863037
Change-Id: I2d0b34d0a6e3b7199e6dd8ec183d13f7aec2e7c4
Reviewed-on: https://chromium-review.googlesource.com/1187391Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585972}

Verified that the feedback data contains a |bluetooth_logs.gz| file.
Will continue to monitor this when new patches in the Chrome OS CL
are available.

To see the contents, run:
zcat bluetooth_logs.gz > logs
btmon -r logs

Bug: 872403
Change-Id: I5316204810873aec84060f670837022365657c36
Reviewed-on: https://chromium-review.googlesource.com/1185893
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585971}

Adds an entry to fieldtrial_testing_config.json to enable the video capture
service on browser_tests and perf bots.

Bug: 792621
Change-Id: I4a1c84ea134732ed307767061b24bf3086f8a2f4
Reviewed-on: https://chromium-review.googlesource.com/1182403Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585970}

In preparation for using isolation nodes, this patch changes
box clipper from directly using the overflow or inner border
box radius clips to using content properties clip.

R=pdr@chromium.org, chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id9f7a4f36ccef0fd1f27de2c0e101503279305ba
Reviewed-on: https://chromium-review.googlesource.com/1182501Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585969}

Before this CL, starting and stopping casting was done with the button
at the bottom of the dialog. This CL removes the button, and allows the
user to start/stop by clicking on a sink.

A sink with a session is indicated by a stop icon replacing the device
type icon for the sink. After this CL the user can click anywhere on an
active sink to stop its session, but in the future we will likely make
only the stop icon clickable. When there is an issue, an info icon
replaces it instead.

The stop icon used is a placeholder, since we don't have the vector icon
used in the mocks yet.

Bug: 872831

Change-Id: I638204db4cf751060be86e701c834e0abab2050e
Reviewed-on: https://chromium-review.googlesource.com/1168508
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585968}

Tabs currently draw a one-DIP overlap into the toolbar to correct for
alignment issues in non-integer DPI scales.  This regressed recently
(in crrev.com/c/1171917) on just the right side.  This CL restores the
old behavior.


Bug: 876730
Change-Id: I524b87af63359b507081ce9f0814ab8c8a3e17f6
Reviewed-on: https://chromium-review.googlesource.com/1186140
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585967}

Bug: 848115
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I26f065e6acd5b3399b1edf1b49facd60f889eb73
Reviewed-on: https://chromium-review.googlesource.com/1184337
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585966}

Currently, IdleSpellCheckCallback is both a state machine that controls
the checking at idle time, and also the IdleTask callback to be passed
to document.requestIdleCallback() API. This results confusion in the
lifecycle management of the class.

This patch changes the class into a state machine only, and introduces
a new IdleCallback class to be passed to requestIdleCallback() to fix
the issue.

Bug: 877154
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I79ae9711cb8308e902e8a472039b5e0723948447
Reviewed-on: https://chromium-review.googlesource.com/1187555
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585965}

Bug: 867725
Change-Id: I8022f3fe45bc327ca59da72a663b11ee9c6aa336
Reviewed-on: https://chromium-review.googlesource.com/1187138Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585964}