- 27 Sep, 2019 40 commits
-
-
Sergey Poromov authored
This reverts commit 230b08fa. Reason for revert: android-builder-perf and android_arm64-builder-perf failures. See: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/115865 https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/114816 Original change's description: > [Android] Remove ChromeBrowserSyncAdapterService from manifest > > This is a follow-up to https://crrev.com/c/1821784 that removes > ChromeBrowserSyncAdapterService from AndroidManifest. > > Please note that chrome/android/java/res_template/xml/syncadapter.xml > is kept in the repo for the time being, as it is being used downstream. > This file will be removed in subsequent CLs. > > Bug: 1002894, 1008314 > Change-Id: I7aa5fd7e2b5c982192aa07970d7400945f95116f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827413 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Auto-Submit: Boris Sazonov <bsazonov@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700703} TBR=treib@chromium.org,bsazonov@chromium.org,mamir@chromium.org Change-Id: If68359d7398372debbaec730e7df22e4cf91602a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002894, 1008314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829339Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700729}
-
Fabio Rocha authored
[DevTools] Fix "TypeError: database.getTableNames is not a function" when adding/removing tables in the Application tab In the Application tab, an uncaught exception was thrown when adding/removing WebSQL tables. This bug was introduced with this change (https://chromium.googlesource.com/chromium/src/+/388ba57c%5E%21/#F2) that renamed `getTableNames` but didn't update one of its callers. The fix is to use `tableNames` instead. While testing the fix and having a closer look at the bug, I noticed two other minor issues, which I also address here: 1) When collapsing/expanding the database node, tables would be added over and over again, as seen in the screenshot below. This was another regression from the same change above, where `removeChildren` was removed from `_updateChildren`, so I added it back. 2) Tables disappear every time a new one is added/removed, and the user needs to expand the database node again. I added a call to updateChildren so that this extra step is not needed and the list is updated as necessary. Let me know if you want 1) and 2) to be separate CLs but they're so minor I thought it'd be overkill. Before: https://imgur.com/a/skjKslL After: https://imgur.com/EIoyKkU Bug: 1006737 Change-Id: I3feb82d281f890bf18be3bcc7ba14c87739f9435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825794Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#700728}
-
Max Moroz authored
R=vakh@chromium.org Change-Id: Idb5cbf5ccfd6f87bcb5d168fcb7f42d49b709f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827878 Auto-Submit: Max Moroz <mmoroz@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700727}
-
Steve Kobes authored
The 3px threshold was added to support animations, but didn't work well for that use case; the transform exclusion is a better approach. The max move distance factor also helps to avoid penalizing trivial movements. A 1px movement (even of a large element) will have a miniscule impact on the score, if nothing else moves in the frame. Bug: 1003893 Change-Id: Ice2a8a3a79cf1c3c30fc4cff037eca94b5ca6954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797693Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#700726}
-
Ehimare Okoyomon authored
This cl changed the display format of a site exception that applies a rule to all third parties on a given site. Previously, the rule in settings looked like this: https://screenshot.googleplex.com/pDiF3NvoLFd.png and now it looks like this: https://screenshot.googleplex.com/6d5FtQkMcJ4.png Bug: 998062 Change-Id: If98eee7323d6429c031dd602e0baf6443fbb2c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816548 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#700725}
-
Tim van der Lippe authored
This was an interface that was already treated as an extern, but was not explicitly in the externs.js file. Bug: 1006759 Change-Id: I95301c059cc1213931498788cff553f955abb646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829098 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL makes sure origin in GPUTextureCopyView is not require anymore as specified in https://gpuweb.github.io/gpuweb/#dictdef-gputexturecopyview Bug: 877147 Change-Id: I2290b4e81d5613efb32b797c85f28c053c54d1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828957Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#700723}
-
Mihai Sardarescu authored
Bug: None Change-Id: I73d396bc9b812780ae75817315b138371859a72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825357Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#700722}
-
Fredrik Söderquist authored
CurrentDocumentTime() is the currently updated progress of the animation timeline, and all scheduling should be relative to that. Bug: 998526 Change-Id: Ieb7bd5306f7a149c435bcf2d9383c9f8a623c463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828897Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#700721}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f13084ded0d6..2e230c0d9b01 git log f13084ded0d6..2e230c0d9b01 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 eseckler@google.com Merge "Fix trace naming due to an overwrite permission issue with root permissions" 2019-09-27 lalitm@google.com Merge "trace_processor: fix comparision of sqlvalues and add neq db constraint" 2019-09-27 hjd@google.com Merge changes I262074ab,I2e91e757 Created with: gclient setdep -r src/third_party/perfetto@2e230c0d9b01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie63597fd2db75f816da0d2af0f067c5fa898fcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700720}
-
Jonathan Backer authored
This has CL has two changes. 1) DirectContextProvider initializes a GLES2DecoderImpl, which will glClear the framebuffer. So create it before drawing to the framebuffer. 2) GLRendererCopier expects readback_offset to be in the Window space (i.e. take into account framebuffer flipping). SkiaRenderer usually uses Skia to handle the co-ordinate transformations with flipped framebuffers (see SkiaOutputDeviceGL::Reshape for example). This is why we tell DirectRenderer not to flip by always having SkiaRenderer::FlippedFramebuffer return false. GLRendererCopier bypasses Skia, so we have to do this flipping manually. Bug: 1006450 Change-Id: Ida16069b2f335591abbb9d627e2abc011f2955e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827467 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#700719}
-
Stephen McGruer authored
This CL is part of the shift away from NonInterpolableValues to instead having more InterpolableValue subclasses. It introduces a new subclass, InterpolableShadow, which can represent a blink::ShadowData (used by text-shadow, box-shadow, and filter's drop-shadow(..) operation). There should be no behavioral change from this CL, it is (intended to be) a pure refactoring. Bug: 1005828 Change-Id: Iab2ad8fd52ddf69735d8c238df45821019297c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819517 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700718}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/791dddd6..d033cf11 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6f64b274b12b1e0a36f0623eb3a022d6f807f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828603Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700717}
-
Victor-Gabriel Savu authored
The histogram is still needed as we are extending the policy it helps track. Bug: 988779 Change-Id: I3fbb39ddffe20a1e194313bfdf87a90995f906c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826777Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#700716}
-
Vasiliy Telezhnikov authored
This CL unsets GrContext from |cache_controller_| during destruction to prevent access to it inside ~ContextCacheController(). Problem introduced in https://crrev.com/c/1824252 Bug: 1008506 Bug: 1008713 Bug: 1008778 Bug: 1008610 Change-Id: I74074684abdfa9c2a4078443e0dd4a72f55ad93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828432Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#700715}
-
Tom Anderson authored
CL [1] added new theme pack colors, but did not update kThemePackVersion. This can cause theme issues when upgrading Chrome. Since the version hasn't been updated since then, an increment is still necessary. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1754155 BUG=1006936 R=pkasting Change-Id: Id26d03a7478d7293d8479a701c24816f0002fd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827665 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#700714}
-
Marc Treib authored
These have been deprecated for a long time, no need to keep them around any longer. This removes the ModelType enum entries, and for WIFI_CREDENTIALS also removes it from the EntitySpecifics proto and deletes the specifics proto file. Unfortunately the specifics for ARTICLE need to be kept around for now, since dom_distiller code uses them for its own local storage (see crbug.com/1007942). Bug: 965503 Change-Id: I3feadc13d6e6facc69fc8733389d6ad64380aaa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823849Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#700713}
-
Hiroki Nakagawa authored
WebEmbeddedWorkerImpl always uses the fixed option (kV8CacheOptionsFullCodeWithoutHeatCheck). Bug: n/a Change-Id: I9fb5c21ddca5825f94622b29366c4e055c79335a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826398Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#700712}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e60338bb. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I299763360755f9743e2c6213847c9145e1e08248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828602Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700711}
-
Ian Struiksma authored
In captured sites recipe replay, each action that changes the frame has a WaitTillPageIsIdle check except for ExecuteTypePasswordAction. Adding this check fixes these 2 password tests and might stabilize others: capture_update_pass/go_daddy capture_update_pass/wargaming Bug: 984662 Change-Id: I2577da53f98585eb87072c33e0a397ba960a87ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827883 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#700710}
-
Marc Treib authored
Before this CL, the order of methods in ProfileSyncService.java was seemingly completely arbitrary. This CL attempts to order/group them in a reasonable way: - Java-specific setup/initialization - SyncService (and SyncUserSettings) access - Passphrase/encryption-related stuff - Not-actually-SyncService stuff (for Sessions and DeviceInfo) - Testing stuff Bug: 985290 Change-Id: I1187e5799668bb5e8a97204ec1829aaf8eb3bbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827374Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bc8049ef0bc6..ba2ba59c4ba1 git log bc8049ef0bc6..ba2ba59c4ba1 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 danilchap@webrtc.org Rewrite test::DirectTransport to work with any TaskQueue implementation Created with: gclient setdep -r src/third_party/webrtc@ba2ba59c4ba1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I58e6bcdc29c20a85722e87dbce78712707e8fb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828853Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6b4b8141e11d..faa2a365b5c0 git log 6b4b8141e11d..faa2a365b5c0 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 sugoi@google.com Increase limits for uniforms and vertex outputs Created with: gclient setdep -r src/third_party/swiftshader@faa2a365b5c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I3e2704194902909eabadad2d0a6fac4a9ba44823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828854Reviewed-by:
-
Jan Scheffler authored
This patch adds a pane below the cookie list to show a cookies value when one is selected. Bug: chromium:462370 Change-Id: Ibf245d75579ee5be357fddd6a4f5027f766b87b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807238Reviewed-by:
-
Kent Tamura authored
The test added by crrev.com/700572 and crrev.com/700584 collided. This CL fixes the autofocus test path in state-restore-dynamic-controls.html. TBR=masonfreed@chromium.org Bug: 1000926 Change-Id: I3e3fcbbbb280991cf5907250d3e72663682c0911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828769 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#700705}
-
David Bokan authored
The TRACE event in GestureEventQueue::PassToFlingController was inappropriately named. This CL moves it to FlingController and renames it to be accurate. Also added some instant events for when the event is filtered to aid debugging. Change-Id: I96d96e9cc3c758e822d3756df2139296a017b7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828110 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700704}
-
Boris Sazonov authored
This is a follow-up to https://crrev.com/c/1821784 that removes ChromeBrowserSyncAdapterService from AndroidManifest. Please note that chrome/android/java/res_template/xml/syncadapter.xml is kept in the repo for the time being, as it is being used downstream. This file will be removed in subsequent CLs. Bug: 1002894, 1008314 Change-Id: I7aa5fd7e2b5c982192aa07970d7400945f95116f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827413Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700703}
-
Rune Lillesveen authored
Shorthand properties containing var() references are represented as CSSPendingSubstitutionValues. The style value factory had casts ignoring this fact which caused crashes. Bug: 1007866 Change-Id: I8d83ba03ce6e4d3a8ce7d2ced949a4bd5ab1072e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827016Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700702}
-
Findit authored
This reverts commit 551bbdf8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 700645 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTUxYmJkZjhjN2UyNWJhN2E1ODdjMmFkOTJkMmQ0ZDUyNTI2MzY4ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/82259 Sample Failed Step: browser_tests Sample Flaky Test: ProfileMenuClickTest_SyncError.SetupAndRunTest/5 Original change's description: > [profile-menu] Implement sync states > > Sync-is-on and sync-error states are added > to the profile menu. > > Bug: 995720 > Change-Id: I8e1b385298464dc57990cb75cec397851197cb30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827423 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700645} Change-Id: I1abe2790f5bd1d2311189b98a6386eaf7ed8e081 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829025 Cr-Commit-Position: refs/heads/master@{#700701}
-
Omer Katz authored
During clearing of weak member, IntersectionObserver's disconnect method can be called. Disconnecting IntersectionObserver also removes tracked elements from the Document's IntersectionObserverController. If the controller was not yet allocated, it will be allocated during the call. This results in an allocation during atomic pause (when allocation is not allowed). In practice removing an element from a newly allocated controller doesn't do anything. Thus the fix is to only remove the element if we already have a controller. Bug: 1005208 Change-Id: I46b3e2657d72ac52d71f76382c8481c99ae8fdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829097Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#700700}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f8bb908702bd..a0159c03485b git log f8bb908702bd..a0159c03485b --date=short --no-merges --format='%ad %ae %s' 2019-09-27 jaedon1.lee@samsung.com Vulkan: Implement basic geometry shader feature Created with: gclient setdep -r src/third_party/angle@a0159c03485b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I06fce4da000a5a3bb8acadae0aafb28229d6cc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828852Reviewed-by:
-
Dominic Battre authored
This CL replaces the traing for form elements via WebSelectElement/WebInputElement by using unique renderer IDs. It does not fix all leaks by Autofill, yet. TBR=jochen@chromium.org Bug: 949587 Change-Id: I824c186fe0ef5c72d3df594e1218a61b6893a6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827014 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700698}
-
Khushal Sagar authored
Its common for snapshots to be used on the same context where canvas is rendered. Generating a sync token in this case unnecessarily issues an ordering barrier. R=fserb@chromium.org Bug: 1005074 Change-Id: Id10ec4d4f9f2736234130ad2a30d5ed743bdc9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827948 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700697}
-
Francois Doray authored
With this CL, we store the render_process_id and render_frame_id (if any) associated with each receiver in LockManager. This is a prerequisite to build a Web Lock observer interface, through which code outside of //content can know which frames hold lock and avoid freezing them. Bug: 980533 Change-Id: Id72c23e0ebd4d30f1efe68b8115b7e63f3af31c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756766Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#700696}
-
Vadym Doroshenko authored
Bug: 999871 Change-Id: Icb6c3852009130d3486f94f80d21e3d6425785cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829079 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
This CL allows to run a standalone Results Processor with any output format that has a formatter defined in processor.py. This is useful for external clients which do not need to wait until Telemetry is fully switched over to results_processor formatters. Bug: 981349 Change-Id: I4c7850a7c044d3926d9359769ab23e780ab31910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823864 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#700694}
-
Luca Hunkeler authored
Bug: b/141610802 Change-Id: I1d6b16883a89d2f398657530ada42018e1963818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827410Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#700693}
-
Boris Sazonov authored
Change-Id: I40b60b41d8050d52ebed4c16e70ee69618f2ddcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829078 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700692}
-
Mikhail Khokhlov authored
Histograms output format requires tracing module, so we need to add it to path. Bug: 981349 Change-Id: Id4980fbdb6e1baa27328dc5710c3021e63910dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828901Reviewed-by:
-
Lily Chen authored
This change makes the ThirdPartyMetricsObserver browsertests work under the new SameSite cookie changes (SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure). Also makes a drive-by change to the behavior of the ThirdPartyMetricsObserver on URLs without a registrable domain, e.g. IP addresses, "localhost", TLDs. In these cases, the hostname is used instead of returning early from OnCookiesAccess(), i.e. this causes a third party access to be logged instead of not logging. This is consistent with cookie parsing behavior, for which the domain is assumed to be the hostname and the cookie is still accepted, if no registrable domain is found. Bug: 1006816 Change-Id: I4f8bef6656849de05911e30522c36858d8ed5f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815915Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#700690}
-
