GitLab

Use dataEquivalent instead of comparing pointers. Updating the base
RenderStyle in ActiveAnimations asserts that the cached base RenderStyle
is correct by comparing RenderStyle objects. It triggered an assert when
comparing two shape-outside values represented by different objects
representing the same value.

R=esprehn@chromium.org,dstockwell@chromium.org
BUG=425473

Review URL: https://codereview.chromium.org/669093002

git-svn-id: svn://svn.chromium.org/blink/trunk@184345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org,aandrey@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/649183010

git-svn-id: svn://svn.chromium.org/blink/trunk@184344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/674103002

git-svn-id: svn://svn.chromium.org/blink/trunk@184343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's not necessary to do initialization of FontBuilder separately from
StyleResolverState::setStyle. It just adds noise.

Also, use a reference for Document in FontBuilder, since its existence can
be guaranteed in all cases.

R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/671613003

git-svn-id: svn://svn.chromium.org/blink/trunk@184342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because there is a "cue" entry in both pseudoTypeWithoutArgumentsMap and
pseudoTypeWithArgumentsMap, this path is never taken (verified with
ASSERT(0)) when running LayoutTests/media/.

It is taken for something like ::cuefoo, but that makes no sense.

This was initially the only code path:
http://trac.webkit.org/changeset/136991

Later commits made it obsolete:
http://trac.webkit.org/changeset/137955
https://src.chromium.org/viewvc/blink?revision=155834&view=revision

This was the last usage of PseudoUserAgentCustomElement, so remove that
too, together with its use counter:
https://src.chromium.org/viewvc/blink?revision=155928&view=revision
https://www.chromestatus.com/metrics/feature/timeline/popularity/103

At the time pseudos starting with "x-" were also
PseudoUserAgentCustomElement, but has since been removed:
https://src.chromium.org/viewvc/blink?revision=170210&view=revision

Review URL: https://codereview.chromium.org/646853007

git-svn-id: svn://svn.chromium.org/blink/trunk@184341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=364627
TEST=virtual/stable/webexposed

Review URL: https://codereview.chromium.org/680473002

git-svn-id: svn://svn.chromium.org/blink/trunk@184340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424767

Review URL: https://codereview.chromium.org/640823005

git-svn-id: svn://svn.chromium.org/blink/trunk@184339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The "stylsheets" field is not used at runtime,
so it is removed to reduce the footprint.

R=vsevik

Review URL: https://codereview.chromium.org/676993002

git-svn-id: svn://svn.chromium.org/blink/trunk@184338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was reverted due to bug 426608; the fix was landed on the Chromium side.

Original review url: https://codereview.chromium.org/671003002

BUG=426608,426053
TBR=leviw

Review URL: https://codereview.chromium.org/663233004

git-svn-id: svn://svn.chromium.org/blink/trunk@184337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468

BUG=423983

Review URL: https://codereview.chromium.org/672383003

git-svn-id: svn://svn.chromium.org/blink/trunk@184336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When resizing the viewport, srcset re-evaluates its resources, and downloads
a new one if needed.

However, since srcset is by definition not related to art-direction,
there's no need to download a new resource is there is a higher density one
that's already in the memory cache.

This CL avoids that unneccessary download.

BUG=425701

Review URL: https://codereview.chromium.org/674923004

git-svn-id: svn://svn.chromium.org/blink/trunk@184335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems that TypeErrors can be thrown when we modify the content of
pickle files (e.g. InterfacesInfoCoreIndividual.pickle). We can
just overwrite pickle files if pickle.load() throws an exception.

Review URL: https://codereview.chromium.org/643153006

git-svn-id: svn://svn.chromium.org/blink/trunk@184334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=426047

Review URL: https://codereview.chromium.org/672423003

git-svn-id: svn://svn.chromium.org/blink/trunk@184333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With WebLocalFrameImpl on the heap, this object no longer needs to use
persistent (or untraced) references.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/674773003

git-svn-id: svn://svn.chromium.org/blink/trunk@184332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We added AXComputedObjectAttributeCache to WebKit because we wanted to
cache some expensive computations in the AX tree, but none of the other
WebKit ports wanted it.

A much simpler solution is to just store the cached value inside the
AXObject. To determine if the value is out of date, I added a
modification count that increments whenever there's a layout or DOM
mutation. We can reuse the same modification count for more cached
attributes.

BUG=425879

Review URL: https://codereview.chromium.org/670093002

git-svn-id: svn://svn.chromium.org/blink/trunk@184331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch cleans up the reason strings to not have periods. Additionally,
a typo has been fixed in InspectorTraceEvents.

BUG=410701,424451

Review URL: https://codereview.chromium.org/650993004

git-svn-id: svn://svn.chromium.org/blink/trunk@184330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Timeout expectation for serviceworker/fetch-mixed-content.html (patchset #1 id:1 of https://codereview.chromium.org/668773003/)

Reason for revert:
Fixed by https://codereview.chromium.org/664343005

Original issue's description:
> Timeout expectation for serviceworker/fetch-mixed-content.html
> 
> Timing out following chromium r300644, but this looks like a test-only
> failure due to invalid cert in the localhost HTTPS server.
> 
> BUG=426047
> TBR=aboxhall@chromium.org,horo@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184199

TBR=aboxhall@chromium.org,jsbell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=426047

Review URL: https://codereview.chromium.org/648333003

git-svn-id: svn://svn.chromium.org/blink/trunk@184329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change displays CSS animation keyframes alongside the associated
animation player in the Animations sidebar pane. No visible changes are
introduced except with the hidden 'Animation Inspection' experiment enabled.

BUG=419269

Review URL: https://codereview.chromium.org/664993002

git-svn-id: svn://svn.chromium.org/blink/trunk@184328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is critical to display list canvases, due to the fact, that we fallback from
rendering on impl thread, when the canvas is not fully redrawn inside each
frame. On Browsermark 2 it is actually messed up due to floating point rounding.
The area in SkScalar is {0.00061, 0.00061, 1599.99997, 999.99998}, rounded down
to {1,1,1599,999} and the entire canvas area seems to be not redrawn.

BUG=386601

Review URL: https://codereview.chromium.org/666253003

git-svn-id: svn://svn.chromium.org/blink/trunk@184327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVG font implementation is removed from Blink. Remove LeakExpectations
entries for SVG font tests as they don't leak Documents anymore.

BUG=366455,242735
TBR=pdr

Review URL: https://codereview.chromium.org/673093002

git-svn-id: svn://svn.chromium.org/blink/trunk@184326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184321

BUG=242735
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/673883005

git-svn-id: svn://svn.chromium.org/blink/trunk@184325 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a minor style correction. We'd prefer the 'implicit false' rather
than 'len(array) > 0'.

Review URL: https://codereview.chromium.org/678453004

git-svn-id: svn://svn.chromium.org/blink/trunk@184324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds comprehensive unit tests to the css-syntax based
tokenizer. I've tried to cover all the edge cases I could think of here.

A few cases don't work correctly, which I've left as commented out
tests:
- Idents starting with two dashes like --abc aren't parsed as idents
- Escape should be replaced with U+FFFD when they represent either
(U+0000), a surrogate codepoint (U+D800 - U+DFFF) or are larger than
the maximum allowed codepoint (U+110000).
- We don't correctly replace U+0000 with U+FFFD
- Our handling of newline escapes (i.e. "check if two code points are a
valid escape") is incorrect in some cases as we don't perform
preprocessing.

Note that there have been minor spec changes since the candidate rec and
the tests here are based on the latest editor's draft.

http://dev.w3.org/csswg/css-syntax

BUG=424988

Review URL: https://codereview.chromium.org/646893003

git-svn-id: svn://svn.chromium.org/blink/trunk@184322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes SVG fonts in all platforms, as was discussed in
https://groups.google.com/a/chromium.org/d/msg/blink-dev/pYbbUcYvlYY/LQvFvM8KZZEJ

BUG=242735

Review URL: https://codereview.chromium.org/656913006

git-svn-id: svn://svn.chromium.org/blink/trunk@184321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Two of the Cache.put() tests were failing because of crbug.com/424629;
adjust the assertions so that one test fails (as it should) to track
that bug, but relax the assertions in another to verify just the
intended behavior (which passes).

BUG=374802
R=asanka@chromium.org

Review URL: https://codereview.chromium.org/675783004

git-svn-id: svn://svn.chromium.org/blink/trunk@184320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because of the bindings change related to Promise-returning functions (see
http://crbug.com/359411), some layout tests that had been written before that
have been broken. As the bindings change is done, this CL fixes these tests.

BUG=362992

Review URL: https://codereview.chromium.org/669353002

git-svn-id: svn://svn.chromium.org/blink/trunk@184319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reduces deferred paint save pressure and allows us to remove a
couple of GC state savers.

R=schenney@chromium.org,senorblanco@chromium.org
TBR=esprehn@chromium.org
BUG=424655

Review URL: https://codereview.chromium.org/671813002

git-svn-id: svn://svn.chromium.org/blink/trunk@184318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/640923004

git-svn-id: svn://svn.chromium.org/blink/trunk@184317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm curious how common Ruby really is, as it adds complexity to
Line Layout.

Review URL: https://codereview.chromium.org/672343002

git-svn-id: svn://svn.chromium.org/blink/trunk@184316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the design document for the existence of the
blink_skia_config.gyp file, it was originally intended to be a gypi
as proposed in this change. However, at the time, use of the
'<(webkit_src_dir)' gyp variable was required to get the correct
location of WebKit. Since variables do not expand in 'includes' in gyp,
a gyp file was used instead so that it could be used in 'dependencies'.

These limitations no longer exist and converting to a gypi allows for
easier interoperation with gn. There will be a subsequent change to
Chromium to use this new file, and then the existing gyp file will be
removed in a follow-up change.

Review URL: https://codereview.chromium.org/671323002

git-svn-id: svn://svn.chromium.org/blink/trunk@184315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

compute_interfaces_info_individual has global variables. These variables
are updated each time we call compute_info_individual(). This could be
a problem when we want to call compute_info_individual() for separate
components in the same process. Such cases could happen in
run-bindings-test when we add union types collection in
compute_info_individual(). We would want to collect all union types
which are used by IDL files under Source/bindings/test/idls, but we
don't want to collect them for IDL files under Source/{core,modules}.
This CL introduces a class and moves global variables into the class
as instance variables.

This CL doesn't change generated bindings code at this moment.

BUG=425916

Review URL: https://codereview.chromium.org/671863002

git-svn-id: svn://svn.chromium.org/blink/trunk@184314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we call setWidget for a newly created LocalFrame that's not fully attached
to the frame tree, it will be in an inconsistent state and cause crashes during
painting. Instead, update the widget at swap-time, when the frame actually
becomes fully attached.

BUG=422583

Review URL: https://codereview.chromium.org/668963002

git-svn-id: svn://svn.chromium.org/blink/trunk@184313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Originally proposed in the Encoding standard as 'ScalarValueString',
this type was finally added to Web IDL with the name 'USVString'
("Unicode scalar value string"). The behavior is identical: unpaired
UTF-16 surrogate code units in JS strings are converted to U+FFFD
replacement characters by the binding layer.

The type name is not exposed to script, so this is not a web-exposed
change.

Spec: http://heycam.github.io/webidl/#idl-USVString

BUG=423660
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/644473006

git-svn-id: svn://svn.chromium.org/blink/trunk@184312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2. (patchset #1 id:1 of https://codereview.chromium.org/671003002/)

Reason for revert:
Broke the browser tests crbug.com/426608

Original issue's description:
> Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2.
> 
> This is blink side CL to expose HTML pre tag in chromium side with proper MSAA+IA2 role.
> 
> BUG=426053
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184300

TBR=dmazzoni@chromium.org,aboxhall@chromium.org,shreeram.k@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=426053

Review URL: https://codereview.chromium.org/675033002

git-svn-id: svn://svn.chromium.org/blink/trunk@184311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cache.put() should fail the operation if request's scheme is not
"http" or "https", or if the method is not "GET"

Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html

R=jkarlin@chromium.org
BUG=425505

Review URL: https://codereview.chromium.org/675733003

git-svn-id: svn://svn.chromium.org/blink/trunk@184310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the alignment subject is larger than the alignment container, it will
overflow. Some alignment modes, if honored in this situation, may cause data
loss; an overflow alignment mode can be explicitly specified to avoid this.

BUG=249451, 376823

Review URL: https://codereview.chromium.org/614263005

git-svn-id: svn://svn.chromium.org/blink/trunk@184309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=399775

Review URL: https://codereview.chromium.org/637283010

git-svn-id: svn://svn.chromium.org/blink/trunk@184308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec was updated with the determination that add(), addAll() and put()
should resolve to `undefined`, not the response(s). Only put() is
currently implemented; update the resolution type.

BUG=425469
R=jkarlin@chromium.org

Review URL: https://codereview.chromium.org/658743003

git-svn-id: svn://svn.chromium.org/blink/trunk@184307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WebNotificationManager is analogous to the WebNotificationPresenter
living in public/web/, but without any dependency on RenderView or
RenderFrames. It also splits up the concept of the data associated with
a notification and the delegate allowing the embedder to interact with
it, as it will soon become possible for the embedder to trigger creation
of Notification objects as well (for event delivery in Service Workers).

BUG=392187

Review URL: https://codereview.chromium.org/672183003

git-svn-id: svn://svn.chromium.org/blink/trunk@184306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With most of the SVG record time rasterization out of the way, the only
client left for calculateDeviceSpaceTransformation() is
calculateScreenFontSizeScalingFactor(). Let's hide the ugly there.

R=fs@opera.com,schenney@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/677443003

git-svn-id: svn://svn.chromium.org/blink/trunk@184305 bbb929c8-8fbe-4397-9dbb-9b2b20218538