GitLab

Same goal as https://codereview.chromium.org/2921463003

I think that one didn't suppress properly because the TestBody itself
isn't in the racy stacks (merely in the spawning stacks which might
not count in the suppression rules)...

Unsuppressed race report @
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_TSan_Tests%2F6818%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Flogs%2FTimerSequenceTest.OneShotTimerUsedAndTaskedOnDifferentPools%2F0

BUG=552633
TBR=danakj@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2921623005
Cr-Commit-Position: refs/heads/master@{#476400}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2909123003
Cr-Commit-Position: refs/heads/master@{#476399}

BUG=

Review-Url: https://codereview.chromium.org/2914833003
Cr-Commit-Position: refs/heads/master@{#476398}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

(and then amended to use ThreadChecker instead for StatusTrayStateChangerWin)

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2909213002
Cr-Commit-Position: refs/heads/master@{#476397}

Bug: 728507
Change-Id: I15a6fdc5dca349894d1682520e7c99958b3953f3
Reviewed-on: https://chromium-review.googlesource.com/521863
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476396}

Also remove the flags from chromeos restart request since those flags
aren't passed in the browser command line or about flags.

Bug: 514813
Change-Id: I353204417c4e054aa2969e2894272d7e8e96c829
Reviewed-on: https://chromium-review.googlesource.com/515704Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476395}

Review-Url: https://codereview.chromium.org/2914973002
Cr-Commit-Position: refs/heads/master@{#476394}

This patch reorganizes the initialization of TextIterator for better code
health.

1. Members originally initialized in the function body of TextIterator::ctor
   are changed to be initialized in the initialization list. Some wrapper
   functions are created for members with non-trivial initialization.
   - start_container_
   - start_offset_
   - end_container_
   - end_offset_
   - end_node_
   - past_end_node_
   - node_
   - iteration_progress_
   - shadow_depth_

2. Members with trivial initialization are initialized in class declaration
   instead of ctor:
   - needs_another_new_line_
   - needs_handle_replaced_element_
   - should_stop_
   - handle_shadow_root_

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2921483002
Cr-Commit-Position: refs/heads/master@{#476393}

BUG=699244

Review-Url: https://codereview.chromium.org/2907243002
Cr-Commit-Position: refs/heads/master@{#476392}

Solely for experimenting with new query "tail" suggestions.

BUG=726769

Review-Url: https://codereview.chromium.org/2889823002
Cr-Commit-Position: refs/heads/master@{#476391}

Bug: 713222
Change-Id: I89dc5253a173a6d64ead697db765181282a14b6b
Reviewed-on: https://chromium-review.googlesource.com/515622
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#476390}

WebView autofill implementation doesn't use chrome's autofill service
and UI, instead, it use autofill service in Android platform to get
form autofilled.

BUG=693204

Review-Url: https://codereview.chromium.org/2839023003
Cr-Commit-Position: refs/heads/master@{#476389}

https://pdfium.googlesource.com/pdfium.git/+log/a64cd6c86438..f6ca07b3fda4

$ git log a64cd6c86..f6ca07b3f --date=short --no-merges --format='%ad %ae %s'
2017-06-01 tsepez Replace some repeated code with existing CFXJS_Engine::NewString() helper.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I39203fdc81880f9440fbbbb80f3d3320cdaa0b6a
Reviewed-on: https://chromium-review.googlesource.com/521722
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476388}

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2816713003
Cr-Commit-Position: refs/heads/master@{#476387}

BUG=552633

Review-Url: https://codereview.chromium.org/2916943002
Cr-Commit-Position: refs/heads/master@{#476386}

This reverts commit 3678003e, and also
add a feature flag for Request Mobile Site.

Bug: 727738
Change-Id: Id669e83b548fac668575d5460b6c6f850375fb29
Reviewed-on: https://chromium-review.googlesource.com/519444
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476385}

Backport patch released in v1.1.5
https://git.xiph.org/?p=opus.git;a=commitdiff;h=8d02afe05b80097f5a09361bb75e2950cb3ea6e2

BUG=728233

Review-Url: https://codereview.chromium.org/2918573003
Cr-Commit-Position: refs/heads/master@{#476384}

The window.view width and height attributes exclude any non-overlay
scrollbars. This means that if a scrollbar appears or disappears they'll
change values. According to the spec (and intuition) this should fire a
resize event but it doesn't.

This patch adds the resize event whenever the main frame loses or gains
a non-overlay scrollbar.

Bug: 728658
Change-Id: I32359342e795a1390cbedc95330260f03e0e2066
Reviewed-on: https://chromium-review.googlesource.com/521362Reviewed-by: David Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476383}

Tether MessageTransferOperation: Only wait for a response from a host for a certain amount of time before timing out.

BUG=672263

Review-Url: https://codereview.chromium.org/2915713002
Cr-Commit-Position: refs/heads/master@{#476382}

This CL fixes these issues in the host list UX:
1. Fixes the mysterious shadow occasionally showed between host cards.
2. Fixes the constraint of the label's width.
3. Use anchor constraints to minimize position calculations and use leading &
   trailing anchors to better support RTL languages.

BUG=728280

Review-Url: https://codereview.chromium.org/2916003002
Cr-Commit-Position: refs/heads/master@{#476381}

Before, 'Refreshing' shows on long click 'Stop refreshing' menu item.
Now added tooltip 'Stop refreshing' on the menu item.

BUG=725140

Review-Url: https://codereview.chromium.org/2921463002
Cr-Commit-Position: refs/heads/master@{#476380}

This is prep for turning on AppNap as a variation of the
MacAllowBackgroundingProcesses experiment.

BUG=460102

Review-Url: https://codereview.chromium.org/2913883002
Cr-Commit-Position: refs/heads/master@{#476379}

BUG=728713

Review-Url: https://codereview.chromium.org/2915133002
Cr-Commit-Position: refs/heads/master@{#476378}

Passed on Chrome and Safari.

BUG=652439

Review-Url: https://codereview.chromium.org/2919603002
Cr-Commit-Position: refs/heads/master@{#476377}

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1ebMBNhqRew/_6hAQKAfBwAJ

BUG=715158

Review-Url: https://codereview.chromium.org/2912403002
Cr-Commit-Position: refs/heads/master@{#476376}

While dragging, the cursor was locked, so CursorClient::SetCursor calls
were collapsed into a single call at the end of the drag. When crossing
displays with different densities, the cursor scale was incorrect until
the window was dropped. This CL removes cursor locking to prevent the
OnCursorDisplayChanged update from being postponed.

BUG=631136
BUG=642894
TEST=caroline: Cursor scale is correct while dragging across displays.

Review-Url: https://codereview.chromium.org/2812663002
Cr-Commit-Position: refs/heads/master@{#476375}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=scottbyer@chromium.org

Review-Url: https://codereview.chromium.org/2914573002
Cr-Commit-Position: refs/heads/master@{#476374}

This CL adds click listeners to account rows in Chrome settings on Android.
Tapping the row opens Android settings for the corresponding account.

BUG=722907

Review-Url: https://codereview.chromium.org/2912933003
Cr-Commit-Position: refs/heads/master@{#476373}

This adds V4LocalDatabaseManager::CheckCsdWhitelistUrl() and tests for
it. A later CL will switch the three callers of MatchCsdWhitelistUrl()
to this new function, and remove the Match method.

BUG=714300

Review-Url: https://codereview.chromium.org/2890293004
Cr-Commit-Position: refs/heads/master@{#476372}

It's possible for the PaymentRequest to be aborted before the show. For
example if CanMakePayment returns false, the merchant can close the
Payment Request.

Bug: 728641
Change-Id: Ie1c770a1f8fdceb6012f6eccf8dad6b286794382
Reviewed-on: https://chromium-review.googlesource.com/521742
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476371}

This adds a function that checks whether or not the process is currently
sandboxed. It uses the underlying sandbox_check() functionality,
which is not yet further exposed.

BUG=689306

Review-Url: https://codereview.chromium.org/2914693002
Cr-Commit-Position: refs/heads/master@{#476370}

I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be9a6ef2ce5137

Owners presubmit checks for files in components/resources are failing with an error like:

  File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry
    ('%s does not refer to an existing file.' % directive[5:]))
owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file.

TBR=jochen
NOPRESUBMIT=true
BUG=

Review-Url: https://codereview.chromium.org/2913993003
Cr-Commit-Position: refs/heads/master@{#476369}

Add Content Suggestion Push feature flag

BUG=728083

Review-Url: https://codereview.chromium.org/2898153004
Cr-Commit-Position: refs/heads/master@{#476368}

This has been on by default for quite a few releases.
It's time to remove the switches.

BUG=426656,625289

Change-Id: I25bf2f3ec3d23cf51df6aeb5a1966a168b8617ad
Reviewed-on: https://chromium-review.googlesource.com/519564Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476367}

Review-Url: https://codereview.chromium.org/2920613003
Cr-Commit-Position: refs/heads/master@{#476366}

BUG=546208

Review-Url: https://codereview.chromium.org/2824523002
Cr-Commit-Position: refs/heads/master@{#476365}

After the recent cleanup of crrev.com/2907563002, the flag
ENABLE_MEMORY_TASK_PROFILER became redundant and now is just
matching 1:1 USE_ALLOCATOR_SHIM. Use that instead.
No intended behavior change.
Also fix mistake of using defined(X) instead
of BUILDFLAG(X).

BUG=550886

Change-Id: I03a840b22861182208f1297a0c3f1152fd985c32
Reviewed-on: https://chromium-review.googlesource.com/520768
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476364}

TBR=sdefresne@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2914253002
Cr-Commit-Position: refs/heads/master@{#476363}

Speculative fix for timeouts on linux_android_rel_ng in the
FrameTreeBrowserTest.FrameTreeAfterCrash test.

BUG=727725
TEST=Less flakiness
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2919483003
Cr-Commit-Position: refs/heads/master@{#476362}

This class was part of the "Shiny Modern" Views UI look, but ended
up unused.

BUG=None

Review-Url: https://codereview.chromium.org/2920463002
Cr-Commit-Position: refs/heads/master@{#476361}