GitLab

The "Site Details" page currently only shows content settings that are set to a
non-default setting for the given origin. This patch will show all content
settings in "Site Details", regardless of whether they are still set to the
default setting or not.

BUG=656758,709171
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2912253003
Cr-Commit-Position: refs/heads/master@{#476514}

Support is compliant with RFC 5280 and supports all the policy
extensions specified therein:

 * Inhibit Any Policy
 * Policy Constraints
 * Policies
 * Policy Mappings

Testing is done solely using the PKITS test suite, which has fairly good
coverage of these extensions:

  4.8 (Certificate Policies)
  4.9 (Require Explicit Policy)
  4.10 (Policy Mappings)
  4.11 (Inhibit Policy Mapping)
  4.12 (Inhibit Any Policy)

BUG=634456,634453,634452

Review-Url: https://codereview.chromium.org/2903283002
Cr-Commit-Position: refs/heads/master@{#476513}

This change simplifies the scope and lifetime of the manifest_.

Bug: 728667
Change-Id: Ia234f9cf6e56dac45c5f358f6b3cd8bdc6652ba3
Reviewed-on: https://chromium-review.googlesource.com/522202
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476512}

This patch moves TextIteratorTextState's member initialization to the class
declaration, since they are all trivially initialized.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2922553002
Cr-Commit-Position: refs/heads/master@{#476511}

Clicking back-to-safety will now navigate backward for the malicious
subresource case, which is consistent with Chrome's behavior.

This removes is_resource_cancellable, since it was only added for the
old WebView behavior (see crrev/458833).

BUG=699196

Change-Id: Idb78f514f3ccbc8d899622c3700d71c93fdc7253
Reviewed-on: https://chromium-review.googlesource.com/516803Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476510}

This CL changes CompositionMarker to take and store its thickness param as an
enum instead of a bool. This makes code creating CompositionMarkers easier to
understand (and also enables us to add additional thickness values in the future
if necessary).

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2906953002
Cr-Commit-Position: refs/heads/master@{#476509}

This patch renames |VisibleSelection::end()| to |End()| to follow Blink coding
style.

BUG=727486
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2920733002
Cr-Commit-Position: refs/heads/master@{#476508}

Bug: 718063
Change-Id: Ia60355916d1e9e440f661255e40e4af83f288365
Reviewed-on: https://chromium-review.googlesource.com/521364
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476507}

Fixes a bug where the resolved term isn't always selected in the text.
The case fixed is due to the selection including a trailing space
when at the end of a line.  It's unclear why the trailing space is
included in the selection.  We simply trim the trailing space.

BUG=726767

Review-Url: https://codereview.chromium.org/2910713002
Cr-Commit-Position: refs/heads/master@{#476506}

Even on a beefy workstation, resizing theme images takes a long time
(>1s). This causes a painful hiccup in the UI. This patch addresses that
by moving the operation to a helper thread. The actual application of
the theme won't be any faster but it won't block interaction.

As a future area of investigation it might be worth changing the "theme
installed" infobar to show earlier with a message like "installing
theme..." until this operation is completed, since otherwise it can feel
like nothing is happening.

BUG=316070

Review-Url: https://codereview.chromium.org/2799003002
Cr-Commit-Position: refs/heads/master@{#476505}

Mapping a custom element constructor to its definition used to look in
a JavaScript map from constructor to custom element name string, and
then hash that name to look up the custom element definition in the
registry.

After this change the JavaScript map values are IDs so the definition
can be retrieved directly from a vector. This avoids marshaling the
name string from V8 to C++, and avoids hashing the string, to look up
a definition. (There's still a map from name to ID on the side so that
CustomElementRegistry.get can look up definitions by name, but it is
not used in common operations like creating a custom element.)

Bug: 710184
Change-Id: I90ee5759bf692b5a2df43a4a59ef4fac94d22f2c
Reviewed-on: https://chromium-review.googlesource.com/520543
Commit-Queue: Dominic Cooney <dominicc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476504}

Change one more native layer message to cr.sendWithPromise and adjust
tests to use browser proxy for this message instead of triggering an
event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2919693002
Cr-Commit-Position: refs/heads/master@{#476503}

BUG=687863

Review-Url: https://codereview.chromium.org/2914193003
Cr-Commit-Position: refs/heads/master@{#476502}

- make View::set_background take a smart pointer (a la SetBorder)
- move background factory functions out of views::Background (also a la
  Border) for reduced verbosity
- remove a couple redundant background factory functions

No behavioral changes.

Bug: none
Change-Id: I4d4971ea04dcb1f17ebda5671fd997beb1a692a3
Reviewed-on: https://chromium-review.googlesource.com/520702
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476501}

BUG=728789

Review-Url: https://codereview.chromium.org/2915013003
Cr-Commit-Position: refs/heads/master@{#476500}

BUG=715193
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2918613003
Cr-Commit-Position: refs/heads/master@{#476499}

This reverts commit eb03fb79.

Reason for revert: Test is still flaky after all.

Original change's description:
> Re-enable WebVrTest#testPoseDataUnfocusedTab
> 
> Re-enables the previously flaky WebVrTest#testPoseDataUnfocusedTab.
> Flakiness appears to have been caused by the move to JUnit4 and fixed
> in one of the CLs that did additional cleanup and improvements after the move.
> 
> Bug: 726986
> Change-Id: I6e54b87e21eaed91ac668125857c09e6df4b46e2
> Reviewed-on: https://chromium-review.googlesource.com/521842
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476409}

TBR=mthiesse@chromium.org,bsheedy@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 726986

Change-Id: Iecf5abe7ab0f1d27dcb149ca53f480f758de7be3
Reviewed-on: https://chromium-review.googlesource.com/522182
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476498}

1) We need the outer-container to be scrollable when gaia screen and
virtual keyboard are shown together, so the dark overlay ('login-shield')
should always have the same size with the larger one of
the outer-container and the scroll-container, otherwise we see areas
without overlay when scrolling up.

2) We should remember to clear contents on the small pods container
before rebuilding pods.

BUG=718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2916973002
Cr-Commit-Position: refs/heads/master@{#476497}

Revert of ChromeOS: Per-user time zone: refactor tests first. (patchset #10 id:180001 of https://codereview.chromium.org/2907493002/ )

Reason for revert:
Looks to have caused Linux CrOS link failure:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/87898

Original issue's description:
> ChromeOS: Per-user time zone: refactor tests first.
>
> This Cl prepares tests to support per-user timezone implementation.
>
> BUG=622555, 699472
>
> TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org
>
> Review-Url: https://codereview.chromium.org/2907493002
> Cr-Commit-Position: refs/heads/master@{#476478}
> Committed: https://chromium.googlesource.com/chromium/src/+/410dbeb8df3d4ab140390d7d1e603163885c8c9c

TBR=stevenjb@chromium.org,phajdan.jr@chromium.org,xiyuan@chromium.org,alemate@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622555, 699472

Review-Url: https://codereview.chromium.org/2919933002
Cr-Commit-Position: refs/heads/master@{#476496}

BUG=672263

Review-Url: https://codereview.chromium.org/2917803002
Cr-Commit-Position: refs/heads/master@{#476495}

TBR=grt
BUG=712414

Review-Url: https://codereview.chromium.org/2916953002
Cr-Commit-Position: refs/heads/master@{#476494}

The "Images" content setting is missing from "Site Details". Add it.

chrome: //settings/content/siteDetails?site=http%3A%2F%2Fpermission.site%3A80
Review-Url: https://codereview.chromium.org/2915743002
Cr-Commit-Position: refs/heads/master@{#476493}

Depending on:
https://chromium-review.googlesource.com/c/518308/

Bug: 727804
Change-Id: I70e48bd5336a2fca3e5661ef1df8e03941003a10
Reviewed-on: https://chromium-review.googlesource.com/517675Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476492}

resulting in the connection being closed due to a synchronous write error.

BUG=728434

Review-Url: https://codereview.chromium.org/2915973002
Cr-Commit-Position: refs/heads/master@{#476491}

preferences.mojom and preferences_configuration.mojom had to be merged as they
would cause a circular import otherwise.

BUG: 654988
Change-Id: I061365e7c6c7ae3c851e427a24d2a322e1210987
Reviewed-on: https://chromium-review.googlesource.com/514902Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Johan Tibell <tibell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476490}

Per MTBR review, this list is growing too big to keep living inside
MediaLog; so create a new home for all watch time related keys in
a new "watch_time_keys.{h,cc} file.

BUG=none
TEST=compiles

Change-Id: Ib927f21f04d0a321dac0eec8cc81af74302334e3
Reviewed-on: https://chromium-review.googlesource.com/521804Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476489}

BUG=725736

Review-Url: https://codereview.chromium.org/2899203002
Cr-Commit-Position: refs/heads/master@{#476488}

We may want to land another CL to update text input styles:
https://codereview.chromium.org/2875193002/

BUG=690239

Review-Url: https://codereview.chromium.org/2906983002
Cr-Commit-Position: refs/heads/master@{#476487}

It is mostly unused, there is only one constant in that header file,
which is "used" at content/public/common/content_descriptors.h. But
let's just use 0 there, and remove this header file now.

BUG=None

TBR=bradnelson@chromium.org,isherman@chromium.org

Change-Id: Ibb768b429f79693f5b85f0ea47d037cf954badfd
Reviewed-on: https://chromium-review.googlesource.com/520942
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476486}

Adds a few simple signals for a Tap gesture relative to the content
that was tapped.  These signals include word length and tap offset.
Logs UMA for CTR when these signals are present.

Updates the CS Context with analysis of the content where the Tap
gesture occurred.

One signal determines if the user tapped near the edge of a word
or not. The rest look at very short words, or relatively long words.

All signals use the existing CSHeuristics framework to do the checking and logging.

Updates the CSHeuristics framework to make the CSContext available
to heuristics so they can inspect the text tapped before deciding
whether to suppress or not.

Adds Field Trial params to enable actual suppression based on
these new signals (likely to be used only for interactive-testing
and demonstration purposes).

BUG=723194

Review-Url: https://codereview.chromium.org/2906763002
Cr-Commit-Position: refs/heads/master@{#476485}

BUG=672263

Review-Url: https://codereview.chromium.org/2916203002
Cr-Commit-Position: refs/heads/master@{#476484}

Right now EventTargeter talks to EventDispatcherDelegate directly but it
should not have any knowledge of EventDispatcherDelegate. Adding an
EventTargeterDelegate to route calls to EventDispatcher and then
EventDispatcherDelegate.

BUG=none, related to https://codereview.chromium.org/2905333002/
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2911293002
Cr-Commit-Position: refs/heads/master@{#476483}

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

Typing chrome into quick_launch restores focus only to the original
chrome window; it doesn't restore focus to chrome windows launched
through quick_launch for some reason.

BUG=727837

Review-Url: https://codereview.chromium.org/2920473003
Cr-Commit-Position: refs/heads/master@{#476482}

This comes from a review comment on http://crrev.com/2917483002. The
if guard on the function call to GetLinuxWindowManager is no longer
the same as the guard of the function definition.

This CL makes them the same again.

BUG=724244
R=thestig@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_compile_only_ng

Review-Url: https://codereview.chromium.org/2914963003
Cr-Commit-Position: refs/heads/master@{#476481}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dccdc028..8aacdbbc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2921723002
Cr-Commit-Position: refs/heads/master@{#476480}

This will make it easier to have sorted lists and list-like select controls.

BUG=none

Review-Url: https://codereview.chromium.org/2916743002
Cr-Commit-Position: refs/heads/master@{#476479}

This Cl prepares tests to support per-user timezone implementation.

BUG=622555, 699472

TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2907493002
Cr-Commit-Position: refs/heads/master@{#476478}

Review-Url: https://codereview.chromium.org/2910823002
Cr-Commit-Position: refs/heads/master@{#476477}

This switch will be used by telemetry so all chrome logging goes to
/var/log/chrome/chrome instead of split between this location and
/home/chronos/user/log/chrome, which is in the cryptohome, and sometimes
not collected by autotests.

BUG=chromium:724273
TEST=manual

Review-Url: https://codereview.chromium.org/2893313003
Cr-Commit-Position: refs/heads/master@{#476476}

One of HttpServerPropertiesImpl's responsibilities is to store HTTP alternative services that have failed and keeps track of their time-until-retry (i.e. when their brokenness expires). The broken alt-svcs and their respective expiration times are kept in a list ordered by expiration time. When the expiration task runs, it drops items from the front of the list until the expiration time of the head alt-svc is no longer in the past. Turns out this list was kept in insertion order as opposed to expiration-sorted order. This change keeps this queue in expiration-sorted order, as expected.
The additional logic added to implement the above change led to a refactor of HttpServerPropertiesImpl: its broken alt-svc logic is put in its own class, BrokenAlternativeServices.

BUG=724302

Review-Url: https://codereview.chromium.org/2898983006
Cr-Commit-Position: refs/heads/master@{#476475}