GitLab

BUG=229940

Review URL: https://chromiumcodereview.appspot.com/16115002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177394

Review URL: https://chromiumcodereview.appspot.com/15754003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202726 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202725 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151268:151287&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16146004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=221543

Review URL: https://chromiumcodereview.appspot.com/15086005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202723 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a method HasWord(string) to SpellcheckCustomDictionary and changes
the internal data structure in SpellcheckCustomDictionary from a vector to a set
for more efficient querying. Spelling service client will use the new method to
send IN_DICTIONARY feedback to spelling service for words that are in user's
custom spellcheck dictionary. Spelling service client will use this method in
upcoming CLs.

This CL also modifies IPC message "SpellCheckMsg_Init" to pass a set instead of
a vector of custom dictionary words. The browser sends this message to the
renderer to initialize spellcheck.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15940004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238041

Review URL: https://chromiumcodereview.appspot.com/15897003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202721 0039d316-1c4b-4281-b951-d872f2087c98

http://src.chromium.org/viewvc/chrome?revision=202702&view=revision

TBR=cmp@chromium.org

Review URL: https://codereview.chromium.org/15846019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202720 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/16069006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202718 0039d316-1c4b-4281-b951-d872f2087c98

This function returns an object whose keys are the notification
IDs of all notifications created by that extension.

BUG=240924

TBR=miket@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15715008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202716 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the existing "WebRTC hack" where the native audio layer runs at 44.1 but WebRTC at 44.0. Now when native WebRTC supports 44100, it is possible to add the same support to WebRTC in Chrome.

BUG=243450
TEST=content_unittests and misc. WebRTC clients using 44.1 as sample rate on input and output devices.

Review URL: https://chromiumcodereview.appspot.com/15907005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202713 0039d316-1c4b-4281-b951-d872f2087c98

This searches for shortcuts in the usual locations containing the app's old
name, deletes them, and creates new shortcuts in the places where there were
pre-existing shortcuts.

BUG=153981

Review URL: https://chromiumcodereview.appspot.com/14993013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202712 0039d316-1c4b-4281-b951-d872f2087c98

This is breaking chrome on windows 8, can't relaunch in desktop
see bug

BUG=244453

> Make InputMethodWin TSF-aware.
> 
> This patch set introduces following event handlings
> so that InputMethodWin can work with TSF-based IME.
> - Focus handling (OnFocus/OnBlur)
> - TextInputType handling (OnTextInputTypeChanged)
> - Composition Handling (OnDidChangeFocus/ConfirmCompositionText)
> 
> Basically this is just a quick fix and InputMethodWin
> should be refactored eventually.
> 
> BUG=239690
> TEST=Manually done on Windows 7 with --enable-text-services-framework
> 
> Review URL: https://chromiumcodereview.appspot.com/14698032

TBR=Yukawa@chromium.org

Review URL: https://codereview.chromium.org/15897010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202709 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202708 0039d316-1c4b-4281-b951-d872f2087c98

I've been unable to repro the crash, but perhaps there's a way for
VersionUpdaterWin::OnReportResults to be invoked twice. This change
detaches the VersionUpdaterWin instance from the GoogleUpdate instance
when it releases its reference.

BUG=236413,242895
R=mad@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15649007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202707 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mstarzinger@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15891008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202704 0039d316-1c4b-4281-b951-d872f2087c98

Merge some member functions and rename others.

Clean up SpdyHttpStream logic a bit.

BUG=243643

Review URL: https://chromiumcodereview.appspot.com/15936003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202703 0039d316-1c4b-4281-b951-d872f2087c98

This is the Chrome-side half of a CL to allow mmaping and skipping validation
for chrome-extension: files we have seen before and know are safe.  To do this
we need to know the path of the file on disk, but we don't entirely trust the
renderer not to tamper with it.  To work around this, a nonce is passed along
with the file handle.  This nonce can be used by the NaCl process to acquire the
file handle directly from the browser process, as well as a fresh copy of the
file handle.

This change significantly revises the OpenNaClExecutable method of the
PPB_NaCl_Private interface.  The method was added anticipation of this CL, but
the overall design shifted after the method was added.

BUG=https://code.google.com/p/chromium/issues/detail?id=224434

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202278

R=dmichael@chromium.org, jschuh@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/14750007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202702 0039d316-1c4b-4281-b951-d872f2087c98

This DCHECK triggers very rarely. Adding additional info to the
DCHECK so we have a better idea of why it's failing.

BUG=244398

Review URL: https://chromiumcodereview.appspot.com/16023016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202701 0039d316-1c4b-4281-b951-d872f2087c98

Similar to http://crbug.com/237823.

BUG=244259

Review URL: https://chromiumcodereview.appspot.com/15706007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202700 0039d316-1c4b-4281-b951-d872f2087c98

Disable kiosk app settings UI by default and add a flag to turn it on.
This is a CL for M28 before it is moved to extensions UI.

BUG=243859

Review URL: https://chromiumcodereview.appspot.com/15715014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202699 0039d316-1c4b-4281-b951-d872f2087c98

Temprarily workaround that needs to be replaced by ui::BaseShellDialog.

BUG=180997

Review URL: https://chromiumcodereview.appspot.com/15817004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202696 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202695 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r11398: (khim) Add few more test to automatically catch errors
r11399: (eliben) Move the pnacl_info_template.json file from the Chrome repo to the NaCl repo.
r11400: (mseaborn) Minidumper: Extend build ID reader to work with PNaCl toolchain on x86-64
r11401: (kschimpf) Update pnacl llvm revision
r11402: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS
r11403: (binji) build_nexe.py now normalizes paths before accessing the filesystem.
r11404: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS
r11405: (mseaborn) PNaCl: Switch to using "-pnacl-abi-simplify-{pre,post}opt" meta-passes
r11406: (shcherbina) Factor out objdump parsing utils to separate module.

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/16001004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202693 0039d316-1c4b-4281-b951-d872f2087c98

Again, these code is not depending on any content stuff, so moving it to gpu/ side will allow us to disable more gpu tests per GPU.

BUG=230477
TEST=gpu_unittests,tree
TBR=kbr@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/15827008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15750002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202689 0039d316-1c4b-4281-b951-d872f2087c98

Previously a library that was needed on two architectures
but only found on one would be silently ignored.

BUG=
R=binji@chromium.org

Review URL: https://codereview.chromium.org/15891011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202688 0039d316-1c4b-4281-b951-d872f2087c98

The chrome webui settings page contains code to hide the sync settings
overlay if sync is disabled or if the user is signed out in the
background while the overlay is visible. It does so by calling the
SyncSetupOverlay.CloseOverlay() function.

It turns out that if SyncSetupOverlay.closeOverlay() is called when
the sync settings overlay is not visible, it will close whatever overlay
is visible (in case of bug 244141, the clear-browsing-data overlay).

This patch modifies SyncSetupOverlay.CloseOverlay() to only close the
sync setup overlay if it is visible, and not any other overlay.

BUG=244141
TEST=All non-sync settings UI overlays must stay visible when the user is disconnected or when sync is disabled.
R=zea@chromium.org

Review URL: https://codereview.chromium.org/15740030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202687 0039d316-1c4b-4281-b951-d872f2087c98

Field's server type mapping (using Autofill server response) for forms with checkable elements/password fields is off 

BUG=244290

Review URL: https://chromiumcodereview.appspot.com/16164003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202684 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of the code duplication of driver_bug_workarounds, i.e., get rid of the hardwired workarounds.

Then apply the workarounds from json file to gl_tests.

BUG=
TEST=gl_tests,gpu_unittests
R=gman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16159004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202682 0039d316-1c4b-4281-b951-d872f2087c98

This change was made in http://crrev.com/200122, but appears to have
been lost in a merge at http://crrev.com/200407.

BUG=243275

Review URL: https://chromiumcodereview.appspot.com/16021009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/15688008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202679 0039d316-1c4b-4281-b951-d872f2087c98

This is a concrete class wrapping a string that contains the
data of a serialized WebKit::WebHistoryItem class. Previously,
we've just passed around these as strings, giving them names
like "state", "content_state" or "history_state". It has been
hard to identify all of the places in the code where these
strings get passed around. A concrete class should make usage
more apparent. Plus, instead of manipulating the strings using
methods from webkit/glue/glue_serialize.h, we can just declare
methods on the PageState class. This makes the code much cleaner.

This first pass just implements PageState in terms of glue_serialize.
It also adds content/public/renderer/history_item_serialization.h
as the home for PageState to WebKit::WebHistoryItem conversion,
which should ideally only be usable from the renderer process.
(This bit is a step toward resolving bug 237243.)

page_state.h declares operator==() to support DCHECK_EQ, which
seems consistent with the idea of PageState being a replacement
for std::string. I didn't want to litter tests with calls to
PageState::ToEncodedData(). That would get cumbersome.

Originally reviewed at:
https://codereview.chromium.org/14985014

The only difference is that page_state.cc is now split into two
pieces: page_state.cc and page_state_webkit.cc.  The second holds
the definition of all methods that depend on webkit/glue.  That way
code like Chrome Frame and the iOS port of Chromium can use PageState
without pulling in a dependency on webkit/glue at link time.

BUG=240426
R=brettw@chromium.org, grt@chromium.org, joth@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/16162003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116128
TBR=asargent@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/15929004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177394

Review URL: https://chromiumcodereview.appspot.com/15754002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202675 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces a new function for fetching the handles of all
children of a sync node, then puts it to use in optimizing the
GenericChangeProcessor's GetSyncDataForType() function.

Prior to the UniquePosition changes, it was simple and cheap to fetch
the ID of a successor or predecessor item.  After the change, it
requires a few expensive map lookups.  In other words, GetSuccessorId()
has gone from being O(1) to O(lg(n)).  This is a especially a problem in
code paths where we use GetSuccessorId() to iterate over all nodes in a
folder.

The UniquePosition change also makes it pretty easy to fetch all child
nodes under a given parent.  We could easily return all the EntryKernels
under a given folder.  Unfortunately, the APIs don't make it easy to
expose that functionality.  Instead, we do something less efficient, but
still much better than the status quo: return the IDs of all the
children.  The caller will need to look up each entry at O(lg(n)) cost,
but at least it didn't have to do two lookups to fetch each ID.

This change should lead to a slight performance improvement in the
ModelAssociation time of types that use the GenericChangeProcessor.

BUG=178275, 241813

Review URL: https://chromiumcodereview.appspot.com/14667013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202673 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233420
TEST=http/tests/media/media-source/webkitmediasource-errors.html LayoutTests
      now passes w/o crashing.

Review URL: https://chromiumcodereview.appspot.com/15927003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244218
R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/16170002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202670 0039d316-1c4b-4281-b951-d872f2087c98

Following crrev.com/202558, android's pylib was initialized on platforms that didn't need.
Check for platform and also make it safer to use should there be problems with "which".

BUG=242960
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/15804004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202669 0039d316-1c4b-4281-b951-d872f2087c98