- 31 Jan, 2020 40 commits
-
-
Kevin Marshall authored
Adds a new field "force_content_dimensions" to the Cast ApplicationConfig table. If the field is set, then the value is passed to Frame::ForceContentDimensions() on application startup. Bug: b/144361044,b/144725868 Change-Id: I895071e8236aaf0e55435b0c1ea5e6eef8008e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029259 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#737427}
-
Demetrios Papadopoulos authored
- Adding a new c/b/r/settings/settings.gni file. - Defining |settings_namespace_rewrites| and |settings_auto_imports| holding common Settings-related entries - Also extract a few non-Settings common rewrites to tools/polymer/polymer.gni This is so that they can be reused across multiple BUILD.fn files. Bug: 1026426 Change-Id: I11ee3b4e30d3e4871b9483e2a7a9ff5ec8bae7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032568 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737426}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bfe3ef8feb3b..261f792f836a git log bfe3ef8feb3b..261f792f836a --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sprang@webrtc.org Allow software fallback on lowest simulcast stream for temporal support 2020-01-31 phoglund@webrtc.org Implement histogram perf results writer. Created with: gclient setdep -r src/third_party/webrtc@261f792f836a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9de66edbbb0ccd2bb8dce65d4834e578d00b56dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737425}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f768708f30f0..c2a397db501d git log f768708f30f0..c2a397db501d --date=short --first-parent --format='%ad %ae %s' 2020-01-31 soxia@microsoft.com Accessibility: "Clear site data" button click sets focus Created with: gclient setdep -r src/third_party/devtools-frontend/src@c2a397db501d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042144 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I814e64074be7b9863bc62cab9ab17a1c2eeea86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033419Reviewed-by:
-
Patrick Monette authored
Bug: 993033 Change-Id: Iff54ba97386e5e81438f3442a05c48d9df9ff88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031752 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#737423}
-
Elly Fong-Jones authored
This test flakily fails on Mac, like in this run: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2044 The flakes are caused by the scrollbar sometimes showing or not showing; see the root cause analysis given on the linked bug. Using "overflow: hidden" on the body will prevent the scrollbar from ever showing. Bug: 1005670 Change-Id: Icb7ac47e6c0acd53b7733693282a493e3ab0e09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033366Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737422}
-
Matt Jones authored
This patch ensures the getter for the bottom controls offset is no larger than the bottom controls height. This fixes an issue with the bottom container (infobars, etc.) where the infobar would appear partially or completely offscreen because of controls height being 0 without having updated offsets. We should be getting a signal from the renderer for this, but that can be addressed in a followup. Bug: 103602 Change-Id: Iedecc00364649c5be09c70e0f7db37773db57e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033367Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737421}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f44a809f9a3b..2dd9ed07760d git log f44a809f9a3b..2dd9ed07760d --date=short --first-parent --format='%ad %ae %s' 2020-01-31 natlee@microsoft.com Handle Device Lost for Command Encoder Finish Created with: gclient setdep -r src/third_party/dawn@2dd9ed07760d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I31a4ac6085a197190c2794635f76a3c87539c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033421Reviewed-by:
-
John Chen authored
Rebaseline to fix 6 new web tests failures on MacOS 10.14. These were all pixel comparison failures introduced by recent CLs. These CLs were authored before MacOS 10.14 was added as a default trybot, and thus only rebaselined the tests to 10.13. https://crrev.com/737203 introduced 4 failures: * virtual/controls-refresh-hc/virtual/controls-refresh/color-scheme/month-picker/month-picker-appearance-disabled-values.html * virtual/controls-refresh-hc/virtual/controls-refresh/color-scheme/month-picker/month-picker-appearance.html * virtual/controls-refresh/month-picker/month-picker-appearance-step.html * virtual/controls-refresh/month-picker/month-picker-appearance-value-not-in-interval.html https://crrev.com/737259 introduced 2 failures: * virtual/layout_ng_fragment_traversal/fast/table/027-vertical.html * virtual/layout_ng_fragment_traversal/fast/table/border-collapsing/003-vertical.html Bug: 1028242 Change-Id: I9909f63ccdb264cd982c04523aaa077c83432ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033329 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737419}
-
Clark DuVall authored
Calling ClearBindings() on a factory with no in progress requests could have previously led to a leak. Change-Id: Ia7bba6f5476366d4ffa7912974190c32c0bebd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032717Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737418}
-
Sadrul Habib Chowdhury authored
When a frame ends, inform the trackers of the BeginFrameArgs that caused the most-recent activation from the main-thread. This information will be used in subsequent CLs to validate/assert assumptions, and improve tracking updates from the main-thread. BUG=1021963 TBR=xidachen@ reviewed trivial change in platform/graphics/ change. Change-Id: I3aa314031affd06b244c9ca5e14bc8c72fb915cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028254 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737417}
-
Dale Curtis authored
The high efficiency path for skipping uploads when a VideoFrame is already in a given texture was not working. The last uploaded id was never set on the texture. Bug: 776222 Test: Manual inspection confirms texture uploads only when needed. Change-Id: If8a7c19d45f874e4335418ea5c19f602c2e007c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032340Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737416}
-
Manu Cornet authored
Also remove |TargetBounds| comparison logic in the shelf layout manager that isn't used any more, and access some of the shelf components directly from |Shelf| instead of going through |ShelfWidget|. This is a step in the direction of better compartmentalizing each shelf component and better coordinate animations. Change-Id: If9e4b6dcb17c40988e54db2395271b84922a6167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032073 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737415}
-
Francois Marier authored
Bug: 1042466 Change-Id: I6097ebac532787baf383076fe9eeed9bff54aa4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003916Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Francois Marier <francois@brave.com> Cr-Commit-Position: refs/heads/master@{#737414}
-
Patrick Noland authored
Bug: b/148339489 Change-Id: I1714f3439c6d88d764b8e894add7fd93eeed2baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032422 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737413}
-
ccameron authored
This reverts commit 2a085af2. Reason for revert: 5 GPU FYI bots started failing after this (extremely mysteriously, because this shouldn't affect them this way) https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20Intel/98243 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Release%20%28Intel%29/19387 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20AMD/96734 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/20055 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20GPU%20ASAN%20Release/14113 Original change's description: > Remove three flaky suppressions on Mac NVIDIA WebGL > > These tests are no longer flaky > conformance/ogles/GL/exp2/exp2_001_to_008.html (WebGL 1 and 2) > conformance2/textures/canvas/tex-3d-rg16f-rg-float.html > > Bug: 923080 > Change-Id: Ibc0e4b488779a0843a787acacac6c9544e34c50f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029260 > Auto-Submit: Austin Eng <enga@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737052} TBR=kbr@chromium.org,enga@chromium.org Change-Id: I92cc1297bd71bc82b8e22662e58affe53b40ad6c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033626Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#737412}
-
Xida Chen authored
This reverts commit e11c77ab. Reason for revert: Suspect causing layout test failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/7513 Original change's description: > Switch to using an explicit ended signal for HTMLMediaElement. > > We've long used now > dur as an implicit signal, but with poorly muxed > media this can be unreliable. Since EndedPlayback() is used for a few > important signals, we should ensure it's always right. As such, switch > to using the explicit signal known by the WebMediaPlayer. > > This has been the source of a lot of flakiness over the years and we've > been thinking about doing this since 2014. > > The only tricky part is in handling seeks to the end of file correctly; > our pipeline previously required that play be called before we would > trigger a real pipeline ended event. Instead we relied on HTMLME just > declaring the playback ended at now >= dur. Now we will "render" end > of stream even if playback hasn't started if we have nothing to play. > > Bug: 409280, 1035472 > Test: Updated unittests, all existing tests pass. > > Change-Id: I1fbea34e8ac9e772d5b3573cd57df5d8c065e9c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021292 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737397} TBR=dalecurtis@chromium.org,jrummell@chromium.org,mlamouri@chromium.org,rtoy@chromium.org,guidou@chromium.org Change-Id: I99a7000fa2bc33db0b9abc3b257bc56f0778fb2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 409280, 1035472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033541Reviewed-by:
-
Xida Chen authored
This reverts commit 35e625a4. Reason for revert: I think this caused compile failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/9728?blamelist=1#blamelist-tab Original change's description: > build cachetool on windows > > The only issue seems to be handling arguments :) > > Change-Id: I1574bf3fdb50b15c9599adb63395c83bc28681a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018125 > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737401} TBR=rsleevi@chromium.org,jeremya@chromium.org Change-Id: I5665cd7302b6f6ade7a48a7c278b15fae5a3aa29 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033341Reviewed-by:
-
Nico Weber authored
This used to not work, but now it does. Follow-up to https://chromium-review.googlesource.com/c/2016844 Bug: 1047347 Change-Id: I6a8290ef69c5f1d5840c289fc73677dbe3d5236d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031679 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#737409}
-
Tibor Goldschwendt authored
Change-Id: I22a400da520922e46308cc5a870876ef9865d5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026893 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#737408}
-
Caroline Rising authored
Bug: 1041919 Change-Id: Icbdb857215141367764738a03064a180ff8abd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001402 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737407}
-
Reilly Grant authored
The native handle passed to the Shape Detection interface registrar can be leaked if the barcode or text detection feature is not available. This change ensures that it is always wrapped in a MessagePipeHandle and closed on failure to bind to an implementation. Bug: 1020746 Change-Id: Ic8a60135ed1ff43c27bb074bd577442dac40482f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032175 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#737406}
-
Reilly Grant authored
The Mojo Java bindings may be used outside the browser process. For example, by the Shape Detection service in the GPU process. This annotation signals that the file should be registered for non-browser processes when explicitly JNI registration is used. Bug: 961699 Change-Id: I9663de449cebe30f9e5b6ae88d8cc3114aec7789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032176 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Eric Robinson authored
Had a small issue with the naming, as I mixed up where some of the names belonged in the json. This should fix it up. Bug: 1020306 Change-Id: Ie91a8ab9e8a3fc07f0f0a00ab12ec05dc50e52c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033424Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#737404}
-
Liviu Tinta authored
Remove the RuntimeFeature FractionalMouseEvent flag including all the virtual tests that go with it. Bug: 1041985 Change-Id: Ib32f3a0292bab5ef4822f02ab64c2bee7b06de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020563 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#737403}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/539e9740e1cd..bb93f7b380bc Created with: gclient setdep -r src-internal@bb93f7b380bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4e499a0168f4e51809b7f8cb88bb5dd359e68842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737402}
-
Jeremy Apthorp authored
The only issue seems to be handling arguments :) Change-Id: I1574bf3fdb50b15c9599adb63395c83bc28681a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018125Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#737401}
-
Dale Curtis authored
This prevents the "skip already uploaded frame" logic from actually working. Though it seems to be broken in some other way currently. Bug: 776222 Change-Id: I58dc0490c976588d1c0d9a37210330fcfa399474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031720Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae2b962ce583..4ada8ab49f7b git log ae2b962ce583..4ada8ab49f7b --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sdefresne@chromium.org [roll] Fix the command in the commit message Created with: gclient setdep -r src/third_party/depot_tools@4ada8ab49f7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7c21af65ce5df0d787b2c38b09e04ea1f4839260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033406Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c0114c6399a..f768708f30f0 git log 3c0114c6399a..f768708f30f0 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 lomitch@microsoft.com Fixed localization issue with compositing reasons in the layers tool. Created with: gclient setdep -r src/third_party/devtools-frontend/src@f768708f30f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:946860 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e3df6ad5582a6bac2c97279c9edcf0c8562bed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033408Reviewed-by:
-
Dale Curtis authored
We've long used now > dur as an implicit signal, but with poorly muxed media this can be unreliable. Since EndedPlayback() is used for a few important signals, we should ensure it's always right. As such, switch to using the explicit signal known by the WebMediaPlayer. This has been the source of a lot of flakiness over the years and we've been thinking about doing this since 2014. The only tricky part is in handling seeks to the end of file correctly; our pipeline previously required that play be called before we would trigger a real pipeline ended event. Instead we relied on HTMLME just declaring the playback ended at now >= dur. Now we will "render" end of stream even if playback hasn't started if we have nothing to play. Bug: 409280, 1035472 Test: Updated unittests, all existing tests pass. Change-Id: I1fbea34e8ac9e772d5b3573cd57df5d8c065e9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021292Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737397}
-
Sergey Silkin authored
- Don't require availability of SW H264 (webrtc_h264_sw_enabled) on android. Allow H264 processing with HW only. - Don't pass SW encoder factory to SEA if SW encoder of given type is not available. Bug: webrtc:11244, 1046501, 599650 Change-Id: I96991c9f40402d6dd723b10fd272b2dfe3120af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027848Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#737396}
-
Garrett Beaty authored
Also enable branch CQ/CI for Phase C builders. Bug: 1024643,1047744 Change-Id: If63fcdb223938b0c72b61502d0e61827dd1b70fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028258Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#737395}
-
Rob Schonberger authored
Update for further 6 months. Bug: 1036935 Change-Id: Ib9fcab37731ac55c69a71b8a941733a0b91cdf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029481 Auto-Submit: Rob Schonberger <robsc@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Xida Chen authored
TBR=odejesush@chromium.org NOTRY=true Bug: 1047760 Change-Id: Idcca8c22fcb2133b4553dbbbd9258fa8a3af0ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033433Reviewed-by:
-
Connie Wan authored
Minimum repro: 1) Open 1 tab. 2) Open 3 more tabs and add them to a group. 3) Navigate the 3 grouped tabs to: - https://www.google.com/gmail/about/# - https://www.google.com/gmail/about/# - https://www.google.com/imghp?hl=en&tab=ri&ogbl (Order doesn't matter. These links just came from the top right of the New Tab Page.) 4) Close all three grouped tabs at the same time, either via ctrl+W or right click + Close or other. Observe a crash. On local builds, there is an issue with either not finding a group or grabbing an index outside the view model. Root cause: - This only happens with URLs that qualify for RunUnloadListenerBeforeClosing: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=1665&rcl=2abf9b055a62f339f09785bb5f96187d9fcdb512 (in this case, the Images URL.) - This UngroupTab() call would happen between the first and second set of closed tabs: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=467&rcl=2abf9b055a62f339f09785bb5f96187d9fcdb512 - That would change the grouped state of the tab: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=1935&rcl=5aa34a3af25ca337f5d9604c24d63bc873572196 - Which would then confuse the TabStripLayoutHelper: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip_layout_helper.cc?l=477&rcl=9bce6a24f278f92b1a71b178b7e8acc6e8c02a9c - Which would grab and close the wrong slot, causing interference either with the group header closing or the next tab closing. Fix: - Prevent the tab itself from getting ungrouped during close (though the rest of the TabGroup bookkeeping still needs to happen behind the scenes). - Prevent a closing tab from querying group metadata, since the group may also be closing at the same time. Change-Id: I0cc69cb157ba5485c4d9c1a85ff0a393cdc6ce3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020908Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#737392}
-
Thomas Tellier authored
Also, getting rid of experimental accessibility features as this was the last one using it. Bug: 867474 Change-Id: Ibec61de069342dbc30e96a4a3c62c0f7332300ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783440 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737391}
-
Robert Ogden authored
Adds the integration to the last CL and a couple tests. Bug: 1023486 Change-Id: Ia0999fa09282df394944756e350f413867f45f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033426 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737390}
-
Nazerke authored
This CL removes public properties for BrowserState and dispatcher values and updates the coordinators implementation to get them from self.browser. The refactored coordinators: - Advanced Signin Settings Coordinator - Google Services Settings Coordinator - Signin Interaction Coordinator. Bug: 1029346 Change-Id: I9c7dda862e3d26898a84dd6c6d52f464d66441d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033256 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#737389}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5de415c5e3f9..c73475fb3c99 git log 5de415c5e3f9..c73475fb3c99 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 syoussefi@chromium.org Vulkan: Fix UtilsVk dirtying driver uniforms descriptor set binding Created with: gclient setdep -r src/third_party/angle@c73475fb3c99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I69f40ef43c62b45b5f5ddd671e155c8d41471723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033123Reviewed-by:
-
