- 01 Feb, 2019 24 commits
-
-
Jacob DeWitt authored
This is required due to WebXR breaking API changes made in M73. The associated test now checks that the WebXRDeviceM73 token works and that the WebXRDeviceM69 token no longer works. Bug: 925983 Change-Id: Ibca4bf9476a3f5958a34ed8a162a75748ce313a0 Reviewed-on: https://chromium-review.googlesource.com/c/1448976Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#628178}
-
Dale Curtis authored
Mostly just structural changes to return early instead of having a large set of nested conditionals. The only real change is when color accuracy is turned off, we won't blindly set SRGB mode anymore. This won't fix the default path, but may resolve issues where color accuracy has been turned off. BUG=854438, 902550, 825578, 851216 TEST=none R=liberato, sunnyps Change-Id: I5f5e12d1520e15e92167a1fc2e03f6606467c95d Reviewed-on: https://chromium-review.googlesource.com/c/1448741 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#628177}
-
Robbie McElrath authored
We're not supporting in-process network service on ChromeOS for now. Bug: 927435 Change-Id: I88f4e62ac1534c88cf77635fa6b8c4ac5464397e Reviewed-on: https://chromium-review.googlesource.com/c/1449109 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628176}
-
David Jacobo authored
Smart text selection already has a metric for usage, more specifically this is recorded everytime an apps request is done to the ARC container. Currently the feature can be accessed via touch gestures or the context menu. This CL adds tracking to the access via touch gesture, since context menu was already covered. Bug: None Test: Build. Change-Id: Id394796f140605041efa0a37e298fd0764571292 Reviewed-on: https://chromium-review.googlesource.com/c/1449002 Auto-Submit: David Jacobo <djacobo@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#628175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1345366c21ea..88bfed46ab6e git log 1345366c21ea..88bfed46ab6e --date=short --no-merges --format='%ad %ae %s' 2019-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 794364ebd51c..258398020826 (1 commits) 2019-01-31 egdaniel@google.com Fix type in Andoird string. 2019-01-31 reed@google.com fix tiler to handle large float rects Created with: gclient setdep -r src/third_party/skia@88bfed46ab6e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:927075 TBR=borenet@chromium.org Change-Id: I226b13831d3b8170118b9e102ff1701e612a1708 Reviewed-on: https://chromium-review.googlesource.com/c/1448117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628174}
-
danakj authored
Since the data comes from the |delegate_| of the RenderWidgetHostImpl, it does not depend on a |view_| being non-null. This reduces the number of early outs for the browser controls code. TBR=ajwong@chromium.org Change-Id: I17b4ac724708091a65cf8936ecb56ba5080da581 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1443530 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#628173}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2061050c4d27..b2818db71e6e git log 2061050c4d27..b2818db71e6e --date=short --no-merges --format='%ad %ae %s' 2019-01-31 chiniforooshan@chromium.org Telemetry: Use config to get UMA histograms Created with: gclient setdep -r src/third_party/catapult@b2818db71e6e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:927067 TBR=sullivan@chromium.org Change-Id: Ia50436c7d95a6f2eee7782aaffd5f580d75bf994 Reviewed-on: https://chromium-review.googlesource.com/c/1448710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628172}
-
liberato@chromium.org authored
We'll often want to add features to our LabelledExamples that are difficult or impossible to get at the site where we're building the example. For example, "number of concurrent media players" or "current in-use network bandwidth" might not be available from everywhere we might want it (e.g., "media/" or "renderer process"). Further, many features are generic; we don't want every LearningTask to have to invent them. We'd like to provide some basic features to any task that wants to include them. This CL introduces FeatureProvider, which lets us collect features where it's convenient (e.g., the browser), and append it before sending the examples to the learning algorithm. If the LearningTask has a feature description that matches a pre-defined feature, then it will be filled in before being included in the training data. LearningTaskControllerImpl optionally taks a FeatureProvider, which it applies to all examples as they're added. Since the learning code makes no threading assumptions (e.g., it can be run on a background thread), the FeatureProviders are all wrapped up as SequenceBound<>, so that they can hop to whatever thread the FeatureProvider needs, such as the main thread. Change-Id: If3948f139fe2ae977cd1d814b9248b455e7b6907 Reviewed-on: https://chromium-review.googlesource.com/c/1446540 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#628171}
-
Sandra Sun authored
Since the swipe navigation shouldn't occur without the renderer calling OnOverscrolled(), this patch renames rendererDisabledOverscroll_ to overscrollTriggeredByRenderer_ and set the value to false for each gesture sequence. So unless OnOverscrolled() is called with overscroll-behavior:auto, swipe-navigation should not happen. Prior to this change, a webpage whose root scroller has overscroll-behavior:auto, but has another inner scroller with overscroll-behavior:none, overscrolling the inner scroller does not scroll the outer scroller(because the scroll chain is cut), and does not trigger OnOverscrolled(), leaving |rendererDisabledOverscroll_| with its default value of false. However, the unhandled scroll delta would still be directed to the browser side and triggers the navigation. Bug: 906765. Change-Id: I163c67b0f6201754133012ec98cc74bab9e78f0d Reviewed-on: https://chromium-review.googlesource.com/c/1403921Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#628170}
-
bsheedy authored
Re-introduces the gtest-histogram conversion in process_perf_results.py, but restricts its usage to a whitelist. This is to help prevent the conversion from introducing widespread issues, instead isolating any potential issues to tests that are okay with being broken for a bit. Bug: 923564 Change-Id: Ic54312bfbe5f3dcde6f7d3cc915b18dfa00e2c5a Reviewed-on: https://chromium-review.googlesource.com/c/1449096 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#628169}
-
khachatryan authored
Due to dependences between the Window tests they are failing on Mac platform. Disabling those tests for Mac. Bug: chromedriver:2663 Change-Id: I5dddd1dc32e361f96b5de126abbb492f066e2bbf Reviewed-on: https://chromium-review.googlesource.com/c/1448688Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628168}
-
Dan Beam authored
R=dpapad@chromium.org BUG=925209 Change-Id: I9704386f3856f601aa0c0c781f27ce28fe8e6b37 Reviewed-on: https://chromium-review.googlesource.com/c/1445313 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#628167}
-
Alexei Filippov authored
This is a reland of ccd67a4b Original change's description: > [heap profiler] Introduce the in-process samples storage mode. > > In the new mode the client heap_profiling::SamplingProfilerWrapper > collects and stores all the live allocation samples without sending > them to the profiling service. > > Profiling service can request the current profile from the client using > the RetrieveHeapProfile method of the ProfilingClient interface. > > TBR=dtrainor@chromium.org > BUG=923459 > > Change-Id: I0a787f1b8850b3dc3d48d27cabf71ee2baf5bd82 > Reviewed-on: https://chromium-review.googlesource.com/c/1432376 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627138} TBR=erikchen@chromium.org,boliu@chromium.org,dtrainor@chromium.org,tsepez@chromium.org Bug: 923459 Change-Id: Ifc286d7010a2419521fa3bd1a9e9b473df0f3502 Reviewed-on: https://chromium-review.googlesource.com/c/1448973Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#628166}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/464111eaef80..846d12afedbf git log 464111eaef80..846d12afedbf --date=short --no-merges --format='%ad %ae %s' 2019-01-31 zoddicus@users.noreply.github.com Add whitelist for decorations in WebGPU (#2346) 2019-01-31 33432579+alan-baker@users.noreply.github.com Remove unused lambda capture (#2350) 2019-01-31 afdx@google.com Fixes #2338. Added functionality to remove OpPhi instructions (replacing their uses) when merging blocks (#2339) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for WorkgroupSize BuiltIn decoration (#2334) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for multiple BuiltIn decorations (#2333) 2019-01-30 zoddicus@users.noreply.github.com Add whitelist of allowed BuiltIn decorations for WebGPU (#2337) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU validation for LocalInvocationIndex BuiltIn decoration (#2335) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for FragDepth BuiltIn decoration (#2332) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for FragCoord BuiltIn decoration (#2331) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for FrontFacing BuiltIn decoration (#2330) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for InstanceIndex BuiltIn decoration (#2329) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for VertexIndex BuiltIn decoration (#2328) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@846d12afedbf The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6e318f5d574255576297a25bd2077dc44ea8e0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1449012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628165}
-
Fumitoshi Ukai authored
add category and short_name for builders in chromium.fyi.goma https://ci.chromium.org/p/chromium/g/chromium.fyi.goma/console and goma.latest https://ci.chromium.org/p/chromium/g/goma.latest/console Change-Id: I298a8038e416f8fca5ad5d3ad08cc02b1eab603b Reviewed-on: https://chromium-review.googlesource.com/c/1447355Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#628164}
-
Dan Beam authored
Update all the loading shims to account for this (and simplify code). Because prod code is bundled, we can just use --md-* vars from md_colors.css directly, rather than continue duplicating them (yay!). Drop toolbar bottom-border everywhere but in dev mode on extensions. In dev mode, extensions should have bottom-border below both toolbar and dev bar (and the loading shim should look accordingly as well). Additionally, fix some wrong icon colors inside toolbar (i.e. search, vertical more dots) and fix toolbar selection overlay bottom-border color. All of the changes in this CL are directly from Namrata. Screenshots (light & dark): https://imgur.com/a/yB0Xl19 R=dpapad@chromium.org BUG=883049,926937 Change-Id: I5b1ebc9d6130d2e899093602bf198cb407b46fdf Reviewed-on: https://chromium-review.googlesource.com/c/1445238 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628163}
-
John Abd-El-Malek authored
Once this is rolled internally, CastNetworkContexts::OnLocaleUpdate needs to be called from SaveLocaleAndNotify. The functionality from CastHttpUserAgentSettings would then be fully ported to work with the network service. Bug: b/123321526 Change-Id: Ibb1b725a496bbb0803fe04260edaf2f5d7476b76 Reviewed-on: https://chromium-review.googlesource.com/c/1448238Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628162}
-
Julian Pastarmov authored
It wasn't specific enough about not covering cert related interstitials. BUG=923867 TEST=none Change-Id: I7685706c666e6818e27f171e4ec9ac9f073c2a67 Reviewed-on: https://chromium-review.googlesource.com/c/1442792 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#628161}
-
Julie Jeongeun Kim authored
This CL removes dead files, merge_session_observer_bridge.mm/h. Bug: 926889 Change-Id: Ib66ed739e254bdac1be7b3019b270999c0e77fc4 Reviewed-on: https://chromium-review.googlesource.com/c/1447403Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#628160}
-
Wez authored
FDIO will implement BSD socket APIs using the new SocketProvider service rather than the old LegacySocketProvider, so add the new service to our sandbox policies. LegacySocketProvider will be removed after the Fuchsia SDK is rolled to pick up the new FDIO implementation. Bug: 927469 Change-Id: Ib662e052272a60dc1ee7d3d50553df89efa266df Reviewed-on: https://chromium-review.googlesource.com/c/1448985Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628159}
-
Brian Salomon authored
Bug: skia:8736 Change-Id: If4d8eb548b8b8ec55ea93f8db82a72b3330e71aa Reviewed-on: https://chromium-review.googlesource.com/c/1448749 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#628158}
-
Xiaocheng Hu authored
Explainer: http://bit.ly/2QVAwGq#heading=h.i9ha0k20utmo This patch: 1. Adds line information into NGCaretNavigator. Each line is represented as a [start_offset, end_offset) range on |text_|. Also marks the role of each character in the line using newly introduced |CharacterFlag|. 2. Make visual caret left and right movements aware of the lines, so that it correctly moves across line boundaries even when bidi is involved. Bug: 894651 Change-Id: Ic0354feb6abf5de859dacb785e48493d355e3bfc Reviewed-on: https://chromium-review.googlesource.com/c/1407182 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#628157}
-
Bence Béky authored
In qpack_encoder_stream_sender_fuzzer.cc, use NoopEncoderStreamSenderDelegate from qpack_encoder_test_utils.h instead of redefining it. Move MockEncoderStreamSenderDelegate from qpack_encoder_stream_sender_test.cc to qpack_encoder_test_utils.h so that it can be easily found and reused if needed in the future. This CL lands internal change 231643834 by bnc. Change-Id: I9d4b16cc045171554ab0a2165a3d1fa59f643f48 Reviewed-on: https://chromium-review.googlesource.com/c/1446472Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628156}
-
Thomas Guilbert authored
The flag was turned on via an experiment in M72, and turned on by default in M73. The old path is being removed in M74. Bug: 790766 Change-Id: I55ec170b0debc3e600c5974dfd824fcc6cfb3a4d Reviewed-on: https://chromium-review.googlesource.com/c/1447113 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#628155}
-
- 31 Jan, 2019 16 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04bdd8103515..232527952597 Created with: gclient setdep -r src-internal@232527952597 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:926053 TBR=mmoss@chromium.org Change-Id: I6548942ae12e0eef9661dfc604b6aeb114055150 Reviewed-on: https://chromium-review.googlesource.com/c/1448677Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628154}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a2e2d7f291cf..8926f0f331d8 git log a2e2d7f291cf..8926f0f331d8 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 tsepez@chromium.org Remove some cross-component include directives. Created with: gclient setdep -r src/third_party/pdfium@8926f0f331d8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifc796c98aee72465021db56197377fb1ab893965 Reviewed-on: https://chromium-review.googlesource.com/c/1448675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628153}
-
Kenneth Russell authored
The Vulkan driver isn't correctly installed yet. Bug: 927459 Tbr: cwallez@chromium.org No-Try: True Change-Id: I10d3f69ab527cda141b1f0d24ea3ed6ca8567619 Reviewed-on: https://chromium-review.googlesource.com/c/1448558 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#628152}
-
Mike Wasserman authored
TBR=lanwei@chromium.org Bug: 927454 Change-Id: I57c80d1124b6b3de96eb17626f4182c6776be749 Reviewed-on: https://chromium-review.googlesource.com/c/1448748Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#628151}
-
Dave Tapuska authored
Replace the identifier with the base value. sed -i "s/ThreadIdentifier/base::PlatformThreadId/g" ie: Change-Id: Ic3ae82468c6432c65c7f34b5788879d44bdf9b64 Reviewed-on: https://chromium-review.googlesource.com/c/1448705 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628150}
-
David Benjamin authored
Bug: 927022 Change-Id: I6f982752b35fbe3117e10128a5c8b50e02deb697 Reviewed-on: https://chromium-review.googlesource.com/c/1446815 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#628149}
-
Bo Liu authored
So don't use package, and just hard code the string. It's actually an activity-alias, I believe. TBR: tedchoc@chromium.org Change-Id: Ib75fc55fbcbf3ea3ba674c2ac7940bfeff21dcb4 Reviewed-on: https://chromium-review.googlesource.com/c/1449091Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#628148}
-
Nikita Podguzov authored
Bug: 814364 Change-Id: I3741e1fbe9193cb563ce2c9670219f9d651b9b52 Reviewed-on: https://chromium-review.googlesource.com/c/1406813Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#628147}
-
Henrique Ferreiro authored
This include is not used. Bug: 927247 Change-Id: I9cc12a5de471250d6bae6ecff3c85ecf72d50b2b Reviewed-on: https://chromium-review.googlesource.com/c/1447735Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#628146}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6e669b46b479..67957c299322 git log 6e669b46b479..67957c299322 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 smbarber@chromium.org usergroup_baseline: add cicerone-client group Created with: gclient setdep -r src/third_party/chromite@67957c299322 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id688703fdaa61a2634d4edd07824221ae64009fa Reviewed-on: https://chromium-review.googlesource.com/c/1449013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628145}
-
Gyuyoung Kim authored
signin_manager() has not been used by anywhere. So it's not necessary now. This CL removes the function and related to a member variable and header includes. Bug: 927252 Change-Id: Ib05e73367f72a0dc0b752f6402ac2a19e9dd0ffc Reviewed-on: https://chromium-review.googlesource.com/c/1447994Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#628144}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 186c9384. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 2376792a "Enable analyser tests to run with Chrome" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I804b84ade1c2de1f22d174c4141aa11cde46412b Reviewed-on: https://chromium-review.googlesource.com/c/1448792Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628143}
-
Henrique Ferreiro authored
This include is not used. Bug: 927250 Change-Id: I6aeb3993b7b2656bf7d136ce1706703e8627a49b Reviewed-on: https://chromium-review.googlesource.com/c/1448157Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#628142}
-
Moe Ahmadi authored
Adds unit tests for the TranslateInfobarMediator for: - whether it installs UI handlers on ChromeIOSTranslateClient as expected. - whether it returns the expected menu items for the translate infobar. Bug: 910994 Change-Id: I90b9aa4a466a659afea37f0ca3e5a3e4535df84d Reviewed-on: https://chromium-review.googlesource.com/c/1436943 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#628141}
-
Quan Nguyen authored
On repeat shows, the "remove user" confirmation message gets reset to hidden. If user menu goes out of bounds on the right, shift left. If it goes out of bounds on the bottom, shift right of the anchor and up. Bug: 917308 Change-Id: I2a8cefd7eb1fd68087408999822def1c80b51762 Reviewed-on: https://chromium-review.googlesource.com/c/1448080Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628140}
-
Jay Harris authored
- Updates Windows and Mac to run through the badge manager so that the last badge value is stored. - Threshes out the concept of a badge_manager_delegate, as it was too tightly coupled to Chrome OS to be used for Windows and Mac. - Checks the app is in scope before calling the badge manager, so as to not regress Windows/Mac. - Moves Windows and Mac specific badging code from badge_service_delegate_impl to specific badge_manager_delegates. Bug: 719176 Change-Id: I01289830d3d1f1d34fec846785f0fd60deed6e97 Reviewed-on: https://chromium-review.googlesource.com/c/1429324Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#628139}
-