- 16 Oct, 2014 40 commits
-
-
enne authored
In order to support GL_TEXTURE_RECTANGLE_ARB, cc::GLRenderer needs to know the size of the mask texture to unnormalize the texture coordinates. This has already been done for TileDrawQuad. As an optimization, rather than adding two more members onto the already bloated RenderPassDrawQuad, turn mask_uv_rect into mask_uv_scale. The position of the mask is now assumed to always be at the origin of the quad's transform, which it always is in cc. This is equivalent to saying that the mask is always attached to the owning layer of a render surface (since that's what defines the transform origin of the render surface). By making this assumption, the old mask_uv_rect can be calculated in a helper function from just quad->rect and quad->mask_uv_scale. With this patch, mask_texture_size is currently unused, but its values are unit tested. Depends on https://codereview.chromium.org/652393002/ R=danakj@chromium.org,jamesr@chromium.org BUG=423533 Review URL: https://codereview.chromium.org/659683002 Cr-Commit-Position: refs/heads/master@{#299932}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/7851a56..2f912f3 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=rmistry@google.com Review URL: https://codereview.chromium.org/640263003 Cr-Commit-Position: refs/heads/master@{#299931}
-
viettrungluu authored
R=sergeyu@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/660703003 Cr-Commit-Position: refs/heads/master@{#299930}
-
dcheng authored
BUG=423621 Review URL: https://codereview.chromium.org/657333002 Cr-Commit-Position: refs/heads/master@{#299929}
-
palmer authored
Other embedded content, such as plug-ins, is also prevented from incurring auto-log-in requests. BUG=334230 TEST=You still get the auto-log-in infobar when the requesting site is the top-level frame, but never otherwise. Review URL: https://codereview.chromium.org/131483010 Cr-Commit-Position: refs/heads/master@{#299928}
-
earthdok authored
This was blocked on http://crbug.com/423873 which is now fixed. BUG=414808 R=jam@chromium.org Review URL: https://codereview.chromium.org/645033003 Cr-Commit-Position: refs/heads/master@{#299927}
-
cjhopman authored
Adds these targets: //chrome/android:chrome_javatests //chrome/android:chrome_shell_test_java //chrome/android:chrome_shell_test_apk //chrome/android:chrome_sync_shell_test_apk //chrome/android:uiautomator_tests_java //chrome/android:uiautomator_tests //chrome/test/android:chrome_java_test_support //chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_apk //chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_resources depends on https://codereview.chromium.org/570203002/ TBR=ben BUG=359249 Review URL: https://codereview.chromium.org/586383002 Cr-Commit-Position: refs/heads/master@{#299926}
-
asvitkine authored
Changing previous experiment that made 50% of users on canary use stable configs to instead not create any experiments. Experimenting with this to see impact of experiments on stability. BUG=421481 Review URL: https://codereview.chromium.org/662663002 Cr-Commit-Position: refs/heads/master@{#299925}
-
rdevlin.cronin authored
It looks like there are a few edge cases when the BrowserActionView in BrowserActionsContainer::ToolbarExtensionUpdated() could be NULL. Check the view before using it. BUG=424050 Review URL: https://codereview.chromium.org/640373005 Cr-Commit-Position: refs/heads/master@{#299924}
-
wajahat.s authored
The Java class org.chromium.content.browser.WebContentsObserverAndroid is incorrectly named and should be WebContentsObserver to follow the same pattern as for other classes. The current WebContentsObserverAndroid is deprecated and it extends new class WebContentsObserver inorder to delegate all method calls. This is done for external repositories to adapt new class name to WebContentsObserver after this change. Once this is done WebContentsObserverAndroid will be removed in next patch. BUG=396118 Review URL: https://codereview.chromium.org/589113002 Cr-Commit-Position: refs/heads/master@{#299923}
-
nick authored
BUG=304341 TEST=browser_tests TBR=agl@chromium.org Review URL: https://codereview.chromium.org/639033004 Cr-Commit-Position: refs/heads/master@{#299922}
-
binji authored
The default umask() implemented by libnacl returns 0777, which if actually used, would create files with 0 mode. BUG=none R=sbc@chromium.org Review URL: https://codereview.chromium.org/643543004 Cr-Commit-Position: refs/heads/master@{#299921}
-
sky authored
Nukes LayoutItems and folds into Layout as that is the only place calling into it. Removes early out if parent() is NULL in Layout. No point in doing that. BUG=416641 TEST=none R=msw@chromium.org Review URL: https://codereview.chromium.org/656033007 Cr-Commit-Position: refs/heads/master@{#299920}
-
binji authored
It is legal to create a file with mode bits that conflict with the open flags, e.g.: open("foo", O_WRONLY | O_CREAT, 0444); BUG=none R=sbc@chromium.org Review URL: https://codereview.chromium.org/659513002 Cr-Commit-Position: refs/heads/master@{#299919}
-
dmurph authored
BUG=419287 Review URL: https://codereview.chromium.org/633273002 Cr-Commit-Position: refs/heads/master@{#299918}
-
tengs authored
All callers of OAuth2ApiCallFlow in the codebase do not use the refresh token flow, preferring to obtain the access token in other ways. The access token and URL request context are also refactored from the constructor to the Start(), so an OAuth2ApiCallFlow object can be passed around without first knowing the access_token needed to make the request. BUG=421982 TEST=updated existing tests Review URL: https://codereview.chromium.org/654123002 Cr-Commit-Position: refs/heads/master@{#299917}
-
mnaganov authored
Finally, we can revert the temporary hacks for using Blink UTF conversion routines, as we implemented a similar fast path in the routines from base::. I have double-checked that this doesn't regress performance on the benchmark that we were using. This reverts commit ed921a04. BUG=391492 Review URL: https://codereview.chromium.org/660843002 Cr-Commit-Position: refs/heads/master@{#299916}
-
aurimas authored
Fix indentation issues to allow enabling Checkstyle indentation rule. BUG=318404 Review URL: https://codereview.chromium.org/660603002 Cr-Commit-Position: refs/heads/master@{#299915}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/c8ee2ce..2606d14 TBR=cbiesinger@chromium.org,dstockwell@chromium.org Review URL: https://codereview.chromium.org/664473003 Cr-Commit-Position: refs/heads/master@{#299914}
-
tonyg authored
Revert of [Telemetry] Always use ephemeral port chosen by Chrome. (patchset #1 id:1 of https://codereview.chromium.org/650963003/) Reason for revert: Possibly caused flake. Will reland if mistaken. BUG=424245 Original issue's description: > [Telemetry] Always use ephemeral port chosen by Chrome. > > This reduces a potential source of flake for desktop Chrome. The > reference builds are now M37 (and I've verified they behave properly) > and stable is now M38. > > BUG=379980 > > Committed: https://crrev.com/f71a95de8adcd6cab36f87d669feda3fb1984896 > Cr-Commit-Position: refs/heads/master@{#299621} TBR=kbr@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG=379980 Review URL: https://codereview.chromium.org/659923003 Cr-Commit-Position: refs/heads/master@{#299913}
-
xhwang authored
BUG=422730 Review URL: https://codereview.chromium.org/651113002 Cr-Commit-Position: refs/heads/master@{#299912}
-
dcheng authored
BUG=423621 Review URL: https://codereview.chromium.org/657313002 Cr-Commit-Position: refs/heads/master@{#299911}
-
dcheng authored
BUG=none TBR=sky@chromium.org Review URL: https://codereview.chromium.org/659103002 Cr-Commit-Position: refs/heads/master@{#299910}
-
rnephew authored
BUG= Review URL: https://codereview.chromium.org/606853002 Cr-Commit-Position: refs/heads/master@{#299909}
-
aurimas authored
Fix indentation issue to allow enabling Checkstyle indentation rule. BUG=318404 Review URL: https://codereview.chromium.org/652173003 Cr-Commit-Position: refs/heads/master@{#299908}
-
gunsch authored
R=bulach@chromium.org BUG= Review URL: https://codereview.chromium.org/660683002 Cr-Commit-Position: refs/heads/master@{#299907}
-
lliabraa authored
BUG=418602 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/663553002 Cr-Commit-Position: refs/heads/master@{#299906}
-
mdempsky authored
This splits out the policy-to-BPF-program handling code from SandboxBPF into a new "PolicyCompiler" class. Additionally, it extracts an interface "TrapRegistry" to decouple PolicyCompiler from Trap (which should probably eventually be renamed something like SIGSYSTrapRegistry). Most significantly this CL means bpf_dsl no longer depends on SandboxBPF, which also now focuses primarily on the task of installing a compiled policy. BUG=414363 Review URL: https://codereview.chromium.org/660433002 Cr-Commit-Position: refs/heads/master@{#299905}
-
lliabraa authored
iOS does not have this requirement, but we've been installing the 10.6 SDK on the buildbot slaves to make the 'find_sdk.py --verify' call happy. However, iossim no longer builds with 10.6 so it's time to update the mac_sdk_min for iOS to 10.8 and remove the false requirement for official builds. BUG=418602 Review URL: https://codereview.chromium.org/660783004 Cr-Commit-Position: refs/heads/master@{#299904}
-
cmasone authored
Several configs in the Linux GN build are used in only one place. Defining these configs in build/config/linux/BUILD.gn makes them get resolved on all Linux-derived platforms, during both target builds and host-tool builds. This doesn't work on CrOS, which does not need or want the packages references by these configs. gconf is used in multiple places, so moving the config won't work. Instead, the gconf config is only resolved when building for a Linux target. BUG=None TEST=GN build for Linux and CrOS R=jamesr Review URL: https://codereview.chromium.org/655343002 Cr-Commit-Position: refs/heads/master@{#299903}
-
gayane authored
Histogram is in minutes. In case logs are uploaded by multiple tasks the interval between those is not recorded. BUG=421543 Review URL: https://codereview.chromium.org/633373011 Cr-Commit-Position: refs/heads/master@{#299902}
-
viettrungluu authored
R=sky@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/656213002 Cr-Commit-Position: refs/heads/master@{#299901}
-
bauerb authored
In order for the test to work, this CL also adds a success callback to SupervisedUserService::AddAccessRequest() and moves the logging of the success value to the client of AddAccessRequest, i.e. the SupervisedUserInterstitial. BUG=412314 Review URL: https://codereview.chromium.org/661763002 Cr-Commit-Position: refs/heads/master@{#299900}
-
qsr authored
Also fix parsing of validation files. TBR=ppi@chromium.org Review URL: https://codereview.chromium.org/640223003 Cr-Commit-Position: refs/heads/master@{#299899}
-
treib authored
Also, replace the deprecated CHROME namespace with PERMISSION_CHROME_URL (see https://cs.corp.google.com/#piper///depot/google3/google/kidsmanagement/v1/permissions_common.proto&l=30 ) BUG= Review URL: https://codereview.chromium.org/640223002 Cr-Commit-Position: refs/heads/master@{#299898}
-
dmichael authored
Its lifetime is scoped to the RenderFrame, and it might go away before the hosts that refer to it. BUG=423030 Review URL: https://codereview.chromium.org/653243003 Cr-Commit-Position: refs/heads/master@{#299897}
-
pfeldman authored
TBR=jochen BUG=423738 Review URL: https://codereview.chromium.org/656033005 Cr-Commit-Position: refs/heads/master@{#299896}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/30bc88c..7851a56 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=rmistry@google.com Review URL: https://codereview.chromium.org/656683006 Cr-Commit-Position: refs/heads/master@{#299895}
-
dtseng authored
BUG=417106 TEST=none Review URL: https://codereview.chromium.org/647343004 Cr-Commit-Position: refs/heads/master@{#299894}
-
rch authored
BUG= Review URL: https://codereview.chromium.org/638373004 Cr-Commit-Position: refs/heads/master@{#299893}
-