- 22 Jul, 2014 40 commits
-
-
tdanderson@chromium.org authored
Add the new unit test WidgetTest.GestureEventDispatch to verify that non-scroll gesture events are dispatched to the correct views in a view hierarchy and that the default gesture handler in RootView is set correctly. This replaces the test ViewTest.GestureEvent. BUG=395397 TEST=WidgetTest.GestureEventDispatch Review URL: https://codereview.chromium.org/406943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284751 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
This is failing 75% of the time. This directory is created by copying files from other parts of the tree, and some of those have suppressions. So don't duplicate those suppressions. Also, this code isn't shipped. BUG=382995 R=thestig@chromium.org Review URL: https://codereview.chromium.org/409913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284750 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@chromium.org authored
TBR=zhaoqin@chromium.org BUG=396172 NOTRY=true Review URL: https://codereview.chromium.org/412623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284746 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284745 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
This is a followup to https://codereview.chromium.org/353493002/ BUG=390520 Review URL: https://codereview.chromium.org/405433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284744 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
Sometimes fullscreen wasn't required in order to lock. In such case, fullscreen being left should have no consequence. BUG=162827 Review URL: https://codereview.chromium.org/409143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284743 0039d316-1c4b-4281-b951-d872f2087c98
-
naiem.shaik@gmail.com authored
Translate is turned into a component, classes and functions have to be moved to the translate:: namespace. BUG=331782 TEST=components_unittests:unit_tests --gtest_filter=Translate* TBR=thakis Review URL: https://codereview.chromium.org/378253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284742 0039d316-1c4b-4281-b951-d872f2087c98
-
limasdf@gmail.com authored
BUG=354046 Review URL: https://codereview.chromium.org/403843005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284741 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284740 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
I'm seeing asserts coming from PacedSender. The assert is not correct and should be removed. NOTRY=true TBR=miu BUG=none Review URL: https://codereview.chromium.org/409943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284739 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178551:178666&mode=html TBR=johnme@chromium.org,pkasting@chromium.org BUG= Review URL: https://codereview.chromium.org/407143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284738 0039d316-1c4b-4281-b951-d872f2087c98
-
jvoung@chromium.org authored
The nexe isn't actually needed, so it could link against a dummy PNaCl shim. However, something weird is going on and it attempted to link against the real shim. See notes in reverted NaCl roll: https://codereview.chromium.org/409733002/ Leaving out some of the PNaCl targets which actually do manage to turn off pexe -> nexe translation. Since this is selectively done, beware of flipping 'build_pnacl_newlib': 0 to 1. BUG=none Review URL: https://codereview.chromium.org/409753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284737 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: https://codereview.chromium.org/401923004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284736 0039d316-1c4b-4281-b951-d872f2087c98
-
wajahat.s@samsung.com authored
FileOutStream should be closed in finally block in writeKeyToFile() method, as closing in try{} will not close and release system resources when an exeption is thrown. Also, catch relavant exception instead of catching generic exception. BUG=None. Review URL: https://codereview.chromium.org/405403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284735 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
BUG=349211 TEST=Existing tests pass. Review URL: https://codereview.chromium.org/407583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284734 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284733 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
This pulls in the following CLs: r1354: Use hash_set and hash_map instead of std::tr1::unordered_set and std::unordered_set. r1355: Enable crash reporting to work correctly when the library is inside another file (an archive). r1356: Annotate PageAllocator for MSan. BUG=394028,390618 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/411523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284732 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284731 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
For now, these warnings are just noise (and lots of it). BUG=393235 R=aurimas@chromium.org Review URL: https://codereview.chromium.org/397843006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284730 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
This is a reland of r284079 which was reverted in r284248 for components build issues. That, in turn, was a reland of r283813 which was reverted in r283845 because it broke WebRTC tests on Android. That, in turn, was a reland of r283542 which was reverted in r283591 because it broke the WebView build. This is a much larger change than its diff suggests. If it breaks something, please revert first and ask questions later. BUG=393317 R=agl@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/401153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284729 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
There are typically only a few events in a given gesture packet. Avoid heap allocating in the common case by switching from a raw vector to a StackVector. BUG=395168 Review URL: https://codereview.chromium.org/403173004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284728 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=338338 TEST=None R=jamesr@chromium.org Review URL: https://codereview.chromium.org/401923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284727 0039d316-1c4b-4281-b951-d872f2087c98
-
ygorshenin@chromium.org authored
BUG=377725 TEST=unit_tests:NetworkPortalDetectorImplTest.* Review URL: https://codereview.chromium.org/385553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284726 0039d316-1c4b-4281-b951-d872f2087c98
-
limasdf@gmail.com authored
BUG=354458 Review URL: https://codereview.chromium.org/262223003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284725 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
BUG=225777,179716 TEST=unit tests pass Review URL: https://codereview.chromium.org/394923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284724 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
GuestViews are registered and re-registered on a per-profile basis. This would cause a DCHECK to fire. Make registration lazy and once on first GuestView creation. BUG=none TBR=fsamuel@chromium.org Review URL: https://codereview.chromium.org/409133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284723 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=393266 Review URL: https://codereview.chromium.org/382403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284722 0039d316-1c4b-4281-b951-d872f2087c98
-
johnme@chromium.org authored
Revert of Refactoring : Move AuthAttempt and Authenticators to chromeos/login (https://codereview.chromium.org/391373002/) Reason for revert: I'm afraid the BrowserThread layering violations in this patch actually cause compile failures on: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/372 http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/364 Original issue's description: > Refactoring : Move AuthAttempt and Authenticators to chromeos/login > Extracted LoginEventRecorder from BootTimesLoader to loose dependecies. > > BUG=387613 > R=nkostylev@chromium.org > TBR=bauerb@chromium.org > TBR=stevenjb@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284682 TBR=bauerb@chromium.org,nkostylev@chromium.org,stevenjb@chromium.org,antrim@chromium.org NOTREECHECKS=true NOTRY=true BUG=387613 Review URL: https://codereview.chromium.org/413473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284720 0039d316-1c4b-4281-b951-d872f2087c98
-
mrunal.kapade@intel.com authored
This change also removes redundant header includes for tts_message_filter.h and tts_controller.h. This is part of an effort to move TTS to content. BUG=347045 Review URL: https://codereview.chromium.org/408123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284718 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
BUG=392280 NOTRY=true Review URL: https://codereview.chromium.org/402213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284714 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
This version of the RTL should handle SEH and C++ exceptions better BUG=345874,394325 NOTRY=true TBR=rnk@chromium.org Review URL: https://codereview.chromium.org/411583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284713 0039d316-1c4b-4281-b951-d872f2087c98
-
mkosiba@chromium.org authored
This makes it possible to send IPC messages in such a way that they're delivered together with the SwapCompositorFrame corresponding to the next commit. BUG=364612 Review URL: https://codereview.chromium.org/240163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284712 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
We "dropped" the prefix well over a year ago and would like to deprecate/remove from Blink when we can. webkitIndexedDB -> indexedDB webkitIDBFooBar -> IDBFooBar Also, correct uses of the long removed errorCode and webkitErrorMessage properties on IDBRequest (now just error.name and error.message). Review URL: https://codereview.chromium.org/401893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284711 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
* Merging DriSurfaceAdaptor into DriSurface * Merging GbmSurfaceAdaptor into GbmSurface * Extracting GbmSurfaceless implementation into separate class & having GbmSurface extend it * Remove ScanoutSurface Depends on https://codereview.chromium.org/393233005 BUG=none NOTRY=true Review URL: https://codereview.chromium.org/403043004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284710 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Calling delete[] on void* is undefined behavior. Cast to the right type before calling delete[]. Fixes a clang warning. BUG=82385 TBR=siggi Review URL: https://codereview.chromium.org/401423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284709 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
This change allows scanout buffers to be kept alive until the last of SurfaceOzone{Canvas,EGL} and HardwareDisplayController are destroyed. For HardwareDisplayController this means that buffers will be kept around until the CRTC is properly restored. For SurfaceOzoneEGL this means that on monitor disconnects (HDC is destroyed) the buffers are kept alive for any remaining EGL operations still happening. BUG=none NOTRY=true Review URL: https://codereview.chromium.org/393233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284708 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284707 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
This change fixes the following problem: 1. Run browser with remote debugging enabled (--remote-debugging-port=9222) 2. Open remote debugging front-end in the same browser (localhost:9222) 3. Inspect that front-end using built-in DevTools. 4. Go to Timeline and press Ctrl+R Result: Timeline recording starts automatically and never stops after reload. With this patch: It will stop recoding after reload. BUG=None Review URL: https://codereview.chromium.org/409073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284706 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Pull grit 171 to get the new deps fixes required to implement this. This removes the call to grit for querying inputs completely, and enables depfile writing to enable automatic rebuilds when things are out-of-date. Adds a new outputs variable that bypasses querying grit for outputs. This will assert that the given files exist in grit. This version allows outputs to be empty in which case it will revert to the old dynamic behavior. I'm going to land this with just the worst cases fixed to make landing easier. Then followup with converting the rest of the grit targets and removing the dynamic option. R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/407653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284705 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
be safe to land. Mainly adding FailureValue but not wiring it via PageTestResults/GTestTestResults/PageRunner yet. The remaining change will be landed separately to better isolate the problem that caused it to be reverted. BUG=392901 Review URL: https://codereview.chromium.org/405283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284704 0039d316-1c4b-4281-b951-d872f2087c98
-