- 14 Jul, 2017 40 commits
-
-
Tatsuhisa Yamaguchi authored
This change will only add these items: - Cut, Copy - zip selection "Available offline" is not refreshed in some cases. "Get info" and "Rename" is not added by this change. Those should be fixed by another change. TEST=manually tested by check-select files and opening the menu Bug: 740842 Change-Id: Ic074b3b38eddf5c1bd9d8ae162e5c0d24bb17c8e Reviewed-on: https://chromium-review.googlesource.com/566768Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486715}
-
yhanada authored
This implements the wayland extended_keyboard interface for ack_key events. The client will use this interface to send whether received key events are handled or not. This CL doesn't have to be submitted together with Android side CL. Android container can run without the Android side CL. Bug: b/28104183, b/36384707 Test: Android container runs and we can start apps. Change-Id: I8191e29ca0538b29305dcc6b707bf1b10b32d30b Reviewed-on: https://chromium-review.googlesource.com/558335 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486714}
-
Daniel Vogelheim authored
R=mkwst@chromium.org Bug: 708041 Change-Id: Ib049e39a0d8bd33b7625273614e5ad28dbb26937 Reviewed-on: https://chromium-review.googlesource.com/565403Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#486713}
-
oka@chromium.org authored
In the following scenario, time between (1) to (4) was exported. We should export the time for (4). (1) ShowKeyboard is called (2) Before animation finishes, HideKeyboard is called (3) time passes. (4) ShowKeyboard is called and keyboard is actually shown. Bug: 742721 Change-Id: I1fc3a92cea7bfce25e8efb407a3e41508a367c36 Reviewed-on: https://chromium-review.googlesource.com/571108Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#486712}
-
Christian Dullweber authored
Content Settings don't need to be filterable and using WebsiteSettingsFilterAdapter doesn't work in some cases. Bug: 741934 Change-Id: I765cd9683079fa7592afc3aedc0ea0f243d782ed Reviewed-on: https://chromium-review.googlesource.com/570241Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#486711}
-
Alexander Alekseev authored
This Cl removes references to iron-flex-layout in OOBE/Login UI. Bug: 719331 Change-Id: Iedde72b6e5db6c44820394cf44f4d876d43ff07e Reviewed-on: https://chromium-review.googlesource.com/566538 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#486710}
-
jdoerrie authored
This change introduces |FindKey|, |FindKeyOfType|, |SetKey|, |DictEnd| and |DictItems| to base::Value. These methods are part of the new API proposal and abstract away the pointer based underlying storage of Dictionary Values. Bug: 646113 Change-Id: I09150f3b2fd47e24074caa50a30a058fc4f558a7 Reviewed-on: https://chromium-review.googlesource.com/561682 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486709}
-
Jianzhou Feng authored
Bug: Change-Id: I2ec08840ce270562842b21a2da8ace173fdf1069 Reviewed-on: https://chromium-review.googlesource.com/571253Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Jianzhou Feng <jzfeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486708}
-
Jia authored
All these shorthand properties call the same helper function ConsumeShorthandVia2LonghandAPIs. Hence these properties are grouped in one cl. Bug: 668012 Change-Id: I308be0165a6e7962874053e6cbefd831cac6f410 Diff: https://gist.github.com/06821a4b93df191366b1b8a2ac9d01ad/revisions Reviewed-on: https://chromium-review.googlesource.com/571338 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#486707}
-
Daniel Bratell authored
Best to not try to add a string to a set without converting the set to a string first. R=dpranke@chromium.org Bug: 713137 Change-Id: Id4c632b1f944fcafdd046983b1ddd4678c44928f Reviewed-on: https://chromium-review.googlesource.com/564939Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: bratell at Opera <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#486706}
-
Yoshifumi Inoue authored
This patch changes "undo-{combined-,forward-,}delete.html" to use |assert_selection()| and integrate into "undo-delete.html" since these test are similar for improving readability. Note: This patch similar to the patch[1] which convert "undo-delete-boundary.html". [1] http://crrev.com/c/567615 Convert editing/undo/undo-{combined-,forward-,}delete-boundary.html to use assert_selection() Bug: 230267, 679977 Change-Id: I7e21fae9a023cc70577d373161ac0e8e7beafc66 Reviewed-on: https://chromium-review.googlesource.com/571205Reviewed-by:Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486705}
-
Ramin Halavati authored
Annotation and call deserialization and duplicate code checking added to network traffic annotation auditor's unittest. Bug: 656607 Bug: 690323 Change-Id: I4397359da0c170f9fe9a1dda0bcc57ef723ed863 Reviewed-on: https://chromium-review.googlesource.com/568034 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Dominic Battre authored
Bug: 732846 Change-Id: I56baa3c06e6eb77da4d47432c48fb7751f9d6394 Reviewed-on: https://chromium-review.googlesource.com/570160Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#486703}
-
Shuhei Takahashi authored
BUG=chromium:742722 TEST=trybot Change-Id: I9c232f829bd5e290edd2fbe2e1296e65153f1fae Reviewed-on: https://chromium-review.googlesource.com/571107Reviewed-by:
-
Tsuyoshi Horo authored
I'm planing to add MixedContentChecking related settings to WorkerSettings for off-main-thread-fetch. But WorkerSettings is not set correctly in ServiceWorkerGlobalScope. So this CL just adds SetWorkerSettings() in ServiceWorkerGlobalScope::Create(). BUG=607575, 443374 Change-Id: I0e32bb84ce316b7125bfe11facfe5182095ae63f Reviewed-on: https://chromium-review.googlesource.com/571207Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486701}
-
Takashi SAKAMOTO authored
DiscardVirtualMemory makes the contents of discarded memory undefined. c.f. https://msdn.microsoft.com/ja-jp/library/windows/desktop/dn781432(v=vs.85).aspx BUG= Change-Id: Ifd06e6f75271dc6a38cf0a34027cb20f1a887cfe Reviewed-on: https://chromium-review.googlesource.com/571621 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#486700}
-
Dominic Battre authored
This CL introduces measuring the events that save/update bubbles are triggered and reasons why save/update bubbles are dismissed. NOTRY=true Bug: 732846 Change-Id: I885985e0ffcd610af8c2f0a1d55824d63330b43f Reviewed-on: https://chromium-review.googlesource.com/565286 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Takeshi Yoshino authored
Bug: Change-Id: Ifc41fef8f84a0703da21af3afeffed9e1c9d81e9 Reviewed-on: https://chromium-review.googlesource.com/571204Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486698}
-
Han Leon authored
This CL is to fix the root cause for failures of service worker wpt tests. The test loads an url for an Image object with 'anonymous' crossOrigin property at line227 of fetch-canvas-tainting-iframe.html, succeeds in loading without tainting, and then it loads the url again for another Image object with 'use-credentials' crossOrigin property at line234, this is expected to result in loading error, but currently it results in success. The root cause is that Memory Cache is reusing the first time's response for the second time resource request, although these two requests have different credentials mode. BUG=735883 TEST=blink_tests external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html external/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html Change-Id: I9acdcf3811b6dcd5ea2ffe858ec35f51f7f2cc3f Reviewed-on: https://chromium-review.googlesource.com/567690Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#486697}
-
Bugs Nash authored
This patch - Added CSSPropertyAPIBorderColor - Implemented parseSingleValue method on CSSPropertyAPIBorderColor and CSSPropertyAPIBorderWidth, moving parsing logic from CSSPropertyParser legacy switch - Added details of API implementations to CSSProperties.json5 so that generated files will be updated Bug: 668012 Change-Id: I05487329dab8542022d2750ddb1d81a4dbc65a1f Reviewed-on: https://chromium-review.googlesource.com/566346Reviewed-by:
-
yoichio authored
Since integers returned by SelectionStartEnd() don't relate each other if start LayoutObject != end LayoutObject. To emphasize that for readability, we should split it. Bug: 739062 Change-Id: I9609262fe2aeb63a49fa95a4d17de66c167d92f8 Reviewed-on: https://chromium-review.googlesource.com/566268 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486695}
-
Yoshifumi Inoue authored
2017-07-14T11:14:28 2017-07-14T11: 14:22 Bug: Change-Id: I39e2a7d0906be5f8883d7467d2414babf6a84362 Reviewed-on: https://chromium-review.googlesource.com/571559Reviewed-by:
-
Hayato Ito authored
This is one of the efforts to organize core/dom files. See https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit?usp=sharing for details. The name of core/typed_arrays honers the existing name of platform/wtf/typed_arrays. We might want to remove DOM prefix from files in another CL. Bug: 738794 Change-Id: Id5b637701fb003a4ce1531d3c5a9534d6708ca1e Reviewed-on: https://chromium-review.googlesource.com/566756 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
Test: interactive_ui_tests OobeTest.NewUser Bug: 742695 Change-Id: I1779bc181f4c393ec74e523e346da601d1da6eef Reviewed-on: https://chromium-review.googlesource.com/571525Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#486692}
-
Jay Civelli authored
Now that ChildProcessLauncher has been moved to base, changed the MultiprocessTestClient to use it instead of duplicating the functionality. Bug: 702316 Change-Id: I3828f7cf16d815b45c7aca9925ef4b69866e66f4 Reviewed-on: https://chromium-review.googlesource.com/562519 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#486691}
-
Yutaka Hirano authored
It was needed because we couldn't use net errors in blink. We can use them now. Bug: 702845 Change-Id: I76ce587a437e6c64810de0b0b8d6894951162037 Reviewed-on: https://chromium-review.googlesource.com/571562Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486690}
-
Ryo Hashimoto authored
HomedirMethods::MountEx was converting MountParameters to MountRequest proto. To simplify this, remove MountParameters and use MountRequest everywhere. - Construct MountRequest directly in MountEx's caller sites. - Rename FillKeyProtobuf() in homedir_methods.cc to KeyDefinitionToKey(), and make it public. BUG=741274 Change-Id: Ibb8dd4a7975f6aff87ada881938be29300e7344c Reviewed-on: https://chromium-review.googlesource.com/567844Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#486689}
-
mfomitchev authored
This CL takes advantage of the mechanisms introduced in https://codereview.chromium.org/2979933002/ to run the UI Service inside the browser process in Mushrome (i.e. when chrome is launched with --mus parameter). UI Service runs on a separate thread with high priority. For now both the UI Service and the GPU Service are moved. Once WS/GPU split if finished, GPU will need to be moved into its separate process. CrOS BrowserProcessPlatformPart owns the ImageCursorsSet used by the UI Service for cursor manipulation. BUG=722527 Review-Url: https://codereview.chromium.org/2983443002 Cr-Commit-Position: refs/heads/master@{#486688}
-
Mitsuru Oshima authored
New animation first makes copies of screen, and chagnes the rotation after these copies are made. If a device enters tablet mode while coyping it may remember the wrong rotation. BUG=742605 TEST=covered by unit tests. Also tested manually: 1) Start portrait only ARC++ app 2) Try to close and open the lid multiple times Change-Id: I835b3409f34f101dac45784eda501635f7fe085e Reviewed-on: https://chromium-review.googlesource.com/571258 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#486687}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8efa3b7d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/312 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I9bbffc01856dfa827d0230c2a5637d3e1bb1e660 Reviewed-on: https://chromium-review.googlesource.com/571480 Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486686}
-
Tetsui Ohkubo authored
Use the title text instead of multi line message for "CAPS LOCK is ON" notification. Primarily fix for MD style notification but also works properly in the current style. BUG=740813 TEST=manual Change-Id: I9121ae49fcf77fa4e7092d4a6a354b1d1a21d04e Reviewed-on: https://chromium-review.googlesource.com/569329 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Terry Anderson <tdanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486685}
-
meade authored
Spec: https://drafts.css-houdini.org/css-typed-om/#csstranslation Additionally found during testing: - Z should not be able to be set to null - Use new CSS.px(1) syntax for inlinestyle/translation test for brevity BUG=545318 Review-Url: https://codereview.chromium.org/2961243002 Cr-Commit-Position: refs/heads/master@{#486684}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ee3e0bacc8be..83d118550f72 $ git log ee3e0bacc..83d118550 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 ethannicholas converted CircleEffect to SkSL 2017-07-13 fmalita Delete unread SkPicture mbox 2017-07-13 bsalomon Move GrAALinearizingConvexPathRenderer off GrLegacyMeshDrawOp 2017-07-13 egdaniel Add support for creating a GrContext backed by Metal. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I1c4299ac66aa68f14c8c48a83bd2aa85c2d82f0e Reviewed-on: https://chromium-review.googlesource.com/570994Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486683}
-
Sandra Sun authored
When performing a scrollIntoView, if some scrolling boxes in the chain has the smooth behavior while the others don't, the sequenced smooth scrolls shouldn't be aborted. This patch fixes the bug by setting the ScrollType to kSequencedSmoothScroll once we noticed a smooth scroll in the scroll chain, so that ScrollableArea::SetScrollOffset() will not abort the sequenced smooth scrolls. This patch also moves the first call of RunQueuedAnimations() to LayoutObject::ScrollRectToVisible() to make sure that all sequenced smooth scrolls get a chance to run. Bug: 735863 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8d72bcc873efcf82883ab7272328c3759789e7a3 Reviewed-on: https://chromium-review.googlesource.com/550237Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#486682}
-
Piotr Swigon authored
This should be a no-op functionality wise. This patch introduces CustomTabsUiType as a better way to specify the look&feel of the UI. In this and following patches I will aim to minimize number of intent EXTRAs and replace multiple booleans indicating visibility of various UI elements with a single value specifying a UI type. This patch takes care of only few low hanging fruits to make it easy to review. I plan to make a few more code structure and readability improvements on top of this later on. This refactoring is considered a prerequisite to introducing Minimal-UI PWA display mode, which is yet another UI type for Custom Tab. Bug: 604390 Change-Id: Ifa75e341dd1f7ac64cfa70c4dbb507b3df9c7f6c Reviewed-on: https://chromium-review.googlesource.com/567789 Commit-Queue: Piotr Swigon <piotrs@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486681}
-
Siddhartha authored
Discussion at crrev.com/10983063. The comments at crrev.com/10983063#msg16 says that the only issue with supporting PurgeMemory for session storage is it would set is_initial_import_done_ to false and this could potentially cause an import if GetItem is called. So, the fix should just be not setting import_done_ to false if map is empty. For the case when a SetItem is called before Purge, PurgeMemory would be noop since it has uncommitted changes. BUG=696112 Change-Id: I1a57c49dea41e030f5770b9d74742984b920f1d1 Reviewed-on: https://chromium-review.googlesource.com/560722 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#486680}
-
Alan Cutter authored
TBR: thakis@chromium.org Bug: 742670 Change-Id: I3e6bfb0d990f36c5643f3f766d63a0dae0c243c3 Reviewed-on: https://chromium-review.googlesource.com/571538Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#486679}
-
tsergeant authored
BUG=727174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2962283002 Cr-Commit-Position: refs/heads/master@{#486678}
-
Miguel Casas-Sanchez authored
This CL moves the three standard functionality LayoutTests for mediacapture-fromelement to the external/wpt folder, adapting them accordingly and adding the necessary webmfiles. Also removes the HTMLMediaElementCapture-*.html expectations. Bug: 619625 Change-Id: If06df91ae918b5f0d3eacc597c88709a83227a82 Reviewed-on: https://chromium-review.googlesource.com/566151 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#486677}
-
Hidehiko Abe authored
This is preparation to remove MockCryptohomeClient, as preparation to replace Callback by OnceCallback in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: I4b6f21228e402973a18e07aa5d80a134b2018f58 Reviewed-on: https://chromium-review.googlesource.com/569798Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
