GitLab

Patterns have a transformation matrix, which controls how the pattern is used when it is painted. 

Initially, a pattern's transformation matrix must be the identity transform. 

When the setTransform() method is invoked on the pattern, the user agent must replace the pattern's
transformation matrix with the one described by the SVGMatrix object provided as an argument to the method.

Specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvaspattern-settransform
IDL Definition: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#2dcontext:dom-canvaspattern-settransform
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dUt2_2xn3NU

BUG=289572
R=junov@chromium.org

Review URL: https://codereview.chromium.org/527193002

git-svn-id: svn://svn.chromium.org/blink/trunk@181737 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec now allows currentTime to be set when the readyState is still HAVE_NOTHING.
This patch modifies the behaviour in accordance to the spec. The default playback
start position is set to the new currentTime and the resource plays from that point
once it is loaded.
http://www.whatwg.org/specs/web-apps/current-work/#dom-media-currenttime

BUG=399314

Review URL: https://codereview.chromium.org/517593003

git-svn-id: svn://svn.chromium.org/blink/trunk@181736 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows developers to pass any combination of plugin flags
without modifying the existing GYP setup. For example,
GYP_DEFINES+="blink_gc_plugin_flags='dump-graph=1 warn-raw-ptr=1'"
will enable both graph dumps and raw-pointer warnings.

R=haraken@chromium.org
BUG=334149

Review URL: https://codereview.chromium.org/551343003

git-svn-id: svn://svn.chromium.org/blink/trunk@181734 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a filter primitive has an 'in' (or, where applicable, 'in2') attribute
that references a non-existent result, treat that reference as having the
default value (==no value) instead of producing an error.
This aligns with Presto and IE.

BUG=411833

Review URL: https://codereview.chromium.org/558693002

git-svn-id: svn://svn.chromium.org/blink/trunk@181733 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec: https://svgwg.org/svg2-draft/painting.html#OrientAttribute

BUG=367748

Review URL: https://codereview.chromium.org/539833004

git-svn-id: svn://svn.chromium.org/blink/trunk@181732 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove some CSS properties from UseCounters (patchset #1 id:1 of https://codereview.chromium.org/558473002/)

Reason for revert:
We don't want to remove properties that we still support.

Original issue's description:
> Remove some CSS properties from UseCounters
> 
> All of these measure stable features except CSSPropertyWebkitCursorVisibility which
> is actually removed.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181680

TBR=rob.buis@samsung.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/559073002

git-svn-id: svn://svn.chromium.org/blink/trunk@181731 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL caused memory leaks in content_unittests.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7259

> Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor
> to oilpan's heap
> 
> - MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor must be moved
> to oilpan's heap in one go because their lifetime are tightly coupled.
> 
> - Removed m_descriptor->setClient(0) from MediaStream's destructor. This is OK
> because MediaStreamDescriptor has a strong Member back to the Client
> (i.e., MediaStream).
> 
> - Removed m_component->source()->removeObserver(this) from MediaStreamTrack's
> destructor. This is OK because this CL made the observers weak
> (i.e., MediaStreamSource::m_observers is a hash set of weak members to
> MediaStreamTrack objects).
> 
> - Removed WebMediaStreamTrack::ExtraData::m_owner because it's unused.
> 
> - Introduced MediaStreamComponentDisposer to delay the destruction of
> MediaStreamComponent::m_extraData. The ExtraData is exposed to the web
> and some Chromium objects inherit from the ExtraData. If we clear the
> m_extraData in the MediaStreamComponent's destructor, those Chromium-side
> objects are also destructed in the MediaStreamComponent's destructor.
> This is problematic because the destructors of the Chromium-side classes
> can touch other on-heap objects in the Blink side. To avoid the issue,
> we need to delay the destruction of the ExtraData to thread-specific
> weak processing. The disposer pattern actually makes the deletion of
> the extra data happen earlier and not later. The disposer makes sure
> that the extra data is destructed in weak processing which is run before
> sweeping and therefore all the objects are still alive and can be touched.
> 
> 
> - The same problem arises for MediaStreamDescriptor and MediaStreamSource.
> This CL adds MediaStreamDescriptorDisposer and MediaStreamSourceDisposer.
> 
> - This CL depends on https://codereview.chromium.org/543603003/ and https://codereview.chromium.org/549153002.
> 
> BUG=340522
> 
> Review URL: https://codereview.chromium.org/552653005

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/562663002

git-svn-id: svn://svn.chromium.org/blink/trunk@181730 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Enumerations are essentially the same as Strings, but those values
are restricted to specific values. When a value is invalid, we should
throw an exception as the spec requires[1].

[1] http://heycam.github.io/webidl/#es-enumeration

BUG=321462

Review URL: https://codereview.chromium.org/561633003

git-svn-id: svn://svn.chromium.org/blink/trunk@181729 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This affects the 'crossOrigin' IDL attributes in the interfaces
HTMLImageElement, HTMLLinkElement, HTMLMediaElement and HTMLScriptElement,
and is done to match the corresponding specification change:
  http://html5.org/r/8727

The effect is that on setting the IDL attribute to null, the content
attribute is removed (if present) instead of set to the string "null", and
on getting null is returned instead of the empty string if the content
attribute is not present.

BUG=409524

Review URL: https://codereview.chromium.org/529933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181728 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves the single call to ContentSecurityPolicy::completeURL
up from CSPDirectiveList to ContentSecurityPolicy. We now resolve the
URL when sending reports rather than resolving them during parsing. This
allows us to parse a policy without already being bound to an execution
context.

BUG=411889

Review URL: https://codereview.chromium.org/561693002

git-svn-id: svn://svn.chromium.org/blink/trunk@181727 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current behavior, pseudo classes inside :not() work when they used in the <content select=””> context,  however, it does not satisfy the matching criteria.
This patch reject them.


BUG=389003

Review URL: https://codereview.chromium.org/547363002

git-svn-id: svn://svn.chromium.org/blink/trunk@181726 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=366145

Review URL: https://codereview.chromium.org/557283002

git-svn-id: svn://svn.chromium.org/blink/trunk@181725 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For CSS Animations the name is prefilled with the animation-name. For
Transitions the name is the transitioning property.

BUG=351446

Review URL: https://codereview.chromium.org/535843002

git-svn-id: svn://svn.chromium.org/blink/trunk@181724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org, mkwst@chromium.org, oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/561703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderGrid has several methods that take pointers to RenderBox
instances but the body of those methods assumes that the objects
will never be NULL. We should replace them by references.

Review URL: https://codereview.chromium.org/554293003

git-svn-id: svn://svn.chromium.org/blink/trunk@181722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FYI: screenshot is available here: https://code.google.com/p/chromium/issues/detail?id=391593#c30

BUG=391593

Review URL: https://codereview.chromium.org/532223002

git-svn-id: svn://svn.chromium.org/blink/trunk@181721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated main.py to support core/modules results.
Moved all current test results into Source/bindings/tests/results/core.
Added TestInterface5.idl to tests/idls/modules and V8TestInterface5.{h,cpp} to tests/results/modules.

BUG=358074

Review URL: https://codereview.chromium.org/557203002

git-svn-id: svn://svn.chromium.org/blink/trunk@181720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup to CL 486193002 to remove default arguments from template types,
which is only allowed in c++11 and later (and we haven't officially switched
to c++11 yet afaik).

Review URL: https://codereview.chromium.org/559733004

git-svn-id: svn://svn.chromium.org/blink/trunk@181719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a garbage collected class is polymorphic (has virtual methods) it
needs to have a vtable from its left-most base class. Otherwise
pointers to the polymorphic subclasses are not guaranteed to point
to the beginning of the object.

This should have been caught by the gc plugin. We will investigate
that separately.

R=oilpan-reviews@chromium.org, sigbjornf@chromium.org, yhirano@chromium.org, zerny@chromium.org
BUG=411742

Review URL: https://codereview.chromium.org/562573002

git-svn-id: svn://svn.chromium.org/blink/trunk@181718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As all objects deriving from DOMWindowProperty are on the heap, make
it a GC mixin and have it trace its Window reference. The registered
DOMWindowProperty instances on a LocalDOMWindow live at least as long
it.

The benefit is that we can remove its destructor. Deriving objects can
as a consequence remove their empty finalizers.

R=ager@chromium.org, haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/552733003

git-svn-id: svn://svn.chromium.org/blink/trunk@181717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=396372,410229

Review URL: https://codereview.chromium.org/555063002

git-svn-id: svn://svn.chromium.org/blink/trunk@181716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch does two things:

* The single parse-time UseCounter is now out of the parsing flow, and
  in the side-effects method.

* Parse-time ConsoleMessages generated in ContentSecurityPolicy and
  CSPDirectiveList are now stored on ContentSecurityPolicy and spun out
  to the console in the side-effects method.

BUG=411889

Review URL: https://codereview.chromium.org/554303002

git-svn-id: svn://svn.chromium.org/blink/trunk@181715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove all the embedded resources from blink and migrate to using grd generated
pak files.

BUG=312586

R=haraken@chromium.org, jochen@chromium.org

Part 2: https://codereview.chromium.org/561653002
Part 3: https://codereview.chromium.org/560763002

Review URL: https://codereview.chromium.org/558933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181703

BUG=410706
TBR=h.joshi@samsung.com

Review URL: https://codereview.chromium.org/559923002

git-svn-id: svn://svn.chromium.org/blink/trunk@181713 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Point w3c/web-platform-tests/custom-elements/ failures to
appropriate bug.

Review URL: https://codereview.chromium.org/547383002

git-svn-id: svn://svn.chromium.org/blink/trunk@181712 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Method DatabaseContext::contextDestroyed always calls from ExecutionContext destructor. In the case when the context is WorkerGlobalScope - from WorkerGlobalScope destructor. This unregister call does nothing in this situation.
And it looks dangerous when we try to use the methods of the object in destructor. E.g. if we make the method ExecutionContext::isWorkerGlobalScope virtual the program will crash in DatabaseContext::contextDestroyed.

R=tkent@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/551373003

git-svn-id: svn://svn.chromium.org/blink/trunk@181711 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up of Blink r181385.

BUG=402536

Review URL: https://codereview.chromium.org/553353002

git-svn-id: svn://svn.chromium.org/blink/trunk@181710 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In those the conversion functions that take an ExceptionState& argument,
always throw via the ExceptionState object, and never directly to V8.
Various existing callers assume this, and fail to detect exceptions that
were thrown directly to V8.

This misbehavior is a regression from
  https://codereview.chromium.org/313033002/
which changed the definition of the TONATIVE_DEFAULT_EXCEPTIONSTATE()
macro, but these functions were somewhat tricky to use even before then,
since exceptions were sometimes thrown to V8 and sometimes not, while
always stored in the ExceptionState object.

Review URL: https://codereview.chromium.org/559553003

git-svn-id: svn://svn.chromium.org/blink/trunk@181709 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a node to reveal exists in the current profile show it right there
rather than switching to another profile.

Review URL: https://codereview.chromium.org/553063002

git-svn-id: svn://svn.chromium.org/blink/trunk@181708 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reenable data URL layout tests which were temporarily skipped until Chromium side change gets landed

- Enables the temporarily skipped tests
- Change the blob test case to expect failure. This is because it turned
  out that we cannot use the optimization for data URL loading when XHR
  is set to load data as Blob.
- Delete the unnecessary expectation file

Depends on
- https://codereview.chromium.org/480413007/
- https://codereview.chromium.org/294193002/

BUG=308768

Review URL: https://codereview.chromium.org/492183002

git-svn-id: svn://svn.chromium.org/blink/trunk@181707 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Linux sometimes means android too.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/556143002

git-svn-id: svn://svn.chromium.org/blink/trunk@181706 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec[1] says the EventSource constructor should take EventSourceInit
dictionary as an argument. This CL doesn't change behavior. Tests under
http/tests/eventsource cover this change.

[1] http://www.w3.org/TR/eventsource/#eventsource

BUG=403150

Review URL: https://codereview.chromium.org/561533002

git-svn-id: svn://svn.chromium.org/blink/trunk@181705 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=396372

Review URL: https://codereview.chromium.org/556453004

git-svn-id: svn://svn.chromium.org/blink/trunk@181704 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allowing drawText to return width of what was drawn, 
so that we don't have to make call to width to 
re-measure in Canvas drawing.

R=eae@chromium.org
BUG=410706
TEST=TEST=fast/canvas/canvas-drawtext-width-return.html

Review URL: https://codereview.chromium.org/519373002

git-svn-id: svn://svn.chromium.org/blink/trunk@181703 bbb929c8-8fbe-4397-9dbb-9b2b20218538

to oilpan's heap

- MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor must be moved
to oilpan's heap in one go because their lifetime are tightly coupled.

- Removed m_descriptor->setClient(0) from MediaStream's destructor. This is OK
because MediaStreamDescriptor has a strong Member back to the Client
(i.e., MediaStream).

- Removed m_component->source()->removeObserver(this) from MediaStreamTrack's
destructor. This is OK because this CL made the observers weak
(i.e., MediaStreamSource::m_observers is a hash set of weak members to
MediaStreamTrack objects).

- Removed WebMediaStreamTrack::ExtraData::m_owner because it's unused.

- Introduced MediaStreamComponentDisposer to delay the destruction of
MediaStreamComponent::m_extraData. The ExtraData is exposed to the web
and some Chromium objects inherit from the ExtraData. If we clear the
m_extraData in the MediaStreamComponent's destructor, those Chromium-side
objects are also destructed in the MediaStreamComponent's destructor.
This is problematic because the destructors of the Chromium-side classes
can touch other on-heap objects in the Blink side. To avoid the issue,
we need to delay the destruction of the ExtraData to thread-specific
weak processing. The disposer pattern actually makes the deletion of
the extra data happen earlier and not later. The disposer makes sure
that the extra data is destructed in weak processing which is run before
sweeping and therefore all the objects are still alive and can be touched.


- The same problem arises for MediaStreamDescriptor and MediaStreamSource.
This CL adds MediaStreamDescriptorDisposer and MediaStreamSourceDisposer.

- This CL depends on https://codereview.chromium.org/543603003/ and https://codereview.chromium.org/549153002.

BUG=340522

Review URL: https://codereview.chromium.org/552653005

git-svn-id: svn://svn.chromium.org/blink/trunk@181702 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In getPositionAndOffset, previous block was used when space is entered for dir=auto. While for dir=auto text using previous block gives wrong caret position, which was leading to caret offset not calculated.  In case of RTL, previous inline box position is used.

Since auto scenario, combines RTL and LTR text. In renderText, only render block direction is used. New condition has been added in RenderText to test if dir=auto, then use inlineBlock bidiLevel to decide about caret position rendering.

R=leviw, eae
BUG=296847
TEST=Direction auto tests covering move caret position to the right when
LTR text is entered and adding RTL text to move caret to the left.

Review URL: https://codereview.chromium.org/541823003

git-svn-id: svn://svn.chromium.org/blink/trunk@181701 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add another category of failure cards that display bots that have
been running or offline over a threshold of time. This is special-
cased for chromium.webkit & blink to start.

Also removing ct-revision-details since it's effectively obsoleted
by this change.

BUG=399957
NOTRY=true

Review URL: https://codereview.chromium.org/555263004

git-svn-id: svn://svn.chromium.org/blink/trunk@181700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't compute all the keys for a loop that we almost
always early out from. Also, the early out was wrong because
it was just returning from the anonymous function.

NOTRY=true

Review URL: https://codereview.chromium.org/557173002

git-svn-id: svn://svn.chromium.org/blink/trunk@181699 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=396366

Review URL: https://codereview.chromium.org/562493002

git-svn-id: svn://svn.chromium.org/blink/trunk@181698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removing showValidationMessage, as code on the chromium side has landed.

R=tkent@chromium.org
BUG=91638

Review URL: https://codereview.chromium.org/557753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181697 bbb929c8-8fbe-4397-9dbb-9b2b20218538