- 13 Jul, 2020 40 commits
-
-
Numfor Mbiziwo-Tiapo authored
This adds a simple putAll implementation that loops put. A basic web platform test is added as well. Change-Id: I8fcc25ffacb64d15855da921eb14f3770df28694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274217 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#787815}
-
Christopher Cameron authored
The GrContext used by SharedImageBackingFactory can be GL, Vulkan, Metal, or Dawn. SharedImageBackingFactory had started storing this as is_vulkan, is_metal, is_dawn, instead of a single switch. Update this to be a single switch. R=kylechar TBR=geofflang Bug: 894929 Change-Id: I44c6273ce0818244586b87c53f4f15da83e11239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292999 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#787814}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Idbc37012f45394eac1189024b9480dba88b1fa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293278Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#787813}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ie741f01d887c262139c0f4f951bc4c683444f415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292706Reviewed-by:
-
Anders Hartvoll Ruud authored
There was a bug in this test, but the fixed test has now been imported, so we can safely remove expectations. Bug: 1093622 Change-Id: Ice3da9052d863b320aeb0cd81602a8186860e02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292217Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#787811}
-
Guillaume Jenkins authored
Moves the core ProfileReportGenerator class from chrome/browser to components so it can be reused by iOS. The desktop implementation of the delegate is staying in chrome/browser. For easier reviewing, the core class still takes the concrete delegate as constructor argument, but in the following CL, this will be changed to use the reporting delegate factory. Bug: 1091936 Change-Id: I8f8ece003f24ba7c660f597562ae4448e737cc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288812Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#787810}
-
Liquan (Max) Gu authored
Context: PaymentRequestDelegateImpl is an internal class of PaymentRequestFactory. It was made non-static just to reuse PaymentRequestFactory#getWebContents. Since static internal class is generally a more preferable code practice than non-static internal class, we should refactor to make it static. Before: PaymentRequestDelegateImpl is not static. After: PaymentRequestDelegateImpl is static. Change-Id: Ic5a8b45cb66c0c729751b1b0222c5ba77133b1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295220Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#787809}
-
Marijn Kruisselbrink authored
Following changes in https://crrev.com/c/2290535 from isFile/isDirectory to kind, and following changes in http://crrev.com/c/2285670 from getFile/getDirectory to getFileHandle/getDirectoryHandle. Bug: 1103841, 1103022 Fixed: b/160828615 Change-Id: I9ca756c54a072e2049d1b176805138ccde8c17b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293177 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#787808}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Id440f7d672e39ab52511edd128f8cdc2662f4a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293004Reviewed-by:
-
Abhishek Kumar authored
Add connection failure metrics into histogram. This will be published for interface specific network connection failures. BUG=chromium:1085300 Cq-Depend: chromium:2277056 Change-Id: Ied6b33cb7420ea2574422d4f958d4adc585ab52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288764 Commit-Queue: Abhishek Kumar <kuabhs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787806}
-
Lei Zhang authored
Change-Id: Icd8f0a84e6ae6fa9c68c4d34b91ad44fc5fff6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285749Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#787805}
-
Koji Ishii authored
Supports range-based for loop to get |NGPhysicalBoxFragment|. Bug: 829028 Change-Id: I8473172ea723c725f63637307e189ae8abc52f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291293 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787804}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85f14941793d..5f4c6e5b4c89 2020-07-13 patrick.brosset@microsoft.com Grid: Make line number labels consistently sized 2020-07-13 tvanderlippe@chromium.org Add @types/codemirror 2020-07-13 tvanderlippe@chromium.org Reset OWNERS of BUILD.gn to INFRA_OWNERS 2020-07-13 tvanderlippe@chromium.org Move devtools_module_entrypoints to separate gni file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1097043,chromium:1098730 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3afc6f3357254d273bc9e1b87969848162011c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295138Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787803}
-
Koji Ishii authored
Dumps only when a new flag |DumpItems| is specified, not to break existing unit tests. For now, |NGFragmentItem|s are dumped in the same format as layout tree dump for now. We can make this more similar to |AppendFragmentToString|. Bug: 982194 Change-Id: I6d12de2d9784ffdffef7e7d6450d229f84ca5f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294740Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Idcc55d4edf716f685baa570a28f8fdc202f2e414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293003Reviewed-by:
-
Xing Liu authored
The scheduled download currently will be started when we restart the browser. The download schedule struct is not written to the db. Bug: 1104673,1078454 Change-Id: I1f39f4517250e0aa2dcce4696feab90a94cb8851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294340Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787800}
-
Nico Weber authored
Since cflags currently ends up empty except for the mllvm flag in compiler_codegen on Windows, just don't copy cflags to asmflags on Windows for now. This should go away in a week or two anyways. Bug: 1104915 Change-Id: I7538e1297df69f0a066f84756ededbae5fd615ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295323 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787799}
-
Peter Kasting authored
Rename only; no functional change. Bug: none Change-Id: I71b3c7fd651d716d0df3ccc90b9f065799cf9053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290872 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#787798}
-
Leonid Baraz authored
It was observed on Fievel device. When ActivityStorage::LocalTimeToUtcDayStart is called with parameter being base::Time::Max(), it returns timestamp like 1939-01-12 08:00:00.000 UTC, and all activity intervals referring to year 2020 are filtered out. It looks like in certain SDK timestamp.LocalMidnight() does not work correctly, when timestamp.is_max(). As a workaround, the code will no longer call it for Max timestamp. This can never happen to actual intervals, only to a report threshold. Bug: 1104428 Change-Id: I1704e6fe43f7c42517653c007f293aa7c3b0eb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293264Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787797}
-
Samuel Huang authored
Running SuperSize-archive on TrichromeGoogle.ssargs fails because the largest .so file cames from Google3, but its data (.map and unstripped .so file) are unavailable. This CL implements a workaround: Change Trichrome's generated .ssargs files to specify --no-native for Trichrome Chrome to disable native code processing. Bug: 1103271, 1040645 Change-Id: I1af591738ef6b1e8375c21b3272017a5da1fd6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293167Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#787796}
-
Evan Stade authored
This reverts commit f4332f96. Reason for revert: broke dialogs during tab reparenting, see crbug.com/1103617 Original change's description: > Speculative fix for app modal dialog crash > > Cancel JS dialogs when a WebContents's delegate is set to null, as the > dialog can't show without a WebContentsDelegate. > > Bug: 1060986 > Change-Id: I5272faa23d5461fc8251887d9bc02f03c54e37e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283388 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785954} TBR=avi@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1060986 Change-Id: Icab13a52cde868b8a9339d1bb1e585a1ab9aa24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293477Reviewed-by:
-
Robert Liao authored
This also unbans gmock. gmock has been used with success in //base as well as many other components. Additionally, there is investigation to creating a set of mocks in Views for help testability. BUG=134675 Change-Id: Ic54d0855b3a958eed02bf0aafe9a4613e8c6be13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293009 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: I53c8756ba52e99123741859b457aca20e33ace6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293316Reviewed-by:
-
Zhi An Ng authored
map returns an iterator in Python 3, causing the comparison to fail, use list comprehension instead. Bug: chromium:1068191 Change-Id: I95014b4568faeb6e0901f0ae695504f51258016a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293619 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#787792}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ Bug: 1097092 Change-Id: I086ceb10e88a657c91d8d4938e49ee85f7d66f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295082Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#787791}
-
Yann Dago authored
Bug: 1095208 Change-Id: Iaac0f618d574ba505b9dc9b048ca5e0749925edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283412Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
Saurabh Nijhara authored
As per the UI mocks of update required screen, the title of the admin message container is to be shown in bold. This is applicable only to ChromeOS. Bug: 1048607 Change-Id: I9d25024ca12aee5b54232c31dc7a4d52f3488573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292521Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#787789}
-
Eric Roman authored
This seems to be required when using the clangd completer in newer YouCompleteMe versions. Change-Id: I6659f5f4b74c56ccedca1ca336f19fb2373e68b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293182Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787788}
-
John Lee authored
https://i.imgur.com/wcaYtf9.png Fixed: 1102273 Change-Id: I774d8022f13ef3f8d7ce978c742585312f6c5188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290190 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#787787}
-
Philip Rogers authored
This patch includes updated baselines (in platform/mac), as well as overriding baselines for 10.13 and below (in platform/mac-mac10.13). These baselines were mistakenly not included in the original patch (crrev.com/785697) which caused a rollout (crrev.com/785857). Bug: 1079418 Change-Id: I50f227a4b2f1c8ec043e8ca6f1c4f127317123d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285341Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#787786}
-
Juliet Levesque authored
Remove the text color change and font size increase for NS_LOG(ERROR) and NS_LOG(WARNING) for a more consistent look on the logging tab of chrome://nearby-internals. See the following screenshot for display: https://screenshot.googleplex.com/zFd8PRJzUsO. Bug: 1093634 Change-Id: I5ea64a7461661a01a2f5f0e63c01229c3d1c31a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286729Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#787785}
-
Joshua Berenhaus authored
Bug: 1088051 Change-Id: Ib400d10aa0c7e92d1bd0fa8a7071ed89a7306a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293262 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#787784}
-
Jeffrey Kardatzke authored
This links up using the Chrome OS CDM daemon behind the flag cdm-factory-daemon. The implementation is hosted in the GPU process, and the browser process controls which CDM implementation is used. This also updates PlatformVerification to enable checking if Verified Access is enabled or not without actually going through the verification flow. BUG=b:153111783 TEST=Chrome OS CDM is used when flag is enabled, uses library CDM if daemon isn't running or Verified Access is disabled Change-Id: Ic06c9f26b70b718a0102eeadd2d00bb7ed4984d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284042Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#787783}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f012836. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I33e41339923bbed9f2fb288faf4d0dd883a551b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295259Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787782}
-
Fabio Tirelo authored
This reverts commit 008ff342. Reason for revert: Broke Mac10.15 Tests Example build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2345 Original change's description: > [Prerender] Move tests around fragments. > > Move the tests that verify NoStatePrefetch behavior around fragments > from PrerenderBrowsertests to NoStatePrefetchBrowserTests. > > Please see this spreadsheet for details: > > https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing > > Bug: 898955 > Change-Id: I39942e88cab7be78aa1aef09d7fafab8cabaaab7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279999 > Commit-Queue: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787715} TBR=ryansturm@chromium.org,nator@chromium.org Change-Id: I6e8938d480e132b8c3e4723437fc943076697c58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294572Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#787781}
-
Shimi Zhang authored
- Make all the member variables to be private. - Rename all the member variables to have a trailing '_' - Make necessary changes to the callsites where uses these variables directly. Test: No logic change, should be covered by the current tests. Bug: 1103886 Change-Id: I05bd46765899f464352264e74e70168d3cd25915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294339Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#787780}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594640123-15dad8eca9e1c0a172946dc66975935b724f3416.profdata to chrome-win32-master-1594648594-97cb9ce3cb39a74bf15fa7f9f08c38efdf753597.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2976d1e5c6f7d71b82075a94d908f20cb721ade7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295130Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 85-4181.3-1594028802-benchmark-85.0.4183.18-r1 to 85-4181.3-1594028802-benchmark-85.0.4183.22-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9dcb68260fc4e2b2c2c32c74b0915cd9fd631865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295420Reviewed-by:
-
Peter Kotwicz authored
This CL changes the PathUtils#getDownloadsDirectory() strict mode comment to be less urgent given that fixing this is a low priority BUG=508615 Change-Id: Ib0a7abf4f4d3a4ac6bb03889381c6ea879102473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288190Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787777}
-
Andrew Grieve authored
It's really unusual to have a template that does not result in a target with name=target_name. In this case android_test_apk() was appending "__apk" for no apparent reason. Change-Id: I0867622ff27962aebc1c64c12a57c8ab0925d6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293216 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
