- 29 Nov, 2016 40 commits
-
-
fs authored
This makes 'transform', 'gradientTransform' and 'patternTransform' presentation attributes on SVGGraphicsElements, SVGGradientElements and SVGPatternElements respectively. Spec: http://www.w3.org/TR/css3-transforms/#svg-transform http://www.w3.org/TR/css3-transforms/#svg-syntax http://www.w3.org/TR/css3-transforms/#svg-gradient-transform-pattern-transform Salvaged from https://codereview.chromium.org/423093014, but takes a different approach to bridge the syntax gap and avoid crbug.com/577219. The strategy taken here is to use the SVGTransformList to generate a CSSValue for the presentation attribute style, and hence postponing both support for the full transform syntax and a way around the bug mentioned above. Essentially softening the blow. These two "features" are expected to be implemented eventually, so this is just a "first step". BUG=369942 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2478233002 Cr-Commit-Position: refs/heads/master@{#434934}
-
gsennton authored
Make minidump uploading test utility more useful/accessible to WebView to allow for testing the WebView-implementation of minidump uploading. BUG=665448 Review-Url: https://codereview.chromium.org/2532133002 Cr-Commit-Position: refs/heads/master@{#434933}
-
skyostil authored
Review-Url: https://codereview.chromium.org/2539443002 Cr-Commit-Position: refs/heads/master@{#434932}
-
sigbjornf authored
Follow up on r420711 (crbug.com/589632) and adjust the expected lower bound on ".elapsedTime" to also include zero for 'start' events. TBR=dmazzoni BUG=660448 Review-Url: https://codereview.chromium.org/2540623002 Cr-Commit-Position: refs/heads/master@{#434931}
-
dominicc authored
ReplaceSelectionCommand::doApply repeatedly rewrites the DOM to fix up the content it is inserting. One of those modifications--removing redundant inline styles--may end up deleting the very span it is tracking the insertion of. This moves the node of interest into the InsertedNodes collection. As the inserted nodes collection is modified, it adjusts the node of interest to a surviving node. BUG=668808 Review-Url: https://codereview.chromium.org/2533703002 Cr-Commit-Position: refs/heads/master@{#434930}
-
spqchan authored
- Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG=666990, 666977 Review-Url: https://codereview.chromium.org/2520003007 Cr-Commit-Position: refs/heads/master@{#434929}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#434928} -
mkwst authored
The ASAN bots say this causes a crash; I can't replicate it locally, but I believe that the combination of `document.write` and synchronous `javascript:` URL navigation could cause the auditor to trigger while the document is detaching. This patch adds a small check. BUG=668772 Review-Url: https://codereview.chromium.org/2531253002 Cr-Commit-Position: refs/heads/master@{#434927}
-
aleksandar.stojiljkovic authored
This resolves performance issue when uploading video to e.g. FLOAT or UNSIGNED_SHORT textures. If canUseCopyTextureCHROMIUM returns false, we shouldn't create AcceleratedImageBufferSurface, call paintCurrentFrame and texImage2DBase since they would not be used. This is because imageBuffer-> copyToPlatformTexture is not supported when canUseCopyTextureCHROMIUM is false and it would early return false. BUG=624436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2527343002 Cr-Commit-Position: refs/heads/master@{#434926}
-
yamaguchi authored
BUG=545399 TEST=manual test by the repro steps in the bug CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2535713003 Cr-Commit-Position: refs/heads/master@{#434925}
-
lushnikov authored
This patch migrates all of the smallIcons usages in consoleView.css onto UI.Icon. BUG=669323 R=dgozman Review-Url: https://codereview.chromium.org/2538673002 Cr-Commit-Position: refs/heads/master@{#434924}
-
meade authored
Review-Url: https://codereview.chromium.org/2528263004 Cr-Commit-Position: refs/heads/master@{#434923}
-
wfh authored
https://helpx.adobe.com/security/products/flash-player/apsb16-37.html BUG=412078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=jschuh@chromium.org Review-Url: https://codereview.chromium.org/2534103002 Cr-Commit-Position: refs/heads/master@{#434922}
-
dbeam authored
R=jyquinn@chromium.org BUG= Review-Url: https://codereview.chromium.org/2494853003 Cr-Commit-Position: refs/heads/master@{#434921}
-
dbeam authored
R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2528523002 Cr-Commit-Position: refs/heads/master@{#434920}
-
vitaliii authored
Previously we had a provider, which was not connected to any data source. This CL connects it to PhysicalWebDataSource,rewrites the existing test and adds a new one. BUG=635893 Review-Url: https://codereview.chromium.org/2517113005 Cr-Commit-Position: refs/heads/master@{#434919}
-
satorux authored
To avoid data copies in many places. BUG=593251 TEST=user image and wallpaper stuff works as before Review-Url: https://codereview.chromium.org/2517053004 Cr-Commit-Position: refs/heads/master@{#434918}
-
lanwei authored
In the previous patch https://codereview.chromium.org/2233543002/, we missed to check if the touch events which we will make uncancelable when there is an active fling are on the same layer as the current active scroll layer or its descendants. Now, we add the scroll layer check here to minimize the breaking cases and also match with other browsers' behavior, such as Safaris and Firefox. This code has two parts: 1. Delete the is_fling flag we used on https://codereview.chromium.org/1923973002/ to indicate if the actice fling is happening. 2. Add check to the touch start if it hits on the same layer as the current active scroll layer. BUG=595327 Review-Url: https://codereview.chromium.org/2471523002 Cr-Commit-Position: refs/heads/master@{#434917}
-
gurrrik authored
`ProfileManager::GetLastUsedProfile` creates a profile if it does not exist. `HttpsEngagementMetricsProvider::ProvideGeneralMetrics` can be called in `PostMainMessageLoopRun`, and it will try to create a profile, which is not what you'd want during shutdown. BUG= Review-Url: https://codereview.chromium.org/2531023002 Cr-Commit-Position: refs/heads/master@{#434916}
-
gozzard authored
print_preview_ui.cc previously specified different specified a system print dialog shortcut message of "(Ctrl+Shift+P)" for Windows and ChromeOS, and "(Shift+Ctrl+P)" for everything else except Mac OSX. These have been unified such that everything besides Mac OSX uses "(Ctrl+Shift+P)". Review-Url: https://codereview.chromium.org/2534733002 Cr-Commit-Position: refs/heads/master@{#434915}
-
satorux authored
The comment is irrelevant as this function does nothing to do with Bytes. ResizeCustomizedDefaultWallpaper() used to take UserImage::Bytes but that parameter was removed in crrev.com/385364 BUG=593251 Review-Url: https://codereview.chromium.org/2517413002 Cr-Commit-Position: refs/heads/master@{#434914}
-
dgozman authored
Extracted the meaningful part of the test which checks multiple scripts in the same html file. BUG=none Review-Url: https://codereview.chromium.org/2537023002 Cr-Commit-Position: refs/heads/master@{#434913}
-
vitaliii authored
As it was suggested in codereview.chromium.org/2517113005, this CL adds FakePhysicalWebDataSource. In addition to this, it adds helper functions for creating physical web pages for tests. BUG=None Review-Url: https://codereview.chromium.org/2529303002 Cr-Commit-Position: refs/heads/master@{#434912}
-
tapted authored
Currently GetAllChildWidgets only works for Widgets, but the API doesn't require that. Passing a non-Widget allows the Widgets parented off a Cocoa browser window to be easily obtained. This will help with testing of browser dialogs. BUG=654151 Review-Url: https://codereview.chromium.org/2535163002 Cr-Commit-Position: refs/heads/master@{#434911}
-
wuchengli authored
Allocating input buffers can be very slow. Doing it in GPU child thread can cause gpu process watchdog timeout. Move it to decoder thread. BUG=chrome-os-partner:56452 TEST=Run VDA unittest and play video. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2530493003 Cr-Commit-Position: refs/heads/master@{#434910}
-
ccameron authored
This feature has been split off from --enable-color-correct-rendering enable-color-correct-rendering is a tweaking of the existing color awareness to be more consistent and robust, and will only be noticeable on non-sRGB monitor. enable-true-color-rendering does all blending and interpolation operations in a physically correct linear space, and has perceptually noticeable differences on all monitors. TBR=achuith,avi,pdr BUG=667433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2530503003 Cr-Commit-Position: refs/heads/master@{#434909}
-
fdoray authored
Singletons are allowed by default on joinable threads. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2536823002 Cr-Commit-Position: refs/heads/master@{#434908}
-
wangxianzhu authored
Previously calculateBoundaries() were used for two different purposes: - For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(), y(), width(), height()) which is a result of layout. - For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout to calculate the boundaries based on the positions of text fragments. Remove InlineBox::calculateBoundaries() because we don't need it in this abstraction level. Rename InlineTextBox::calculateBoundaries() to frameRect(). Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual. BUG=666416 Review-Url: https://codereview.chromium.org/2518363003 Cr-Commit-Position: refs/heads/master@{#434907}
-
ericwilligers authored
BUG=668914 Review-Url: https://codereview.chromium.org/2529253002 Cr-Commit-Position: refs/heads/master@{#434906}
-
tsergeant authored
This fixes an issue where after touchscreen tapping the search icon, the browser would return focus to the search icon, immediately closing the search field. Using the native 'click' event instead of the simulated 'tap' event fixes this issue. BUG=624356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2530293002 Cr-Commit-Position: refs/heads/master@{#434905}
-
riajiang authored
BUG=664212 TEST=covered by tests Review-Url: https://codereview.chromium.org/2524873002 Cr-Commit-Position: refs/heads/master@{#434904}
-
ericwilligers authored
BUG=668914,667644 Review-Url: https://codereview.chromium.org/2528263002 Cr-Commit-Position: refs/heads/master@{#434903}
-
dcheng authored
BUG=none Review-Url: https://codereview.chromium.org/2531113002 Cr-Commit-Position: refs/heads/master@{#434902}
-
allada authored
This patch moves the flattenNodeList() and renames it flattenChildren() to be more appropriate. It is also moves it to the nodes instead of the DataGrid. R=dgozman BUG=None Review-Url: https://codereview.chromium.org/2540543002 Cr-Commit-Position: refs/heads/master@{#434901}
-
wangxianzhu authored
After the renaming, we'll have the following terms: - physicalLocation: physical location of a box or an inline in the containing block. (0,0) is the top-left corner of the containing block. Renamed LayoutBox::topLeftLocation() and InlineBox::locationIncludingFlipping() to physicalLocation(). - location: location in "physical coordinates with flipped blocks direction". (0,0) is the top-left corner of the containing block for writing-mode in normal blocks direction (horizontal-tb and vertical-lr), and is the top-right corner of the containing block for writing-mode in flipped block direction (vertical-rl). Renamed InlineBox::topLeft() to location() to keep consistence with LayoutBox. Removed InlineBox::top(), left(), right(), bottom(). BTW removed LayoutInline::logicalPositionToPhysicalPoint() which was not properly named because the input is not "logical" position but "physical position in flipped blocks direction". Also it was redundant. Replaced the callsites with flipForWritingMode(). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG= Review-Url: https://codereview.chromium.org/2536453002 Cr-Commit-Position: refs/heads/master@{#434900}
-
tkent authored
If we have a way to leak UA shadow DOM to web authors or Chrome extension authors, these unchecked casts would be dangerous. This CL introduces toFooTypeOrDie() helpers, and apply it to UA shadow DOM. BUG=668970 Review-Url: https://codereview.chromium.org/2534873004 Cr-Commit-Position: refs/heads/master@{#434899}
-
tbansal authored
Record the time duration between data saver initialization and the first request whose resolved porxy is a data saver proxy. Also, record the time duration between IP address change event, and the next subsequent request whose resolved proxy is a data saver proxy. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=666134 Review-Url: https://codereview.chromium.org/2504963004 Cr-Commit-Position: refs/heads/master@{#434898}
-
kouhei authored
Simplify PendingScript disposal path by removing method releaseElementAndClear. Callers should use dispose() directly instead of repeating stopWatchingForLoad + releaseElementAndClear calls. BUG=None Review-Url: https://codereview.chromium.org/2536553002 Cr-Commit-Position: refs/heads/master@{#434897}
-
ntfschr authored
Don't let proguard remove WebViewDatabaseAdapter methods, since these are used in Android cts tests. BUG=31318603 Review-Url: https://codereview.chromium.org/2532943003 Cr-Commit-Position: refs/heads/master@{#434896}
-
cernekee authored
This is now plumbed up in shill; update histograms.xml to match. BUG=486182 TEST=trybots Review-Url: https://codereview.chromium.org/2534073002 Cr-Commit-Position: refs/heads/master@{#434895}
-