- 25 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b6183ea36975..8cfc41ae955d 2020-07-25 wl@gnu.org Fix `-Wformat' compiler warnings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ie307782c724c00f818c37909d6cb1b5ebd698918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791535}
-
Andres Calderon Jaramillo authored
This CL changes the video encode accelerator test that exercises the scaling path for zero-copy encoding so that the scaling factor is 1/2 instead of 3/4. The reason is that per b/160141652#comment3, half down scaling is expected to be the practical case. Note that this requires making sure that the input stream is not too small. That's because if it's too small, scaling down might produce a stream that's below the minimum supported resolution of the encoder. Bug: b:160141652 Test: video.EncodeAccel.*_dmabuf on rammus and kukui. Change-Id: I8e6b4595ac5e67bc00669f5d224c8c21a1b93edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315799 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791534}
-
David Tseng authored
Test: tools/json_schema_compiler/compiler.py -g externs extensions/common/api/automation.idl > third_party/closure_compiler/externs/automation.js results in no diffs. automation.js was hand edited previously. Run tools/json_schema_compiler/js_externs_generator_test.py Change-Id: I949530eecb24e5a26bc2f5bff13c831bdad3dbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314016 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791533}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui/webui/history. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=calamity@chromium.org Bug: 1106699 Change-Id: Ic96df4cdd31606f2d8b0397a67304ffa0d6d0ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316578Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791532}
-
Anastasiia N authored
- Migrate inline login flow to use Polymer. - Remove unused method: "handleOAuth2TokenFailure" - Remove "show-back-button" call, and use <if expr="chromeos"> to show the button on ChromeOS only. Bug: 1096007 Test: browser_tests --gtest_filter="*InlineLoginBrowserTest*" Change-Id: If146b080bb0fef65f8e931ac35809a8dfa8aa66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279795Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#791531}
-
Dylan Cutler authored
This web IDL annotation will automatically add instrumentation with the bindings code to record how much entropy these APIs leak about users' cross-site identity. Bug: 973801 Change-Id: Ie4d1aa3483bd1883511ccc46d9e4cb2879884c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302726Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#791530}
-
Michael Tang authored
Allows for subframe recordings to be saved to either the disk or memory buffers. Change-Id: I0630babd421716ed9bf354e22a3b8eca8ce46932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274166Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791529}
-
Lei Zhang authored
Convert the few remaining callers within base/. Bug: 1009837 Change-Id: I32d4aa4290deb753c2b1c0773a3cbde1cdf71578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313376 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791528}
-
dpapad authored
The test code was waiting for an event emitted from the prod code, but in some cases the event had already fired before the test code had registered the listener, causing the test to hang indefinitely. Fixed: 1104824 Change-Id: I10597aabc565ecbcef2dcd4e191cc80521f1686e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316129 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791527}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df7cabc2cd02..96de0520b550 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1109003 Tbr: Change-Id: I28d1912f3a689c92d5f5deda9a0848d2063eba2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319000Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791526}
-
Stefan Zager authored
LocalFrame::RemoteViewportOffset and LocalFrameView::MapLocalToRemoteRootFrame are legacy artifacts from when ViewportIntersectionState contained only an offset from an OOPIF to the main frame, rather than a full transform. BUG=1088483 Change-Id: I9d0aa3ffe127ff184f2f0741d2e4e6effa7d799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304968 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791525}
-
bttk authored
CallbackControllerTest covers the same functionality as before, but is more readable. Change-Id: I54d1409964ed0b077747abc0173a464867c9540d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315255Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#791524}
-
Cammie Smith Barnes authored
Currently the FCP ads metric only records the FCP of the main frame and ignores the FCP of any child frames. This CL updates the metric to store the earliest FCP in the ad frame tree, taking into account the child frames as well as the root ad frame. Tests: chrome/test:unit_tests --gtest_filter=*FirstContentfulPaint* Bug: 1103782 Change-Id: Id1cb1e9a98ba03656bb3da1ef6592b779bd5fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307442Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791523}
-
Noah Rose Ledesma authored
Add a method to the notification service for switching audio output devices. This currently has no effect. Bug: 1096243 Change-Id: I638bf11c36a3b5d0aa7a3beece9394a1df8e545c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293073Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#791522}
-
Daniel Hosseinian authored
Disallow wrapping within the #end div and add a 20px padding to the left. When window width is less than or equal to 600px, do not display the PDF title and the zoom input. Bug: 1108453 Change-Id: I60dbd2ada5a6a81cdf9f40daf6019889498d308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314788 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
-
Peng Huang authored
This is a reland of 0c9696bf Original change's description: > ExternalVkImageBacking: fix concurrent read problem > > Concurrent read access from both GL and Vulkan is not allowed. > Get rid of the concurrent read problem by releasing the texture > from GL temporarily, when a Vulkan read is requested. And resume > GL read access, when the Vulkan read access is over. > Current chrome GL and Vulkan concurrent read pattern is - Blink holds > and caches read access for a backing shared image for a WebGL or > 2D canvas. SkiaOutputSurfaceImplOnGpu only requests read access just > before playing back DDL and releases the read access after playing back > DDL and before SwapBuffers. The GPU will not schedule other tasks > between playing back DDL and SwapBuffers. So it should be safe to > temporarily pause GL read access. > > Bug: 1104231 > Change-Id: I729eeebd5196bc5387ac148133b5926358bb4b53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311330 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791022} Bug: 1104231 Change-Id: Ia916f250ca30b3c2b8a07016d2530fad79385aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316399Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791520}
-
Swapnil authored
We have several failure reasons that specify why the extension failed to install. We want to add failure reason to the existing event type INSTALLATION_FAILED for the event based reporting for force installed extensions. Bug: 1106343 Change-Id: I7c0e8a098c468904189b47c101036fd59279bca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302033 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#791519}
-
Gayane Petrosyan authored
Adding FindUniqueMatch function that checks if provided selector has a unique match. Additionally adds a basic use case when selector is an exact text without context. Bug: 1102382 Change-Id: Ifd105517d4ce4af36e7cd500e17ff0ca28a8d0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283244 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791518}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595656565-f8273935e4463fa6320c26f96bf11cce31594e4d.profdata to chrome-mac-master-1595678123-cab8caa4f93e8afba47417bd0b38f6939852da88.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I18cd0c0b7a93d80952cdf457a8009a84088c5f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319116Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0d158ac68107..d5a4775cfc77 2020-07-25 hao.x.li@intel.com Query API: QuerySet on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib3a7c6cafe9b147e351644e6afdc44b53f9b009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319122Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Move the following methods from PRImpl to PaymentUIsManager without logic changes. - getModifier - getLineItems - loadCurrencyFormattersForPaymentDetails - isMixedOrChangedCurrency - getOrCreateCurrencyFormatter * Because the methods being moved reference some PR parameters, we also add getModifiers and getRawTotals to PaymentRequestParams. * Because the methods reference mCurrencyFormatterMap, mUiShoppingCart, they are moved into PaymentUIsManager as well. Bug: 1102522 Change-Id: Iaf69afee236bc9369bea4e87ee4d2547800d5487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310900 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791515}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0ca429b29e9d5e72bbbdd9950f486212b61f13ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314935Reviewed-by:
-
Marijn Kruisselbrink authored
Introduces directories where access to the directory itself is blocked, and access to subdirectories is blocked as well, but individual files can still be opened. This enables opening of individual files stored on for example MTP devices on Windows, which is implemented on Windows by copying the file to a temporary directory and returning that path to chrome. This does not give access to folders on things like MTP devices. That will require a much larger rewrite/implementation of new file system backends, and is unlikely to happen anytime soon. But at least it won't result in the confusing "blocked because in a system folder" error if a user opens individual files on an MTP device (anything else is already filtered out/blocked by the file dialog itself, by the flags chrome passes to the file dialog). Also adds logging when we block access to a directory to make it easier to troubleshoot why certain paths are blocked, even if we can't reproduce it ourselves. Bug: 1094835 Change-Id: I170c3b9fa83c809d63d0a031aec5debd10bb3ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316888 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791513}
-
Xida Chen authored
This is one of the key input metrics, so extend it for another year. Bug: 1105083 Change-Id: I312490b1149323ea2c5be229251361b7e7769a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300606Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791512}
-
Ghazale Hosseinabadi authored
In this CL, we make code changes to revoke extension's permission when updating to incognito mode. We also add a unit test to verify the expected behavior. Bug: 633706 Change-Id: I617092c1ed954b7d10b71f8d61a08154657f9262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293077 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=mark@chromium.org Bug: 1106699 Change-Id: I4583985cfaa38bdd820ddd43ad0f3757b93f403c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316208 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791510}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ieaffc63cff8d92af05db651a5bdb965178f47657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318428Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791509}
-
Evan Stade authored
Fixed: 1109261 Change-Id: I1533048a2d8e67f0b82a1d20769ad22bf35c6213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317765 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791508}
-
Yusuf Sengul authored
This change adds abstraction for the Windows APIs that are used create and manage GCPW extension. Bug: 1101590 Change-Id: I5fb88a6f73cc4c85f42728b9dee487d1067b8bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278651 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#791507}
-
rbpotter authored
Bug: 1105701 Change-Id: I1f45d55f6eb744bc63885016e5e8a9b2b4571d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311521Reviewed-by:
-
Xing Liu authored
There is a new property in modal dialog to control whether the positive button is blue. For download later dialog and location dialog, the positive button should be blue. Bug: 1108865 Change-Id: I6ee6d6c1b3e190c9a7186dcfe31929f13b0c96cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315431Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791505}
-
Lei Zhang authored
They are explicitly inline. Fix some lint errors along the way. Change-Id: I94b8ea7ed7ab2025163d92f06db220f889094cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315223Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791504}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/importer. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=gab@chromium.org Bug: 1106699 Change-Id: I69553cfbfa8231eab0805402b64a2d7b03786ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316536 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#791503}
-
Nohemi Fernandez authored
BookmarkEarlGrey contains the required methods that are being re-implemented in the Signin codebase. To ensure consistency across the codebase remove sign-in versions and update tests. Bug: 1103274 Change-Id: I2a9348945def367512240279731e7e9b6839960f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290633Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#791502}
-
Mounir Lamouri authored
Bug: 1108415 Change-Id: I6fe8888a8c70ca4217a9738fecd82b46d188c485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314817 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791501}
-
Avi Drissman authored
There will be different binaries offered for Intel and Arm Macs, so distinguish them. This achieves this via a slight refactor, funneling all the places that show this data through the same function. Bug: 1106067 Change-Id: Id5f44ab4d7ca3186d09669984abed5b0377224ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305749 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Pavol Marko authored
This is a speculative fix for flakiness in SitePerProcessIgnoreCertErrorsBrowserTest.SubresourceWithCertificateErrors. Instead of assuming that the SSLStatus of a NavigationEntry is finalized when the navigation completed, wait for the WebContents to announce a visible security state change through a WebContentsObserver. Bug: 1105145 Test: content_browsertests Change-Id: I52333c49e82f22a9bbd8b5f82f0e9c69121eb58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316360 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Lei Zhang authored
It is not obvious what's going wrong, so save some data into the crash dumps to help with the investigation. Bug: 1108574 Change-Id: I4a9bbc147e2d47ca901e7ff35b44f7edf05de975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315080Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791498}
-
My Nguyen authored
We are merging languages settings in browser into OS settings in Chrome OS, so some metrics are added to track users responses and interactions. This is the second CL following adding metrics for OS settings. Bug: 1106033 Change-Id: I2861bfe702a7edc6fbc05dbf13db55543aa11e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299666 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791497}
-
Stefan Zager authored
It broke with: https://chromium-review.googlesource.com/c/chromium/src/+/2301589 Also, add my self to OWNERS, because I care. Change-Id: Ibb344fc4f432b5d3815ea40ab8e121e9403fa513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316946Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#791496}
-
