- 03 Jan, 2018 40 commits
-
-
Jonathan authored
Updating the filter file for new failures that have been found. TBR=kylechar@chromium.org Bug: 794961 Change-Id: Idd96cb7029e2c16038cb3e1d43dd3a4f2573c244 Reviewed-on: https://chromium-review.googlesource.com/847422Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#526609}
-
Matt Reynolds authored
Haptics on Dualshock4 devices are typically not supported by OS-level haptics APIs, so in order to support vibration effects on these devices we issue device-specific reports using the raw HID protocol. Dualshock4ControllerBase implements the common logic for creating the report buffer from the vibration intensity values. Users should implement WriteOutputReport to provide the OS-specific logic for sending the report to the device. BUG=749295 Change-Id: I742316f385235b44c0658dd9e571fa73cf4f496e Reviewed-on: https://chromium-review.googlesource.com/810053 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526608}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/bd319d25b886..7365f0261183 $ git log bd319d25b..7365f0261 --date=short --no-merges --format='%ad %ae %s' 2018-01-02 dtu [pinpoint] Add subdirectories for job-page and jobs-page elements. 2017-12-22 dtu [pinpoint] Shorten pinpoint element paths. 2017-12-27 erikchen Add explicit --is-local-build flag. 2018-01-02 mheikal Catapult: Manifest parsing now works with xml namespaces stripped 2018-01-02 eakuefner [TBMv2] Smoke test diagnostic equality in JS 2018-01-02 bokan Remove gesturesExpectedInViewportCoordinates branches 2018-01-02 eakuefner Stop merging by tags in add_reserved_diagnostics 2018-01-02 perezju [Telemetry] Fix binding to devtools agent on CrOS after login Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie1097cf9cdf898208274b57bf1d998e4369bef43 Reviewed-on: https://chromium-review.googlesource.com/848023 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526607}
-
Vladimir Levin authored
This patch removes at raster decode flag, which is only used in tests. R=enne@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1f8f81856c12c8f521a6e57268d35430dc3135c7 Reviewed-on: https://chromium-review.googlesource.com/848302Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526606}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/e8bb6da08dc6..57c2b8b16ab9 $ git log e8bb6da08..57c2b8b16 --date=short --no-merges --format='%ad %ae %s' 2017-12-31 reed remove unused declarations Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I747c70ab678ea9e324c1b794d44d9a71140a6f25 Reviewed-on: https://chromium-review.googlesource.com/848310Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526605}
-
Jonathan authored
The gn_isolate_map to telemetry_perf_unittestes_viz doesn't work as there is no associated build target. Providing an executable override doesn't seem to resolve this. I'm removing the config to get the Linux Viz bot back up and running until the error can be sorted out. TBR=dpranke@chromium.org Bug: 795760 Change-Id: I28dd3bc515aaa16bae59258ba0b1bb0b42ac4676 Reviewed-on: https://chromium-review.googlesource.com/846231Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#526604}
-
Jiaquan He authored
Bug: 733662 Change-Id: I218c5eb20ea029303d53b269197afe61c65353c7 Reviewed-on: https://chromium-review.googlesource.com/845879Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#526603}
-
Toni Barzic authored
Makes chromeos::ExternalCache an interface, and introduces a test external cache implementation. The test implementation is currently not used, but the plan is to eventually inject it into KioskAppManager in unittests where needed (immediate plan is to use it in unittests for chromeos::StartupAppLauncher). BUG=686901 Change-Id: I711221e57358c535f3bc34750a5c59521b805be6 Reviewed-on: https://chromium-review.googlesource.com/845059 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526602}
-
Eric Karl authored
This reverts commit 74522773. Reason for revert: Have fixes for the original issues. Will land those after un-reverting. Original change's description: > Revert "Remove use of DeferredTextureImageData APIs and Support Decode to Scale" > > This reverts commit 86c790e6. > > Reason for revert: This is causing performance / memory regressions that are trickier to address than expected. Reverting this for now. > > Original change's description: > > Remove use of DeferredTextureImageData APIs and Support Decode to Scale > > > > We aren't benefitting from the complexity added by the > > DeferredTextureImageData APIs, and this API blocks us from using > > PaintImage::Decode's decode-to-scale functionality. > > > > This change removes our usage of DeferredTextureImageData APIs, > > instead using SkImage::makeTextureImage to handle upload. Additionally, > > we now use the PaintImage::Decode API, adding decode-to-scale support. > > > > Bug: 773799 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: Ia5f480213c3a5c8225ccd289aa2c081056840f94 > > Reviewed-on: https://chromium-review.googlesource.com/713593 > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#517206} > > TBR=vmpstr@chromium.org,ericrk@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 773799 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: Ie4493559e334100f03dfed1dfb7a408fc26a33e0 > Reviewed-on: https://chromium-review.googlesource.com/830587 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524613} TBR=vmpstr@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 773799 Change-Id: Ic4492707672b8652bd3b102d3918399afb5321b4 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/847030 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526601}
-
liberato@chromium.org authored
Remove the build-time flag for MCVD, and replace it with a runtime flag media::kMojoVideoDecoder. When enabled, chrome will consider using MojoVideoDecoder but not GpuVideoDecoder. Regardless of the flag, WebRTC can still use the VDAs directly. that the correct decoder was used. Bug: 765542 Test: Manually set feature, tried WebRTC and H264 playback. Verified Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibf4fe584507f7d426a75c53e8fd07033f6c4900e Reviewed-on: https://chromium-review.googlesource.com/786148 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526600}
-
Ted Choc authored
This moves the existing iOS histogram/enum to a shared component and logs the same information in Android. BUG=790783 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id9a9391834d55581f498493a7bcfacb7e0416a94 Reviewed-on: https://chromium-review.googlesource.com/818469 Commit-Queue: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#526599}
-
Dave Schuyler authored
This Cl converts the internal page to display power usage information from the old i18n-content to the new $i18n{} localization. Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7983c7d01d993b81cf2dd4111712425f63db7ca5 Reviewed-on: https://chromium-review.googlesource.com/846424Reviewed-by:Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#526598}
-
erikchen authored
A uint32_t was being multiplied by 1024, and then implicitly cast to uint64_t. Instead, first explicitly cast to uint64_t, then multiply by 1024. Bug: 798234 Change-Id: I93188aca5b1169eeed2e91ef68f9d1a007a6e48b Reviewed-on: https://chromium-review.googlesource.com/848233Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526597}
-
Leo Zhang authored
This CL removes legacy translate infobar code which includes: * Old UI entry on Android and its sub panels * Native for the old Android UI * Tests for the old UI Bug: 727436 Change-Id: I9e98fcc763c110ea07832abbfa06a7a9dbd7a200 Reviewed-on: https://chromium-review.googlesource.com/838760 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526596}
-
Sergey Ulanov authored
With this CL it's possible to build webkit_layout_tests target for Fuchsia. The tests don't run yet. Bug: 778467 Change-Id: Ib869f6f98c52d99f069f9aa431c0c1cafcc7a1d1 Reviewed-on: https://chromium-review.googlesource.com/843013 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526595}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:432444 Change-Id: I4e703013cc1c0ddb243bf18e95eda199da618859 Reviewed-on: https://chromium-review.googlesource.com/847673Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526594}
-
Shimi Zhang authored
This cl introduces SelectionInsertionHandleObserver interface which deals with following events in SelectionPopupController#onSelectionEvent(): SELECTION_HANDLES_MOVED SELECTION_HANDLE_DRAG_STARTED SELECTION_HANDLE_DRAG_STOPPED INSERTION_HANDLE_MOVED INSERTION_HANDLE_DRAG_STARTED INSERTION_HANDLE_DRAG_STOPPED Bug: 798017 Change-Id: Iff08d5cb0a32528523b0fcc606c9c617e6c4fb48 Reviewed-on: https://chromium-review.googlesource.com/846339 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526593}
-
Max Moroz authored
-fsanitize=fuzzer and -fsanitize=fuzzer-no-link are two compilation flags that enable coverage instrumentation needed for libFuzzer. The instrumentation has more stuff under the hood compared to -fsanitize=trace-pc-guard. Also, it can be changing over time without a need to update GN flags again and again (e.g. move from edge to trace-pc-guard or something like that). Bug: 764514 Change-Id: I53bf5a3355335f4f627e9024b7ed7fe601c9ecfd > Revert "Migrate to -fsanitize=fuzzer-no-link when use_fuzzing_engine=true." > > This reverts commit c1406d52. > > Reason for revert: The builds are failing on linking of some fuzzers: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FLibfuzzer_Upload_Linux_ASan%2F7088%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout > > Original change's description: > > Migrate to -fsanitize=fuzzer-no-link when use_fuzzing_engine=true. > > > > -fsanitize=fuzzer and -fsanitize=fuzzer-no-link are two compilation > > flags that enable coverage instrumentation needed for libFuzzer. > > > > The instrumentation has more stuff under the hood compared to > > -fsanitize=trace-pc-guard. Also, it can be changing over time > > without a need to update GN flags again and again (e.g. move from > > edge to trace-pc-guard or something like that). > > > > Bug: 764514 > > Change-Id: I48ef328dee49a9620a1b44bd5cd920f116e1bc1b > > Reviewed-on: https://chromium-review.googlesource.com/802395 > > Commit-Queue: Max Moroz <mmoroz@chromium.org> > > Reviewed-by: Oliver Chang <ochang@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#522505} Change-Id: I53bf5a3355335f4f627e9024b7ed7fe601c9ecfd Reviewed-on: https://chromium-review.googlesource.com/846100Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526592}
-
Yuzhu Shen authored
The purpose is to avoid shadowed variable warnings, because some mojom definitions use "buffer" as field names. Bug: None Change-Id: I32b1905d6639c22b10f8979050525e8a06f728de Reviewed-on: https://chromium-review.googlesource.com/847634Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526591}
-
chrome://creditsDavid Benjamin authored
- "BoringSSL" rather than "boringssl" is probably a more suitable stylization for that page. - Sorting uppercase letters above lowercase ones is a little confusing. A case-insensitive sort is a bit more natural. - libaddressinput's name is more a description and kind of odd to show in chrome://credits. Have it appear as libaddressinput instead. Note this does make it more obvious that we have both "BSDiff" and "bsdiff" and "icu" and "ICU", which is a little odd, but reflects the number of copies of them we have. bsdiff, in particular, has a couple of different evolutions. Bug: none Change-Id: I882c924bfe765a27844a007db80653172ed03800 Reviewed-on: https://chromium-review.googlesource.com/842952Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#526590}
-
Sasha Bermeister authored
Remove WebStorageQuotaType and replace users with StorageType in WebKit/common. This is pre-work to change all users of StorageType to use the mojo enum instead. This patch also renames StorageType in StorageArea to StorageArea::StorageType, to prevent name conflicts. There is also a small change in DeprecatedStorageQuota.cpp which was relying on a static cast to WebStorageQuotaType. Bug: 781643 Change-Id: I8f8a4cafa1faf35a8d09dbcafd697af1ffe251d5 Reviewed-on: https://chromium-review.googlesource.com/828640 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#526589}
-
Erik Chen authored
This reverts commit e4d9e6a3. Reason for revert: This CL causes an infinite loop for some users. https://bugs.chromium.org/p/chromium/issues/detail?id=798234#c9 Original change's description: > Expire redirect parents when expiring any history visit. > > This CL fixes an issue with history deletion where Visits that were > the end of redirect chains were not deleting their redirect parents. > In effect, removing a single history entry from chrome://history was > not removing all Visits associated with it, causing similar URLs to > continue to show up in the omnibox autocomplete. > > Bug: 786878 > Change-Id: Id207dd7810629458d19a847d3ff52c0e562f2ce6 > Reviewed-on: https://chromium-review.googlesource.com/795527 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525589} TBR=calamity@chromium.org,brettw@chromium.org,sdefresne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 786878 Change-Id: I5b10eef437b09b8e61c8ca5d025e9b15e1226935 Reviewed-on: https://chromium-review.googlesource.com/848052Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526588}
-
Nate Chapin authored
When a cache hit occurs for a Resource that supports async cache hits, Resource::AddClient schedules a task to process the cache hit on the process-wide loading task runner, rather than a per-frame loading task runner. This is because a Resource that is fully loaded has no context to determine which frame it should attribute itself to. Having callers provide a WebTaskRunner* to AddClient allows the caller to handle that attribution. Bug: 624696 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic6d00e725cdd9141f83dcb5f8bcd34af3c5ac27d Reviewed-on: https://chromium-review.googlesource.com/723879 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#526587}
-
Fadi Meawad authored
This reverts commit e442ea06. Reason for revert: This CL caused major regressions in android webview performance. See https://crbug.com/798310 Original change's description: > Reland "[PageLifecyle] Move the launch process state to Webkit/common" > > This is a reland of 99a51fca > > The failures described in crbug.com/796940 was result of throttling > the scheduled tasks as a result of the new backgrounding state. > > The fix foregrounds the RendererScheduler before running the tests > to avoid throttling. > > Original change's description: > > [PageLifecyle] Move the launch process state to Webkit/common > > > > This CL introduces Webkit/common/page/launching_process_state.h that > > includes the launch background and launch boosted state. > > > > The reason this file is needed, is because the state is different per > > OS but needs to be consistent between the RenderProcessHostImpl and > > the RendererSchedulerImpl. To prevent future changes in one not > > reflecting in the other, the code is moved to a common place and > > shared. > > > > This CL fixes an issue where the scheduler assumes that it is > > foregrounded while it is actually backgrounded during the initial > > phase on Android. > > > > Bug: chromium:780191 > > Change-Id: Ib8dbfb6447f58c8b998a94ae2c69f8bc906d150f > > Reviewed-on: https://chromium-review.googlesource.com/815678 > > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Bo <boliu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#525563} > > TBR=haraken@chromium.org,boliu@chromium.org > > Bug: chromium:780191,chromium:796940 > Change-Id: I117afad3b910239656dbc7e9dc3a1447291263a9 > Reviewed-on: https://chromium-review.googlesource.com/840340 > Reviewed-by: Fadi Meawad <fmeawad@chromium.org> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525841} TBR=boliu@chromium.org,fmeawad@chromium.org,haraken@chromium.org,oysteine@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:780191, chromium:796940, chromium:798310 Change-Id: I0c8b7e075c29761d2a6f0d02461551b651682748 Reviewed-on: https://chromium-review.googlesource.com/847653Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#526586}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bb5733a4..a9293af8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If4c3627cf3886111c5d0e2e7d5e059d4c50969bd Reviewed-on: https://chromium-review.googlesource.com/847287Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526585}
-
Xiaocheng Hu authored
A previous patch crrev.com/c/843490 introduced ShapeResult::GetCharacterRange() to make usage of the static GetCharacterRange() function easier. This patch applies the new function to simplify LayoutNG selection painting. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7ece0f54f169f33f0841bd8463acc4d388ace46e Reviewed-on: https://chromium-review.googlesource.com/846101Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#526584}
-
Tom Anderson authored
This CL fixes building with libstdc++ instead of libc++. BUG=797448 R=sky Change-Id: I631cbb68511ac76214e07806ace99539ffe49f17 Reviewed-on: https://chromium-review.googlesource.com/848154 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526583}
-
Joel Einbinder authored
Bug: 760316 Change-Id: I2e1a5b06e1b3b5e2e1e3151ca2299172b789ffa5 Reviewed-on: https://chromium-review.googlesource.com/827941Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#526582}
-
Reilly Grant authored
base::RefCountedBytes tracks its own size so the length parameter can be replaced by asking the buffer for its length. Change-Id: If54c6d3bae1fb535c64068f3c09dce782d9be917 Reviewed-on: https://chromium-review.googlesource.com/830655Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526581}
-
Jinsuk Kim authored
JavascriptInjector in https://crrev.com/c/828000 missed calling |WebContents::SetUserData|, therefore the newly created instance is leaked. This CL fixes it. Bug: 798549 Change-Id: Ia9c95edcba363f5fc5b8aafaf97cec0ea3dd4759 Reviewed-on: https://chromium-review.googlesource.com/848112Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#526580}
-
Gregory Chatzinoff authored
Bug: 767219 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I677343a47696ed1b4a70dd9c029f2b65fe5d9181 Reviewed-on: https://chromium-review.googlesource.com/843462 Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526579}
-
Dmitry Gozman authored
This is an embedder feature, not the protocol one. As a side bonus, this unblocks DevToolsAgent migration to blink. Bug: 776009 Change-Id: I5c8f18ec0d8f07a556a7630f0d534fbb779d7fdf Reviewed-on: https://chromium-review.googlesource.com/837509Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526578}
-
Robert Hogan authored
This is a re-land of https://codereview.chromium.org/13431004 which was reverted nearly 5 yrs ago due to performance regressions at https://crbug.com/230147. Changing an empty layer to 1x1 layer makes it artificially overlap with other layers so in the test case here a squashing layer gets created when none is needed. This creates an artificial need to resize the bogus squashing layer when its descendant objects overflow changes. It's worth trying again I think. Bug: 787565 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iff7ca289eef8480f99d30a84c9be77ee2c9e2289 Reviewed-on: https://chromium-review.googlesource.com/842984Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#526577}
-
Ryan Landay authored
FrameSelection.h contains a declaration for an UpdateSelectionIfNeeded() method, whose implementation has since been removed. This CL removes the unused declaration. Change-Id: Ic0410d804e7df32e7ed7d3df8371e1cb2a2672ed Reviewed-on: https://chromium-review.googlesource.com/847698Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#526576}
-
bsheedy authored
Adds a VR instrumentation test to ensure that clicks from the Daydream controller are actually registered on the webpage. Bug: 797299 Change-Id: I604918c57c403de81a8bd673420df912a7f0fa16 Reviewed-on: https://chromium-review.googlesource.com/843451Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526575}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/9185bde7ee18..94dc17710fd7 $ git log 9185bde7e..94dc17710 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If7e8ceeb04dad75f5e68e238a4fe8f07d7808bee Reviewed-on: https://chromium-review.googlesource.com/847910Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526574}
-
Will Chen authored
No longer flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fapplication-panel%2Fresources-panel-websql.js Speculatively, because of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/792534 TBR=eostroukhov@chromium.org Bug: 749251 Change-Id: I91e376ad73dae38fc8ae5e960f6eddbb85a1c84f Reviewed-on: https://chromium-review.googlesource.com/848024Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526573}
-
Darren Shen authored
This patch refactors StylePropertyMap.set to roughly double its speed: 1) Avoid creating CSSParserContext when possible. 2) Optimise for the common case of setting a non list-valued property. 3) Use CSSProperty as much as possible to avoid conversions between CSSPropertyID and CSSProperty. Bug: 785132 Change-Id: Ic57615c8414c03871fb57085de92efbb75bd6413 Reviewed-on: https://chromium-review.googlesource.com/838160Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526572}
-
Tom Anderson authored
This reverts commit 13a1bab9. Reason for revert: Windows are shown after XFlush(). > This reverts commit f93b585a. > > Reason for revert: Windows don't get shown > > Original change's description: > > Remove ui::X11EventSource::BlockUntilWindowMapped > > > > This CL removes BlockUntilWindowMapped() and the 2 references to it. > > > > The first reference, in X11WholeScreenMoveLoop, waits until an offscreen window > > is mapped. The window is override-redirect (so there's not WM that > > asynchronously decides when to map the window), so any operations done on the > > window should succeed after the window is mapped since the X server processes > > events in sequence. > > > > The second reference is from X11WindowBase. A similar removal was done in > > DesktopWindowTreeHostX11 in [1], so BlockUntilWindowMapped() shouldn't be needed > > here either. > > > > [1] https://chromium.googlesource.com/chromium/src/+/662c24fc6debb33ee34a927d21dc26154b8973d6 > > > > R=sadrul@chromium.org > > > > Change-Id: I251e67839dd5216f5164a103a82ad8a906811a03 > > Bug: None > > Reviewed-on: https://chromium-review.googlesource.com/823212 > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#525869} > > TBR=sadrul@chromium.org,thomasanderson@chromium.org > > Change-Id: I7bc83f409171941ce812ab09e0191b935127a38b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 797358 > Reviewed-on: https://chromium-review.googlesource.com/842685 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526056} R=sadrul@chromium.org BUG=797358 Change-Id: I601defea876f5547b045e8584cb592366c36f4ac Reviewed-on: https://chromium-review.googlesource.com/842474Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526571}
-
François Degros authored
StatisticsRecorder is now an actual container of collections. There is only one global recorder at any time, referenced by StatisticsRecorder::top_. Each StatisticsRecorder also has a pointer to the previous global recorder. We now have a stack (singly linked list) of StatisticsRecorder objects, where the top of the stack (StatisticsRecorder::top_) is the current global recorder. This pattern is clearer and cleaner. It avoids a bunch of static variables, indirections, unique_ptrs and calls to operator new. It gets rid of the ugly hacks of UninitializeForTesting. It reduces memory fragmentation by having fewer dynamically allocated objects. Removed methods Reset, UninitializeForTesting and DumpHistogramsToVlog. They are now unnecessary. Reviewed, clarified and documented the thread safety status of each method. Added comments. Change-Id: Ia1a7611905009d0449068c801464ad0df7813c0d Bug: Reviewed-on: https://chromium-review.googlesource.com/830997 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#526570}
-