GitLab

This is a regression from [1] which added a dup() call on
the renderer launching process. This CL removes these calls
by reveiling the subtle ownership of the file descriptors.

The original intention here was to completely hide and simplify
the notion of the ownership, at the cost of a few dup() calls.
However, the crash report on the reported bug indicates that
the dup() can fail and it lets the renderer initialization fail,
probably due to some per-process limit of the number of opened files.

[1] https://codereview.chromium.org/585203002

R=mdempsky@chromium.org, jam@chromium.org
BUG=455364

Review URL: https://codereview.chromium.org/909553003

Cr-Commit-Position: refs/heads/master@{#315353}

Revert of Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread (patchset #1 id:1 of https://codereview.chromium.org/899473002/)

Reason for revert:
this CL doesn't fix the original issue

Original issue's description:
> Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread
>
> For MediaPlayerListener, the callbacks can happen on a non-UI thread.
> Weak_ptr is not thread safe, so we shouldn't bind the weak_ptr in those callbacks.
> This change creates a threadsafe proxy class to bridge all the callbacks.
>
> BUG=453581, 447368, 447367
>
> Committed: https://crrev.com/2e9885788692f69203a98fb42347428ef553d640
> Cr-Commit-Position: refs/heads/master@{#314241}

TBR=xhwang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453581, 447368, 447367

Review URL: https://codereview.chromium.org/879273006

Cr-Commit-Position: refs/heads/master@{#315352}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4e534d0..31223e0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/903733003

Cr-Commit-Position: refs/heads/master@{#315351}

This was blocked on a WebRTC issue for a long time. However,
latest trybot runs appear green.

BUG=360622, 324216, 307043
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/227533008

Cr-Commit-Position: refs/heads/master@{#315350}

BUG=

Review URL: https://codereview.chromium.org/891773003

Cr-Commit-Position: refs/heads/master@{#315349}

This should allow https://codereview.chromium.org/878163004/ to land safely.

BUG=400499

Review URL: https://codereview.chromium.org/902053006

Cr-Commit-Position: refs/heads/master@{#315348}

Similar to the existing Logcat, allows to iterate over the lines of
output from long running commands.

BUG=

Review URL: https://codereview.chromium.org/909833002

Cr-Commit-Position: refs/heads/master@{#315347}

Revert of Sync commit errors should temporarily re-enable trigger pre-commit getupdates (patchset #2 id:20001 of https://codereview.chromium.org/905853002/)

Reason for revert:
Looks like this broke the build

Undefined symbols for architecture armv7:
  "syncer::sessions::test_util::SimulateDownloadUpdatesFailed(syncer::EnumSet<syncer::ModelType, (syncer::ModelType)2, (syncer::ModelType)33>, syncer::sessions::NudgeTracker const&, syncer::sessions::SyncSession*)", referenced from:
      syncer::BackoffTriggersSyncSchedulerTest_FailDownloadOnceThenSucceed_Test::TestBody() in sync_scheduler_unittest.o
      syncer::BackoffTriggersSyncSchedulerTest_FailDownloadTwice_Test::TestBody() in sync_scheduler_unittest.o
      syncer::SyncSchedulerTest_FailedRetry_Test::TestBody() in sync_scheduler_unittest.o

Original issue's description:
> Sync commit errors should temporarily re-enable
> trigger pre-commit getupdates
>
> Add a boolean variable in class DataTypeTracker, so every
> time when a data type got conflict response from server
> during commit, will set that boolean variable to true, then
> next time sync, GetUpdate will check the boolean to see if
> need to GetUpdate to resolve conflict locally.
>
> BUG=324893
>
> Committed: https://crrev.com/21f43c5af27e24c34565df26bb51fcc704c97597
> Cr-Commit-Position: refs/heads/master@{#315339}

TBR=zea@chromium.org,stanisc@chromium.org,maniscalco@chromium.org,pvalenzuela@chromium.org,gangwu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=324893

Review URL: https://codereview.chromium.org/891123003

Cr-Commit-Position: refs/heads/master@{#315346}

A few updates to the documentation, a developer pointed out some of the docs weren't quite clear.

TBR= sbc@chromium.org, jmedley@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/886163005

Cr-Commit-Position: refs/heads/master@{#315345}

In order to be able to use it in places other than content (e.g. handles
for unified touch selection controller), ImageWindowDelegate is moved to
a new ui module called aura_extra.

Also, to make it more useful, ImageWindowDelegate can now be customized
by setting background color and image offset.

COLLABORATOR=mfomitchev
BUG=399721

Review URL: https://codereview.chromium.org/880703002

Cr-Commit-Position: refs/heads/master@{#315344}

BUG=455900

Review URL: https://codereview.chromium.org/900363003

Cr-Commit-Position: refs/heads/master@{#315343}

Reason for revert:
Looks like this broke the linux 32 bots:

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/9539
lots of failures like:
ASSERTION FAILED: !((reinterpret_cast<uintptr_t>(address) + sizeof(HeapObjectHeader)) & allocationMask)
../../third_party/WebKit/Source/platform/heap/Heap.cpp(875) : void blink::FreeList::addToFreeList(Address, size_t)

TBR=dpranke@chromium.org,rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/907953002

Cr-Commit-Position: refs/heads/master@{#315342}

This is a clean-up, it follows up on https://codereview.chromium.org/825773003/.

BUG=451018

Review URL: https://codereview.chromium.org/866983003

Cr-Commit-Position: refs/heads/master@{#315341}

Revert of Mac: Enable two finger double-tap smart zoom (patchset #1 id:1 of https://codereview.chromium.org/909633002/)

Reason for revert:
This is a suspect in the dramatic increase in crash rates noted
in crbug.com/456860.

The crashes are on 10.10, so there are no stack traces, so this
is just a guess.

Original issue's description:
> Mac: Enable two finger double-tap smart zoom
>
> BUG=452592
>
> Committed: https://crrev.com/e69b4fd53dbf2d4c1fdc82de623186d7b21c29fb
> Cr-Commit-Position: refs/heads/master@{#315214}

TBR=avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=452592

Review URL: https://codereview.chromium.org/859393005

Cr-Commit-Position: refs/heads/master@{#315340}

trigger pre-commit getupdates

Add a boolean variable in class DataTypeTracker, so every
time when a data type got conflict response from server
during commit, will set that boolean variable to true, then
next time sync, GetUpdate will check the boolean to see if
need to GetUpdate to resolve conflict locally.

BUG=324893

Review URL: https://codereview.chromium.org/905853002

Cr-Commit-Position: refs/heads/master@{#315339}

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35192/steps/cc_unittests/logs/stdio#failure1
TBR=aelias@chromium.org

BUG=456617

Review URL: https://codereview.chromium.org/913543002

Cr-Commit-Position: refs/heads/master@{#315338}

base::NthType was once added in a prototype of base::Bind refactoring
though it is no longer used in the final code.

BUG=433164

Review URL: https://codereview.chromium.org/897943003

Cr-Commit-Position: refs/heads/master@{#315337}

This adds a test to ensure that the disable switch is respected
by ConfigurePrerender in prerender_field_trial.cc.

BUG=455449

Review URL: https://codereview.chromium.org/897983003

Cr-Commit-Position: refs/heads/master@{#315336}

This is the last stage of the trace_event directory restructuring.
This is part of a set of 3 CLs which is moving tracing clients to use
the new base::trace_debug namespace.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/879913002

Cr-Commit-Position: refs/heads/master@{#315335}

BUG=None
R=earthdok@chromium.org

Review URL: https://codereview.chromium.org/872353003

Cr-Commit-Position: refs/heads/master@{#315334}

(pyOpenSSL 0.13 or greater).

This relands https://crrev.com/855603002/,
"Roll Web Page Replay to pick-up HTTPS certificate fixes," and
picks-up one additional Web Page Replay change to test for SNI support.

BUG=431686

Review URL: https://codereview.chromium.org/903153002

Cr-Commit-Position: refs/heads/master@{#315333}

BUG=448011

Review URL: https://codereview.chromium.org/908493002

Cr-Commit-Position: refs/heads/master@{#315332}

The UMA histogram is used to verify performance of the Finch experiment "UseDelayAgnosticAEC".

In webrtc:r8170 the Echo Delay Metrics queried through webrtc::EchoCancellation::GetEchoDelayMetrics() were changed from reset upon query to fixed aggregation window.
These metrics are used in GetStats() and further to calculate and log WebRTC.AecDelayBasedQuality.
Before the change we could not handle multiple clients, so we queried the metrics when a client called GetStats(). Now we can handle these two types of stats independently.

In webrtc:r8230 a new metric was added. This metric calculates the fraction of poor delays.
Before the change we calculated such a metric in chromium for logging WebRTC.AecDelayBasedQuality. Now we can query the metric directly and average several queries to match the desired aggregation length.

- Adds a fourth histogram bucket to track invalid data
- Adjusts the algorithm to log UMA histogram w.r.t. the new fraction_poor_delay metric
- Removes UMA histogram dependency on someone else calling GetStats()
- Changed GetAecStats() to take EchoCancellation instead of AudioProcessing.

BUG=450193

Review URL: https://codereview.chromium.org/904203003

Cr-Commit-Position: refs/heads/master@{#315331}

The new property is accessibilityFeatures.animationPolicy.
The new field for animation policy is added to Web Preference and the new profile is added.
accessibility_features.json is not specific to chromeos any more.
When the animation policy is updated through the extension,
Web preference is updated and WebSettings from Blink is updated.

BUG=3690

Review URL: https://codereview.chromium.org/785723002

Cr-Commit-Position: refs/heads/master@{#315330}

In javap 1.7 the signature line was prefixed with 'Signature: ', which in javap 1.8 has changed to 'descriptor: '.

This CL adds support for the new format, and adds a test to ensure that all parsers still work correctly.

Review URL: https://codereview.chromium.org/872843004

Cr-Commit-Position: refs/heads/master@{#315329}

Background context:
 - This CL is about breakpad *micro*dumps, not to be confused with
   minidumps (see crbug.com/410294 for details and design doc).
 - Breakpad microdumps are, before and after this CL, enabled only
   for Android.
 - At present state, the logic that decides whether microdumps should
   be enabled or not is hardcoded in breakpad_linux.cc. Such logic
   today enables breakpad only when unwind tables are stripped out.
   So far so good as it was the only intended use case.

New use case which justifies this CL:
At this stage of the project, Android WebView is also going to get
microdumps. Conversely to what happens in Chrome, however, WebView
needs microdumps to be always enabled. The rationale of this choice
is: WebView can not take advantage of the regular minidump uploader
and microdumps are going to represent the only form of crash reporting.

From the crash/ code perspective, this invalidates the assumption that
microdumps can just be enabled when NO_UNWIND_TABLES == 1 and requires
the introduction of a more customizable logic.

Description of the change:
This CL is a minimal refactoring required to introduce such logic. It
adds a ShouldEnableBreakpadMicrodumps method in CrashReporterClient and
moves the NO_UNWIND_TABLES logic around.
The overall behavior of "when are microdumps enabled" is unchanged after
this CL.

BUG=410294,456494

Review URL: https://codereview.chromium.org/904213002

Cr-Commit-Position: refs/heads/master@{#315328}

This CL is to correctly support disabling/enabling per-request caching in
HttpURLConnection.

BUG=398997

Review URL: https://codereview.chromium.org/860893002

Cr-Commit-Position: refs/heads/master@{#315327}

This is a recently introduced dependency.

BUG=355223
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/909913002

Cr-Commit-Position: refs/heads/master@{#315326}

R=sky

Review URL: https://codereview.chromium.org/910453002

Cr-Commit-Position: refs/heads/master@{#315325}

This CL changes the grit_whitelist parameter to be a string instead of a
part of grit_defines.
This allow user to override the parameter with another file.

The goal of this is to allow creating bundles with their own whitelists.

At the moment, if you want to create a small executable (i.e. an ios extension)
that only uses 3 strings, you are required to include all the strings
whitelisted by the main chrome bundle.
By allowing to override the whitelist argument (instead of only appending the
argument array, it will allow to specify a specific whitelist for a specific
target.

BUG=456837

Review URL: https://codereview.chromium.org/862043002

Cr-Commit-Position: refs/heads/master@{#315324}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d693046..b8214f9

TBR=dpranke@chromium.org,caseq@chromium.org

Review URL: https://codereview.chromium.org/905333002

Cr-Commit-Position: refs/heads/master@{#315323}

Have content::FileInfoToWebFileInfo() set the temporarily Blink-unused
field WebFileInfo::modificationTime to something milliseconds-based

Once landed, this is to allow Blink to switch to no longer using
WebFileInfo::modificationTimeMS, but modificationTime only (again.)

This is the fourth patch in the following series,

1: [blink] add WebFileInfo::modificationTimeMS [ https://codereview.chromium.org/873723004/ ]
2: [chromium] fill in modificationTimeMS [ https://codereview.chromium.org/884413002/ ]
3: [blink] make use of modificationTimeMS [ https://codereview.chromium.org/884393002/ ]
4: [chromium] *this one* [ https://codereview.chromium.org/862203003/ ]
5: [blink] switch to using modificationTime instead of *MS [ https://codereview.chromium.org/882343002/ ]
6: [chromium] stop setting modificationTimeMS [ https://codereview.chromium.org/890523002/ ]
7: [blink] remove modificationTimeMS [ https://codereview.chromium.org/869613005/ ]

R=jochen
BUG=451747

Review URL: https://codereview.chromium.org/862203003

Cr-Commit-Position: refs/heads/master@{#315322}

Revert of [WebView] Add unique visual state request ids. (patchset #4 id:60001 of https://codereview.chromium.org/900303002/)

Reason for revert:
This is breaking some bots, see for example:
https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Arm64%20Builder%20(dbg)/builds/8923

https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder%20(dbg)/builds/73663

The reason is:
M D ST: Write to static field org.chromium.android_webview.AwContents.sNextVisualStateRequestId from instance method org.chromium.android_webview.AwContents.flushVisualState(AwContents$VisualStateFlushCallback)  At AwContents.java

Original issue's description:
> [WebView] Add unique visual state request ids.
>
> Each flushVisualState request returns a unique id
> that allows callers to match requests with callbacks.
> The reasoning behind is to potentially allow clients
> to reuse VisualStateFlushCallback objects to avoid
> additional java allocations.
>
> BUG=455651
>
> Committed: https://crrev.com/d011b93e7c8f966ba068b0c77c8a1400bdedee88
> Cr-Commit-Position: refs/heads/master@{#315304}

TBR=boliu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=455651

Review URL: https://codereview.chromium.org/907723004

Cr-Commit-Position: refs/heads/master@{#315321}

Owners of the extensions system should own their message filters in the
renderer host.

R=sky@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/905833003

Cr-Commit-Position: refs/heads/master@{#315320}

The libluis wrapper depends on the load event to fier when
the nacl component is loaded to initialize the braille
translator.  Somehow, this doesn't fire during startup unless
a message is sent to the component which causes braille translation
to not work at all, resulting in no braille output on the display
at all.

This is a minimal workaround intended for backporting to the M-41 branch while
the real cause can be investigated and addressed.

BUG=455889
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/905353002

Cr-Commit-Position: refs/heads/master@{#315319}

BUG=440359
TBR=rsesek@chromium.org, noms@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/898533005

Cr-Commit-Position: refs/heads/master@{#315318}

It's no longer necessary for the NaCl side to define and refer to the
NaClFileToken struct.

So we can change the Chromium side to define NaClFileToken, instead of
using the definition from nacl_file_info.h.  This will let us remove
nacl_file_info.h from the NaCl side.

We copy the comment from nacl_file_info.h.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073
TEST=build

Review URL: https://codereview.chromium.org/903333002

Cr-Commit-Position: refs/heads/master@{#315317}

- AvatarFetcher moves out as AccountAvatarFetcher
- Avatar icon size constant moves out as kAvatarImageSize
- Avatar icon scaling moves out as ScaleImageForAccountAvatar

BUG=448011

Review URL: https://codereview.chromium.org/901493003

Cr-Commit-Position: refs/heads/master@{#315316}

TBR=yawano@chromium.org
BUG=none
TEST=TEST=GYP_GENERATORS=ninja gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/909883002

Cr-Commit-Position: refs/heads/master@{#315315}

Renaming webview copy of V8 snapshot to be able to differentiate
between snapshots for 32- and 64 bit architectures.
This is done so that snapshots for different architectures can be
repacked into the same APK.

BUG=455699

Review URL: https://codereview.chromium.org/903793002

Cr-Commit-Position: refs/heads/master@{#315314}