GitLab

The default apps v2 container is pretty basic. We want to provide something that looks prettier and also implements some functionality specific to our use-case:

* When connected to a host, a disconnect icon is added to the window controls (it's therefore no longer needed in the tool-bar).
* When connected to a host, maximize == full-screen.
* In full-screen mode, the window controls are still accessible, but are auto-hidden near the top-left corner (but not obscuring it, since it's often a hot-spot on the server).
* For touch-screen devices with no concept of hover, clicking the "stub" will also reveal the controls.

There should be no change to the v1 UX, but I don't plan on landing this CL before the M36 branch point, just in case.

BUG=134213

Review URL: https://codereview.chromium.org/265393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373002

Review URL: https://codereview.chromium.org/285803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270341 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/289493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270339 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373098
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/270343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773

Review URL: https://codereview.chromium.org/265743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270336 0039d316-1c4b-4281-b951-d872f2087c98

Pull out and extend a bunch of mechanical changes from:
  https://codereview.chromium.org/220493003/
in hopes that the actual functional changes will be cleaner.

This includes:
 - cached_hits -> cache_hits
 - cached_hashes -> cache_hits
 - ASSERT_TRUE(UpdateStarted()) in db tests.
 - *_EQ() has expected value on the left in db tests.
 - ASSERT to check container sizes before dereferencing in db tests.
 - Compare list names as strings in db tests.
 - Consistently use prefix_hits for prefix hits in db tests.
 - Check prefix_hits before cache_hits in db tests.
 - Remove unused cache-related code from browser test.

BUG=357763

Review URL: https://codereview.chromium.org/283873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/286743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270334 0039d316-1c4b-4281-b951-d872f2087c98

DB layout is not changed yet.

After this change, all user code should be changed to stop using PutCacheEntry, GetCacheEntry, RemoveCacheEntry, and GetCacheEntryIterator.

BUG=275271
TEST=unit_tests

Review URL: https://codereview.chromium.org/289453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270333 0039d316-1c4b-4281-b951-d872f2087c98

The wpr server will use DoNothingForwarder, which asserts that the remote
port is the same as the local one, and the ports used are the ones in
the CrOSBrowserBackend's wpr_port_pairs; so if running locally,
use the local port as a remote one.

BUG=359293
NOTRY=True

Review URL: https://codereview.chromium.org/254903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270332 0039d316-1c4b-4281-b951-d872f2087c98

Looks like we forgot to save the visible viewport to the local member
in RenderWidget. This was a problem when DisableAutoResize was called
(such as by the BrowserPluginGuest, as in the bug) since it would
pass the member variable along, resetting the pinch viewport to 0,0.
Since the pinch viewport was recently made to clip its contents, this
resulted in a blank screen.

BUG=371061

Review URL: https://codereview.chromium.org/284883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270331 0039d316-1c4b-4281-b951-d872f2087c98

This will enable aura to be used on multiple threads.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/285793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270330 0039d316-1c4b-4281-b951-d872f2087c98

4m7s -> 3m51s: remove expensive regexp.
Short-circuits "VmHWM".
Remove old stats for xoom tablets.

BUG=372489

Review URL: https://codereview.chromium.org/278763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270329 0039d316-1c4b-4281-b951-d872f2087c98

This reverts the changes to baselines for static initializers that were changed in:
http://src.chromium.org/viewvc/chrome?revision=270015&view=revision
https://src.chromium.org/viewvc/chrome?revision=270042&view=revision

These were introduced because of an added static initializer which was later
removed in:
http://src.chromium.org/viewvc/chrome?revision=270304&view=revision

BUG=none
TBR=bokan@chromium.org,qyearsley@chromium.org,rsleevi@chromium.org

Review URL: https://codereview.chromium.org/275013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372709
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/288493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270327 0039d316-1c4b-4281-b951-d872f2087c98

New window blocking for kiosk is done by a browser list observer now.
The blocking code in CanCreateWindow is no longer needed. And it prevents
webview's newwindow event being fired in kiosk mode.

BUG=373023

Review URL: https://codereview.chromium.org/281903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270326 0039d316-1c4b-4281-b951-d872f2087c98

This new API returns a list of accounts signed in to the profile. The
first element of the list is always the primary account. Other accounts
are returned after, sorted by obfuscated gaia ID.

The API is currently available in dev channel. If the flag
--extensions-multi-account (or --new-profile-management) is enabled,
getAccounts will return all accounts. Otherwise only the primary account
is returned.

BUG=258515

Review URL: https://codereview.chromium.org/274853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270325 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to possible build breakage: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%20LSan%20Tests%20%282%29&number=2633

> sync: Improve handling of bad UniquePositions
> 
> Makes the client assign a valid position to incoming bookmarks if the
> server has not populated the required fields.  This code should never be
> triggered unless there is a bug in the server.  This risks reordering
> users' bookmarks, but that's probably preferable to a crash.
> 
> Detects bookmarks that do not have valid position information during
> database load.  If these corrupted bookmarks are detected, the entire
> database is declared to be corrupt.  Sync will then re-download
> all of the user's data, which should fix the problem.
> 
> BUG=367247
> 
> Review URL: https://codereview.chromium.org/278153002

TBR=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/270543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270324 0039d316-1c4b-4281-b951-d872f2087c98

In Debug build:

$ gn gen out/Debug --args='os="android" cpu_arch="x86"'

$ ninja -C out/Debug gfx_jni_headers

In Release build:

$ gn gen out/Debug --args='is_debug=false os="android" cpu_arch="x86"'

$ ninja -C out/Release gfx_jni_headers

BUG=None
TEST=see above
R=cjhopman@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/278253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270319 0039d316-1c4b-4281-b951-d872f2087c98

Adds class ServiceWorkerScriptCacheMap and new ServiceWorkerVersion::Listener methods related to script caching progress. The listener methods are not yet invoked.

BUG=364318

Review URL: https://codereview.chromium.org/280423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270318 0039d316-1c4b-4281-b951-d872f2087c98

Update PIN browser test
Invalid PIN browser test

Review URL: https://codereview.chromium.org/273753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270317 0039d316-1c4b-4281-b951-d872f2087c98

Remove resources that have no other users.

Review URL: https://codereview.chromium.org/274863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270316 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/277623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270315 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270312 0039d316-1c4b-4281-b951-d872f2087c98

Fix ExtensionPopup::OnWidgetActivationChanged crashes.
(Issue 327776 shows GetWidget() may be NULL in rare cases)

Simply close extension popups on anchor window activation.
(the previous complex logic was just trying to achieve this)

Cleanup, remove USE_AURA preprocessor conditions.

Add BrowserActionInteractiveTest.DestroyHWNDDoesNotCrash.
Add some helper functions and do minor cleanup.

BUG=327776,320889,179786,106723
TEST=No Extension popup behavior changes. Extension popup bubbles close when clicking the browser window in Windows classic, glass, and Metro Ash. (no close on JS alerts from extension popups, no close on inspect popup, expected close on clicking away from the bubble, etc. on Win Classic/Aero/Ash, ChromeOS, Linux Desktop Aura).

Review URL: https://codereview.chromium.org/268143007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270310 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary for CAContext sharing (determined empirically, as
that API is undocumented).

BUG=312462

Review URL: https://codereview.chromium.org/279163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270309 0039d316-1c4b-4281-b951-d872f2087c98

Makes the client assign a valid position to incoming bookmarks if the
server has not populated the required fields.  This code should never be
triggered unless there is a bug in the server.  This risks reordering
users' bookmarks, but that's probably preferable to a crash.

Detects bookmarks that do not have valid position information during
database load.  If these corrupted bookmarks are detected, the entire
database is declared to be corrupt.  Sync will then re-download
all of the user's data, which should fix the problem.

BUG=367247

Review URL: https://codereview.chromium.org/278153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270308 0039d316-1c4b-4281-b951-d872f2087c98

Answers requires a session token to utilize the caching for Answers.
The token has a lifetime of one minute, and the expiration time gets
refreshed with each new query sent.

BUG=370192
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/276073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270307 0039d316-1c4b-4281-b951-d872f2087c98

Speculatively reverting as it may have caused the tree to break: http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20345/steps/compile/logs/stdio

> Reduce creation of ViewsDelegate
> 
> By consolidating override of OnBeforeWidgetInit that finds shell many
> of the places that were setting a viewsdelegate no longer need to.
> 
> Also, made AshTestHelper install a ViewsDelegate so that tests don't have.
> 
> Because of removed an include of views_delegate from ash_test_helper I had to update some includes.
> 
> BUG=none
> TEST=none
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/280863002

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/286753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345759

Review URL: https://codereview.chromium.org/287733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270304 0039d316-1c4b-4281-b951-d872f2087c98

It's still a very small timeout, but at least it'll be adjusted
(somewhat) for ASAN, and can be controlled via a command-line flag.

Also switch to using base::TimeDelta instead of int64_t micros.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/281893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270303 0039d316-1c4b-4281-b951-d872f2087c98

Browser tests append about:blank to the command line, which if
passed to a packaged app with write access will result in a file named
'about' being created in the current directory.

This change prevents about:blank being passed to packaged apps as a
launch parameter.

BUG=371925

Review URL: https://codereview.chromium.org/280703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270302 0039d316-1c4b-4281-b951-d872f2087c98

It hasn't been needed since the return-muted-audio-hack was removed in
r197701.

BUG=144683

Review URL: https://codereview.chromium.org/282943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/285623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=this is the test
NOTRY=True

Review URL: https://codereview.chromium.org/281793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270299 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270298 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173976:173990&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/289523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270297 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351553
TEST=existing unit tests

Review URL: https://codereview.chromium.org/280383009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270293 0039d316-1c4b-4281-b951-d872f2087c98

This pulls the new buildtools repo which will contain sha1 references to binaries we pull from google storage. This is so related Chromium projects can shared the same binaries without individually managing versions.

Review URL: https://codereview.chromium.org/281863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270292 0039d316-1c4b-4281-b951-d872f2087c98

By consolidating override of OnBeforeWidgetInit that finds shell many
of the places that were setting a viewsdelegate no longer need to.

Also, made AshTestHelper install a ViewsDelegate so that tests don't have.

Because of removed an include of views_delegate from ash_test_helper I had to update some includes.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/280863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270290 0039d316-1c4b-4281-b951-d872f2087c98