- 06 Nov, 2013 40 commits
-
-
abarth@chromium.org authored
We don't actually call this code yet, but we're going to need this code in order to demo a spinning cube. I've verified that this code draws a cube when called directly from mojo_shell. It should work when called from sample_app once we figure out how we want to expose GL to Mojo apps. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/61423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233309 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
Was not the cause of breakage. See bug for that. BUG=314916 R=benwells@chromium.org TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/60393005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233308 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
These images were not valid Android 9-patches as their borders did not correctly indicate the stretchable and static areas of each image. BUG=314199 R=dtrainor@chromium.org Review URL: https://codereview.chromium.org/60453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233307 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
BUG= R=rogerta@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/58183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233306 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
This triggered a DCHECK in https://codereview.chromium.org/51683002/ . BUG=166689 R=davidben@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/60193004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233305 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
In r232724, FakeURLFetcher went from being able to return only HTTP/200 or HTTP/500, to being able to return any arbitrary HttpResponseCode. However, the URLRequestStatus returned was hard coded to FAILURE for HTTP/5xx and SUCCESS for all other codes. This patch further modifies FakeURLFetcher to be able to return arbitrary URLRequestStatus values in addition to an HttpResponseCode. We no longer hard code the URLRequestStatus based on the HttpResponseCode being returned. It also updates all call sites that currently use FakeURLFetcher. R=achuith@chromium.org, ajwong@chromium.org, akalin@chromium.org, mattm@chromium.org, mmenke@chromium.org, nyquist@chromium.org, sky@chromium.org, tim@chromium.org, vitalybuka@chromium.org TBR=bengr, sergeyu BUG=313905 TEST=All existing tests pass trybots and waterfall Review URL: https://codereview.chromium.org/60923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233304 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
TBR=cpu@chromium.org, wiltzius@chromium.org, kmess@chromium.org, kareng@chromium.org, tapted@chromium.org BUG=314861 Review URL: https://codereview.chromium.org/62213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233302 0039d316-1c4b-4281-b951-d872f2087c98
-
maybelle@chromium.org authored
Added UMAs for: 1) How many times the button is shown 2) How many times the button is selected 3) How many times the YouTube button is selected 4) How many times a video is fullscreened 5) How many times a play ends in success or error 6) The % of a video that the user watched remotely BUG=284482 NOTRY=true Review URL: https://codereview.chromium.org/55193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233301 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=315754 R=dgrogan@chromium.org TBR=jhawkins@chromium.org Review URL: https://codereview.chromium.org/62373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233300 0039d316-1c4b-4281-b951-d872f2087c98
-
bajones@chromium.org authored
Reverting because this patch caused the GPU bots to begin failing. The failures may actually be legitimate, but we should determine if that's the case and fix the failing tests before landing this patch again > Align the interface of TestHarness defined in gpu_tests/webgl_conformance.py with that in third_party/webgl_conformance. > > BUG=314997 > NOTRY=true > > Review URL: https://codereview.chromium.org/58833003 TBR=jun.a.jiang@intel.com Review URL: https://codereview.chromium.org/62573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233299 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=315732 R=dgrogan@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/62213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233298 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
The original fix stopped working with the new style of dialogs, since they're not parented to the WebContents anymore but instead to its parent. It also turns out we don't need to watch out for transient windows, as they're now top level ones with their own HWND so clipping works through the OS and we don't need to do anything special. BUG=299224 R=ben@chromium.org Review URL: https://codereview.chromium.org/53153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233297 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=315677 R=dgrogan@chromium.org TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/61553005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233296 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
BUG=none R=kbr@chromium.org Review URL: https://codereview.chromium.org/59063007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233295 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
TBR=pshenoy Review URL: https://codereview.chromium.org/62493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233294 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
> content: Disable CommandBufferProxyImpl::Flush traces by default. > > BUG=309441 > > Review URL: https://codereview.chromium.org/33003003 The number of command buffer flushes with impl-side painting should now have been reduced to an amount that allows us to have these traces enabled by default. TBR=piman@chromium.org BUG=309441 Review URL: https://codereview.chromium.org/62093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233293 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=313521 R=jennyz@chromium.org TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/53403005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233292 0039d316-1c4b-4281-b951-d872f2087c98
-
dskelton@chromium.org authored
This CL updates the Quickoffice manifest files corresponding to the component extension update. This lifts the version to 32.93.1611.7 This update delivers a required UMA fix (crbug 313725) The corresponding copmonent extension update CL is here: https://chrome-internal-review.googlesource.com/#/c/147686/ BUG=315589 TEST=manual NOTRY=true Change-Id: I947852b0780d78a10e61b128ff4a8ad77893fe5d Review URL: https://codereview.chromium.org/62303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233291 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Disable ExtensionServiceTest.BlacklistedExtensionWillNotInstall and WillNotLoadBlacklistedExtensionsFromDirectory. They are crashing. BUG=315396 NOTRY=true Review URL: https://codereview.chromium.org/61463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233290 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
When initializing invalidator pass parameter that says that token is OAuth2 access token. Review URL: https://codereview.chromium.org/54353005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233289 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233288 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=303930 R=armansito@chromium.org Review URL: https://codereview.chromium.org/61183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233287 0039d316-1c4b-4281-b951-d872f2087c98
-
digit@chromium.org authored
See https://chromium.googlesource.com/chromium/deps/openssl/+/08086bd0f0dfbc08d121ccc6fbd27de9eaed55c7 BUG=298606 R=rsleevi@chromium.org, agl@chromium.org, wtc@chromium.org Review URL: https://codereview.chromium.org/60483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233286 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
R=bauerb@chromium.org Review URL: https://codereview.chromium.org/60263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233285 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
This CL introduces a global preprocessor macro to rename WebKit to blink. After this CL lands, we'll update the code to use the blink namespace incrementally. Once we've converted all the code, we'll remove the preprocessor macro. R=jamesr@chromium.org, jamesr BUG=295096 Review URL: https://codereview.chromium.org/24246009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233284 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
R=davemoore@chromium.org Review URL: https://codereview.chromium.org/60803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233283 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
R=davemoore@chromium.org Review URL: https://codereview.chromium.org/60013007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233282 0039d316-1c4b-4281-b951-d872f2087c98
-
vangelis@chromium.org authored
BUG=315221 NOTRY=true Review URL: https://codereview.chromium.org/60633006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233280 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=315193 TEST=None R=darin@chromium.org, darin Review URL: https://codereview.chromium.org/60863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233279 0039d316-1c4b-4281-b951-d872f2087c98
-
peter@chromium.org authored
NOTRY=true BUG=315548 R=bulach@chromium.org, peter@chromium.org Review URL: https://codereview.chromium.org/61853003 Patch from Miguel Garcia <miguelg@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233278 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
I also changed the token fetcher to return SERVICE_ERROR when we see an HTTP 400 + custom service error, versus INVALID_GAIA_CREDENTIALS. R=courage@chromium.org, droger@chromium.org, pavely@chromium.org, rlarocque@chromium.org TBR=rlarocque@chromium.org (/invalidation) BUG=314705 Review URL: https://codereview.chromium.org/57993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233277 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
BUG=171351 R=nona@chromium.org, satorux@chromium.org Review URL: https://codereview.chromium.org/50243005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233276 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=315594 R=zhaoqin@google.com Review URL: https://codereview.chromium.org/59383016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233275 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=315319 TEST=local bot run R=petermayo@chromium.org, rjkroege@chromium.org Review URL: https://codereview.chromium.org/59263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233274 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
The call to Activate() may trigger deletion. BUG=310746 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/60813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233273 0039d316-1c4b-4281-b951-d872f2087c98
-
fischman@chromium.org authored
BUG=314868 NOTRY=true Review URL: https://codereview.chromium.org/60423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233272 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
This CL adds a new handler to the python sync server so it can serve fake OAuth2 tokens to chrome. It is meant to be used for manual testing with the python sync server, using the workflow described below: - Build the "run_sync_testserver" target. - Run the python sync server: "out/Debug/run_sync_testserver --port=8010" - Launch chrome, sign in, and set up sync - Re-launch chrome with "--lso-url=http://127.0.0.1:8010" Chrome will now fetch OAuth2 tokens from the fake gaia server. You may change the fake OAuth2 token returned by the python sync server on the fly via the setfakeoauth2token handler like so: http://127.0.0.1:8010/setfakeoauth2token?response_code=200&expires_in=2400&request_token=rt&access_token=at&token_type=Bearer You may skip or include any of the query params. Params that are skipped will remain unchanged. BUG=none TEST=Build and run the "run_sync_testserver" target. Test the /o/oauth2/token and /setfakeoauth2token handlers. R=pavely@chromium.org Review URL: https://codereview.chromium.org/58093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233271 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
I'm changing the aura implementation to use Env::AddPreTargetListener. This way I don't need MessageLoop specific code and it'll work correctly for win on both metro and non-metro. BUG=315155 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/60443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233270 0039d316-1c4b-4281-b951-d872f2087c98
-
lushnikov@chromium.org authored
In case of undocked DevTools, we rely on NOTIFICATION_TAB_CLOSING to figure out the moment to destroy DevTools window. However, fast_unload_controller detaches WebContents from browser after receivign beforeunload ack, so we'll never destroy associated DevTools window. This patch triggers DevTools window destruction in result of WebContentsDestroyed callback on front_end WebContents. BUG=315502 R=pfeldman@chromium.org Review URL: https://codereview.chromium.org/61553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233269 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://settings/searchEngineseustas@chromium.org authored
Delay 'focus' event handler to ensure that 'input' event is processed first. BUG=263743 R=arv@chromium.org, tkent@chromium.org Review URL: https://codereview.chromium.org/39843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233268 0039d316-1c4b-4281-b951-d872f2087c98
-