- 12 Jul, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium e2fc7240. With Chromium commits locally applied on WPT: bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 1e9c7b68 "[Client hints] Enable ACHL persistence in content shell, refactor tests" 9c7e7252 "Add slotting for toast action buttons, alongside test scaffolding for future action testing." df1f56f3 "Use testdriver Action API in WPT pointerevent tests - Part 10" 19f78e3e "Reland: [shapedetection] Add some shapedetection tests" 2d2a3ba4 "Cross-scheme initiator should result in `Sec-Fetch-Site: cross-site`." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes cbiesinger@chromium.org: external/wpt/css/css-flexbox dgrogan@chromium.org: external/wpt/css/css-tables drott@chromium.org: external/wpt/css/css-text-decor drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts ecobos@igalia.com: external/wpt/css/css-display ericwilligers@chromium.org: external/wpt/css/motion foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/IndexedDB kojii@chromium.org: external/wpt/css/css-writing-modes mcasas@chromium.org: external/wpt/mediacapture-record msisov@igalia.com: external/wpt/webvtt mstensho@chromium.org: external/wpt/css/css-break external/wpt/css/css-multicol nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents rego@igalia.com: external/wpt/css/css-contain external/wpt/css/css-grid external/wpt/css/css-ui skobes@chromium.org: external/wpt/css/css-scroll-anchoring smcgruer@chromium.org: external/wpt/css/css-position xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ica0375ddafab0bfa5f5de35ac79f9734accfe768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699944Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676964}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97c4e24d49fa..0a985c42ae65 Created with: gclient setdep -r src-internal@0a985c42ae65 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: Ib889e656b1405ac01a1410f7b8b6a79701c9da60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700241Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676963}
-
Michael Spang authored
We'll try to activate this feature at thread creation time, and by sending a message to the browser process (only on OS_LINUX). The latter seems to only be needed on Chrome OS; we may be able to remove it in other Linux builds. Display priority does not typically work on Linux desktop, as we can't increase priority there. It does work and is enabled on Chrome OS, so change the feature to enabled by default on that platform to preserve the current behavior. This makes the feature flag work properly on Linux platforms. Bug: 937462 Change-Id: I0d8244cc32e216d2ebaafe295ead2bd438e58d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697536 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676962}
-
Alex Ilin authored
The information provided by this histogram is no longer useful. Bug: 975501 Change-Id: Ifa4a3e1285dc004ed1e454210a12b0820411ee25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697623Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676961}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1abe66f1c253..7c146083d510 git log 1abe66f1c253..7c146083d510 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 vapier@chromium.org [Typ] delete debug print statement Created with: gclient setdep -r src/third_party/catapult@7c146083d510 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:983432 TBR=zhanliang@google.com Change-Id: I93d0348df553865e74a670c3d13eb73fe600dd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700243Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676960}
-
Yuke Liao authored
This CL removes the dependency between use_clang_coverage and coverage_instrumentation_input_file so that the coverage feature can be turned off with a single change by setting use_clang_coverage to false. Change-Id: Iff4d4c3207fa82d81a5b6bcfe417cc955764096d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698670Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#676959}
-
Rayan Kanso authored
Add some more validations for `launchUrl` and `iconUrl`. Bug: 973844 Change-Id: I4ba3949046b459f754c1142821111356c1fe6447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689207 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676958}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d84fd2677c30..71b0b56a4914 git log d84fd2677c30..71b0b56a4914 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 ljusten@chromium.org usergroup_baseline: Expect kerberosd-exec in kerberosd Created with: gclient setdep -r src/third_party/chromite@71b0b56a4914 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id477db246b7d9f5e8a1be033e45091018a4c3608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699199Reviewed-by:
-
Shimi Zhang authored
This is a followup of http://crrev/c/1685837. See more at https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit Bug: 955171 Change-Id: Ic791b7a25c42494f83fb14308ce29549c55a2388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697525Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676956}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/91350f8..6453c2f Also re-enable shaders-with-invariance test. Recent ANGLE fixes allow conformance/glsl/misc/shaders-with-invariance.html to pass again on most configurations. Bug: 980675 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel Change-Id: I2abe0b1b0e2ac61488db3efdc00a9efe01376c6e Tbr: jmadill@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698992Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676955}
-
Jonathan Metzman authored
Only include parts that generate a PDF file that loads an empty XFA doc. Bug: 969811 Change-Id: Ifab808fd9f052fac80b7b86668f8e9278d0370de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659849 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676954}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/25378d6a29ce..2a4f36b14f03 git log 25378d6a29ce..2a4f36b14f03 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 geofflang@chromium.org GL: Work around Intel driver bug when clearing to zeros or ones. 2019-07-12 jmadill@chromium.org Revert "PRESUBMIT.py: Don't require "Bug:" for autoroller CLs." 2019-07-12 jonahr@google.com Fix copyTexImage2D corner case with same source/target image. Created with: gclient setdep -r src/third_party/angle@2a4f36b14f03 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ib0784cad05248bdb10226789742569fe4f86fe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699198Reviewed-by:
-
Victor Fei authored
Renamed content/test/accessibility_browser_test_utils.{h|cc} to content/public/accessibility_notification_waiter.{h|cc} Subsequently exposing AccessibilityNotificationWaiter to public. The reason behind the renaming of the file name is that accessibility_browser_test_utils.{h|cc} contained only one class, AccessibilityNotificationWaiter This change is required by CL:1667787 as its browser test from chrome/browser revealed a case for AccessibilityNotificationWaiter to be exposed. Bug: 928949 Change-Id: Ie3a59ae1e28113570bf79fe222dd0a8954a2f5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695064Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676952}
-
Becca Hughes authored
Add SeekTo action that seeks to a position from the beginning of the media. Also adds a ScrubTo action that may be supported by some media sessions. It is used for scrubbing on a position scrubber. The client should call ScrubTo while the user is scrubbing and then call SeekTo to release the scrub. BUG=977375 Change-Id: If926271b1aeebee7b3ef6529962213e1f2b0fde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693171 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676951}
-
jonross authored
BrowserStateBrowserControlsVisibilityDelegate has a timer which is used to ensure that the browser controls are visible for a minimum amount of time. However this causes a race condition for telemetry tests. The controls can become unlocked after telemetry has triggered a scroll. This leads to incidental compositor frame submissions which affect the performance. Pinpoint job with associated traces for the jank: https://pinpoint-dot-chromeperf.appspot.com/job/11a923eae40000 This change adds an Android specific flag to prevent locking the controls for this timed duration. Page loading will still cause locks. Though tests tend to wait for loading to complete already, so that lock will not affect the measurements TEST=Ran telemetry rendering.mobile scrolling stories Bug: 896264 Change-Id: Ia1b3451cf4e4b7170b3478861a4e91316ab3bee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696189Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#676950}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/82875de9a5fb..5c03085cff01 $ git log 82875de9a..5c03085cf --date=short --no-merges --format='%ad %ae %s' 2019-07-11 dschinazi Fix replacing connection IDs when initial crypters are in use 2019-07-11 fayang gfe-relnote: In QUIC, fix a misuse of largest_packet_peer_knows_is_acked when multiple packet number space is enabled. This is protected by existing FLAG_quic_supports_tls_handshake. 2019-07-11 dschinazi Fix QUIC version used when computing ALPN 2019-07-11 renjietang Remove static stream map as it's not used anymore. 2019-07-11 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_deprecate_queued_control_frames. 2019-07-10 renjietang Add more protection in QuicSpdySession::GetSpdyDataStream(). 2019-07-10 renjietang Move Qbone control streams out of static_stream_map. 2019-07-10 fayang gfe-relnote: In QUIC, do not add connection ID of packets with unknown connection ID and no version to time wait list, instead, send appropriate reset depending on the packets' sizes and drop them. Protected by gfe2_reloadable_flag_quic_reject_unprocessable_packets_statelessly. 2019-07-10 bnc Add QpackProgressiveDecoder-generated error message to quic_offline_decoder output. 2019-07-09 bnc Use QuicStream::transport_version() in QuicSpdySession. 2019-07-09 bnc Remove HttpDecoder::set_visitor(). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Idfb4a566e004c0fbc77ef56425cbcbd7884741cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699255 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#676949}
-
Lei Zhang authored
They were replaced in https://crrev.com/224520 in 2013. Change-Id: Ie95c2028b3935a0c3a20d244bc084519fd7b324e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699250Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676948}
-
Sergio Villar Senin authored
Document stores a timestamp for the moment it was created in order to compute the elapsed time whenever required. This looks like the perfect use case for base::ElapsedTimer. We wouldn't have to convert from double to int anymore. Actually we can go further and completely get rid of int downcasts as well and operate always in terms of base::TimeDelta. Document::ElapsedTime() returns a base::TimeDelta from now on and it was also moved to the private section as it isn't used from the outside. Bug: 979137 Change-Id: I2a3ede41fa947c400769ad21c515eefb857b7fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679755Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#676947}
-
Evan Stade authored
Bug: 268984 Change-Id: I0dfeb73a3ab21c69d225e69ce593eb6dcdf42843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696528Reviewed-by:
-
Devlin Cronin authored
Enable the getters and setters for the "action" API, including: action.getPopup action.setPopup action.getTitle action.setTitle action.getBadgeText action.setBadgeText action.getBadgeBackgroundColor action.setBadgeBackgroundColor Add a parameterized end-to-end test that exercises each of these for both the action API and browserAction and pageAction (where applicable - pageAction does not have all of these options). Bug: 893373 Change-Id: I9e93650a0228b7b3d696174992a6622c64bce2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684535 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676945}
-
Thomas Tangl authored
Bug: 975875 Change-Id: Ifdb6e5adca6db5b7387443bd9198934b4204dc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695288Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#676944}
-
Sergio Villar Senin authored
We were doing some unneccesary double <-> base::Time conversions. We can just store base::Time and then convert it to doubles for the histograms. Bug: 979137 Change-Id: Ifa93dd5d91ddfbfc3dd6eca50115bc9e402ce183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678483 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#676943}
-
David Maunder authored
Task IDs track navigations and relationships between navigations Bug: 946356 Change-Id: I409dde8f32703d07afffe3584cc6ad7e7160ee14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666613Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676942}
-
Mohammad Refaat authored
Bug: 982030 Change-Id: I194cf28f8299667756332529cd13d2e6a7c113a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689926Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#676941}
-
Antonio Gomes authored
media::MovingAverage::count_ is declared as uint64_t and its getter, count(), returns size_t. During the Onion soup'ing of some classes [1] that include this header (soon) from Blink, some compilers face issues [2]. [1] https://crrev.com/c/1698170/ [2] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8908195303894439840/+/steps/compile__with_patch_/0/stdout BUG=704136 R=dalecurtis@chromium.org Change-Id: I87773edec09f8ae95d6c099e12801148b128c218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698422Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#676940}
-
Charlie Andrews authored
This histogram will be important as we change the key in the metadata recorder from <name_hash> to a <name_hash, ID> tuple, allowing us to track spans that represent similar IDs but are different (e.g. two simultaneous frames loading pages in the same process). This will increase the number of unique items in the map and put pressure on the number of available slots. This histogram will help ensure that the metadata recorder doesn't overflow. Overflow would be bad because we would fail to add metadata to samples that should have it. Bug: 980308 Change-Id: I8df33963d7c5432131172ab81f715082554f1296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698884 Commit-Queue: Charlie Andrews <charliea@chromium.org> Auto-Submit: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676939}
-
Steve Kobes authored
This renames the fields in FrameRenderDataUpdate, and removes all references to "jank" in page_load_metrics except for the UMA and UKM metric names. Bug: 963474 Change-Id: Ie7a00d1962dce79d9aad79c677ad1f947d496a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667749Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#676938}
-
Rayan Kanso authored
Since developers can provide absolute/relative paths, the launch URL is resolved in the renderer then piped to the storage layer and the content provider. Bug: 1688788 Change-Id: I9d5f1cd2a945ea6664431f2efbfaf033ce2566c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688961Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Pavel Shmakov authored
https://android-review.googlesource.com/c/platform/frameworks/support/+/1009050 Bug: 981334 Change-Id: I76995c62e57103da14e7bc7d016ff160aec5b820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688835Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676936}
-
Kristyn Hamasaki authored
Modified unit tests for changes to CSSAgent. Bug: 977214 Change-Id: I5710a35cfa19955fa3ceccb11c0d5c098fdc498e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668310 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#676935}
-
David Maunder authored
Bug: 976390 Change-Id: I31c1e474f48c3e621172e69ed64d841f0e504106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665196 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#676934}
-
Andrii Sagaidak authored
When a user is searching for a flag and there is no matching results found, a message saying "No matching experiments" is displayed. This PR adds ability for screen readers to announce this message. Bug: 983365 Change-Id: I3fc458a105cefb9294954d1c4d6a91f5f77e0212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698993Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676933}
-
Cammie Smith Barnes authored
We change the name of the feature kSplitCacheByTopFrameOrigin to kSplitCacheByNetworkIsolationKey, in order to more accurately reflect how we are splitting the cache. Bug: 910708 Change-Id: I405451b37c5b18a2ef8a87dc66a34831b0695b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693284 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676932}
-
Yao Xiao authored
For network isolation key, rename the member initiating_frame_origin to frame_origin to align with Charlie's comments in https://chromium-review.googlesource.com/c/chromium/src/+/1665549/24/content/browser/loader/navigation_url_loader_impl.cc#1104 Bug: 910708 Change-Id: I7efba2f3e8c91c2356088ded3cdb367e6f37262f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698168Reviewed-by:
-
Lei Zhang authored
We want to keep these around to keep an eye on Cloud Print stats. Bug: 970002 Change-Id: Ieaede81e06dd910d5297b7b3fecfa37897f776d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699744 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#676930}
-
Juan Antonio Navarro Perez authored
None of the subclasses use the argument, so it always gets the default value of ''. Confusingly this is only passed to the LegacyPageTest constructor, whose first and only argument is about cache clearing [1] and has nothing to do with names of actions. There was possibly an API change at some point and this only works because of a happy accident. [1]: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/legacy_page_test.py?rcl=1abe66f1c25324dc3e5c2bf84f3d5c5aed105196&l=48 Bug: 921000 Change-Id: I6fd512cf410d639f7fbca2d51db0ce801e6f2bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699664 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#676929}
-
W. James MacLean authored
Temporarily disable this test while we figure out why it's flaky. TBR=mpearson@chromium.org TBR=alexmos@chromium.org Bug: 959924 Change-Id: I9e9d1422b9575bb09be4eb209b8913131f0b45ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699086 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#676928}
-
Yoav Weiss authored
We suspect that for privacy reasons we may have to remove support for the onload and onerror events of link rel=prefetch. This CL adds use counters that will help us see if we should expect compatibility hurdles on that front. Change-Id: I25a72120f2ed10ab364fdd506c4c8fd1ae566f17 Bug: 983541 Change-Id: I25a72120f2ed10ab364fdd506c4c8fd1ae566f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699674Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#676927}
-
Mohammad Refaat authored
Replaces methods of tab_test_util.h: GetCurrentTab() by GetCurrentWebState() GetNextTab() by GetNextWebState() GetTabAtIndexInCurrentMode(NSUInteger index) by GetWebStateAtIndexInCurrentMode(int index) Also with that chrome_test_util has a duplicate method GetCurrentWebState, i deleted it and replaced it usage by the one in tab_test_util.h Bug: 983291 Change-Id: I8242d5eae010ffb70d7757531906a55cac68972f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697438Reviewed-by:
-
rbpotter authored
When the zoom buttons are refocused with the keyboard, also ensure that the toolbar manager's keyboardNavigationActive boolean is reset to true. This value is cleared by Print Preview when focus returns to the Print Preview controls, to allow the zoom buttons to fade out. Bug: 982694 Change-Id: Ie4f9b00d48f44277271d43d415abedc51e0a3a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695813 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#676925}
-
