- 12 Apr, 2018 40 commits
-
-
Tetsui Ohkubo authored
This CL adds separator between notification center part and system tray part of UnifiedSystemTray. Screenshot: https://screenshot.googleplex.com/i2G4zquv1Gz UX spec: http://shortn/_U7QSE9nhSk TEST=manual BUG=828752 Change-Id: Ia1719faada97c0886b1a8d8526e5a8777f0dd222 Reviewed-on: https://chromium-review.googlesource.com/1006296Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#550383}
-
Sam McNally authored
QuickOffice needs to be able to enable fullscreen to support its present functionality. Implement the fullscreen-related WebContentsDelegate methods in MimeHandlerViewGuest by forwarding to the embedding WebContentsDelegate. Also override EmbedderFullscreenToggled to forward fullscreen exit reporting to the guest. Bug: 819761 Tbr: lazyboy@chromium.org Change-Id: Ia334104375cf8d92a0b45b92cb1b6e80a1e9c407 Reviewed-on: https://chromium-review.googlesource.com/1004394 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550382}
-
Matt Giuca authored
BrowserView's toolbar() will have null app_menu_button() and browser_actions() in hosted app windows, which could result in null dereferences in certain corner cases. This adds null checks where it's obviously safe to do so. A better fix would be to use toolbar_button_provider() to access the hosted app window's real app menu button and actions container, but that requires more careful consideration. Bug: 826596, 811982 Change-Id: Iea0a0ea3acffe5ed1016e61bd8ae2fe36971c79d Reviewed-on: https://chromium-review.googlesource.com/1010002Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#550381}
-
Christian Fremerey authored
This reverts commit cfec3da6. Reason for revert: Checking if flakiness is still happening on Mac ASAN bot Original change's description: > Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac > > TBR=chfremer@chromium.org > > Bug: 810321 > Change-Id: Ia12ba855ab9fb8e66c9d48c8e66cf91f76f72e08 > Reviewed-on: https://chromium-review.googlesource.com/908461 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535381} TBR=olka@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 810321 Change-Id: I6e021bca934428cf9c94a34d4f0e874c25868033 Reviewed-on: https://chromium-review.googlesource.com/1010842 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550380}
-
https://pdfium.googlesource.com/pdfium.git/+log/e6d4559a1b6c..9e625db795ca $ git log e6d4559a1..9e625db79 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 thestig Slightly simplify CPDF_Color::SetColorSpace(). 2018-04-12 tsepez Return pdfium::span<char> from ByteString::GetBuffer(). 2018-04-12 tsepez Return pdfium::span<wchar_t> from WideString::GetBuffer(). 2018-04-12 rharrison Tidy up types in CBC_PDF417HighLevelEncoder 2018-04-12 rharrison Fail decode if continuing to get insufficient size error 2018-04-12 thestig Make the input data to CPDF_ColorSpace::GetRGB() const. 2018-04-12 thestig Change CPDF{XFA}_Page::PageToDevice() to take a CFX_PointF. 2018-04-12 thestig Add return value to FPDF_DeviceToPage(). 2018-04-12 thestig Add CPDF_Page::DeviceToPage() / PageToDevice(). 2018-04-12 thestig Change some CPDFXFA_Page methods to take rects and points. 2018-04-12 thestig Change GetDisplayMatrix methods to take FX_RECT. 2018-04-12 thestig Make CFX_Font take FX_RECT out params by pointer. Created with: roll-dep src/third_party/pdfium BUG=chromium:802242 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iccdcc7755116bfb7f322ba62beb28cbb11f61bc1 Reviewed-on: https://chromium-review.googlesource.com/1011127 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550379}
-
Brandon Jones authored
This makes it easier to hit the 60FPS ideal while encouraging apps to use some antialiasing by default. Should be paired with a future CL that bumps the default buffer resolution slightly to help compensate for the quality loss. Bug: 832185 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7f089b4cde6c2d55d3965a4927d05a2a74520e2b Reviewed-on: https://chromium-review.googlesource.com/1010774Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550378}
-
Kevin Marshall authored
TBR=piman@chromium.org Bug: 832191 Change-Id: I8fae4dd27cad4dea281e8198fa878d9a8cab3a94 Reviewed-on: https://chromium-review.googlesource.com/1010981Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550377}
-
Toni Barzic authored
BUG=830945 Change-Id: I1d2481f3b2cdc874fb36a72e951b9602cc37b56e Reviewed-on: https://chromium-review.googlesource.com/1005441Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#550376}
-
Kenneth Russell authored
virtual/modern-media-controls/media/controls/modern/ tap-to-hide-controls.html fast/forms/search/search-appearance-basic.html Tbr: steimel@chromium.org, wangxianzhu@chromium.org Bug: 831720, 832274 Change-Id: I301a309a7469d4cd54beaddb2c7f7a4727510ecb Reviewed-on: https://chromium-review.googlesource.com/1011044 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550375}
-
Katie D authored
This bug was not user-facing, but caused an error to be logged to the console. Bug: 832196 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8be6a1515b8f2344e39d53bb3fe90bb04bce4c54 Reviewed-on: https://chromium-review.googlesource.com/1010704Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550374}
-
Chris Blume authored
This patch introduces a child allocator for surface IDs. This allows a renderer to create a surface as it needs (such as when creating the Cast dialog), as opposed to request a surface from the parent. BUG=789259 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I36acec47f083dffd029aba56431eda720579e63e Reviewed-on: https://chromium-review.googlesource.com/861643 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550373}
-
Anita Woodruff authored
- Now when the '--enable-features=NotificationsWithMojo' flag is set, ServiceWorkerRegistration.getNotifications() will be routed through the notification mojo service, instead of via legacy IPC. R=peter@chromium.org Bug: 796991 Change-Id: Ie3d24ae753238da90c316187a4f2b84b4b52d531 Reviewed-on: https://chromium-review.googlesource.com/976222 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550372}
-
Zach Helfinstein authored
Replacing placeholder sounds taken from ChromeVox. Bug: 829004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3aec21ab109b6afafab677b97d11de0df4fc5bfb Reviewed-on: https://chromium-review.googlesource.com/999031 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Change-Id: I55b37b0f0578a22bb1812768658af31f6235da8d Reviewed-on: https://chromium-review.googlesource.com/1007969 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550370}
-
Yue Li authored
- Add AssistantSettingsManager mojom API. - The AssistantSettingsManager will call AssistantManagerService to communicates with internal assistant manager that talks to the server. - The AssistantSettingsManager will use internal utils to construct and unwrap internal proto strings. Bug: 819782 Change-Id: I420d8e70543d665587bd2dfdc803afae9d21a310 Reviewed-on: https://chromium-review.googlesource.com/953654 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#550369}
-
Sunny Sachanandani authored
R=piman Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3af8cc444762d72dfe0aac7ab97414c6fa7f402f Reviewed-on: https://chromium-review.googlesource.com/1009162Reviewed-by:
-
Varun Mohan authored
In the past, there was a 10 minute protection from discarding for tabs that went out of focus. With the move to add proactive discarding, this logic is no longer necessary. This is because the proactive discarding logic will handle the timing. A user visible effect of this CL is that when they are under memory pressure, their tabs can be discarded as soon as they become non-visible. Bug: 775644 Change-Id: I9a2fd8159093fbd0ceb7018246d9d6c002383e0d Reviewed-on: https://chromium-review.googlesource.com/1008243Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Varun Mohan <varunmohan@google.com> Cr-Commit-Position: refs/heads/master@{#550367}
-
Nico Weber authored
TBR=hans@chromium.org Bug: 832211 Change-Id: I48e93524b532b33430219ccfb9758e940238a43a Reviewed-on: https://chromium-review.googlesource.com/1010533Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550366}
-
Alex Sakhartchouk authored
Bug: 831781 Test: run webgl pages, observe no corruption Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6094d6b4ba5e8b026646197600d30b44ab1ff132 Reviewed-on: https://chromium-review.googlesource.com/1010474Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#550365}
-
Daniel Murphy authored
Bug: 716490 Change-Id: I94e6faf11937273273d1e3e48b661a5fe6c700b7 Reviewed-on: https://chromium-review.googlesource.com/985232Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#550364}
-
Oksana Zhuravlova authored
This change also converts the minimum necessary amount of C++ code to pass objects of base::Value by value instead of std::unique_ptr. Bug: 646113,799482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I3690962bbce3a7e630827736d175791ce0fd53b6 Reviewed-on: https://chromium-review.googlesource.com/1008275Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#550363}
-
Nate Fischer authored
This modifies SupportLibWebViewContentsClientAdapter to better support resetting WebViewClient, without re-instantiating the adapter object, and lets SupportLibWebViewContentsClientAdapter be 1:1 with WebViewContentsClientAdapter. Previously, we would re-instantiate SupportLibWebViewContentsClientAdapter each time we re-set WebViewClient. However, this isn't necessary, since we need only associate the new WebViewClient with the same SupportLibWebViewContentsClientAdapter. This will be helpful if we ever add WebChromeClientCompat, since we can re-set either WebViewClient/WebChromeClient without re-instantiating the entire object. Bug: 781764 Test: Manual Change-Id: Id4a099a38fda2ecc4aeed1f68f83c158f85efef2 Reviewed-on: https://chromium-review.googlesource.com/1006184Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550362}
-
Maggie Chen authored
The purpose of this code change is to collect DX12 and Vulkan information on users' Windows systems so that we know which one is more popular. This DX12 vs Vulkan statistcs on Windows will be very helpfull in the software design decision making. During BrowserThreadsStarted, a 15 second delayed task will be posted to start an un-sandboxed GPU process. This process will determin if DX12 and Vulkan can be supported in the Windows system. Two new UMA_HISTOGRAM_BOOLEAN, GPU.SupportsDX12 and GPU.SupportsVulkan, are added to record this result. DX12 support is determined by the success in D3D12CreateDevice() and Vulkan support is determined by the success in vkEnumeratePhysicalDevices(). This information is also added to the GPU info. Now "about:gpu" on Windows system will show if DX12 and Vulkan are supported. All the added functions will be running on the Windows platforms only. BUG=775983 TEST=manual,Chrome://histograms R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icf52cebaf89ea5f41d364ea147f7fa74d1c6331b Reviewed-on: https://chromium-review.googlesource.com/996594 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
Adrienne Walker authored
This adds a limit per raster type of how many outstanding speculative (i.e. non-required) tasks can be in flight at any given time. Not only will the task graph not schedule more than this limit, but it will also wait for these tasks to have been completed on the gpu service side as well. Bug: 816571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff2cbc5ecaabafa62db6a06c0e8540156bfbe22d Reviewed-on: https://chromium-review.googlesource.com/998682 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#550360}
-
Victor Costan authored
This roll includes 1324e2d706d739217cceae361259a5cc01d1ff41 which fixes the undefiend behavior breaking the Linux CFI bot introduced in fe402c27790ff1cc9a7e17c5d0aea4ebe7fd8a71. https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7e5f90d3780d..b640d8743d85 $ git log 7e5f90d37..b640d8743 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 costan Remove multiple inheritance from "unintesting call" mock classes. 2018-04-11 misterg ...merging 2018-04-11 misterg merging 2018-04-11 misterg Upstream cl/192179348 2018-04-11 misterg merging 2018-04-11 misterg ..and this should be it 2018-04-11 misterg more 2018-04-11 misterg pizza work, cont 2018-04-11 misterg osx pizzas, cont 2018-04-11 misterg fixing osx pizza 2018-04-10 misterg merging 2018-04-10 misterg merging 2018-04-10 misterg merging 2018-04-10 misterg RE-Doing the merge, this time with gcc on mac in the PR so I can catch errors before merging the PR 2018-04-10 gennadiycivil Include gcc on mac into PR matrix 2018-04-09 gennadiycivil Revert "gmock actions 2" 2018-04-09 misterg ... and this 2018-04-09 misterg this should be it 2018-04-09 misterg yet more 2018-04-09 misterg formatting 2018-04-09 misterg tuning 2018-04-09 misterg tuning 2018-04-09 misterg more 2018-04-09 misterg cont 2018-04-09 misterg msvc 2018-04-09 misterg more msvc 2018-04-09 misterg msvc 14 2018-04-09 misterg testing msvc again 2018-04-09 misterg More msvc 14 2018-04-09 misterg And also silence for MSVS14 2018-04-09 misterg preproc syntax ( I can never remember it) 2018-04-09 misterg syntax 2018-04-09 misterg cont. 2018-04-09 misterg continued 2018-04-06 costan Sync gmock-generated-nice-strict.h.pump with gmock-generated-nice-strict.h. 2018-04-06 misterg more mcvs fixing 2018-04-06 misterg linkage, fixing MSVC 2018-04-06 misterg fixing MSVC 2018-04-06 misterg more warnings 2018-04-06 misterg more warnings 2018-04-06 misterg more MSVC warnings 2018-04-06 misterg warnings 2018-04-06 misterg cont - 2 2018-04-06 misterg cont 2018-04-06 misterg more warnings 2018-04-06 misterg deal with MSVC warn, cont 1 2018-04-06 misterg Cont. deal with MCVS warnings 2018-04-06 misterg Deal with MCVS warnings 2018-04-06 misterg merging gmock-actions 2 2018-04-05 misterg Merging gMock, 2 Created with: roll-dep src/third_party/googletest/src Bug: 830017, 829773 Change-Id: I2a20f5e12c1b0475e15c98251f9c3100247e14b9 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1004440Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550359}
-
Joel Einbinder authored
The contentEncoded bit would sometimes be lost if a revision was added before the original content was recieved. The ImageView was not waiting long enough before calculating the image size. Missing content failures were not being detected. Change-Id: I6bf7069fe7ee185b24be60ebceb023613af76a99 Reviewed-on: https://chromium-review.googlesource.com/1008864Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#550358}
-
Filip Gorski authored
* Fetches favicons for contextual suggestions using the Image Id provided by the ExploreService Bug: 829103 Change-Id: Icb670b3df670039f78c7336ae7050b86f50ef07c Reviewed-on: https://chromium-review.googlesource.com/1010887Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550357}
-
Yuwei Huang authored
We have got approval to turn on the fullscreen exit UI at 100% for Canary and Dev, but the Finch experiment has too much overhead for us, so it's easier to just turn it on with a CL. Bug: 829606 Change-Id: I3ad3880361e66aaef08a07646dc81f0dbda0670a Reviewed-on: https://chromium-review.googlesource.com/1010966Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550356}
-
Yuwei Huang authored
We got some crash reports happened when the user tries to send a feedback during a session. Looks like their host os is OTHER, which is not mapped to a string and crashes the app. It's unsure when will the host OS be OTHER. Let's just add back the mapping for now. Bug: 831956 Change-Id: I2bf285955a266ab61aae4dfc525b5185546c9109 Reviewed-on: https://chromium-review.googlesource.com/1010969Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550355}
-
Andrew Grieve authored
* Removes .equals() and .hashCode() (unused in non-test code) * Coalesce version checks in decode() * Move mTag field from generated to Union base class. diagnose_bloat.py --enable-chrome-android-internal shows: -262 entries methods -33,740 bytes main dex size bytes main dex size * Largest single symbol savings from equals(): -428 * Largest single symbol savings from hashCode(): -299 * Largest single symbol savings from decode(): -112 Bug: 828403 Change-Id: Iad41ec6baf0101fd5080375f3a0e65b561d90395 Reviewed-on: https://chromium-review.googlesource.com/1005031 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550354}
-
Troy Hildebrandt authored
When tapping the microphone button on the search widget on the home screen, #isVoiceSearchEnabled would return false because we were trying to get WindowAndroid from the Tab, which doesn't exist in this case. We now rely on getting the WindowAndroid from the LocationBar so the two agree. What happened as a result is that recording metrics would fail almost every startup, if the call to RecordHistogram.record* was called before native was initialized, so CachedMetrics is used now. Bug: 831985 Change-Id: I34c4dbe46afd42c1d793e737a48c45dc3430701d Reviewed-on: https://chromium-review.googlesource.com/1010772 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550353}
-
Jason Chase authored
This CL adds support for origin trials to follow the implied_by relationships defined for the runtime flags. The implied_by relationship only applies if both of the runtime flags are configured with an origin trial name. The implied by relationship is actually implemented in two ways: 1) The generated OriginTrials::<name>Enabled methods will now check the defined trial, and any implied by trials 2) When a token enables a trial, any implied trials are also enabled at the same time. Approach (1) doesn't handle the case of dynamically added tokens. In theory, approach (2) makes (1) unnecessary. Keeping (1) and (2) for now to ensure all cases are handled. Bug: 831346 Change-Id: Ibab588f11c69d31f1acd9e599ee917fb036dd32b Reviewed-on: https://chromium-review.googlesource.com/1008850Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#550352}
-
Zhongyi Shi authored
update flags https://chromium-review.googlesource.com/c/chromium/src/+/1006069 Refactor QuicConnection::Set(En|De)crypter and related methods These SetEncrypter/SetDecrypter methods took in a raw pointer to a QuicEncrypter/QuicDecrypter, and this changes them to take std::unique_ptrs instead. Merge internal change: 191952319 https://chromium-review.googlesource.com/c/chromium/src/+/1006074 [fix-write-blocked] Enable flag to fix QUIC write-blocked CHECK failures. n/a (Quartc change only) Merge internal change: 191932760 https://chromium-review.googlesource.com/c/chromium/src/+/1006016 Implement AES packet protection for initial encryption QUIC TLS crypto changes protected by FLAGS_quic_supports_tls_handshake Merge internal change: 191923711 https://chromium-review.googlesource.com/c/chromium/src/+/1005990 Call QuicConnection::WriteIfNotBlocked instead of OnCanWrite() from WriteAndBundleAcksIfNotBlocked to avoid writing another packet when the writer is already blocked. Protected by FLAGS_quic_reloadable_flag_quic_is_write_blocked. Merge internal change: 191910257 https://chromium-review.googlesource.com/c/chromium/src/+/1006014 Change the most common DLOG(INFO)'s in quic_stream.cc to DVLOG(1). n/a (Debug logging only) Merge internal change: 191904604 https://chromium-review.googlesource.com/c/chromium/src/+/1005891 Remove unused socket_receive_buffer from QuicConfig. n/a (Remove unused code) Merge internal change: 191904598 https://chromium-review.googlesource.com/c/chromium/src/+/1005879 [fix-iw10] Set the quic flag to enable IW10 to work with BBR. n/a (quartc code only) Merge internal change: 191834057 https://chromium-review.googlesource.com/c/chromium/src/+/1005845 [quic-expr] Quartc BBR options for number of RTTs in startup and initial cwnd. Adds QuartcBbrOptions for all the initial congestion window and RTT options. Quartc probably won't use most of these, but it's easier to add them all now. Sets QuartcConnection to use IW10 and 1RTT options. These options reduce the aggressiveness of the BBR startup phase. With IW10, the initial congestion window is reduced from its default size of 30 packets to 10 packets, meaning that BBR won't send as many packets in its initial burst. With 1RTT, BBR will only continue to send at startup rates for 1 RTT with no gains before it exits, rather than the default of 3 RTTs with no gains before exiting startup. n/a (Quartc change only) Merge internal change: 191659031 https://chromium-review.googlesource.com/c/chromium/src/+/1005809 Deflake NegotiatedInitialCongestionWindow by checking the value of the initial congestion window. n/a (Test only)` Merge internal change: 191635217 https://chromium-review.googlesource.com/c/chromium/src/+/1005836 Do not sending PROBING retransmissions when QUIC pipe-filling is enabled unless when there are unacked handshake packets. Merge internal change: 191615575 https://chromium-review.googlesource.com/c/chromium/src/+/1005449 Add GetPacketNumberLength, GetConnectionIdLength and IncludeVersionInHeader to QuicPacketCreator. n/a (refactor only) Merge internal change: 191583017 https://chromium-review.googlesource.com/c/chromium/src/+/1005448 Set the QUIC initial congestion window based on connection options in QuicSentPacketManager, rather than TcpCubicSenderBytes. Protected by FLAGS_quic_reloadable_flag_quic_unified_iw_options. Merge internal change: 191490391 https://chromium-review.googlesource.com/c/chromium/src/+/1005626 Add IsValidStatelessResetToken and OnIetfStatelessResetPacket to QuicFramerVisitorInterface. Add IsValidStatelessResetToken to QuicConnectionVisitorInterface. n/a (add unused code) Merge internal change: 191478833 https://chromium-review.googlesource.com/c/chromium/src/+/1005394 Change net/quic/quartc to use QuicMemSliceSpan. Merge internal change: 191341992 relnote: n/a (Quartc only) https: //chromium-review.googlesource.com/c/chromium/src/+/1005357 Change-Id: I444d6a8be23235abcab2a9d24fadc6d6e5e2e0f8 Reviewed-on: https://chromium-review.googlesource.com/1005563 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#550351}
-
Moe Ahmadi authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I723f6632b3708f86e25158f4065cb5d70590ffe6 Reviewed-on: https://chromium-review.googlesource.com/1010463Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550350}
-
Danyao Wang authored
Original review: https://chromium-review.googlesource.com/c/chromium/src/+/1006854 Using wpt-import in Chromium f7fd2525. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15475 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=danyao No-Export: true Change-Id: I6c70ccb059be8b9dbd6ca037176a39e79707eac2 Reviewed-on: https://chromium-review.googlesource.com/1010838Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550349}
-
rbpotter authored
Bug: 821485, 822505 Change-Id: I33f117cd64726a475ef2df220f9a8089fd5e9312 Reviewed-on: https://chromium-review.googlesource.com/1000408Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550348}
-
Christopher Cameron authored
Add functions to RWHNSViewClient to forward keyboard and Ime events. The messages that are forwarded during a keyboard event are forwarded to a RenderWidgetHost that is cached at the beginning of the event. This could potentially be different from the RenderWidgetHost to which other messages are forwarded. To ensure that behavior is preserved, bracket the lifetime of -[RenderWidgetHostViewCocoa keyEvent:] with calls that cause the RenderWidgetHostViewMac on the other side to save off the target RenderWidgetHost until the end of the function. Bug: 821651 Change-Id: I805aa282b05909604c62a12e4e82133c6aa0e554 Reviewed-on: https://chromium-review.googlesource.com/1005789Reviewed-by:
-
Kim Paulhamus authored
Since the current implementation doesn't support non-U2F authenticators, all non-U2F scenarios can be immediately denied with NotSupportedError. This CL also moves handling for empty allowCredentials (part of the aforementioned errors) out of u2f_sign, since u2f_sign should never be called with empty allowCredentials. Bug: 819256 Change-Id: I991949919fbe7a5e1e9c123ee750d80c3d25e9c3 Reviewed-on: https://chromium-review.googlesource.com/1006482 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550346}
-
Sammie Quon authored
1) Fix pin keyboard shifting when going from message to no message. 2) Fix loosing focus on input when clicking disabled backspace - it will also not loose focus anymore if anywhere on the PIN keyboard is clicked. 3) Fix no focus on input when directly going to lockscreen (chrome:settings/lockScreen). Test: manual Bug: 828450, 827948, 827126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id64b80287c6667a419f186cf67d7b77c62cf02d1 Reviewed-on: https://chromium-review.googlesource.com/1006262 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Eric Lawrence authored
The SameSite cookie specification calls for ignoring the SameSite attribute if the value is empty or unrecognized. Previously, Chrome would refuse to create a cookie with an empty or unrecognized SameSite attribute value. Bug: 635882 Test: net_unittests Change-Id: I429058d6f97db107307f9affb99bf96f4e175a2a Reviewed-on: https://chromium-review.googlesource.com/1007866 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#550344}
-
