GitLab

Review URL: https://codereview.chromium.org/1099713005

Cr-Commit-Position: refs/heads/master@{#326863}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1102573006

Cr-Commit-Position: refs/heads/master@{#326862}

Adds a gyp and gn build target: base_junit_tests
Adds test suite: base_junit_tests

Depends on https://codereview.chromium.org/1048153002/
BUG=448030,472152

Review URL: https://codereview.chromium.org/1051343002

Cr-Commit-Position: refs/heads/master@{#326861}

Review URL: https://codereview.chromium.org/1100803004

Cr-Commit-Position: refs/heads/master@{#326860}

To fix PresentationServiceImplTest.DefaultSessionStartReset timeout
in  Android Tests (dbg).

TEST=git cl try + linux_android_dbg_ng
----

Added DefaultSessionStartContext for coordinating sending default
session back to PresentationDispatcher.

When ListenForDefaultSessionStart is called, DefaultSessionStartContext
will be installed on PresentationServiceImpl. When both the default
session and PresentationDispatcher's callback are available, the
callback will be invoked with the session.

On Reset(), if a callback is available, it will be invoked with null.
Changed PresentationDispatcher to not update Blink in that case.

Also, PSImpl now keeps track of the corresponding RFH's ID instead of
RFH* since most of the time we only need to use the ID.

Changed PresentationServiceDelegate's Add/RemoveObserver interface,
since the PresentationServiceDelegate need to be able to correlate
an Observer with a RFH. (at most 1 per RFH, as it stands today).

Added OnDefaultPresentationStarted to
PresentationServiceDelegate::Observer interface and implemented it
in PresentationServiceImpl.

Added tests in PresentationServiceImpl.

BUG=459001

Review URL: https://codereview.chromium.org/1055053004

Cr-Commit-Position: refs/heads/master@{#326859}

WebRTC 9068:9084
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/51fb6e4..324d972

Libjingle 9069:9081
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/c37efc9..d8bca77

TBR=
BUG=

Review URL: https://codereview.chromium.org/1051353006

Cr-Commit-Position: refs/heads/master@{#326858}

BUG=478428
TEST=Hover mouse over Back and Close buttons in new GAIA login (for Add person,
Create new account, etc).  Cursor should change to pointer hand.

Review URL: https://codereview.chromium.org/1097053008

Cr-Commit-Position: refs/heads/master@{#326857}

Most importantly, this passes cflags_cc to the C++ compiler.

This fixes some flag differences with the GYP build, especially when running on 64 bit.

It disables a TLS test on static debug x64 builds which also fails in GYP. This configuration is not run on the bots but is the standard GN Windows build.

BUG=251251
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1062743005

Cr-Commit-Position: refs/heads/master@{#326856}

This adds a new top level trace span for work resulting from I/O
notifications. Currently I/O triggered work may not show up at all in
tracing (unlike work resulting from PostTask).

BUG=none
TEST=chrome://tracing on Chromebook Pixel. Input thread shows I/O spans
  rather than showing nothing.

Review URL: https://codereview.chromium.org/1097283004

Cr-Commit-Position: refs/heads/master@{#326855}

This patch includes the changes that enables
<webview>.addContentScript/removeContentScript API  work on WebUI.

-- Introduce WebUIURLFetcherGroup to manage a set of
WebUIURLFetcher and response after all fetches are
done.
-- Move WebUIURLFetcher from web_view_internal_api.cc to a
separate file.
-- A refactoring is done in UserScriptLoader and
ExtensionUserScriptLoader. Since webUI has different ways
to load user script as extension does, so I revert some old
refactoring in ExtensionUserScriptLoader and move all the
loading related code from UserScriptLoader to
ExtensionUserScriptLoader.

This is the second patch in a series of patches:
1) Implement <webview>.addContentScript/removeContentScript API [1] (https://codereview.chromium.org/959413003)
2) Implement <webview>.addContentScript/removeContentScript API [2] (https://codereview.chromium.org/1056533002)
3) Implement <webview>.addContentScript/removeContentScript API [3] (https://codereview.chromium.org/1058113002)

BUG=461052

Review URL: https://codereview.chromium.org/1056533002

Cr-Commit-Position: refs/heads/master@{#326854}

This CL provides a cleaner way to report session state changes with the following:
1. Removes onError() callback on ClientSession Handler.  Instead, if an error
   is encountered before the session connects, onConnectionFailed() will be called,
   and similarly, onDisconnected() will be called for errors encountered after
   a session is connected.
2. Removes the sessionStateChanged event on clientSession, so session state
   are reported consistently through the ClientSession.EventHandler interface.

BUG=477522

Review URL: https://codereview.chromium.org/1093373005

Cr-Commit-Position: refs/heads/master@{#326853}

The tests weren't actually destroying the adapter when they claimed.
As a result, the final read/rewind call could happen on the "network"
thread between starting the destroy task in Shutdown and actually
tearing down the network thread, at which point the
TestUploadDataStreamHandler network thread pointer is NULL, resulting in
a crash.

The fix is just to destroy the adapters when they should be, at which
point there should be no messages pending on the network thread.  May be
worth revising how thread checks are done if more tests are added.

BUG=480623

Review URL: https://codereview.chromium.org/1098253005

Cr-Commit-Position: refs/heads/master@{#326852}

As discussed in https://codereview.chromium.org/1070433002/, this CL
allows arbitrary scale factors, which works because chromium uses the
resource most closely matching the scale factor (e.g. 1x for 1.25x,
but 2x for 1.9x) and scales it.

BUG=143619

Review URL: https://codereview.chromium.org/1078423002

Cr-Commit-Position: refs/heads/master@{#326851}

nacl_io::Path::Part returns a temporary string. The code that hashes the path
to create a phony ino calls this, and stashes a pointer to the memory.

The real issue with nacl_io_demo is that the quota was too low. I've upped it
to 5 megs now.

BUG=478230
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/1062463004

Cr-Commit-Position: refs/heads/master@{#326850}

BUG=480919

Review URL: https://codereview.chromium.org/1102063002

Cr-Commit-Position: refs/heads/master@{#326849}

BUG=451073

Review URL: https://codereview.chromium.org/929353002

Cr-Commit-Position: refs/heads/master@{#326848}

And renames one to better indicate what it is expected to do.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1052103005

Cr-Commit-Position: refs/heads/master@{#326847}

This CL only implements non-ChromeOS features; AboutSigninInterals and the AccountReconcilor. ChromeOS features will come later, as they require more support. This CL also removes the ReconcilorSource as a parameter to ListAccounts. Changes the observed cookie from the LSID cookie to the APISID cookie at nickk@'s suggestion.

Design doc: https://docs.google.com/document/d/1FfmSS7M87L_2tkVuHO3NuruborFm6qHXe2VdktZg-HQ/

BUG=466799, 463611, 471210

Review URL: https://codereview.chromium.org/1075273002

Cr-Commit-Position: refs/heads/master@{#326846}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

NOTRY=true
BUG=417463

Review URL: https://codereview.chromium.org/1101013002

Cr-Commit-Position: refs/heads/master@{#326845}

Also add the first parts of the Search settings UI in MD-settings, namely the 'default search engine' dropdown. Follow-up CLs will fill in the remaining functionality.

(Disabling presubmit because it requires a manual confirmation that permission_message.h looks ok. I confirmed this.)

BUG=479359
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1096143003

Cr-Commit-Position: refs/heads/master@{#326844}

These were removed in https://codereview.chromium.org/969973002
Please see that CL for why.

Review URL: https://codereview.chromium.org/1059803003

Cr-Commit-Position: refs/heads/master@{#326843}

Changes Client destructor to be override instead of virtual to conform with chromium-style.

BUG=417463

Review URL: https://codereview.chromium.org/1108613002

Cr-Commit-Position: refs/heads/master@{#326842}

- pick up the decsription attribute in buttons
- add the help attribute in sliders

TEST=chromevox_tests --gtest_filter=OutputE2ETest.Audio

Review URL: https://codereview.chromium.org/1099023005

Cr-Commit-Position: refs/heads/master@{#326841}

A flaky test was added in https://codereview.chromium.org/1058003004/
that involved modifying the root cert cache, which did not happen
reliably. This changes and simplifies the test to use two different
servers on the same host, so the test passes since it relies on
same-host not same-origin, but avoids modifying any caches.

R=rsleevi@chromium.org
BUG=480667

Review URL: https://codereview.chromium.org/1080593006

Cr-Commit-Position: refs/heads/master@{#326840}

BUG=466848

Review URL: https://codereview.chromium.org/1090323003

Cr-Commit-Position: refs/heads/master@{#326839}

Remove IsSystemLibrary() and its list of NDK-exposed system libraries.
It is incomplete and not completable.

Replace it with a flag argument to LoadLibrary() that is true if the
library load is prompted by either preloads or dependencies.  Assume
the library being loaded is a system library and load through dlopen()
when the flag is true.

BUG=479220

Review URL: https://codereview.chromium.org/1105893002

Cr-Commit-Position: refs/heads/master@{#326838}

It is possible that an input device has been removed from the system
right after grabbing the device ids using InputDevice.getDeviceIds().
This CL adds checks in TouchDevice.java to avoid NPEs in such cases.

BUG=480619

Review URL: https://codereview.chromium.org/1087263004

Cr-Commit-Position: refs/heads/master@{#326837}

Imports:

- https://android-review.googlesource.com/#/c/147620/
    Exit normally when packing relocs saves no space

- https://android-review.googlesource.com/#/c/147745/
    Always use signed leb128 encoding

- https://android-review.googlesource.com/#/c/148073/
    Adjust DT_VERSYM/VERNEED/VERDEF dynamic sections

BUG=385553

Review URL: https://codereview.chromium.org/1099343004

Cr-Commit-Position: refs/heads/master@{#326836}

This CL also instruments the function to better understand which edge case
triggers the issue in the first place.

BUG=471586

Review URL: https://codereview.chromium.org/1054113004

Cr-Commit-Position: refs/heads/master@{#326835}

The Launcher_MinimzeTask user action is recorded when the user activates a
shelf icon causing a window to be minimized.

TEST=ShelfViewTest.Launcher_MinimizeTaskIsRecordedWhenWindowIsMinimized

BUG=471358

Review URL: https://codereview.chromium.org/1098193003

Cr-Commit-Position: refs/heads/master@{#326834}

Encapsulate task queue selector inside the scheduler helper to avoid
clients changing task queue states in an uncontrolled way.
This will be needed by the upcoming shutdown task queue.

No functional changes.

BUG=463143

Review URL: https://codereview.chromium.org/1103853004

Cr-Commit-Position: refs/heads/master@{#326833}

BUG=466848

Review URL: https://codereview.chromium.org/1092963004

Cr-Commit-Position: refs/heads/master@{#326832}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1052683004

Cr-Commit-Position: refs/heads/master@{#326831}

Remove this ducplication, and let the "run_at" property to refer
extensionTypes.RunAt.

The CL that fixed the complier bug for JSON is:
https://codereview.chromium.org/1100333006

BUG=477457

Review URL: https://codereview.chromium.org/1085033006

Cr-Commit-Position: refs/heads/master@{#326830}

There is delay between suggest apps dialog restoring focus to file manager
window (which happens in BaseDialog.hide) and suggest dialog reporting
result and being marked not shown (which happens in onHide callback).
If another suggest apps dialog is started during that time, it should
fail silently instead of reporting error. Also, any widget container
state set by the new dialog should be reset.

BUG=477106
TEST=1. Open suggest apps dialog for a file.
2. Cancel the dialog by pressing 'Esc'.
3. Try to open an new dialog immediately by clicking 'Enter'
(the list entry for the initial file should have focus at this point)
4. Verify no error is shown.
5. Verify subsequent attempts to open the dialog succeed (after a second
or two)

Review URL: https://codereview.chromium.org/1082423003

Cr-Commit-Position: refs/heads/master@{#326829}

Review URL: https://codereview.chromium.org/1081803005

Cr-Commit-Position: refs/heads/master@{#326828}

I subtly broke this in https://codereview.chromium.org/1071803003. Due
to a cut and paste error, we were never updating |delta|.

Consequently, I missed a regression due to my property trees skipping:
I wasn't forcing a rebuild when contents scale or content bounds
changed (and this was required). I've fixed that in this CL as well.

BUG=471786

Review URL: https://codereview.chromium.org/1105933002

Cr-Commit-Position: refs/heads/master@{#326827}

Revert of Implementing a BLE connection finder. (patchset #6 id:100001 of https://codereview.chromium.org/1094273003/)

Reason for revert:
This change broke the chromium perf dashboard:

https://build.chromium.org/p/chromium/builders/Linux/builds/61221

by adding a new static initializer:

const std::string kSmartLockServiceUUID =
    "b3b7e28e-a000-3e17-bd86-6e97b9e28c11";

I think you want static const char* instead.

Original issue's description:
> Implementing a BLE connection finder.
>
> This CL adds a connection finder class. The connection finder scans for
> Bluetooth Low Energy devices advertising a given target service.
>
> The current version only works when the remote device advertising the
> target service is sending all its primary services UUID.
>
> BUG=479673
> R=msarda
> TBR=tengs
>
> Committed: https://crrev.com/f56835d5211fc533a02f143e06eb310764f6b901
> Cr-Commit-Position: refs/heads/master@{#326807}

TBR=msarda@chromium.org,tengs@chromium.org,sacomoto@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=479673

Review URL: https://codereview.chromium.org/1105863003

Cr-Commit-Position: refs/heads/master@{#326826}

BUG=267773

Review URL: https://codereview.chromium.org/1101603002

Cr-Commit-Position: refs/heads/master@{#326825}

BUG=433446
TEST=media_unittests and EME layout tests pass

Review URL: https://codereview.chromium.org/1072403009

Cr-Commit-Position: refs/heads/master@{#326824}