GitLab

Use the System URL Request Context in the web resource service instead of the default profile's context.

This change should be made because there will be no more default profile, because these services should be able to run without being attached to a specific profile, and because they should only ever fetch json data from controlled URLs.

BUG=64339
TEST=all current web resource tests continue to work.
Review URL: http://codereview.chromium.org/7099004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85081
TEST=Open print preview tab, print a doc. Reopen, the last used printer should be pre-selected.


Review URL: http://codereview.chromium.org/7042034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88399 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/7058055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16264
TEST=manual testing in chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7046050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run remoting_simple_host --me2mom without cached credentials.


Review URL: http://codereview.chromium.org/7041006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88394 0039d316-1c4b-4281-b951-d872f2087c98

Fix a browser, renderer, plugin deadlock caused by the change to reparent plugin windows in the browser
process. Reparenting occurs via Windows API calls on the IO thread which can result in window messages
being dispatched to plugin windows which may be blocked on outgoing sync calls.

Fix is to execute the Windows API calls on the UI thread.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=85397

BUG=85397
Review URL: http://codereview.chromium.org/6995082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88393 0039d316-1c4b-4281-b951-d872f2087c98

The signature changed from (commit bf2f7326):
virtual void OnViewAdded(View* parent, View* child);

To:
virtual void OnViewAdded(const View& parent, const View& child);

BUG=72040
TEST=None

R=ben@chromium.org,sky@chromium.org,pkasting@chromium.org

Review URL: http://codereview.chromium.org/7104042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88392 0039d316-1c4b-4281-b951-d872f2087c98

Use the original non-incognito profile instead of backing off to the default profile when we're in incognito mode.

BUG=64339
TEST=extension webstore private browsertest keeps working.
Review URL: http://codereview.chromium.org/7041007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88391 0039d316-1c4b-4281-b951-d872f2087c98

Add apitest for InputUI extension API.

BUG=Crashes when extension calls a undefined function
TEST=Manually

Review URL: http://codereview.chromium.org/7104002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88390 0039d316-1c4b-4281-b951-d872f2087c98

on different threads than the one on which it's written.

R=eroman@chromium.org


Review URL: http://codereview.chromium.org/7135005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88389 0039d316-1c4b-4281-b951-d872f2087c98

- UserScript reference from BufferedResourceHandler.
- ExtensionInfoMap references from RenderMessageFilter and WorkerProcessHost
and ResourceContext.

BUG=76697

Review URL: http://codereview.chromium.org/7135003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88388 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies message routing to the compositor thread a bit.

Review URL: http://codereview.chromium.org/7129006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88387 0039d316-1c4b-4281-b951-d872f2087c98

See also http://codereview.chromium.org/149741/

BUG=16963
TEST=Observe that the theme image is tiled on a new tab page. Observe that all variables are replaced to their values in chrome://theme/css/newtab.css, i.e. the newtab.css contains no variables like "$$1" or "$$$1".


Review URL: http://codereview.chromium.org/6897002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88386 0039d316-1c4b-4281-b951-d872f2087c98

All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
See the bug for a disussion of this change.

BUG=84424
TEST=none

Review URL: http://codereview.chromium.org/6995085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88385 0039d316-1c4b-4281-b951-d872f2087c98

Note this doesn't need to use IPC at all, so it's a little strange.

Made test for pp::Var/PPB_Var that does only strings (copied from test_var_deprecated.cc).  Fixed string var tracking so test can pass out-of-process (aside from invalid UTF8 checking, which is still not implemented o-o-p).

BUG=85236
TEST=test_var.cc, run tests manually out-of-process.

Review URL: http://codereview.chromium.org/6995083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88384 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a real bug, because e.g. chrome/browser/chromeos/frame/browser_view.cc
has a scoped_ptr<views::MenuDelegate> that it sets to a
SimpleMenuModelDelegateAdapter object. (That class ends up not having a destructor
and no non-POD members, so it's just a latent bug.)

BUG=84424
TEST=none


Review URL: http://codereview.chromium.org/7109037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88383 0039d316-1c4b-4281-b951-d872f2087c98

Only list user certificates in the TPM in the Wi-Fi connection certificate list, as those are the only ones available via PKCS#11 to flimflam and wpa_supplicant.

BUG=chromium-os:16032
TEST=manual, see bug

Review URL: http://codereview.chromium.org/7046051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88381 0039d316-1c4b-4281-b951-d872f2087c98

This should make it possible to run on a VM, and still find the private key created for the owner in the software slot.

BUG=chromium-os:15817
TEST=Built an image and tried it on a VM and a device. Both showed restricted users list.

Review URL: http://codereview.chromium.org/7066070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88380 0039d316-1c4b-4281-b951-d872f2087c98

Since benchmarking results represent only a sample of the entire population of
results, it would be better to calculate the sample standard deviation, which
is an unbiased estimator of the population variance.  Also, since the Array.avg
function throws out the min and max, this function should not be used when
calculating the variance.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7108006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88379 0039d316-1c4b-4281-b951-d872f2087c98

10.6 added object_destructInstance() as a wrapper around
object_cxxDestruct() and also releasing associated objects.  As a
bonus, it's available via dlsym() rather than nlist().

BUG=82937
TEST=none

Review URL: http://codereview.chromium.org/7084017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88378 0039d316-1c4b-4281-b951-d872f2087c98

Patch for 88373 (clang errors)

BUG=chromium-os:15598
TEST=Clang compile succeeds

Review URL: http://codereview.chromium.org/7046055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88377 0039d316-1c4b-4281-b951-d872f2087c98

that care send the correct message. This change is motivated by
wanting to remove SessionID from content. At later cl will remove
TabContentsDelegate::RenderViewCreated.

BUG=none
TEST=none
R=jam@chromium.org,mpcomplete@chromium.org

Review URL: http://codereview.chromium.org/7046041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88376 0039d316-1c4b-4281-b951-d872f2087c98

Revert stubs that were added in r88040.  We need proper interfaces around features that need to be compiled out, instead of adding stubs.
Review URL: http://codereview.chromium.org/7046052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88374 0039d316-1c4b-4281-b951-d872f2087c98

This is a regression caused by http://codereview.chromium.org/6881073/

BUG=chromium-os:15598
TEST=Opening a large window using JS window.open from a panel should open a new tab in the parent browser. See issue for repro.

Review URL: http://codereview.chromium.org/7101008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88373 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85310

TBR=

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88371 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88370 0039d316-1c4b-4281-b951-d872f2087c98

client and audio threads are the same, so we don't need locks/ref counts/etc.

http://codereview.chromium.org/7117001

BUG=62588

Review URL: http://codereview.chromium.org/7117001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:10766
TEST=manual testing in chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7044052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88368 0039d316-1c4b-4281-b951-d872f2087c98

*Update AboutSource to use the source_name of each about/chrome page.
*Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/
-Redirect memory to memory-redirect (wasn't handling chrome://memory/).
-Catalog all kChromeUI*Hosts in url_constants.cc
-Simplify paths (credits, os-credits, ipc, settings, about/version).
-Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison).
-Favor GURL::SchemeIs and url_constants, update & expand tests.
-Add and fixup chrome://chrome-urls (the about:about page).
-Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/.

This change was reverted with r88166 for sync_integration_tests failures.
These failures are a tangential issue, crbug.com/85294; I'll re-land this soon.

BUG=55771
TEST=Access about:, about://, chrome:, chrome:// pages.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88142

Review URL: http://codereview.chromium.org/7068007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88367 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88366 0039d316-1c4b-4281-b951-d872f2087c98

In ChromeDriver, do not use timeouts for automation calls. WebDriver is a tool for general purpose testing, and has no notion of timeouts currently.
Many users were running into cases where they wanted a longer timeout than the current 25s.
BUG=82457
TEST=none

Review URL: http://codereview.chromium.org/6995060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88365 0039d316-1c4b-4281-b951-d872f2087c98

This adds the necessary plumbing for chrome://sessions webui page which shows a hierarchy of sessions and their windows and tabs as well as a "magic" list of suggested tabs. The magic list is currently just the last 10 tabs by timestamp for now - but can later be changed to prototype other heuristics.

BUG=none
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88334
Review URL: http://codereview.chromium.org/6969016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88364 0039d316-1c4b-4281-b951-d872f2087c98

- Replace all "child_count() == 0" with "empty()".
- Change node is-empty check from "child_count() > 0" to "!empty()".

BUG=None
TEST=None

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7003039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88363 0039d316-1c4b-4281-b951-d872f2087c98

Per Alexey's debugging, the problem was because NotificationUIManager was being deleted after the testing PrefsService has gone away.  So when the TestingBrowserProcess is told that PrefsService is going away, destruct the NotificationUIManager then.
Review URL: http://codereview.chromium.org/7129009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88362 0039d316-1c4b-4281-b951-d872f2087c98

Move GeolocationPermissionContextUnittest from subclassing TabContentsWrapper to merely observing infobar removal notifications.  (The existing comment about TestTabContents was made obsolete by r85835.)

Keeping a set of closed delegates instead of tracking the last closed delegate for each tab seems slightly clearer.  Also, back when I first wrote this code in http://codereview.chromium.org/4767001/ , I was convinced it was necessary to the infobar refactor, although I can no longer recall why!

This also eliminates TestTabContentsWrapper::SetContentsWrapper().

BUG=62154
TEST=none
Review URL: http://codereview.chromium.org/6993030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88360 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88359 0039d316-1c4b-4281-b951-d872f2087c98

* adding -j option for track(caption) testing, 
* clean up setting CHROME_FLAGS related code
* remove the loop for media cache testing and control it directly from commandline using -c option (enable/disable media cache)


Review URL: http://codereview.chromium.org/7074060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7054052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88356 0039d316-1c4b-4281-b951-d872f2087c98

Add GetDebugName() method to Profile.  Use it in ProfileSyncServiceHarness,
SyncerThread, and LiveSyncExtensionHelper.

Change VLOG(1)s in SyncerThread to VLOG(2)s.

Turn on logging for the test server if VLOG is enabled for that file, and not just in general.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7024058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88355 0039d316-1c4b-4281-b951-d872f2087c98