- 18 Oct, 2017 40 commits
-
-
Troy Hildebrandt authored
Moves a good chunk of the bottom nav menu logic into first party classes with the rest of the bottom sheet code. This allowed for the XML changes required to properly display labels underneath icons centered and have a proper shadow above the bottom navigation menu. Adds a flag for the bottom nav labels. When enabled, the bottom menu shows labels beneath the icons, is 48dp tall always, opaque, and has a shadow above it. When disabled, the bottom navigation menu is 40-48dp and translucent, without a top shadow. Defers the bottom nav height calculation until after the native library loads, and allows for the visual properties of the bottom navigation menu to be initialized at this time as well, using defaults in the mean time. This is necessary because these things now rely on the flag in ChromeFeatureList. Bug: 761470 Change-Id: Ic77718360c3368da8aed309661feb7d87b14cfba Reviewed-on: https://chromium-review.googlesource.com/714358 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#509914}
-
Lucas Furukawa Gadani authored
Bug: 688565 Change-Id: I70f9e8b1ea785ff72cc41829b9348bf310605127 Reviewed-on: https://chromium-review.googlesource.com/726325Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509913}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/033ea5f77140..8a958528b2ca $ git log 033ea5f77..8a958528b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8f04ff24df82ef33be3e94f92f88f60571642f7b Reviewed-on: https://chromium-review.googlesource.com/726745Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509912}
-
David Tseng authored
Bug: 773866 Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59 Reviewed-on: https://chromium-review.googlesource.com/723606 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#509911}
-
Saman Sami authored
WillDrawCallback is called even for surfaces that will not be drawn. This is because SurfaceAggregator::PrewalkTree iterates not just on embedded SurfaceDrawQuads but also referenced_surfaces which don't necessarily have a SurfaceDrawQuad and therefore won't be included in the final display frame. As a part of video detection in Viz I'm going to create an actual WillDraw method that will be called when a surface is included in the display frame, so rename WillDrawCallback to AggregatedDamageCallback to avoid any confusion. BUG=775035 Change-Id: Ia1db880f53d639e72959f8683f48f4b7e6799cc1 Reviewed-on: https://chromium-review.googlesource.com/726368Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#509910}
-
Eugene But authored
Added code which waits for page loads after navigations. Disabled tests will be enabled in a separate CL. Also improved code formatting were OmniboxText is used. Bug: 772128 Change-Id: I93880d1053e37e012240c7013d3e642b17acf38e Reviewed-on: https://chromium-review.googlesource.com/726241Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509909}
-
Darren Shen authored
This patch changes CSSParserFastPathsFuzzer to use the last 4 bytes for the property ID rather than a hash to get more coverage. See comments at end of [1] for context. [1] https://chromium-review.googlesource.com/c/chromium/src/+/706450#message-eecf2ab42f1c020fbbce3cb064d03718f9fa6eeb Change-Id: I1375add835cac612e8ce6edf298c1a3ff1601435 Reviewed-on: https://chromium-review.googlesource.com/724559Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#509908}
-
Reilly Grant authored
The old Mojo JS bindings are now only used in blessed extension contexts. All of the support for LayoutTests and WebUI can be removed. Logic to enable the new Mojo bindings in WebUI contexts is moved to RenderFrameImpl::DidCreateScriptContext. Bug: 699569 Change-Id: Ib0d9e43a6d73ada45a9286aa85e13d15bc421473 Reviewed-on: https://chromium-review.googlesource.com/706380Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509907}
-
rbpotter authored
Bug: None Change-Id: I9abbdfc3416e5bd22ffc6156bfee9bc4ed12113f Reviewed-on: https://chromium-review.googlesource.com/724919 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#509906}
-
Yuwei Huang authored
Chromoting is planning to bump up iOS deployment target to 10.0. However, one of our dependency, //third_party/usrsctp has used some OSAtomic* functions that have been deprecated on 10.0 SDK. After some discussions with the usrsctp people, we would like to suppress the deprecation warning on usrsctp for now because: * Replacing the OSAtomic* functions with atomic_fetch_add is nontrivial and requires replacing some int32_t with _Atomic(int32_t) globally in their codebase, which is challenging for an engineer who isn't familiar with it. * The OSAtomic* API works all the way up to deployment target 11, if ignoring the warnings. * Filed a bug in their repo but they don't plan to fix that soon. * They have already suppressed the warning in their configure.ac file. This is replicating their change. Bug: 774483 Change-Id: Ie7f65edb767cc241a8b5fe7dc6074ef37387d89f Reviewed-on: https://chromium-review.googlesource.com/726619Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#509905}
-
bsheedy authored
Adds an isolate target to gn_isolate_map.pyl for running vr_common_perftests on the VR perf bot. Bug: Change-Id: Icc61fd0824bfa093fff2f683e52e94731d2bd78e Reviewed-on: https://chromium-review.googlesource.com/726269Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509904}
-
Zhenyao Mo authored
BUG=759634 TEST=startup.warm.blank_page R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I050ced97dbba071b5fb32324239d45d43dd72f6d Reviewed-on: https://chromium-review.googlesource.com/726499Reviewed-by:
ccameron chromium <ccameron@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#509903}
-
Eric Karl authored
Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/544102 The GPU Image Decode Cache now uses GPU discardable so it can share texture limits with other controllers in other processes. This allows us to put an upper limit on the amount of GPU memory that will be used for image decodes - previously this was only limited per-renderer and could grow unbounded. This was originally reverted due to a texture leak in discarding Skia owned textures. This change relies on a new Skia API: SkImage::MakeBackendTextureFromSkImage, which allows us to to take ownership of the GL texture from Skia and safely discard it. TBR=isherman@chromium.org Bug: 438325 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4a0dcb48d6353f9b914e0ee00ddae12ee23d916c Reviewed-on: https://chromium-review.googlesource.com/706593 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509902}
-
Tom Sepez authored
Finish separation of GPU from sandbox. In turn, this allow us to move content/common/sandbox_init_gpu_linux.cc closer to its buddies in content/gpu. Change-Id: If604d306bba0b336f6302dd68e559d34b828539c Reviewed-on: https://chromium-review.googlesource.com/721857 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#509901}
-
Stephen Martinis authored
Also adds a unittest to the perf data generator script to ensure that any lists in the file are alphabetized. Bug: 767262 Change-Id: I8e08159728aa7e574dc40f306d747bd4c4a9f72f Reviewed-on: https://chromium-review.googlesource.com/716848 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sean McCullough <seanmccullough@chromium.org> Cr-Commit-Position: refs/heads/master@{#509900}
-
chaopeng authored
Rietveld Code Review: https://codereview.chromium.org/2910843002/ Bug: 727044 Change-Id: I64e25142632f42144b66f041ad1c9ffb8ae553f5 Reviewed-on: https://chromium-review.googlesource.com/665657 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509899}
-
Corentin Wallez authored
https://chromium.googlesource.com/angle/angle.git/+log/2d88e9b..d042fba BUG=,chromium:774309 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Merge branch 'master' of https://chromium.googlesource.com/chromium/src gpu/config: Return partial info from angle::GetSystemInfo A filure in angle::GetSystemInfo will still return a gpu info collection failure but partial results will be shown in about:gpu which will help diagnosing problems. BUG=chromium:774748 Change-Id: I000b9f83dc35389beeb14657460baed22ac25daa Reviewed-on: https://chromium-review.googlesource.com/726020Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509898}
-
Zentaro Kavanagh authored
- The default is currently that NTLMv2 is disabled (ie. using NTLMv1) - A future release will make the default NTLMv2 enabled. Bug: chromium:22532,chromium:775518 Change-Id: Icb554af932ef1d30b0e9a3cc8cedfea915bd2074 Reviewed-on: https://chromium-review.googlesource.com/673206 Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#509897}
-
David Reveman authored
Request first frame of user image to avoid animations. Bug: 775988 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I47df758d0ce63f0d1f51cefa1e8d90340ad3ef67 Reviewed-on: https://chromium-review.googlesource.com/726303Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509896}
-
Sergey Ulanov authored
Moved audio-processing code that doesn't have dependency on alsa out of chromecast/media/cma/backend/alsa to chromecast/media/cma/backend . This will allow to use this code on other platform that don't use ALSA Bug: 772488 Change-Id: I142557999d7bb0046f8a9de2143a66b1e06ca963 Reviewed-on: https://chromium-review.googlesource.com/716807 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509895}
-
Dave Tapuska authored
Once WillShutdown is called the InputHandlerProxy object should be destroyed since it is no longer valid. BUG=775483 Change-Id: I3dc1cf7d7295ff08bbcec3d8ee2b12690961af2e Reviewed-on: https://chromium-review.googlesource.com/725860Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#509894}
-
Alex Clarke authored
Bug: Change-Id: I0305f69e2473c4a7d845c8f71a77df9e5d07a04d Reviewed-on: https://chromium-review.googlesource.com/725729Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509893}
-
Charlie Andrews authored
TBR=rnephew@chromium.org Bug: 776092 Change-Id: Ie0e1cc1cd0f33adff4ca9049ea181d7e05a3f020 Reviewed-on: https://chromium-review.googlesource.com/726275Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#509892}
-
Brian Salomon authored
https://skia.googlesource.com/skia.git/+log/079e50bbdeeb..c4f93cab667b Suppress several layout tests (1 due to apparent swiftshader bug) Rebaseline LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: 775957,775958 Change-Id: I41ff979a446f7410a5caf78db594d5219f84e090 Reviewed-on: https://chromium-review.googlesource.com/726103 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#509891}
-
Stefan Zager authored
Another batch using the heuristic from: https://chromium-review.googlesource.com/699752 BUG=417782 R=pdr@chromium.org,skobes@chromium.org Change-Id: I2ebb1b05666e5fa55dbb28e61f4f5b283ff9e70b Reviewed-on: https://chromium-review.googlesource.com/726494Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#509890}
-
khmel authored
This CL fixes issue when InkDrop animation stays on shelf button after the click. This was due item controller was replaced during the ItemSelected call and calling callback with action back to ash was dropped. Bug: 771655 Test: Manually Change-Id: I8af7dc844a441ada91c4e35b04847a09ebd582db Reviewed-on: https://chromium-review.googlesource.com/724201 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509889}
-
Mathieu Perreault authored
Changing the method names in anticipation of future change. Moving a class to the implementation Bug: 767931 Change-Id: Id386a7708f05c501c7f44321dfa0b116215118cd Tbr: mahmadi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/726370 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509888}
-
Miriam Gershenson authored
Change-Id: I0dda4e286af4f3fde7e6ddc246c10bf6887fb536 Reviewed-on: https://chromium-review.googlesource.com/726021 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509887}
-
Yi Gu authored
We do not need the metric since the experiment of not compositing small scrollers is done. See crbug.com/684631. Bug: 775643 Change-Id: Ieff65345931a35cb278d25a7d574944585907304 Reviewed-on: https://chromium-review.googlesource.com/723675Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509886}
-
Will Chen authored
This eliminates a lot of the code duplication between the new and legacy integration test frameworks by making security-test.js a small wrapper to load the new security_test_runner modules. I made the old test framework initialization processs sequential (i.e. promise chain) instead of concurrent (i.e. Promise.all(...)) because origin-view-then-interstitial.html test didn't work if the Security module was already loaded before showing the Security panel. I spent a while debugging but couldn't figure out the root cause. Bug: 667560 Change-Id: I74a2a783a5a6e8d81c1e592774928c400131691a Reviewed-on: https://chromium-review.googlesource.com/726367Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#509885}
-
smut authored
Bug: 756270 Change-Id: I615a5dba2f50ebadf8a9851fe4e40dce60165392 Reviewed-on: https://chromium-review.googlesource.com/724667Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509884}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/75257303afa9..79f62e6c96d8 $ git log 75257303a..79f62e6c9 --date=short --no-merges --format='%ad %ae %s' 2017-10-18 wkorman Reland 'Fetch external images in snap_page.' 2017-10-18 perezju Revert "Fetch external images after processing DOM." 2017-10-18 perezju [Telemetry] On debug mode (-vv) log every subprocess command 2017-10-17 dtu [pinpoint] Handle None values. 2017-10-17 wkorman Fetch external images after processing DOM. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I220b6ec18fe6273385fbf9a03c86b5a283f02490 Reviewed-on: https://chromium-review.googlesource.com/726323 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509883}
-
spqchan authored
Refactor SSLErrorHandler by moving the protobuf logic into a new class: SSLErrorAssistant. BUG=773478 Change-Id: I2e72bd4151bee6fe8f406df411c715d65afbaf54 Reviewed-on: https://chromium-review.googlesource.com/696030 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#509882}
-
Sylvain Defresne authored
In preparation of allowing WebStateObserver to observe multiple WebStates, pass the WebState as first parameter to all of the methods of WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I041f66d1bc4a5f905acbf68aafea8b5a11efe306 Reviewed-on: https://chromium-review.googlesource.com/724521 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509881}
-
Francois Doray authored
s/ThreadRestrictions::ScopedAllowIO allow_io;/ ScopedAllowBlockingForTesting allow_blocking;/ in files that have the word "test" in their path. ThreadRestrictions::ScopedAllowIO instances that are not named |allow_io| are not changed by this CL. TBR=jam@chromium.org Bug: 766678 Change-Id: Ie809d1b39d50c1669cd36399cdfe5657cf072c21 Reviewed-on: https://chromium-review.googlesource.com/718983Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#509880}
-
Vladimir Levin authored
This patch plumbs PaintImage decoding state from recorded paint images to checker image tracker and merges them into a map. R=khushalsagar@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic6ed4462c82e4ac5917f5d5bc0abdc9df2756150 Reviewed-on: https://chromium-review.googlesource.com/723587 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#509879}
-
Xiaohui Chen authored
This is a reland of 6ccb7931 Original change's description: > Fix PAI not delay bug in Assistant runtime setup > > BUG=b:67384302 > TEST=build and flash, disable play, run through assistant OOBE, see > play auto installs are delayed until OOBE finishes. > > Change-Id: I458e06e6131313ef24de375550ebd3dff048fb2b > Reviewed-on: https://chromium-review.googlesource.com/706178 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508772} Bug: b:67384302 Change-Id: Iaa18e6b9544a466d3fada2a745783ae2153aaaa3 Reviewed-on: https://chromium-review.googlesource.com/719500Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#509878}
-
Muyuan Li authored
If ARC is not enabled or assistant value prop is not accepted, an "Enable" button will be shown and the runtime flow will be launched if user clicks it. BUG=b:65161403 TEST=manually test by: 1. Disabling play store 2. Clicking "Enable" button in assistant section. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7ffba0d8828a4b673504d77dd3512be28da241a5 Reviewed-on: https://chromium-review.googlesource.com/719599 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#509877}
-
Sylvain Defresne authored
The Tab snapshot should only be deleted when the Tab is closed due to user action (or when the Tab is replaced by another in reaction to user action). In particular, the snapshot should not be deleted when the application is terminated. Change WebStateList CloseWebStateAt to take a flagset allowing to inform the observers whether the Tab was closed due to an action initiated by the user or not and use it to decide whether the Tab snapshot should be deleted or not. Remove global IsShuttingDown() from ApplicationContext. Bug: 753290 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie626042e0b16215fd44f9631fb4e14f68c015e86 Reviewed-on: https://chromium-review.googlesource.com/723826 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#509876}
-
Robert Liao authored
This completes the migration from ScopedComPtr to Microsoft::WRL::ComPtr. BUG=638327 TBR=dcheng@chromium.org Build file change. Change-Id: Iec1047e69dea9913db80cd0cfac50ea36b7fc947 Reviewed-on: https://chromium-review.googlesource.com/726461Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#509875}
-