GitLab

Using wpt-import in Chromium 5316b1cb.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
a558107e "[LayoutNG] Fix flex BODY in quirks mode"
be0ac4b3 "Reland "WaveShaper must output non-zero values even if input is silent""
b9e5f3f7 "[css-contain] Disable layout containment for certain elements"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19096

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/IndexedDB
kozyatinskiy@chromium.org:
  external/wpt/console
meade@chromium.org:
  external/wpt/web-animations
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mstensho@chromium.org:
  external/wpt/css/css-multicol
worker-dev@chromium.org:
  external/wpt/workers
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=foolip

No-Export: true
Change-Id: I1f55148a4bd1008c33abc33271fe21abafe17787
Reviewed-on: https://chromium-review.googlesource.com/1087824
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564753}

GetLastError returns the HRESULT of the last win32 API call and not the
last failed call so this UMA doesn't work as expected. Replace with
GPU.DirectComposition.SwapBuffersFailed boolean UMA that just counts
number of failures.

Bug: 837378
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idee2ad507316823d31f95405e4431287f9aef5ee
Reviewed-on: https://chromium-review.googlesource.com/1072692
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564752}

https://chromium.googlesource.com/angle/angle.git/+log/7ba3f42..d197803


git log 7ba3f42..d197803 --date=short --no-merges --format='%ad %ae %s'
2018-06-05 jmadill@chromium.org Roll dEQP (June 2018).


Created with:
  gclient setdep -r src/third_party/angle@d197803

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Idf7c2cd8887abafba4306ca79840824dc3573bf9
Reviewed-on: https://chromium-review.googlesource.com/1087633Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564751}

Adds support for items querying thumbnails.  This is the same capability
that exists in the current downloads home.  This change has the
following details;

- Exposes a callback to get and cancel visual requests to the View
layer through the model.
- Adds the concept of a ViewHolder that knows how to request for
thumbnail assets.
- Connects the thumbnail request to the ThumbnailProviderImpl and
propertly interacts with the download backend and the
OfflineContentProvider backends.

Bug: 842345
Change-Id: I884a9d46bcece9dba08707f97f40a5b15936ddf0
Reviewed-on: https://chromium-review.googlesource.com/1084077
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564750}

This change avoids set window bounds twice.

BUG=chromium:843001
TEST=Manual test on an eve device.

Change-Id: If08f8e4fd7b8e91db43f265fa8fdc46c3da6eb86
Reviewed-on: https://chromium-review.googlesource.com/1087844Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564749}

This CL adds CSS to change the overflow menu and list item sizes based
on the sizing-* CSS class to match the new mocks.

Bug: 839107, 839088, 837027
Change-Id: I82a633b88c787e200d1b088fb51d7fed2c066e56
Reviewed-on: https://chromium-review.googlesource.com/1087796Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564748}

Change-Id: I7885292bd9d125c45fa7aec61f657df47c2c4fc6
Reviewed-on: https://chromium-review.googlesource.com/1087173
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564747}

Bug: 849759
Change-Id: I932a5530cf213660c85009f63970fe3edb8ed039
Reviewed-on: https://chromium-review.googlesource.com/1072587
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564746}

Bug: 824568, 752273
Change-Id: Iae40dd308ad057b08d4f3a6ad4433794243f4cce
Reviewed-on: https://chromium-review.googlesource.com/1086710Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564745}

This adds a previews type state to the pingback that represents that no
preview was served due to the blacklist acting on one of its rules. The
states are still mutually exclusive.

Bug: 849328
Change-Id: I40235d318b68e9674b67ae40df30153c30aba178
Reviewed-on: https://chromium-review.googlesource.com/1086242
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564744}

In data reduction proxy, add a mechanism to disable the caching of
the canary check result. The goal is to determine if the caching
of the result is the root cause for the drop in page load count when
data saver probing experiment is enabled.

Bug: 849292
Change-Id: I5b62defa8b7fca1a0791c7da345385cc82afe496
Reviewed-on: https://chromium-review.googlesource.com/1086355
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564743}

What:
0. Create PrioritizedTaskRunner which provides 2^32 priority levels for a given
   TaskRunner.
1. Plumb net::RequestPriority into the disk_cache::Entry.
2. Implement support for priorities in the SimpleCache (mem cache doesn't need
   it because it's synchronous and maybe we'll get to block cache later).
3. Remove worker_pool_ from SimpleCacheBackend since we can use
   PrioritizedTaskScheduler instead.
4. Add a feature for field trials.

SimpleCache prioritizes first by RequestPriority and second by request age.


((net::RequestPriority::MAXIMUM_PRIORITY - request_priority_) *
          10000) +
         entry_priority_;

Where request_priority is the net::RequestPriority and entry_priority_ is the
count of entries that have been created at the point of entry creation.

Why:
Today, low priority new requests have as much priority in the cache worker
pool as high priority old requests. This causes TTFB to suffer for high
priority, early requests in the page. Delayed TTFB means time that the
consumer (the renderer) isn't streaming bytes.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I22121c6091e67ee995e12951560413cf7bdd0352
Reviewed-on: https://chromium-review.googlesource.com/1064506Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564742}

TBR=eae@chromium.org
NOTRY=true

Change-Id: Ib155a375fd2fea85895b7a031e9e4f8afadfe181
Reviewed-on: https://chromium-review.googlesource.com/1087642Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564741}

AssistantBubbleController is a sub-controller of AssistantController. A
follow up CL will pull interaction logic out of AssistantController
into another sub-controller called AssistantInteractionController.

This is part of an effort to clean up and simplify AssistantController.

Bug: b:80542452
Change-Id: I57dca92433d37140f5138923e1d35df7fa79d785
Reviewed-on: https://chromium-review.googlesource.com/1086362
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564740}

When a rotation is set, a very tiny error is introduced in the root
window transform due to use of trig functions in computing the transform.

This small error is later turned into a full pixel error when the root
window updates its transform.

Avoid trig functions in the display rotation transform. Use of a scale
factor can still cause similar problems, but this should fix most
problems at 1x scale.

Bug: b/78781894
Test: cast_graphics_unittests with new test in next patch

Change-Id: I1ac5d50ef56a1627f2698a47f5d4a2692446332f
Reviewed-on: https://chromium-review.googlesource.com/1087805Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564739}

A mask layer should always have the same bounds as its parent's.
TrayBubbleView sets a mask layer to layer()->parent(), but used
the bounds of layer() for its mask layer. It caused DCHECK.

Previously, https://crrev.com/c/663422 tried to fix this by using
GetBubbleBounds(), but it still doesn't return the correct bounds in
some cases e.g. |corner_radius| and |has_shadow| = false are set.

TEST=TrayEventFilterTest
BUG=847104,764428

Change-Id: I677a0df7fc5342e7f722c97c30fc0b87f25b23f4
Reviewed-on: https://chromium-review.googlesource.com/1084530Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564738}

The lack of swarming was the most likely cause of mysterious test
failures that weren't affecting any other builder.

Bug: 849868
Change-Id: I6ee8b78886dce01a319062b3d6526381bb25ecf3
Reviewed-on: https://chromium-review.googlesource.com/1087818Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564737}

Due to the possible absence of frame or document loader from the
performance object, it's not guaranteed that processing start would be
always earlier than onload.

Reuse existing code to refactor the buffering-before-onload logic.

Bug: 847496
Change-Id: If3fae54e90747572956610bedadd7963463a5dcc
Reviewed-on: https://chromium-review.googlesource.com/1080131
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564736}

Re-enable the tab-switching benchmark on linux after the tabs-metric fix
in crrev.com/c/1083790.

BUG=842732

Change-Id: Iac9ae2f83ccf6082bb3cf1e7223ccb89bf517f85
Reviewed-on: https://chromium-review.googlesource.com/1084056Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564735}

This CL removes kChromeUITermsOemURL (chrome://chrome://terms/oem)
which is unused in the MD UI and non functional.

This CL also disables:
WebviewClientCertsLoginTest.ClientCertRequestedInOtherWebView
(See comment for details).

Bug: 647411
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4bae3abfadd6261fd37a449dcda4a1f37ba4850a
Reviewed-on: https://chromium-review.googlesource.com/1080174
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564734}

It makes it clear that including users' emails in activity report is a diffrent thing
than reporting list of device users.

Follow up for: https://chromium-review.googlesource.com/c/chromium/src/+/1034120

Test: Run DeviceStatusCollectorTest and ConsumerDeviceCollectorTest
Change-Id: I7b749c5abefb3a892aeb21113647a75feeae1255
Reviewed-on: https://chromium-review.googlesource.com/1080171Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564733}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d566165..6563513


Created with:
  gclient setdep -r src-internal@6563513

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0b87ffe84cd06dd03945e155af1af16f44be4144
Reviewed-on: https://chromium-review.googlesource.com/1087638Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564732}

LaunchProcess was previously implemented using "launchpad", which is
being replaced for SDK users by the fdio_spawn*() APIs.

- Migrate call-sites off the old |options.clone_flags|.
- Add the fdio_spawn*() header file to our GN package rule for "fdio".
- Add TODO to "launchpad" package definition for it to be removed once
  all dependency repos have been updated (e.g. gtest, crashpad).

Bug: 848028
Change-Id: I2d871a0f77bd9cba0d16217371069989fdef17f3
Reviewed-on: https://chromium-review.googlesource.com/1081078Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564731}

Now, this class takes a DeviceIdPair rather than a single device ID.
This is in preparation for integrating this class with SecureChannel.

Bug: 824568, 752273
Change-Id: I21f355967590bbcda699e3f155ab93cd47959af4
Reviewed-on: https://chromium-review.googlesource.com/1086512Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564730}

It's also failing on ASAN which I guess isn't part of [ Debug ].

Bug: 849670, 789111
Change-Id: I93ceceb4c4c84390dc2253132a29c1cccde722fc
NOTRY: true
TBR: horo
Reviewed-on: https://chromium-review.googlesource.com/1087195Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564729}

Change-Id: I2168bf5f55cb30f4cb7098a6a98fe3b9176682e6
Reviewed-on: https://chromium-review.googlesource.com/1087404
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564728}

When the v-keyboard is being shown and the body of the
applist is tapped or clicked, dismiss the keyboard with no
side effects.

Bug: 844773
Change-Id: Iab0325e5cb5e77678df5c33a8e7f8e589e926825
Reviewed-on: https://chromium-review.googlesource.com/1077497Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564727}

This reverts commit 6b9a52cb.

Reason for revert: Compile failure on Fuchsia Cast Audio

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64%20Cast%20Audio/17815

FAILED: cast_shell exe.unstripped/cast_shell 
python "../../build/toolchain/gcc_link_wrapper.py" --output="./cast_shell" --strip="../../third_party/eu-strip/bin/eu-strip" --unstripped-file="./exe.unstripped/cast_shell" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics --target=x86_64-fuchsia -resource-dir ../../third_party/fuchsia-sdk/sdk/toolchain_libs/clang/7.0.0 -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -m64 -Werror -Wl,-O2 -Wl,--gc-sections -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/sysroot/x86_64-fuchsia -L../../third_party/fuchsia-sdk/sdk/arch/x64/lib -o "./exe.unstripped/cast_shell" -Wl,--start-group @"./cast_shell.rsp" ./libcast_graphics_1.0.so ./libcast_external_audio_pipeline_1.0.so -Wl,--end-group   -lzircon -llaunchpad -lasync-default -lfdio -lsvc -lmedia_client 
/b/swarming/w/ir/cache/builder/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: chromecast::shell::AccessibilityManager::~AccessibilityManager()
>>> referenced by cast_browser_process.cc
>>>               obj/chromecast/browser/browser/cast_browser_process.o:(chromecast::shell::CastBrowserProcess::~CastBrowserProcess())


Original change's description:
> Move chromecast accessibility manager.
> 
>   * Move the cast AccessibilityManager into
>     chromecast/browser/accessibility.
>   * Only compile and create AccessibilityManager if extensions
>     enabled.
> 
> Bug: none
> Test: manual
> Change-Id: I83c30b8259caa97093cdd48baafd26b2750d1da7
> Reviewed-on: https://chromium-review.googlesource.com/1081234
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
> Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
> Commit-Queue: Ryan Daum <rdaum@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564692}

TBR=sadrul@chromium.org,alexst@chromium.org,kpschoedel@chromium.org,rdaum@chromium.org,rmrossi@chromium.org

Change-Id: I5f49e4b0bd32517e7fc592d3f5d89160a19e9e78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1087371Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564726}

Refresh adds a new avatar button in the toolbar. The profile menu suite
needs to click on that new button when Refresh is enabled, as a
prerequisite for its tests.

Bug: 846410
Change-Id: I9a9cda0443f972a4246ff309fc163976e1bde05f
Reviewed-on: https://chromium-review.googlesource.com/1087836
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564725}

testserver.py didn't report useful diagnostics on connection failure in proxy
mode. For the CONNECT method it would report an UnboundLocalError and for the
GET method it would log nothing at all.

Log connection failures (and other network errors) in proxy mode.

Behaviour in other modes is unchanged.

BUG=849128

Change-Id: Idbc8f0254438098461b6db2bb68c5268c48e1956
Reviewed-on: https://chromium-review.googlesource.com/1084422Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564724}

And enable it for the sanity test.

This won't work when the test times out and swarming kills it (ie:
we won't pull the logs from the VM before we die.) The fix for that will
come in a follow-up CL.

Bug: 848402
Change-Id: Ie2396adb7e284d5069162a0c8aea145c12d85be1
Reviewed-on: https://chromium-review.googlesource.com/1086416Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564723}

BUG=849850
TBR=scottmg@chromium.org

Change-Id: Ida2589c0e3e24a6202c1df322c15d134bc2a8eaa
Reviewed-on: https://chromium-review.googlesource.com/1087752Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564722}

This class is responsible to keep the module blacklist cache
updated when the ThirdPartyModulesBlocking feature is enabled.

Bug: 846953
Change-Id: Ib8a99ac0352702daec6b79d15324c2e7787d4d1a
Reviewed-on: https://chromium-review.googlesource.com/1055893
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564721}

It disables document.cookie APIs.

Bug: none
Change-Id: I76d4240fbd5f5cfdd2f2fa7d147eafbf939e2982
Reviewed-on: https://chromium-review.googlesource.com/1080984Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564720}

Change-Id: I77d67bdaa80773adabb129307f9a95f88fe92dcb
Reviewed-on: https://chromium-review.googlesource.com/1087831Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564719}

This CL fixes browser tests when UnifiedSystemTray is enabled.
These tests already works on Mash, so they are easier to port to
UnifiedSystemTray by introducing UnifiedSystemTrayTestApi
https://crrev.com/c/1086674 .
Remaining SystemTray browser tests do not work with Mash, so
we first have to make them work with Mash (in upcoming CLs).

TEST=browser_tests --enable-features=SystemTrayUnified
BUG=847104

Change-Id: Ic6ce4ce547913240b68a32959dc86242276807e9
Reviewed-on: https://chromium-review.googlesource.com/1086683Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564718}

In Pre-LayoutNG, selections are painted by LayoutText and LayoutReplaced.
We record SelectionVisualRect in LayoutObject::FragmentData, and check
for change of selection (in style and geometry) in
ObjectPaintInvalidator::InvalidateSelection, update SelectionVisualRect
and add needed invalidation rects into PartialInvalidationVisualRect.

In LayoutNG, selections are mainly painted by NGPaintFragment. Now we
keep track of NGPaintFragment's selection using
NGPaintFragment::SelectionVisualRect, and invlaidate the NGPaintFragment
if SelectionVisualRect changes.

PaintInvalidationReason::kSelection is treated as a full invalidation
reason for LayoutNG to simplify the logic (otherwise we need to support
partial raster invalidation in NGPaintFragment which seems not worth it,
with increased memory usage). This can be adjusted by the fact that we
now have finer grain selection invalidation in LayoutNG
(per NGPaintFragment) than Pre-LayoutNG (per LayoutObject).

For selection style changes (::selection pseudo style), we simply
invalidate the whole containing LayoutObject as the case is rare.

Bug: 849112
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7a04a12e8007fb4c2841e5db9b17f37b6d9e2580
Reviewed-on: https://chromium-review.googlesource.com/1084314
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564717}

This CL disables unit tests that are testing the features that are just
removed in UnifiedSystemTray. These tests crashed/failed when
UnifiedSystemTray was enabled.

TEST=ash_unittests --enable-features=SystemTrayUnified
BUG=847104

Change-Id: I7a8b9b0723737fc03a048d41be2f23b1e73dd8a7
Reviewed-on: https://chromium-review.googlesource.com/1086813Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564716}

https://skia.googlesource.com/skia.git/+log/5e6853d..3857fbf


git log 5e6853d..3857fbf --date=short --no-merges --format='%ad %ae %s'
2018-06-05 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 57776df..f398044 (1 commits)
2018-06-05 kjlubick@google.com Add Gr enums and version parsing for SwiftShader
2018-06-05 herb@google.com Have draw(Text|PosText|PosTextH) use a single entry on the device
2018-06-05 mtklein@chromium.org restore headers lost from skia.h
2018-06-05 jvanverth@google.com Consolidate ambient and spot code setup.


Created with:
  gclient setdep -r src/third_party/skia@3857fbf

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I0b7c4269ed5b0b130d22ebc8c50e136a183cab82
Reviewed-on: https://chromium-review.googlesource.com/1087632Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564715}

This CL fixes TrayEventFilterTest crash when SystemTrayUnified is
enabled.

This CL makes following changes:
* Fix TrayEventFilterTest to use UnifiedSystemTray instance when the
  flag is true.
* Fix vpn/network feature pod buttons not to observe NetworkHandler
  when it doesn't exist. It's cumbersome to mock NetworkHandler for all
  unit tests, and old SystemTray did the same. Also NetworkHandler will
  be refactored soon.

TEST=TrayEventFilterTest (--enable-features=SystemTrayUnified)
BUG=847104

Change-Id: I2b9b281d182d9fbbbf159e9374c53adb29a1c756
Reviewed-on: https://chromium-review.googlesource.com/1082140
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564714}