GitLab

The custom cell for password check is similar to the one needed for
safety check.  It is being renamed to settings_check_cell for more
general use.

The main difference is the whether or not an image is used on the
leading side of the cell. This CL adds an optional image to the leading
side of the cell for compatibility with both checks.

Bug: 1078782
Change-Id: I825bdcb53f624ce2e567a68dc900bddc310dc270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273162
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785836}

Once/Repeating

Change Bind and Callback to BindRepeating and RepeatingCallback
for nacl broker listener and nacl debug exception handler win.

Bug: 1007703
Change-Id: I1f9aac13d3478d2a121faedb47476d6455a427f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278855Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#785835}

This patch renames/removes the GL reference since the flag is
now used by SkiaRenderer too.

Change-Id: I0ca3dd171b379af6a926e5622b9f9230f09f8d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276807Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785834}

The change at r782918, which modified RunNode() to use shell=False,
broke this script, and started returning incorrect output (JS
comments were not stripped)

Bug: 1096473
Change-Id: I9d767d0ec2d92612ddf73c37e8ab70c4aedc6573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284015
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785833}

so that CL like this (crrev.com/c/2214761) can use it.

Bug: None
Change-Id: I685819c89b87603a542324431ba0a6d9a80eb1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283504
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785832}

Once/Repeating

Modified coded_frame_provider and its subclass buffering_frame_provider
and demuxer_stream_adapter to use OnceClosure and BindOnce.
Modified mock_frame_consumer/provider to use
OnceClosure and BindOnce.

Bug: 1007649
Change-Id: I9f464c65065c8676be8ee793a9ba6d099eff9863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278583Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#785831}

Bug: 1068400
Change-Id: I802b82616789443420957e28d87a64bfdb1c93c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283738Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#785830}

https://crrev.com/c/2203775 introduced storing of theme and font family
selections in a user preference. On page load, this was not taken into
account with the radio buttons for the theme selector or the select drop
down for the font family. This change ensures these UI elements are
updated correctly on page load to display the currently active theme
and font family to avoid confusion for users.

This patch also introduces some front end testing for the settings
dialog.

Bug: 1016615, 1070724
Change-Id: I2e45334d012b6d88e813c4bfd4f395adfa309413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208871
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785829}

When the event listener was added for shill::kProhibitedTechnologies,
it treated the property as a list (like other properties) however
the property is actually stored as a string in Shill:
https://chromium-review.googlesource.com/c/chromium/src/+/2197136

This was causing error spam when running on linux and in tests.

This fixes that and adds a test.

Bug: 1081488
TBR=tbegin@chromium.org

Change-Id: I502bfe3369d31514b0f6f8e338408d3433ad5cef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283934Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785828}

This is useful for debugging flaky tests with --iterations=n (or
repeat-each=n) and --exit-after-n-failures=1. Previously the first stderr
was kept which might be for a pass which was confusing in results.html
where the failure results and the passing stderr were displayed.

This doesn't affect normal runs (e.g. on bots) where tests are not
repeated in one run (not including retries).

Also output stderr for timeout tests, which is also useful for debugging.

Change-Id: I25c1296e14b22763f36eb96d4028896f28a11c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284215Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785827}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bee7cd569a4f..c5e8e8bf91ef

2020-07-07 chrome-bot@chromium.org Update config settings by config-updater.
2020-07-06 chrome-bot@chromium.org Update config settings by config-updater.
2020-07-06 smcallis@google.com Disable drallion hw tests due to rework on drallion360 DUTS.
2020-07-06 mmortensen@google.com BuildApi: Add sdk.Delete controller unit tests.
2020-07-06 saklein@chromium.org portage_util: Fix HasPrebuilt check.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I0a196d42ad944c8aba07f69631b574246a7a7d92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284946Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785826}

Bug: 819294
Change-Id: I04fb2cb5d939b9181ec8e42b0d0a9595b43c365a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283315Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#785825}

The idea behind this test suite is to ensure that Chromium always
compiles Abseil in hardened mode (see [1]) and that std types that will
replace Abseil types in C++17 will also support this feature (this
allows Chromium to detect if a lost of safety happens for example
when absl::optional will expand to std::optional).

[1] - https://cs.chromium.org/chromium/src/third_party/abseil-cpp/absl/base/options.h?l=211-236&rcl=39c12e538d4170e9061ac9661a156870b3389c17

Bug: 1096623
Change-Id: I2e35139cc15ce4fc4d1ff3b9743bb75ef72be888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256209
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785824}

See crbub/1094088 for the details. Briefly, when opening the first WebUI
NTP the navigation machinery tries to use the spare renderer at first
but discards the spare since it doesn't have WebUI bindings (yet). The
fix is to allow keeping the spare if no navigation has been committed to
it yet with the assumption that WebUI bindings will be granted later in
the navigation flow.

Credit goes to alexmos@ who came up with the fix and landed the
prerequisite CLs crrev/c/2275146 and crrev/c/2272029.

Using the spare renderer improves NewTabPage.LoadTime.WebUINTP from
~278ms to ~208ms on my linux machine.

Fixed: 1094088
Change-Id: I140d2d19b95f4d2dfd4f87a9278c18bc81e51bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250945
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785823}

Pull most of TestInterfaces out into TestRunner so that we don't need
to keep around both classes which overlap in responsibilities.

Stop plumbing through TestInterfaces to get to TestRunner, expose it
from the same places that currently expose TestInterfaces.

Add a list of main frames to TestRunner, and use that for windowCount()
which changes a couple of test expectations, as they were counting the
proxied RenderViewHost of a cross-site window. The problem is they would
also count same-site fragments of windows opened by other renderer
processes.

R=avi@chromium.org

Bug: 866140
Change-Id: I065916b4e5184a0fbb95981a2a69b6b5a90b0023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281067
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785822}

This CL moves responsibility of detecting idleness for starting
demo mode from CoreOobeHandler to two relevant screens.

Bug: 1100909, 1100910
Change-Id: Icd4142fdb75f3f7376b01d50b808078b42fb6872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277722
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785821}

R=anastasi@chromium.org

AX-Relnotes: n/a
Bug: 1100666
Change-Id: Id7020d13b9a7aa7cec33782d1513aa2bef8cae28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277870Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785820}

Add cached VPD info to the probe service.

Bug: b:158658869
Change-Id: I41854f62e19139e6fab9d15bda67460f2f55d2a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270144
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#785819}

Removed unused bits, inlined some of the code.

Bug: 1067260
Change-Id: I1e5be13ba9bc89f5ec1fa24e90652e4992c462f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279804
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#785818}

In normal cases the session ID returned by the MediaFoundation CDM
(IMFContentDecryptionModule) should never be the same. In the rare case
duplicate session IDs are returned, the current implementation will
crash.

This CL fixes the implementation and adds a unit test.

NOPRESUBMIT=true

Bug: 999747
Change-Id: I319c33517dd6452cb45ee30d3c1c02a41b0c6ccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278416Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785817}

Switches chrome_pdf::URLLoaderWrapper's API from pp::CompletionCallback
to base::OnceCallback. pp::CompletionCallback is still used internally
when calling Pepper APIs., but clients of URLLoaderWrapper no longer
need to deal with pp::CompletionCallback.

Using base::OnceCallback also simplifies resource management,
eliminating the need to manage references to pp::CompletionCallback.

With respect to thread safety, most Pepper APIs invoke asynchronous
callbacks on the original caller's thread, so there should be no new
thread safety issues. The base:: APIs also do sequence checking in
DCHECK mode, which should catch any unanticipated issues.

Bug: 1099022, 1101169
Change-Id: Ia355588b25b54a776ac972a7b5b2104b1a3b18c8
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278169
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785816}

Fixed: 1096770
Change-Id: I60f55f43534f3388801c1a5aca29f936861d7398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253128Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785815}

Bug: 1069010
Change-Id: I27b59f6abb61d81aeb368e183b934394a415e9bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276406
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785814}

https://android.googlesource.com/platform/external/perfetto.git/+log/b4e2a786fc30..509812647060

2020-07-07 treehugger-gerrit@google.com Merge "Fix ASAN failure in clock tracker."
2020-07-07 treehugger-gerrit@google.com Merge "Migrate scroll_jank related tables to the 'chrome/scroll_jank.sql' metric"
2020-07-07 fmayer@google.com Remove unnecessarily standard-incompliant code.
2020-07-07 fmayer@google.com Merge "Add banner for import errors to UI."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ib12d50535a4e032d07d49471d37541b628e533c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284945Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785813}

This adds a default behavior whereby clicking (or equivalent) will cause
the portal to immediately activate, unless the click or DOMActivate
event has preventDefault called by a listener.

This is guarded by a new runtime enabled feature so that this does not
affect the behavior in the current origin trial.

Bug: 1102081
Change-Id: I6a6c2409b0123f95d5068c54a423ac2f29e3e968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281308Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785812}

When you right click the URL in the omnibox, it should select the full
URL.

Bug: 1101679
Change-Id: I01e62bb0d6d85b01b79b0ff41e8b3830648d7b61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275749
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785811}

The strings telling users to turn on Android system settings had
"Chrome" hardcoded in them. This was incorrect for WebLayer, as well as
Chromium and non-stable Chrome versions.

Skip-Translation-Screenshots-Check: True
Bug: 1063433
Change-Id: I267b0b30cca0cca5074bceb981157e56ce78ccf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284354
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785810}

Bug: 1068400
Change-Id: I50e4e238dda647afb70c2e4fe9d29c6324ce61bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283625Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ilia Samsonov <isamsonov@google.com>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#785809}

Bug: 1100855
Change-Id: I6a0c6cda3c8bd452929346d8a9e547b24aa5c60c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279780
Auto-Submit: Matthias Körber <koerber@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#785808}

On Linux, use sched_getaffinity to count usable CPUs, so that runners of
Chromium can restrict cores with e.g. taskset.

This is observable locally by running

    taskset ./chrome

recording a trace with chrome://tracing, and checking the number of
foreground worker pool threads created.

Change-Id: I0402c1323a6e26a8fae6ce845e89a7c69d0acc25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270183
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785807}

svg/dom/content-model.html does some manual parsing of the layout tree
dump which breaks if the LayoutSVGRoot gets a paint layer. This patch
updates the test to pass if the LayoutSVGRoot has a paint layer or not.

Bug: 1101002
Change-Id: Ic7d3b13e57784f9d40c4998b56ea233a44045b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284869
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#785806}

This patch adds a function to the Chrome DevTools Protocol in the
WebAuthn Domain. This function makes it possible to choose whether an
authenticator responds to MakeCredentials / GetAssertion, by toggling
the automaticPresenceSimulation parameter in the authenticator.

Bug: 1086270
Change-Id: Ief1b98189201d039b087ad37cdfb967d03d3b054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280472
Auto-Submit: Fawaz Mohammad <fawazm@google.com>
Commit-Queue: Fawaz Mohammad <fawazm@google.com>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785805}

Thread priority should not be modified after a test.
If that is happening, it needs to be fixed in the code.

This CL remove the code that disable the priority checks.

NOTE TO SHERIFF:
 * please paste failure logs when reverting, the goal is
   to remove flaky tests related to thread priority.
 * assigned flaky test to etienneb@

R=gab@chromium.org

Bug: 1097092
Change-Id: Ib3fddf7372997fc0b3dea61c2020014d35bd9402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262254
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785804}

Bug: 1095641
Change-Id: I7558008667c0c3a83dbb19c9211bad78db1dd3fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272611Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#785803}

Bug: 1102828
Change-Id: I9c11111e018b1c5428c857e28511dcd9cbb98295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285042Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#785802}

Fix three Tab UI bugs:
1. The always translate checkbox in the menu was retranslating an
already translated page when toggled.

2. When reverting a translation from the tab UI, the model's view state
was not being updated. This meant if a user untranslated the page after
clicking the always translate button in the menu, then clicked always
translate again, the page wouldn't translate since the model's state is
incorrectly "translated" rather than "before translate".

3. The 'always translate' button beneath the tab UI was not being
updated when the always translate menu item was being clicked.

Additionally this CL removes some unused code that was missed in the
experiment cleanup.

Bug: 1099571
Change-Id: I0b3545463acc257ab69cd616bce2e9e833cf2ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269751Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785801}

Makes it easy to tell if the aura::Window is visible or not since this
information can't always be deduced from Layer or occlusion state.

BUG=None
TEST=Manually by inspecting an aura window that was hidden/visible.

Change-Id: I17f513de4b14f412ea6195e6ac2d928c5ba8e2ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283234
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785800}

This is a code health CL, no behavior change is expected.

Bug: 1007635
Change-Id: I2e83ea768461f2041fd173bca193e6e510d5d886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277250
Auto-Submit: Xida Chen <xidachen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785799}

Bug: 1068400
Change-Id: I5ac471fc28121a13f02f2d6824704eca8d017f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283631Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#785798}

The first one, Autofill.Autocomplete.{NotOff,Off}.
EditedAutofilledFieldAtSubmission.{Address,CreditCard}, measures how
frequently users change fields filled by Autofill, spliced by whether
autocomplete = off or not.

The second one, Autofill.Autocomplete.{NotOff,Off}.FillingAcceptance.
{NotOff,Off}, measures the how frequently users accept suggestions,
spliced by whether the field from which Autofill was triggered has
autocomplete = off or not.

Change-Id: If2491f59168c5c72284a4f418cb184b1b7722a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268997
Commit-Queue: Christoph Schwering <schwering@google.com>
Auto-Submit: Christoph Schwering <schwering@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785797}