GitLab

There were three different DependentIOBuffer classes, three similar
kBufferSize constants, two similar InitializeResourceBufferConstants
functions and two identical GetNumericArg functions.

Besides being potentially confusing, it causes clashes in jumbo
build experiments (chromium unity build system in development).

This patch moves around GetNumericArg (to merge the two copies) and
InitializeResourceBufferConstants (to make them not clash).
It renames the DependentIOBuffer classes which are deceptively
similar as well as the kBufferSize contstants and some other
variables that were not actually constants.

Bug: 746953
Change-Id: Id7cfa4baac0aa67a7b086896701aeab931e23a96
Reviewed-on: https://chromium-review.googlesource.com/723302Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#510042}

This reverts commit 885d259d.

Reason for revert: Need to test new sound card config on win bots.

Original change's description:
> Disables WebRtcAudioQualityBrowserTest on Windows
> 
> TBR=phoglund
> 
> Bug: webrtc:677256
> Change-Id: I84a0fdf08a25204231ee1869918ecbffc8bdca9d
> Reviewed-on: https://chromium-review.googlesource.com/677458
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Commit-Queue: Henrik Andreasson <henrika@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503516}

TBR=phoglund@chromium.org,henrika@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 677256,737090
Change-Id: Ie41beeec00b3e3fbc7702ba6c7fd8a754c567e18
Reviewed-on: https://chromium-review.googlesource.com/727919Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510041}

https://skia.googlesource.com/skia.git/+log/95c5e3392f3a..7ce549f32ec2

$ git log 95c5e3392..7ce549f32 --date=short --no-merges --format='%ad %ae %s'
2017-10-19 angle-deps-roller Roll skia/third_party/externals/angle2/ 082e70060..6dee4d8c1 (1 commit)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Ie475ccf71d28e6456355d00730515800592662b1
Reviewed-on: https://chromium-review.googlesource.com/727701Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510040}

Bug: 631937
Change-Id: I1b0396f0dc757d9f445909ce244a6f72e1983b49
Reviewed-on: https://chromium-review.googlesource.com/700443Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510039}

This CL enables swarming for all builders using GOMA_TESTS in chromium_fyi.py
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Bug: 776264
Change-Id: I4c31bc7f47788186629d661b34bb16e82e4cfe0b
Reviewed-on: https://chromium-review.googlesource.com/727679Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#510038}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/43e99bf7..f2f56bff

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Iab2f48e478c57bf6775b9bc91a6ed893e2f59bbe
Reviewed-on: https://chromium-review.googlesource.com/727625Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510037}

BUG=739343, 775825

Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0
Reviewed-on: https://chromium-review.googlesource.com/725342Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510036}

Historically, the Oilpan macros for Trace() methods were defined using
macros, since there were two different types of Visitors. The macros can
conditionally include virtual as well: however, this makes it harder to
enable the chrome clang plugin checks around usage of virtual, override,
and final. While it's possible to adjust the plugin heuristics to
account for these macros, the macro definitions are simple enough that
they are no longer needed. Replacement was automated using perl regex to
expand the macros. Manual fixes were required for:

  Source/core/dom/NthIndexCache.h
  Source/core/html/canvas/CanvasRenderingContext.h
  Source/modules/canvas2d/CanvasRenderingContext2D.h
  Source/modules/media_controls/elements/MediaControlDivElement.h
  Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
  Source/modules/vr/VRDisplayCapabilities.h
  Source/modules/vr/VREyeParameters.h
  Source/modules/vr/VRFrameData.h
  Source/modules/vr/VRStageParameters.h

Bug: 775741
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5901e047eb0f08050a00b8faab7ea731e7447db2
Reviewed-on: https://chromium-review.googlesource.com/726978
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510035}

Bug: 583291
Change-Id: I62f45a36db59b118a5f7a571252c4a4a705355b8
Reviewed-on: https://chromium-review.googlesource.com/725723Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510034}

These tests should have been re-enabled in 96a257b8, but weren't.
Do it for realz.

Bug: 570423
Change-Id: I3e2aa6e230af3412b854c2d2cb1a2dba03ced338
Reviewed-on: https://chromium-review.googlesource.com/725816Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510033}

I'm leaving Opera Software today.

TBR=eae@chromium.org
NOTRY=true

Change-Id: Id9e11f73d3a3cbc0f2a772f93945cff21e742933
Reviewed-on: https://chromium-review.googlesource.com/727981Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#510032}

When using network persistence and save a file that is not safe to save
with the desired name on the filesystem, devtools will now encode parts
that are deemed 'unsafe' to save on filesystem.

Example: 'con' and 'nul' are not allowed on windows. '?' also not
allowed on windows.

R=lushnikov,pfeldman
BUG=760316

Change-Id: I29bd227fc3f7f5f10a6b80ed45d21b6a7a6d34a2
Reviewed-on: https://chromium-review.googlesource.com/727195
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510031}

In e.g. some headless environments, we care about deterministic
rendering results. As the new content rendering timeout can affect page
rendering, we'd like a way to disable it.

This patch adds a command line switch to that effect.

Change-Id: Ib0c09aa57df82665ffb4f1290c8ad5d2761aa7bf
Bug: 776292
Reviewed-on: https://chromium-review.googlesource.com/725324
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510030}

This is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/647050.
This CL tries to reland the change after rebasing.

This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is
recorded when a Document object survives 5, 10, 20 or 50 garbage
collections after detached. If a document outlives such long time, the
document might be leaked. The UKM would be very useful to know where such
leaky documents exist and to fix them.

Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing

Bug: 757374
Change-Id: I1f64d2a9260d898c386bb948dd25a1c5586f8eb7
Reviewed-on: https://chromium-review.googlesource.com/722301
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510029}

When we want to return an empty WebString, just explicitly return a
WebString() instead of going through the

    const char* -> WTF::String::FromUTF8 -> WTF::String -> WebString

path to achieve the same thing.

Bug: 736308
Change-Id: If3c9a45b3cac140a1a2d9d48c2b68558d09f106a
Reviewed-on: https://chromium-review.googlesource.com/726085Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#510028}

Bug: none
Change-Id: Id75500ca8b83d211e2b5c3a786e92f030791aedc
Reviewed-on: https://chromium-review.googlesource.com/726855Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510027}

Instead, fake implementation is added into FakeLorgnetteManagerClient,
and it replaces MockLorgnetteManagerClient in unittests.

BUG=223061
TEST=Ran trybot.

Change-Id: I6d9cde402dda453e5b5bdc59c26c384dea6bfd90
Reviewed-on: https://chromium-review.googlesource.com/726039Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510026}

The following tests relied on a callback occurring within a 2 second
window
while an animation was in progress. We now allow 10 seconds.

animations/3d/matrix-transform-type-animation.html
animations/3d/transform-perspective.html
animations/cascade-important-keyframe-properties.html
animations/cascade-important.html

BUG=248938

Change-Id: If33bae00d4da904a5520c83cc85f314e6f7f400b
Reviewed-on: https://chromium-review.googlesource.com/722824Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510025}

All targets that need earl_grey are supposed to depend on
//ios/third_party/earl_grey:earl_grey+link, and those who depend on
//ios/third_party/earl_grey should not compile because
//ios/third_party/earl_grey doesn't have the corresponding header
search path cflags included in its public_configs, dependents don't
know where to find the generated EarlGrey.framework.

However, current code compiles because earl_grey depends on
ochamcrest+link, so dependents of earl_grey knows where to find
Ochamcrest.framework, and coincidentally, EarlGrey.framework and
Ochamcrest.framework are generated in the same directory, thus,
dependents indirectly knows where to find EarlGrey.framework.

This CL converts //ios/third_party/earl_grey to
//ios/third_party/earl_grey:earl_grey+link whereever possible, and will
have a follow up CL to generate EarlGrey.framework and
Ochamcrest.framework in different directories so that the above
mentioned error can be caught at compile time.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibec2be796aff27011689f0e342be4ec050819c39
Reviewed-on: https://chromium-review.googlesource.com/727189Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510024}

Support Active Directory policy in PreSigninPolicyFetcher:
Don't require a policy verification key for Active Directory.
Active Directory provided policy is not signed with any
verification key.

BUG=772372
TEST=unit_tests --gtest_filter=PreSigninPolicyFetcherTest*

Change-Id: I671713f890d1de0444f3fd462de061d8f18e373c
Reviewed-on: https://chromium-review.googlesource.com/707240
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510023}

https://chromium.googlesource.com/catapult.git/+log/2bc7fe7bc1e6..a25d87f24cc6

$ git log 2bc7fe7bc..a25d87f24 --date=short --no-merges --format='%ad %ae %s'
2017-10-17 benjhayden Split vulcanizing histograms_viewer.html from rendering Histograms in an HTML viewer.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id357cec400a91619e4d3cd5d6d2eb09ea9953a9d
Reviewed-on: https://chromium-review.googlesource.com/727720
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510022}

Change-Id: Ie9d4285be4f7bb9e436847ea42779e1828de8540
Reviewed-on: https://chromium-review.googlesource.com/727485Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510021}

This patch implements LocalVisualRectIgnoringVisibility() for
LayoutInline and LayoutText, that are used by PaintInvalidator.

This patch is still at the early iteration in a few ways:
1. Other similar functions (e.g., LocalSelectionRect()) are not
   implemented.
2. The inline fragment iterator is supposed to be useful for
   several other purposes. Making it more generic and applicable
   for other purposes is planned after we collect how we use it.
3. Adds ~20 new failures, part because CurrentFragment() is not
   available in some cases, part because overflow logic isn't
   complete yet. I'll look into these failures in following patches.

Bug: 636993, 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I55c607a40fcf705c46162577fd9a1255f3048da7
Reviewed-on: https://chromium-review.googlesource.com/718637
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510020}

TBR=kochi

Bug: 742715
Change-Id: I1bc4e37d5d1e707276f38bc11dfae2fe93c2d260
Reviewed-on: https://chromium-review.googlesource.com/727389Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510019}

Updated traffic annotation auditor to have more debug data.

Bug:656607
Change-Id: I5503d2be4c38b6b24f3d300dfb618ffab75d38ea

TBR=dpranke

Change-Id: I5503d2be4c38b6b24f3d300dfb618ffab75d38ea
Reviewed-on: https://chromium-review.googlesource.com/727759
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510018}

BUG=b:64195183
TEST=./validate_format.py && ./pretty_print.py
CQ-DEPEND=CL:697486

Change-Id: Ic1533ceb25f4b733c81612919b1dd08af6d989ab
Reviewed-on: https://chromium-review.googlesource.com/725005Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Joel Kitching <kitching@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510017}

Bug: 755727
Change-Id: Ib1224db452ea366eac2d5dd4d940b26fd5c1b035
Reviewed-on: https://chromium-review.googlesource.com/727374Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510016}

The notable thing of this CL is that it tied the lifetime of
content::WebServiceWorkerRegistrationImpl with
content::ServiceWorkerRegistrationHandle in the browser process, so that
they have a real 1:1 correspondence with the key registration handle id.

BUG=769236

Change-Id: I2773706a8c506bb0523e0e1960abecd65c4cc077
Reviewed-on: https://chromium-review.googlesource.com/686557Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#510015}

Moved VolumeControl from backend/alsa to backend directory. To remove
ALSA dependency added SystemVolumeControl interface that abstracts
functionaly implemented in AlsaVolumeControl.

Bug: 772488
Change-Id: I40575d873df00829b445dc8309ad0a61038009c8
Reviewed-on: https://chromium-review.googlesource.com/720076
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510014}

Bug: 771800
Change-Id: I15d2a3ecbbb331fe47e9d031712a99f998782e56
Reviewed-on: https://chromium-review.googlesource.com/720723Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#510013}

This CL changes how to manage observers of NetworkStateNotifier to use
handles in RAII way. Before this CL, we depended on the fact that
WebTaskRunner objects returned from TaskRunnerHelper::Get were always
same for the same execution context. Now we are trying to change the
fact and WebTaskRunnerImpl will always be created for each call.

This is part of the big CL for changing WebFrameSchedulerImpl::
*TaskRunner() to create WebTaskRunnerImpl anytime:
https://chromium-review.googlesource.com/c/chromium/src/+/704459

Bug: 762453
Change-Id: I5308e7cb0493d84c25e4da7f3562cd0fcff0f3af
Reviewed-on: https://chromium-review.googlesource.com/722859
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510012}

All tests that were executed in cast_alsa_cma_backed_unittests are
now built as cast_audio_backend_unittest. Updated all buildbot configs
to run the new test binary and removed the old one.

Bug: 772488
Change-Id: I8339687c082c8ffb828e9676700cd6f7e39ecfe9
Reviewed-on: https://chromium-review.googlesource.com/719726
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510011}

This reverts commit d7b19dd0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 510005 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q3YjE5ZGQwYmU1ZDNjNTUzOGRmYTcxYzkxMDgxMzllYTIxY2UwMGEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder/223434

Original change's description:
> Refer to ui::ResourceBundle with namespace.
> 
> ResourceBundle became ui::ResourceBundle in r72038 but many callers
> still refer to it without the namespace.
> 
> TBR=jamescook@chromium.org,treib@chromium.org
> 
> Change-Id: Ic0b7116beabc945ea4ac27cf4d65dc177274cc85
> Reviewed-on: https://chromium-review.googlesource.com/696139
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510005}

Change-Id: Ia38bdfba8d2468977ed81c3e8b7122430b4435a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/727078
Cr-Commit-Position: refs/heads/master@{#510010}

This reverts commit d7b19dd0.

Reason for revert: widespread compile failures, e.g.

../../ui/base/resource/resource_bundle_ios.mm:93:10: error: use of undeclared identifier 'sequence_checker_'
  DCHECK(sequence_checker_.CalledOnValidSequence());

Original change's description:
> Refer to ui::ResourceBundle with namespace.
> 
> ResourceBundle became ui::ResourceBundle in r72038 but many callers
> still refer to it without the namespace.
> 
> TBR=jamescook@chromium.org,treib@chromium.org
> 
> Change-Id: Ic0b7116beabc945ea4ac27cf4d65dc177274cc85
> Reviewed-on: https://chromium-review.googlesource.com/696139
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510005}

TBR=jamescook@chromium.org,sadrul@chromium.org,ben@chromium.org,thestig@chromium.org,treib@chromium.org

Change-Id: Ib4428ba90efe811331e8190c9d22608d94d51cd6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/727442Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510009}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6e0641b1536..037f9b80bbd8

$ git log e6e0641b1..037f9b80b --date=short --no-merges --format='%ad %ae %s'
2017-10-18 hinoka bot_update recipe: Upload source manifest

Created with:
  roll-dep src/third_party/depot_tools


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=phajdan.jr@chromium.org

Change-Id: Icf4107434c7ad220202d3c8f284d18d8c27a9fcf
Reviewed-on: https://chromium-review.googlesource.com/727123Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510008}

https://skia.googlesource.com/skia.git/+log/aa5c70636f61..95c5e3392f3a

$ git log aa5c70636..95c5e3392 --date=short --no-merges --format='%ad %ae %s'
2017-10-19 angle-deps-roller Roll skia/third_party/externals/angle2/ 23e028432..082e70060 (1 commit)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I46207e4de591598eb08bbe852dbdf1ddb95d5abf
Reviewed-on: https://chromium-review.googlesource.com/727256Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510007}

TBR=dtseng@chromium.org
Bug: 773866

Original change

Reviewed-on: https://chromium-review.googlesource.com/723606
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509911}
Change-Id: I74c39f7d8372b623a827dff89cc20b25f6485a2f
Reviewed-on: https://chromium-review.googlesource.com/727122Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510006}

ResourceBundle became ui::ResourceBundle in r72038 but many callers
still refer to it without the namespace.

TBR=jamescook@chromium.org,treib@chromium.org

Change-Id: Ic0b7116beabc945ea4ac27cf4d65dc177274cc85
Reviewed-on: https://chromium-review.googlesource.com/696139
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510005}

Previously all files used to build CMA backend on desktop builds of
cast_shell had "_default" suffix and were in the common backend
directory. Moved them to a separate directory and renamed them to use
"_desktop" suffix.

Change-Id: I26cb1791f3a9b8dfd8c133f1ff84739f79df5a6c
Reviewed-on: https://chromium-review.googlesource.com/717721
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510004}

Previously we create a child containment layer sized by
LayoutRect::InfiniteIntRect() when a layer has CSS clip-path. This is
because we used object.HasClipRelatedProperty() as the criteria, but the
layer only applies CSS clip and overflow clip. This confuses foreground
layer geometry computation, and resulted in an oversized foreground
layer.

This CL does the following things:

1. Change the criteria so that child containment layer is only created
when either CSS clip or overflow clip is present.

2. Simplify foreground layer and child containment layer geometry
computation, so that subpixel accumulation handling is more correct, and
also infer parameters from the parent graphics layer so the formula is
consistent for different layer hierarchy configuration.

BUG=773536

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic8074ef54270cdd2f628bc73f3bcb6fa929d8881
Reviewed-on: https://chromium-review.googlesource.com/722259
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510003}