- 13 Oct, 2020 40 commits
-
-
Alice Wang authored
This CL replaces the enum AccessPoint in account picker with a boolean to decide whether to show the incognito row. This is a refactoring. There is no behavior change with this CL. Bug: 1136802 Change-Id: I624b15ae24782428ff8f25ea0352c7af4790bd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460904Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#816575}
-
Matt Jones authored
This patch adds a check for the top edge of the viewport when propagating size change events. Previously only two of the three params were checked for differences when determining whether to send the event, now we check all three. Bug: 1136807 Change-Id: Id4a1b7cfac938a6bfd8fd21ae90fb8394d2806db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464915Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816574}
-
Miyoung Shin authored
This fixes a test failure of JavaBridgeBasicsTest#testObjectsInspection__MojoUsed since the ‘allow inspection’ variable is not updated when RemoteObjectGatewayHelper corresponding to the frame is already created. Bug: 1105933b Change-Id: I80c6fd3bcde77ea69b8bc445a3448c8ac69f5d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398071 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816573}
-
Sadrul Habib Chowdhury authored
The shared memory used for transporting ukm smoothness data is owned on the main-thread, but the write happens on the compositor thread. It is possible for the main-thread to discard the shared memory, and the compositor thread may still write to it in inopportune moments. To avoid this race, transfer the ownership of the shared memory to the compositor thread. BUG=1134659 Change-Id: I71df7ecc1393a0779c36b7d27a3496efb3bf2827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467356 Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#816572}
-
Jan Krcal authored
This CL makes sure the profile picker is skipped when an app is explicitly requested using a command-line parameter. Bug: 1123543 Change-Id: If894b3144946ea7d71bcfdf921563d65d4045cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464927 Commit-Queue: Tommy Martino <tmartino@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#816571}
-
Nico Weber authored
I haven't worked on this code in years and am doing a very poor job at doing reviews here. Bug: none Change-Id: I6dfdbe5b173ee5826205b337a6d1222bea2bf48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468057Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816570}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06b956fe4525..bc2dd313cf94 2020-10-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 2067d1a93e6e to f4f1d8a352ca (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: Ibe5c4928fd9055641769faa64563bf295bb8852c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816569}
-
Anton Bikineev authored
Otherwise, if proj or pred has base::internal as associated namespace, ADL can pick up the invoke functions from base::internal, which will result in ambiguous calls. Change-Id: I0659762dcb078427e820f5cbb90db807e126601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447549Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#816568}
-
Rushan Suleymanov authored
This is the second CL in chain which extends usage of the mock_processor in typed url sync bridge tests. This CL removes usage of old processor() method from all tests. The following patch will finally replace the existing processor with mock_processor. Bug: 791939 Change-Id: Iee7070cdd2fe5f584c2f9b7da99486b7412a78a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465851Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816567}
-
Jamie Madill authored
Example run time improvements, sum of all shards: Intel GPU on Windows: 10m 45s -> 3m 46s NVIDIA GPU on Windows: 13m 5s -> 4m 7s ATI GPU on Windows: 17m 23s -> 2m 33s ATI GPU on Mac Retina: 3m 20s -> 1m 0s Intel GPU on Mac: 3m 29s -> 1m 30s NVIDIA GPU on Mac Retina: 11m 41s -> 6m 7s Intel GPU on Linux: 5m 55s -> 1m 5s NVIDIA GPU on Linux: 26m 40s -> 6m 3s Bug: angleproject:5124 Change-Id: Iccbc0646b215d43f4f59c6af98fc3e1a80cb245d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412785Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#816566}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/2464913 made it so that thinlto links can use all available cores, and reduced the number of parallel LTO links to 1. This made individual links 30% to 60% faster, but the reduced parallelism caused bots to still got much slower in aggregate. Based on some handwaving, only a third of a thinlto link seems to be CPU-bound (https://bugs.chromium.org/p/chromium/issues/detail?id=1132930#c14), so try running up to 3 thinlto links in parallel. I expect we'll have to iterate on this heuristic some more. (And we might want to limit ourselves to 1 parallel thinlto link on Windows eventually, see first bug below.) Bug: 1132930,1137812 Change-Id: I77d9446195be4fb1171b8beba45205e91c89a875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467360 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816565}
-
Elizabeth Popova authored
As part of AutofillEnableSupportForMoreStructureInAddresses feature several new field types were introduced. Proior this change they were identified using regex but never counted as found because AddressField::Parse returned nullptr. Bug: 1137796 Change-Id: Idaa8d6d62faed5c593ca447739ecff3819fdc151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465843Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#816564}
-
sandromaggi authored
This CL uses the new |GetStringAttribute| web-action to get the required attribute for matching. It extends the previously |value| only action to also support |innerText|. This CL adds the support for |SelectorProto.TextFilter| as the RE2 enabled filter criterium. Bug: b/169924567 Change-Id: I182504434c7769674f6b9ddecc98d74cb57a4f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464265 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#816563}
-
Peter Marshall authored
Frontend CL: http://crrev.com/c/2456592 Disable CL: http://crrev.com/c/2461340 Bug: 1136848 Change-Id: I4117a51202dfc0ca9ec0eb31534de3300772809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462084Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#816562}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/387fd62a1280..c89a7ee628db 2020-10-13 egdaniel@google.com Use shared gpu memory size for all GrAttachments. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I2de9bace6ab18bcf98bb86c5154354878d2e99e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466852Reviewed-by:
-
Koji Ishii authored
Because BiDi embedding level resolution defined in UAX#9[1] is context dependent, a change in a text node may affect layout change in other text nodes. This patch |SetNeedsLayout| on affected |LayoutText| in such case. Reusing previous fragments in the line cache relies on |NeedsLayout|. Correctly setting |NeedsLayout| fixes it not to reuse the cache when such changes occur. Note that a runtime check added in r780647 crrev.com/c/2255943 also catches this case, so this problem does not cause out-of- bounds access but only incorrect layout and NOTREACHED. [1] http://unicode.org/reports/tr9/#Resolving_Embedding_Levels Bug: 1126809 Change-Id: I174f1eaf32ba0281dd7872a54a2ef1ad67b75933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467816Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816560}
-
Adam Langley authored
In the future, Android phones will likely expose their security key functionality over USB. This will be accessed by using the AOA[1] protocol to communicate with a specific app on the phone. A request for security key functionality is expressed by sending a magic string as the AOA "version". We don't wish to allow WebUSB, the USB extension API, or future users of the USB Mojo interface to be able to exercise this. Thus this change blocks such control transfers by default, unless the caller explicitly indicates that they expect to be sending security key messages. [1] https://source.android.com/devices/accessories/aoa BUG=1002262 Change-Id: I785610ee58e319327950200b7dfb230099cadf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462379Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#816559}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602567235-76a4ea133fcdb6cde619178f9199537d86205f8e.profdata to chrome-linux-master-1602590170-c380e8ad768b677fecdbe9d455856c6615b604e4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4f3f6d4754f57b39ec322676c988354a8aa2beaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468036Reviewed-by:
-
Hidehiko Abe authored
Currently, it is not constexpr, so may not be built on compile time. Actually, no-op editing of the keycode_converter.cc sometimes triggers static initializer check. Specifically, DomKey used in the tables is not constexpr aware, so this CL makes the change. BUG=1137426 TEST=Built on mac-rel bot. Made sure no static initializer check error. Change-Id: Ib2d070c0cc29c725d4b7a0df000940685086d570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462978 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816557}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602567235-69e1809554df433714edde9ed60539d7ae5c84b7.profdata to chrome-mac-master-1602590170-73bf0c77e912d9411bc2ad0c01b4d803226ee02b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifb739e6809ead608568c768bc276c9c2a789688d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466855Reviewed-by:
-
Lei Zhang authored
To make this work with the new layout, where the PDF plugin now lives in a <div>, make some PDF Viewer changes: 1) The PDF plugin element gets an attribute to mark it as having the new UI. 2) PepperPluginInstanceImpl looks for the attribute in PDF plugins, and calls the newly added blink::WebElement::SetTickmarks() on the PDF Viewer's "scroller" element. And make several Blink changes to accommodate this new need: 3) Some find-in-page tickmarks override code moves from blink::LayoutView up the class hierarchy to blink::LayoutBox. The tickmarks override data member moves to blink::PaintLayerScrollableAreaRareData. 4) blink::WebLocalFrame::SetTickmarks() is extended with a target blink::WebElement parameter. If non-null, SetTickmarks() finds the WebElement's LayoutBox for scrolling, and overrides the tickmarks using the code in (3), instead overrides the tickmarks in the blink::LayoutView. 5) PaintLayerScrollableArea looks at its tickmarks override rare data member and uses it if it is non-empty. Then they get painted as normal. Bug: 1135457 Change-Id: I211510a7b09544823d960219bda7128f8694aae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462167Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816555}
-
Ian Kilpatrick authored
Previously we'd apply line truncation when either -webkit-line-clamp was active, *or* if "text-overflow: ellipsis" was active. This patch disables the "text-overflow: ellipsis" branch when we are within a -webkit-line-clamp context. Bug: 1134483 Change-Id: I5ceb40732bd512e5eb8dc59365e10c4fdd4cf15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447610 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816554}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4a959bdd. With Chromium commits locally applied on WPT: cfa13307 "Revert "Enable "Immersive-AR" session for OpenXR runtime"" 9c6fd611 "[:is/:where] Drop pseudo_id when matching nested complex selectors" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ibe0f6188ac788553f180f2efb4f68b9a72e4f855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467682Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816553}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4b8d27d96b7..a08dc37d19e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I66ffd445b614f70afbe00a7918fcf113aaf1c415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465210Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4b8d27d96b7..a08dc37d19e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6658d0e0cbfbefd056303d8227dbc025bd97c81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465211Reviewed-by:
-
Mikel Astiz authored
This historic mechanism to inject dependencies into ProfileSyncService doesn't belong in SyncClient (dependencies to core sync logic / engine itself), and it's questionable whether it should remain in this form in BrowserSyncClient, where feature-specific dependencies are injected, and where multiple similar approaches coexist. Arguably, the most elegant and universal way to inject a dependency to a sync controller is to have full access to the KeyedService that owns the local model. Most controllers are simple and don't actually need this: all they need is a SyncableService or ModelTypeControllerDelegate. However, that introduces code inconsistencies that can be confusing. In this patch, the approach is unified for the remaining SyncableService types, after migrating history delete directives and preferences). The corresponding keyed services are directly injected via BrowserSyncClient and hence SyncClient::GetSyncableServiceForType() can be deleted. Change-Id: I8e80482e8657624dc7c1e15b6bcf0409ae4d1336 Bug: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463617Reviewed-by:
-
Maxim Kolosovskiy authored
This CL fixes two issues. Both issues occurred when |PasswordChangeInSettings| was splitted into two flags |PasswordChangeInSettings| and |PasswordScriptsFetching| (https://chromium-review.googlesource.com/c/chromium/src/+/2436339), but some uses of |PasswordChangeInSettings| were not replaced with |PasswordScriptsFetching|. The change is supposed to be merged to M87 Beta. 1. The param |scripts_list_url| should be read from |PasswordScriptsFetching| Scripts fetching is controlled by |PasswordScriptsFetching| flag, not |PasswordChangeInSettings| flag. The latter might be disabled while scripts need to be fetched. So, it makes sense to read the param from the relevant feature - |PasswordScriptsFetching|. To be on the safe side, the Finch config can provide the param for both features, but the param names must be unique even in separate features. So, this CL renames the param (the param value was not used yet, so we don't need to update any configs). 2. Scripts prewarming should be controlled by |PasswordScriptsFetching|, not |PasswordChangeInSettings|. This issue was not severe and therefore it was hard to notice: even if scripts were not prefetched in advance, scripts were requested when a password check page was shown (|PasswordCheckManager::RefreshScripts|). That method used the correct flag. Bug: 1095627 Change-Id: Ibcfccf5d1348403b5dd46a15515ce4f040cc8047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465913 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#816549}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e2dfd01ded55..b60eeeee9ddb 2020-10-13 jleconte@google.com Partially Revert: Fix 'Unknown git hash' when repository is not chromium. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649 Tbr: nuskos@google.com Change-Id: I3e319a236abac20a5461b449ea6a9346f2d71882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465727Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/599fe36ca9b3..62054633ee57 2020-10-13 kimanh@chromium.org Use skip list on 'stepInto' 2020-10-13 sigurds@chromium.org Refactor factory pattern in ConsoleViewMessage.js 2020-10-13 bmeurer@chromium.org [wasm] Show errors when WasmParser fails. 2020-10-13 jacktfranklin@chromium.org Fix component bridges tests 2020-10-13 sigurds@chromium.org Fix type for SortableDataGrid.create 2020-10-13 sigurds@chromium.org Remove DOM prototype patching of createTextChild(ren) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143,chromium:1136484,chromium:1137302,chromium:1137335 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf8cb03b55feefb8a600ea21ddfb2a1c99418170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466851Reviewed-by:
-
Maxim Kolosovskiy authored
This CL is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/2453289 Bug: 1133783 Change-Id: Icff794b1c644d311a7fa9f16248ee9a4f714da08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463823 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#816546}
-
Viktor Semeniuk authored
This change adds flag to enable Password editing feature on iOS. Bug: 1137475 Change-Id: Ia2b00e9be7c3bc2bf0fc3a49f8f21f3472e12dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466763 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#816545}
-
Colin Blundell authored
This CL eliminates the Java ads blocked infobar from depending on the //chrome-level R by adding Java resources to //components/subresource_filter/android and giving these resources the necessary contents / dependencies. This will facilitate componentizing the infobar for sharing with WebLayer. There is no behavioral change. Note: The somewhat-unexpected dep addition in //weblayer is to work around a weblayer packaging test that otherwise fails. cduvall@ is investigating the root cause of this problem. In any case, the dep addition is not problematic as the whole point of the componentization is that //weblayer will shortly be using this code :). Bug: 1116095 Change-Id: I5ceef180908b34a8f784e5b72a5e10886cf0efac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460727Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#816544}
-
Jan Wilken Dörrie authored
This change implements the base::IsContiguousIterator type trait and makes use of it in base::span's constructor to allow construction from arbitrary contiguous iterators, and not just pointers. Given the lack of std::contiguous_iterator_tag in C++14, the type trait is especially instantiated for iterators that are known to be contiguous. These include pointers, and the iterators for std::array, std::string and std::vector<T> (for T != bool). Lastly, this change adds an implementation of std::to_address, which allows obtaining the underlying address from a pointer like type. TBR=dcheng Bug: 828324 Change-Id: I00d44c5edf8d86f811b7b2d32f07fa15e084d987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093215 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816543}
-
Alexander Bolodurin authored
The cache was introduced in https://crrev.com/c/616409 but was only used to get File::Info for an entry, and the calls to get ExtraFileMetadata made a mojo call each time, even though both functions draw data from the same source (ARC Document objects). It did not impact read-only providers, as the extra metadata returned for them is currently static, but this will change when dynamic metadata is added (DocumentsProvider thumbnail flag). Also, ArcDocumentsProviderRoot::GetMetadata is renamed to GetExtraFileMetadata to disambiguate it from a file system operation with the same name. Bug: 1049966 Change-Id: I94e0dc50e8a646a68b8c7b76e398c7777f4da121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464518 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816542}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1479f79a5304..33bd4fbe1e5b 2020-10-13 ilnik@webrtc.org Remove deprecated video_frame_i420 build target If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1132299 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iabb972d7151a2c8c8ea2226be36db5adad1d992c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466850Reviewed-by:
-
Mohamed Amir Yosef authored
This is to protect against avatar with white background. Screenshot: https://screenshot.googleplex.com/BwjbErJCcuxSCw9 Bug: 1100814 Change-Id: I555f05277e540da623402550a5d8b01323838fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465909 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816540}
-
Rainhard Findling authored
Bug: 1087263,1136855 Change-Id: Ic2799373e50d7f2f15513d126214f596581f1244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465752Reviewed-by:
-
Nazerke authored
This CL add a new TabStrip view to BVC. Bug: 1132236, 1128249 Change-Id: Ife191e6de13b8bbf700fb5ae4abe3fcb34a948e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436537Reviewed-by:
-
Miyoung Shin authored
This CL passes the annotation class from JavascriptInjectorImpl to RemoteObjectRegistry when the object id of the named object or transient object is generated, and we get it from RemoteObjectRegistry when RemoteObjectImpl is created. The transient object should inherit the annotation class from the parent's one. Bug: 1105940 Change-Id: Ica8625113b5d4caf32c3e51a947179d1fb6b4514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397974 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Jan Wilken Dörrie authored
This change gracefully handles a null PasswordManagerDriver in PasswordGenerationPopupControllerImpl::PasswordAccepted instead of forcing a CHECK failure. Bug: 1133635 Change-Id: Ife83a3c8c78b5dff18c3252c3beb0092750d4420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463834 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
