- 30 May, 2019 40 commits
-
-
Patrick Noland authored
This also creates a proper preview for SadTab. Bug: 952331 Change-Id: I53b7debf3fcc92fb7fbe27a13244f9a9466f49ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631361Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#664970}
-
Charles Zhao authored
We are not using background time logging for TabDiscarder for now; so it's better to disable it. We still need to enable it in some unit tests for the test to verify the logic. Bug: 968390 Change-Id: Ic6a16bcd53d9feed918c29cddf86777a4583d5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636663Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664969}
-
Patrick Monette authored
Bug: 921746 Change-Id: I27883781239fcb914088f6ce3fc4a82581177729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632530Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#664968}
-
Robert Liao authored
Now that there is only one style, the temporary |label| is no longer needed. BUG=642920 Change-Id: Iddb86740c94142b35d5e2da66bdbcdd443441863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637641 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#664967}
-
Wei-Yin Chen (陳威尹) authored
The backing bitmap was not released after the Grid-to-Tab transition animation. Bug: 964406 Change-Id: I33cd9249528202b83851721f3ffa824c52aeaa63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636833Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664966}
-
Nigel Tao authored
This fixes `unit_tests --enable-features=AppServiceAsh --gtest_filter="AppSearchProviderTest.InstallUninstallArc"`. It fails before and passes after this commit. Note that `unit_tests --gtest_filter="AppSearchProviderTest.InstallUninstallArc"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: I50f782a0d7d7b40392809421ea4705c5f1df571b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637010Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664965}
-
Mason Freed authored
Prior to this CL, the filter scale was not being used when applying backdrop-filters. This had the effect of making blur radii (etc.) incorrect on high-dpi screens, with a device scale factor != 1. Bug: 965523, 968791 Change-Id: I0eac2d6775cbfa96239d91fb199d8905bb330524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637585 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#664964}
-
Jacob DeWitt authored
When using a Daydream controller with a Mirage headset, the controller position and orientation would get stuck when taking the headset off and putting it back on. Doing so fires an input state change event which causes the XRInputSource to be re-created. The copy constructor for XRInputSource did a shallow copy of its grip and target ray spaces which meant they still point to the old XRInputSource object which no longer is exposed to the webpage or receives updates via mojo. Fix this by making the XRInputSource copy constructor create new target ray and grip space objects that point to the new XRInputSource object. Bug: 968544 Change-Id: I33542bde17bac70d57569bcdcce4a0206d8f45ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637239 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#664963}
-
Haiyang Pan authored
TBR=toyoshim@chromium.org NOTRY=true Bug: 966624 Change-Id: I9428e8b686498f46c7c15ad75e83b08ad996a6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636261Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#664962}
-
Sinan Sahin authored
In its current form, the screenshot mode only disables modal dialogs. We observed that in-product help bubbles are sometimes visible in the screenshots. This CL adds to the screenshot mode by disabling all IPH. Bug: 964012 Change-Id: I778708ad3d5f6d59c65c9da3097ca7f020e2b151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630226 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#664961}
-
Andreea Costinas authored
Chrome forwards the proxy exception bypass list as a string with host names delimited by semicolon [;] while ARC expects a colon [,] delimiter. This causes loss of network conectivity in ARC. This CL formats the proxy bypass list sent to ARC by replacing delimiters and removing the rendundant delimiter at the end of the string bypass list. 1. setup an Ethernet proxy connection with no bypass list 2. verified ARC and ARC app have network connectivity 3. added one host in the bypass list 4. verified ARC connectivity is lost 5. deployed Chrome with fix on the device 6. verified ARC has network connectivity 7. verified app on ARC respects proxy and proxy bypass item 8. added three host names in the bypass list 9. verified ARC app respects bypass list for all hostnames Bug: b:133193788 Change-Id: I363879fe886e3c7abc6557ef163b0d930398b7d7 Tests: manually tested with following steps Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630481Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#664960}
-
Dale Curtis authored
All known issues should be fixed, so lets try this again. BUG=879406 TEST=bots TBR=liberato Change-Id: I88e703e65d767d5a501b5f4ae4f7334572481672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637606Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#664959}
-
Lily Chen authored
This CL adds deprecation messages for cookies that would be blocked under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure, to be logged to the console on getting/setting potentially affected cookies via `document.cookie`. Bug: 966576 Change-Id: Ic8a4b535b019254b8021abb583db1d32b6023a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633972 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#664958}
-
Caleb Rouleau authored
Instead, ask readers to use the isolated output directory to find the exact logs that they are looking for. This will clean up the swarming task output to simply become a summary explaining which benchmark runs were kicked off. Bug: 947103 Change-Id: I199530972acd5f1402396ddda10ac82cf61fc229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629432Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#664957}
-
Alison Maher authored
This change exposes platform specific functions through the manager to allow for iframe traversal in AXNodePosition. Such traversals were not previously possible since AXNode and AXNodePosition have no concept of iframes. Functions GetParentTreeID(), GetParentNodeID(), GetChildTreeID(), GetChildNodeID(), and GetChildCount() were added to AXTreeManager and BrowserAccessibilityManager in order to allow callers to access nodes outside their own tree, as in the case of iframes. In AXNodePosition, AnchorChild(), AnchorParent(), AnchorChildCount() and GetAncestorAnchors() were all updated to use the newly added manager functions. The result is that AXNodePosition now more closely matches iframe functionality in BrowserAccessibilityPosition. Bug: 928948 Change-Id: If74bfc66f1265110797e5eb315e23e2462da2a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591484 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#664956}
-
Lily Chen authored
Identify cookies on get/set in URLRequestHttpJob that come up as CookieInclusionStatus::INCLUDE, but would be blocked if SameSiteByDefaultCookies or CookiesWithoutSameSiteMustBeSecure were enabled, and copy them into the list of excluded cookies, so that appropriate console messages can be displayed about the impending deprecation. This only covers get/set via HTTP headers. Get/set via document.cookie will be handled separately. Bug: 966576 Change-Id: I7edffc66956743cdad3bee6eb13e342eb3e07ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625841 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
-
Mason Freed authored
This CL cleans up the layout tests for backdrop-filter: - The backdrop-filter-bleeding.html test was never really complete, and the effect it was testing for is completely covered by the existing external/wpt/css/filter-effects/backdrop-filter-edge-pixels.html test. - The backdrop-filter-boundary.html test never had a valid expectation file. It now does, and the test has been made a bit more obvious. It already passed. - Another CL (http://crrev.com/663338) made the backdrop-filter-clipped.html test pass. Bug: 497522 Change-Id: Ib95edda9dfb15fc451eaeb225310d422d70787df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637490 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664954}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/12899533d341..8fd3d327fa3c git log 12899533d341..8fd3d327fa3c --date=short --no-merges --format='%ad %ae %s' 2019-05-30 vtsyrklevich@chromium.org Update PDFium PartitionAlloc hooking 2019-05-30 thestig@chromium.org Add a test for CCodec_ProgressiveDecoder. 2019-05-30 thestig@chromium.org Add more tests for FPDF_SetPrintMode(). 2019-05-30 thestig@chromium.org Use SkAutoCanvasRestore in fx_skia_device.cpp. 2019-05-30 tsepez@chromium.org Add another interface to prevent fwl -> fxfa inclusion. 2019-05-30 thestig@chromium.org Delete infra/config/cq.cfg. Created with: gclient setdep -r src/third_party/pdfium@8fd3d327fa3c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956824,chromium:895009 TBR=pdfium-deps-rolls@chromium.org Change-Id: I6b061e6159db33528d48e0b4e85d9b68e278090c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664953}
-
Dale Curtis authored
Since we started allowing play() to occur before the future data state, we can now run into cases where MultiBuffer ends up increasing its buffer sizes before renderer initialization starts. It will not satisfy reads until the new larger buffer sizes are fulfilled, which causes playback startup delays. There's no reason to do this since we can just increase the size after playback starts without penalty. So prevent size increases before kReadyStateHaveEnough and invoke them only after reaching that state. BUG=965684 TEST=new unittest. R=sandersd Change-Id: I0a7a37528f8c814731a34b6bcc4a6c9a3f9ca5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637527 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#664952}
-
James Cook authored
This is a port of the "app drawer" tests from chrome/test/data/webui/settings/settings_ui_browsertest.js For now, we have a similar side-nav drawer UI, so we use similar tests. Bug: 967876 Test: browser_tests Change-Id: I9feda52127f4ffb51b8d56c6cd0160ecb8153bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636590 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#664951}
-
Erik Chen authored
Change-Id: Iabc239d78dde1bf746f6184fdc5f539a0a02637c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637601 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#664950}
-
Aaron Tagliaboschi authored
These methods will (eventually) be used to pass raw header information (both request and response) from the network service directly to the browser process, bypassing the render process. Currently sends information about cookies that were excluded or flagged before being sent in a request or stored in a response. In NetworkServiceClient, a deprecation warning is fired if a cookie runs afoul of the new samesite cookie rules (described in draft-west-cookie-incrementalism) and then fires a verbose message for each cookie. These messages will fire if the feature is on and the cookies are truly blocked and also when the feature is turned off and the feature is flagged by the code in <crrev.com/c/1625841> Also adds use counters for the deprecation messages to measure compat risk. Bug: 856777,966576 Change-Id: Ibf49035bdaf4b20cf0d82e1c1b00e54d4050c0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600541 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#664949}
-
Liquan(Max) Gu authored
The opacity check is unnecessary for FCP++ because: "we won't paint opacity:0 layers if the layer has no hint that it will change opacity". Bug: 968575, 957674 Change-Id: I4adf1c2bba37fcdfc1511580d40481943ce1a444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637724Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664948}
-
Saman Sami authored
It's better to grab it from SurfaceClient since it's constant for all surfaces of the client. Bug: 938947 Change-Id: I4e5c5d986ac7a91146f9fa1677fa472ba5b9a4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637436Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#664947}
-
Scott Haseley authored
The starvation scores for the high and very high priorities were inverted, so very high was acting as if it was between normal and high priority instead of high and highest. Bug: 863341 Change-Id: I98c62cbdc859560b2883375b251c711b8dc13e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634549Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#664946}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e6d52d6c. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." e1be827e "Reland "Use promise in wpt pointer event tests to finish the tests"" 5b933889 "Reland "Adding support to bitmaprenderer in OffscreenCanvas"" 22e874da "Reland "Keep scroll by keyboard after child focused node is removed"" 9d90efc8 "Deflaky pointerevent_touch-action-inherit_child-auto-child-none_touch.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ie7162112c61ac4fcbc2eebdf6d92413310c17333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637530Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664945}
-
Chris Lu authored
Before this change, selectAndScrollToMatch() was selecting the n-th total match, including invisible matches, and if the n-th match was not visible, the next visible match was selected. In addition, it was returning the total index value of the selected match, which included invisible matches. This is particularly problematic when the first overall match was not visible. The logic would select the next visible match and return that match's overall index. It could not return 0 because the logic has no idea how many visible matches precede that index. To remedy these issues, always select the n-th visible index and return that n-th visible index value. Bug: 965834 Change-Id: I45607c18b8532132de304d230b6a9537c37c9f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626658 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664944}
-
Zhenyao Mo authored
This CL only prints out the info in a test, so we could take a look and wire them up in a follow-up. Part of this CL will be reverted after we get the info. This should only affect gl_unittests and should not turn any bots red. I believe this is the least intrusive way to gather what we need. BUG=967860 TEST=bots R=sunnyps@chromium.org Change-Id: I216151660263a575a48542a2c21d914d0f12e3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637863Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664943}
-
Shimi Zhang authored
Test is flaky. TBR: gogerald@chromium.org, rouslan@chromium.org Bug: 968797 Change-Id: Ifda5c81c08142428ef25cd7093ea823eb68bc639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637862Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664942}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f630b2534321..c0d7ee45d45f git log f630b2534321..c0d7ee45d45f --date=short --no-merges --format='%ad %ae %s' 2019-05-30 sugoi@google.com Disable double inline warning in LLVM project Created with: gclient setdep -r src/third_party/swiftshader@c0d7ee45d45f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I0d8bbe7d28c3f0280ff33b3e764136d548ae40e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637769Reviewed-by:
-
Patrick Monette authored
The caller is already assumed to take on ownership of the return value (See browser_main_loop.cc). Wrapping it in a unique_ptr makes this explicit. Tbr: tapted@chromium.org Tbr: thakis@chromium.org Tbr: seantopping@chromium.org Tbr: rdevlin.cronin@chromium.org Tbr: boliu@chromium.org Tbr: skyostil@chromium.org Tbr: oshima@chromium.org Change-Id: I9e9d4944519be30fdbc53c3fb3fbd4083e3b2785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632532 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#664940}
-
Aaron Tagliaboschi authored
Bug: 856777,966576 Change-Id: Ie4500ae83fc0371cf091648519b532cc3b96f7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637033Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Chris Harrelson authored
In particular, non-axis-aligned transforms are not allowed. Bug: 968255 Change-Id: I01151d08fe1f3a6fdf1aad95950c0be672776cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636437Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664938}
-
Ben Pastene authored
It's been folded into dep:chrome. Bug: 963618 Change-Id: Id98b1e01116538f2c9c2f9ddccd9ac023e33d44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637479Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
This CL implements the global shelf and Alt+Tab window activation: - Windows on inactive desks can be activated via the shelf or Alt+Tab, upon which the active desk will be switched. - Shelf menu lists browsers from all active and inactive desks. - Entering tablet mode, maximizes all windows on active and inactive desks. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c38 BUG=866622 Change-Id: I5c5dea1374131e372c4109c4023942c0d4625a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628176Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
Bug: 960467 Change-Id: I3f8c37efeadf1c2792500574952f57766f410e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636576Reviewed-by:
-
Peter Kotwicz authored
BUG=None Change-Id: Ie013396ba56d891d569ab5a3bb305b16e1a0626c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629331 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
Shelf bounds update (e.g. from alignment change) during overview animations is ignored and should be applied after the animations. Bug: 964910 Change-Id: I8d10de13954b5421c345a90ff601bafbe481cabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636566Reviewed-by:
-
Xianzhu Wang authored
ReplacedContentTransform bakes the offset into it, so the contents layer should have zero offset from transform node. Bug: 967652 Change-Id: Iadfe3354286b9847acf41dd88822e40f73ccab64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636601Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664932}
-
Michael Crouse authored
Initial changelist to provide support for preventing the HintsFetcher from requesting hints for hosts that were visited before DataSaver was enabled. This adds a DictionaryPref, kHintsFetcherTopHostBlacklist, to hold a blacklist of hosts in the users browser history before DataSaver is enabled. The change uses the blacklist by removing the hosts it contains from the hosts returned by the PreviewsTopHostProviderImpl. Future changelists will add logic for when to initialize and update the blacklist as well as populating it with the the hosts in the site engagement service when DataSaver and HintsFetcher is initially enabled. Bug: 943846 Change-Id: I6fa9a28609f9712cbe1d15904de778e7bbf896f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625823 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#664931}
-
