GitLab

Everything necessary to use the existing display to touch input-device
association/transform code is accessible from mus now.
ScreenManagerOzone creates a TouchTransformController and tells it to
compute new transforms when the display configuration changes. That's
it.

Delete existing touch code that was added to the WS to associate a
single display and touch input-device.

BUG=679747

Review-Url: https://codereview.chromium.org/2627623003
Cr-Commit-Position: refs/heads/master@{#443162}

This change allows geolocation access for the default search engine if
it would have access to geolocation information via the X-Geo header.

To effect this, a new setting is enabled controlling whether the default
search engine has geolocation access. This is only used if the search
engine supports the X-Geo header, i.e. it is Google.

The setting is consulted for the DSE both when deciding if the X-Geo
header should be added, and when deciding if geolocation API access
should be granted.

To allow the UI to make sense and provide the greatest clarity, the
setting should always be consistent with the underlying content setting
for the DSE's origin. In this end it is initialized accordingly and
various checks are in place to keep it consistent.

BUG=674389

Review-Url: https://codereview.chromium.org/2612993002
Cr-Commit-Position: refs/heads/master@{#443161}

https://skia.googlesource.com/skia.git/+log/8d80bb5f20d8..e4ca362259a3

$ git log 8d80bb5f2..e4ca36225 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 reed add win subclass of raster-allocator

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2625933005
Cr-Commit-Position: refs/heads/master@{#443160}

Now if Map() failed, we clear |data_| and |size_|, but |pp_resource_| is
not cleared. Therefore, if the caller calls buffer.is_null() it will
return false. Since the Init() failed, buffer.is_null() should return
true.

In this CL, if Map() failed, we call Clear() to explicitly clear
|pp_resource_|.

BUG=679801

Review-Url: https://codereview.chromium.org/2629543002
Cr-Commit-Position: refs/heads/master@{#443159}

Purpose: This should prevent upstream changes in manifest from breaking
import or test runner unexpectedly.

BUG=678077

Review-Url: https://codereview.chromium.org/2630493002
Cr-Commit-Position: refs/heads/master@{#443158}

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414

Review-Url: https://codereview.chromium.org/2608423002
Cr-Commit-Position: refs/heads/master@{#443157}

Previously, when tab button was clicked up to thumbnail view option in
gallery, the tooltip for the option did not work. This is also true of
slide view option in thumbnail mode. Both issues are resolved with this
patch.

BUG=549547
TEST=manually tested in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626973004
Cr-Commit-Position: refs/heads/master@{#443156}

BUG=405845

Review-Url: https://codereview.chromium.org/2606733003
Cr-Commit-Position: refs/heads/master@{#443155}

Changes:
stylus 'touch' event is no longer mouse event based on the cl: https://codereview.chromium.org/2507503002/, which leads to this cleanup change.

BUG=633304
TEST=tested that stylus touch event will not wake the device (both in
laptop mode and tablet mode) on kevin.

Review-Url: https://codereview.chromium.org/2621373003
Cr-Commit-Position: refs/heads/master@{#443154}

BUG=None

Review-Url: https://codereview.chromium.org/2543643006
Cr-Commit-Position: refs/heads/master@{#443153}

The interface is no longer needed since we've added GetService<T>()
to the manager class.

BUG=672840
TEST=try

Review-Url: https://codereview.chromium.org/2623273003
Cr-Commit-Position: refs/heads/master@{#443152}

It's been implemented as just "user-select" since Chrome 54.

This was accomplished with:

for type in none text auto; do
  git gs "\-webkit-user-select: $type;" -l | \
      xargs perl -p -i -e "s/-webkit-user-select: $type;/user-select: $type;/g"
done

And a bunch of manual alpha sorting of rules :(.

R=fukino@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2621993006
Cr-Commit-Position: refs/heads/master@{#443151}

On Chromecast we want media logging to be enabled on release builds by
default so that it gets recorded into device logs and sent with
feedback reports from end-users.

Review-Url: https://codereview.chromium.org/2625623002
Cr-Commit-Position: refs/heads/master@{#443150}

Cr-Commit-Position: refs/heads/master@{#443149}

Previous, Gonzales was cherrypicking files from Common module for the
TextRange class which was used as a struct.

BUG=none

Review-Url: https://codereview.chromium.org/2625163002
Cr-Commit-Position: refs/heads/master@{#443148}

BUG=676829
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629513002
Cr-Commit-Position: refs/heads/master@{#443147}

The main change is static_cast-ing a few chars in ported code to
unsigned chars because on some platforms by default char is signed,
on others it's unsigned.

GitHub page showing the diff:
https://github.com/google/cld3/commit/ae02d6b8a2af41e87c956c7c7d3f651a8b7b9e79

BUG=

Review-Url: https://codereview.chromium.org/2627143002
Cr-Commit-Position: refs/heads/master@{#443146}

BUG=

Review-Url: https://codereview.chromium.org/2628613002
Cr-Commit-Position: refs/heads/master@{#443145}

Review-Url: https://codereview.chromium.org/2604223002
Cr-Commit-Position: refs/heads/master@{#443144}

BUG=none

Review-Url: https://codereview.chromium.org/2626173002
Cr-Commit-Position: refs/heads/master@{#443143}

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2528513003
Cr-Commit-Position: refs/heads/master@{#443142}

If a mousedown event was set to preventDefault() and the focus was
in a text input field, it won't blur the focus from the text input
field, and the following mouseup event will update the TextInputState of
the widget with the same TextInputType and ShowIme::IF_NEEDED.

If this is a minimize button of an app for example, the widget will hide,
but the later received IPC msg to UpdateTextInputState() will cause the
virtual keyboard to show up.

We need to make sure that the virtual keyboard is not shown as a result of
UpdateTextInputState() unless there's a valid text input client.

BUG=430026
TEST=Enable the virtual keyboard from settings. Open feedback app
(Alt+Shift+i) and minimize it. The virtual keyboard should not show.

Review-Url: https://codereview.chromium.org/2626903004
Cr-Commit-Position: refs/heads/master@{#443141}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626083005
Cr-Commit-Position: refs/heads/master@{#443140}

Adds disk configuration calculations that are slightly specialized for
Android, ChromeOS, and general desktop. The max memory space and disk
spaced are set based on the total RAM and disk of the device.

BUG=375297

Review-Url: https://codereview.chromium.org/2552153002
Cr-Commit-Position: refs/heads/master@{#443139}

Manual Revert of Reland: chromeos: Fix shelf appearing at login screen under mash (patchset #7 id:140001 of https://codereview.chromium.org/2625733003/ )

Reason for revert:
compile broken and reverting https://codereview.chromium.org/2628973002 didn't seem to fix it.

Original issue's description:
> Reland: chromeos: Fix shelf appearing at login screen under mash
>
> The reland adds a fix for a crash in window animation code when restoring
> a session that has a minimized window. The animation tries to compute a
> shelf item position before the shelf is initialized. The animation is not
> visible to the user. Returning an empty rect results in a default target
> position, which is fine in this case.
>
> Added guards for access to ShelfView before shelf is initialized.
>
> Original CL description:
>
> Previously chrome --mash would always create the shelf on startup, even at
> the login screen. Now it waits until login is complete, like classic ash.
>
> Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
> shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
> flows this doesn't matter, but for supervised user creation it means that the
> shelf is not created until the flow is completed. This is an improvement
> because in the old code the shelf would be created too early and had to be
> explicitly hidden.
>
> Always create a SessionControllerClient in chrome, even in classic ash. This
> allows classic ash to use the mojo pathway via ash::SessionController.
>
> Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
> delay showing the shelf until post-login OOBE (like avatar picture select)
> was complete. It does not seem to be needed anymore, either in production or
> in tests.
>
> Change AshTestImplMus to simulate a user logging in which is required to
> create the shelf on the primary display and also to have a non-zero user
> count to create the shelf on additional displays.
>
> Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.
>
> BUG=666021, 679513
> TEST=ash_unittests and chrome browser_tests
>
> Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
> Cr-Commit-Position: refs/heads/master@{#439845}
>
> Reverted:
>
> Review-Url: https://codereview.chromium.org/2619943002
> Cr-Original-Commit-Position: refs/heads/master@{#442484}
> Review-Url: https://codereview.chromium.org/2625733003
> Cr-Commit-Position: refs/heads/master@{#443106}
> Committed: https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4d01aa0569c1c

TBR=msw@chromium.org,xiyuan@chromium.org,sky@chromium.org,jamescook@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=666021, 679513

Review-Url: https://codereview.chromium.org/2627243003
Cr-Commit-Position: refs/heads/master@{#443138}

This allows them to be used on iOS.

This CL also makes estark@ and lgarron@ owners of page info strings.

BUG=679976

Review-Url: https://codereview.chromium.org/2620123003
Cr-Commit-Position: refs/heads/master@{#443137}

destructor, instead of in the middle of a loop(?!) in the destructor.

BUG=679968

Review-Url: https://codereview.chromium.org/2625813004
Cr-Commit-Position: refs/heads/master@{#443136}

Review-Url: https://codereview.chromium.org/2625233003
Cr-Commit-Position: refs/heads/master@{#443135}

R=dpapad@chromium.org
BUG=680336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623363002
Cr-Commit-Position: refs/heads/master@{#443134}

The CSSValue must be a CSSPrimitiveValue containing a CSSCalcValue.

For example:
testElement.style.width = "calc(4 * (5em - 2px))";
testElmenet.styleMap.get('width');
// Returns CSSCalcLength({px: -8, em: 20})

Also removes redundant test typedcssom/inlinestyle/left-top-right-bottom.html
(superceded by typedcssom/inlinestyle/properties/bottom.html; will
add the others later)

BUG=545318

Review-Url: https://codereview.chromium.org/2371673002
Cr-Commit-Position: refs/heads/master@{#443133}

FloatRect::enclosingIntRect is hot on blink_perf.paint's paint offset
microbenchmark. A similar change to inline LayoutRect::enclosingIntRect[1]
was a large perf win [2] and this patch should have similar benefits.
There are relatively few callers so the risk of binary bloat is low.

enclosedIntRect and roundedIntRect are two additional candidates for
inlining but I'd like to separate these changes so we can measure
the impact (perf, binary) independently.

[1] https://crrev.com/af2c8d1e6a537c356b4cf931bb5aca1e5f09f119
[2] https://chromeperf.appspot.com/group_report?rev=436323

BUG=678597

Review-Url: https://codereview.chromium.org/2628903003
Cr-Commit-Position: refs/heads/master@{#443132}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/dcd70be386e3..d71b47153f16

$ git log dcd70be38..d71b47153 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 dtu [pinpoint] Explicitly differentiate between missing and empty parameters.

BUG=680266

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2628003003
Cr-Commit-Position: refs/heads/master@{#443131}

Collected cookies when invoked from the site info bubble (padlock ->
Cookies -> click the "X in use" link) is already hooked up to
--secondary-ui-md. However, it can also be shown via the content
settings bubble when a cookie is blocked.

We also need TabDialogs' Signin confirmation dialog switched to Harmony,
so set up a way to show Harmony dialogs from the TabDialogs interface.

Opt collected cookies into DialogBrowserTest to make it easy to invoke
for testing.

BUG=654151, 677012, 610428

Review-Url: https://codereview.chromium.org/2534743002
Cr-Commit-Position: refs/heads/master@{#443130}

R=danakj@chromium.org
BUG=670043

Review-Url: https://codereview.chromium.org/2627713002
Cr-Commit-Position: refs/heads/master@{#443129}

Now that the Physical Web no longer displays notifications, the
opt-in notification will not fire.  Instead, users can enable the
Physical Web manually, or if they have Google search enabled (i.e.,
they are already sending info to Google for omnibox results).  Note
that this is the same behavior as on iOS.

BUG=663842

Review-Url: https://codereview.chromium.org/2618613007
Cr-Commit-Position: refs/heads/master@{#443128}

Tiny plugins will now always be disabled by plugin power saver, even if they have the same origin as the main page.

BUG=675707

patch from issue 2576893003 at patchset 1 (http://crrev.com/2576893003#ps1)

Review-Url: https://codereview.chromium.org/2627493002
Cr-Commit-Position: refs/heads/master@{#443127}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d1d93c3a..7ca33baf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2627183002
Cr-Commit-Position: refs/heads/master@{#443126}

Revert of cc: Add image decode queue functionality to image manager. (patchset #12 id:220001 of https://codereview.chromium.org/2537683002/ )

Reason for revert:
Hoping to fix build/test errors such as
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19947

-- sheriff.

Original issue's description:
> cc: Add image decode queue functionality to image manager.
>
> This patch adds an ability to request an image decode from
> the compositor. The caller should specify which image
> (SkImage) to decode and a callback. In return, it gets an
> id. When the image is decoded, the callback is issued with
> this id. The decode is then kept alive for 2 compositor
> frames.
>
> Right now, only unittests are using this functionality.
>
> R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2537683002
> Cr-Commit-Position: refs/heads/master@{#443085}
> Committed: https://chromium.googlesource.com/chromium/src/+/bb991d41668aa0f37aa6d6712e3bf9b52a5480ae

TBR=enne@chromium.org,danakj@chromium.org,ericrk@chromium.org,vmpstr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2631453002
Cr-Commit-Position: refs/heads/master@{#443125}

Previously OnSurfaceAvailable() would call CompleteInitialization() if
init_cb_ was not null, but init_cb_ isn't reset until later in
NotifyInitializationComplete(). So if OnSurfaceAvailable() was called
more than once before deferred initialization completed, we would
erroneously call CompleteInitialization() more than once.

This CL cleans up the logic for OnSurfaceAvailable() so it's safe to call
at any time, and ensures that CompleteInitialization() only runs once.

BUG=677775

Review-Url: https://codereview.chromium.org/2621153004
Cr-Commit-Position: refs/heads/master@{#443124}

Using update-w3c-deps in Chromium 2e36b96a.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7867

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2622083005
Cr-Commit-Position: refs/heads/master@{#443123}