GitLab

Bug: 832981
Change-Id: I230384753592e4397d164460a9cc953c17b10daf
Reviewed-on: https://chromium-review.googlesource.com/1033343Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554508}

There has been a 50/50 finch trial on canary and dev going on for this
feature and no issues has been reported.

Bug: 813929
Change-Id: I79012e9cfa06dfac57c73479aa80d09a050c0395
Reviewed-on: https://chromium-review.googlesource.com/1032889Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554507}

Bug: b:78589509
Test: locally build and run
Change-Id: I862691a0bb5774e9761f5202cd2a23f08099061b
Reviewed-on: https://chromium-review.googlesource.com/1031092Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554506}

Introduce a new PolicyValidationReportRequest which will be used to
upload the results of policy validation after policy fetches.

BUG=794848, b:70641944

Change-Id: I21d9fc52c82ff865a0877254c3c09db61e410547
Reviewed-on: https://chromium-review.googlesource.com/913573
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554505}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bec9b446c412..6b3c651c4ed2

$ git log bec9b446c..6b3c651c4 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 jkop chromite: Turn down stage-level VM test retries

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:823832


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I4bea87876cbf4c369ed68730fa7f378c4113fbd2
Reviewed-on: https://chromium-review.googlesource.com/1033025Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554504}

The minidumps don't show anything out of the ordinary for the aliased
variables when this hang happens.

R=zmo
BUG=823498

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic8f57f2249142ee720b07640c8b11c4af89648ff
Reviewed-on: https://chromium-review.googlesource.com/1031522Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554503}

This patch follows up on r547601 by adding the WebUsbAskForUrls and
WebUsbBlockedForUrls policy settings which allow an administrator to
either override a DefaultWebUsbGuardSetting of 'block' by allowing a
particular set of URLs or override a setting of 'ask' by blocking a
particular set of URLs.

Bug: 771703
Change-Id: If562fc031eedaff7b0691810d8d1383ffbd5f824
Reviewed-on: https://chromium-review.googlesource.com/1026159Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554502}

BUG=837761

Change-Id: Ib256ba3133eae770167b5e06ae6c8ad9d0436658
Reviewed-on: https://chromium-review.googlesource.com/1033589Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554501}

We need to use the content in resources.pak in service manager, but at
that time resource bundle has not been initialized. Create data pack to
load resources.pak and append the data pack to resource bundle during the
initialization.

Move path FILE_RESOURCES_PACK from chrome_paths.h to ui_base_paths.cc.

Bug: 729596, 815230
Change-Id: Iec3a9409cbd9c10775afb72944e66e26650f1181
Reviewed-on: https://chromium-review.googlesource.com/962679Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554500}

Remove references to jming on TODOs and add other members of the team
for related histograms/UKM.

Change-Id: I2ae4425b302cf472cbeb901ff98827d07c148c70
Reviewed-on: https://chromium-review.googlesource.com/1031127Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554499}

https://skia.googlesource.com/skia.git/+log/a886544a7bf7..5cb5c74efdac

$ git log a886544a7..5cb5c74ef --date=short --no-merges --format='%ad %ae %s'
2018-04-27 borenet Reland "[recipes] Use named caches for git and workdirs"
2018-04-27 reed use std::atomic in SkRegionPriv
2018-04-27 angle-skia-autoroll Roll third_party/externals/angle2/ 467c15f97..de279590a (1 commit)
2018-04-27 skcms-skia-autoroll Roll skia/third_party/skcms 5a327ce..dd901e0 (1 commits)
2018-04-27 ethannicholas workaround for Intel OpCompositeConstruct bug
2018-04-26 fmalita [skottie] Apply opaque masks as clips
2018-04-27 rmistry Revert "Remove Android compile bot from the CQ"
2018-04-26 benjaminwagner [infra] Specify machine_type dimension for Linux GCE bots.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: Ib9444275488575c786a1b6d5ac1841bb427a477a
Reviewed-on: https://chromium-review.googlesource.com/1033487
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554498}

In commit #552430 a few struct members were renamed, but code
comments were not updated.

Bug: 823297
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I28c618291fe69e30d2695fb4a062972e64eb4bfa
Reviewed-on: https://chromium-review.googlesource.com/1021658Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554497}

On autoscroll start the mouse_wheel_phase_handler_ ends the current
scrolling sequence(if such exists). While Autoscrolling wheel events
in the mouse wheel event queue are ignored and once autoscrolling ends
the mouse_wheel_event_queue resumes processing wheel events normally.

This change is identical to giving priority to touchscreen scrolling
over wheel scrolling and it is done to make sure that attempting to
wheel scroll during a middle click autoscroll doesn't cause unwanted GSB
/GSE generation.

Bug: 835314
Test: *.TimerBasedLatchingBreaksWithAutoscrollStart
Change-Id: Id568ee2676a6dafc2705c144ea4d92d46311b788
Reviewed-on: https://chromium-review.googlesource.com/1011457
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554496}

These metrics will record the number of occluded/visible/hidden native Chrome windows on Windows. This information will be polled and computed on a repeating timer. This information will be used to determine if occlusion tracking on Windows is worth pursuing going forward.

This is a reland from reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1032858 (revert), https://chromium-review.googlesource.com/c/chromium/src/+/1025074 (original)

The fix is the diff after patchset 1.

Bug: 813093
Change-Id: I30635c4b978a210e496cc43e52470f3b3b9f03d3
Reviewed-on: https://chromium-review.googlesource.com/1033272Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Varun Mohan <varunmohan@google.com>
Cr-Commit-Position: refs/heads/master@{#554495}

* This is accomplished by adding a PageViewTimer class, which uses
  a TabObserver and a TabModelObserver to measure time spent viewing
  pages

Bug: 824186
Change-Id: I14fc98112d254f44be969307a5c9b74f7969f93a
Reviewed-on: https://chromium-review.googlesource.com/1023054
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554494}

To simplify naming, update the parameters for SetGeometry(). Once all
call sites are updated, remove SetGeometryGfx().

Bug: None
Test: Compiled
Change-Id: I6ec82851883271732c029586017ddf8394a85295
Reviewed-on: https://chromium-review.googlesource.com/1024190Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554493}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bdb814e9..df1d991f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I01a7d36286623ffcafa44cba0490dd286f7fb97f
Reviewed-on: https://chromium-review.googlesource.com/1032753Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554492}

It looks quite bad. This was an unintended regression from the fixed-width
look. Adding a test for this regression is unfortunately difficult - mocking
out the MenuController used by a single MenuItemView is complex to do.

Bug: 837158
Change-Id: Ie2e094a69c1d25bbcf8b53cfd66da4dec51e0f1b
Reviewed-on: https://chromium-review.googlesource.com/1030038
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554491}

These APIs are not being used.

Bug: None
Change-Id: Iae36aba550cb117baaa1b8cce677f63c5a652178
Reviewed-on: https://chromium-review.googlesource.com/1032761Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554490}

This setup needs to be done earlyish in the browser's lifetime so that
the error badging can be shown and so that the global error bubble can
appear.

This fixes GlobalErrorBubbleTest.InvokeUi_RecoveryInstallGlobalError.

Bug: 834754
Change-Id: I2b61beb1123436fd15c36d265d1eabbf6d9ded2f
Reviewed-on: https://chromium-review.googlesource.com/1033437Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554489}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia6ed918de4495d0938c6400413aee6d8683ce18a
Reviewed-on: https://chromium-review.googlesource.com/949822
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554488}

On Thinkpad X1 with libinput or synaptics driver, touchpad scroll
event report as ScrollClassEvent not ScrollEvent. For touchpad
report with high precision scroll deltas, we add a event source
check when receive ScrollClassEvent.

Bug: 599497
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4c6b5d763275caa98c56f86ec0de0c5aeed9dca2
Reviewed-on: https://chromium-review.googlesource.com/988748
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554487}

Moved flex-direction adjustment from layout method to a computed style
custom hook.

We temporarily switched between rtl and ltr for each layout requiring
the ComputedStyle to be mutable. The test that failed before adding
this hack no longer fails without it, so removing.

TEST=fast/forms/range/input-appearance-range-rtl.html

Bug: 813068
Change-Id: I698859f10fba32aa02f8b5b61d07bd24557667b1
Reviewed-on: https://chromium-review.googlesource.com/1032553
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554486}

These entries were requested for removal via email and have been
validated via DNS.

Change-Id: I9799002be81d11f55ecb775d04e887457e5b3c3b
Reviewed-on: https://chromium-review.googlesource.com/1033474Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554485}

Previously we wouldn't notice that the keyframes had changed until the
next animation update. This CL fixes that by clearing any cached sampled
effects and notifying the owning Animation that it needs to invalidate
it's information.

This also fixes updating composited animations; invalidating the effect
on the animation causes us to properly restart the composited animation.

Bug: 799061, 835824
Change-Id: Ib307a5409c52c5dab1ee0f98c989d7dbaef42937
Reviewed-on: https://chromium-review.googlesource.com/1026700
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554484}

Add retries while making connection to DevTools.

Bug: 826150
Change-Id: I43b708eabdf2202ed14b41cd43677f814b02079d
Reviewed-on: https://chromium-review.googlesource.com/1026153Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554483}

This flag enables a set of features which are intended to help improve
web developer productivity, by restricting the use of web-platform
features which are commonly problematic, as well as adding new high-
level APIs for common development patterns.

This currently just enables three opt-in policy-controlled features:
 - sync-script
 - unsized-media
 - vertical-scroll

Other policy-controlled features and LAPIs are expected to be added to
this set in the future.

Bug: 837344
Change-Id: Id7f89cbe2cc6fdc92278a42ea033e0fef0baabcb
Reviewed-on: https://chromium-review.googlesource.com/1030906Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554482}

This CL moves toggles that needs to be shared into its own element,
<personalization-options>, and changes their label and sub-label when
unified-consent is turned on.

screenshots: https://imgur.com/a/D7wMnx1

Bug: 800973
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6284b5166381b74a146d1c7cbaafd5e790a3bc89
Reviewed-on: https://chromium-review.googlesource.com/1022716
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554481}

Here's the abbreviated recursion call stack:

FrameLoader::DidFinishNavigation
 FrameLoader::RestoreScrollPositionAndViewState
  Document::UpdateStyleAndLayout
   ...
    LayoutView::UpdateAfterLayout
     WebViewImpl::ResizeAfterLayout
      ...
       LocalFrameView::SetFrameRect
        FrameLoader::RestoreScrollPositionAndViewState

This is clearly a bad thing to do, but the actual symptom is a CHECK
failure, because the inner call to RestoreScrollPositionAndViewState
will call Document::UpdateStyleAndLayout, which will advance the
document lifecycle to kLayoutClean.  That's bad because there's still
an outer invocation of UpdateStyleAndLayout that expects the
lifecycle not to change from kInPerformLayout.

BUG=837524
R=bokan@chromium.org

Change-Id: I9a4bfe0b71ce8cef383673776f6d81a47b5d4b2d
Reviewed-on: https://chromium-review.googlesource.com/1033481Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554480}

Bug: 730693
Change-Id: Ia754b382d9c4626b24ecab368d25b3c6331230be
Reviewed-on: https://chromium-review.googlesource.com/1024434
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554479}

We currently expose a couple of alpha-scaling helpers:

 - ClampedAlphaForBlending: float_alpha[0..1] -> int_alpha[0..256]
 - ScaleAlpha: SkColor * int_alpha[0..256] -> SkColor
 - ScaleAlpha: SkColor * float_alpha[0..1] -> SkColor

Some problems:

 1) ClampedAlphaForBlending is prone to int overflows
 2) several clients take the [0..256] alpha and shoehorn it into a paint
    by clamping to 255; this is imprecise because the original [0..1]
    domain is still scaled to [0..256] instead of [0..255]
 3) in general, there is no reason to go through an intermediate/premature
    int quantization

This CL removes ClampedAlphaForBlending and the int-flavored ScaleAlpha
helper, and updates all clients to use the float ScaleAlpha version.  It
also refactors the implementation to clamp in float, before int conversion.

Bug: 836664
Test: svg/custom/opacity-overflow.svg

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2f27c7f606a6bc428dcd90543f583a9f207a58f1
Reviewed-on: https://chromium-review.googlesource.com/1028451Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554478}

Isolated worlds (like extensions) are designed to be able to bypass a
page's specified CSP. However, when executing an asynchronous scheduled
action (such as one initiated through setTimeout()), the actions were
not allowed to execute. This is because ScheduledAction::Execute()
checked Document::CanExecuteScripts(), which checked if the document
was sandboxed and didn't check if it should bypass the CSP.

Fix this by having the document check if it should bypass the CSP, and,
if it should, allow the script execution.

Add unittests for Document::CanExecuteScripts() as well as an end-to-end
test for an extension with a content script and setTimeout().

Bug: 811528
Change-Id: I7f6497784845a7d05d60048c84b24db9b903eae9
Reviewed-on: https://chromium-review.googlesource.com/1030952
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554477}

This is roughly similar to patricialor@'s work in
https://codereview.chromium.org/2010493005/

Per offline conversation,this wasn't submitted
at the time due to some related bugs that are now fixed.

This works well in ChromeVox AFAICT. In VoiceOver,
testing on permission.site, pointer lock works well,
but fullscreen's announcement can sometimes be cut
off by VoiceOver returning to read the rest of the
page. Waiting until the animation is complete helps
a little but doesn't fully fix it, but I'm not sure
what else we could do.

Bug: 610583, 577011
Change-Id: Ic1ef5ba8f81d432eb1f64335be3f6bb6e4ff31f1
Reviewed-on: https://chromium-review.googlesource.com/1015554
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554476}

Bug: 836908
Change-Id: Idb2422e16651df75fe2dac30d0d4bc65410e67aa
Reviewed-on: https://chromium-review.googlesource.com/1031560Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554475}

It's possible that when setting the opacity of the black scrim, the opacity is
a very small negative value. Set it to zero in this case.

Bug: 835900
Change-Id: Ia3b082e86cb5cca25987023a9a6f46625865b335
Reviewed-on: https://chromium-review.googlesource.com/1024243Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554474}

There are two main bug fixes:
1) make sure the poll time gets properly sent through the cycle snapshot so that
   it can be persisted.
2) On startup, if the poll interval expired in the past, schedule a poll soon.
   Without that, it's highly unlikely we ever do polls on platforms like Android
   where apps can get killed anytime. Plus, as notifications are less reliable
   there, polls are actually more relevant.

The feature to potentially poll on start-up is guarded behind a feature flag,
which allows rolling back to the current behavior.

Bug: 832019
Change-Id: If625704eace7a89a48d057c27d61abb8b10d1bb1
Reviewed-on: https://chromium-review.googlesource.com/1030177Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554473}

As per crbug.com/788024 Comment 1 (see mocks):
- Fix error box style
- Dialog width = 448
- Input box width = 200, left aligned
- Additionally: add SPACE between "Invalid PIN" & "Attempts left"

Harmonious nature of the pin-requestin' dialog.

Bug: 788024
Test: Get yourself into some kinda pin-needin' situation and confirm the
Change-Id: Ie573c8a79fdb2001a3c2b66adc4b80a4b09dd723
Reviewed-on: https://chromium-review.googlesource.com/1013412
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554472}

This reverts commit ce130512.

Reason for revert: broke compilation: https://ci.chromium.org/buildbot/chromium/Win/66613

Original change's description:
> Add ruleset_converter tool to subresource_filter
> 
> This CL also
> - Aggregates all subresource_filter tools into a single target
> - changes subresource_filter tools to use the same (but equiv)
>   condition as some other tools
> - Adds that target to "all"
> 
> Bug: 833419
> Change-Id: I732ac0860f90e036281bdf899f8b5e6e92f3f3e5
> Reviewed-on: https://chromium-review.googlesource.com/1031211
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554455}

TBR=sky@chromium.org,jkarlin@chromium.org,csharrison@chromium.org

Change-Id: I03e004c156e40d695c866ba07a00c480eedcd225
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833419
Reviewed-on: https://chromium-review.googlesource.com/1033399Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554471}

Bug: 736457
Change-Id: I818c4d048145ae77bfd5c0244cde67886c30f8be
Reviewed-on: https://chromium-review.googlesource.com/1031786Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554470}

Monochrome.apk_Dex
        +2 entries fields
        +5 entries methods
        +1 entries types
        +1 entries strings
Monochrome.apk_Breakdown (+1,897 bytes)
      +145 bytes Zip Overhead
      +251 bytes Non-compiled Android resources size
       +17 bytes Package metadata size
       -20 bytes Java code size
    +1,504 bytes Compiled Android resources size
Monochrome.apk_Specifics
    +2,289 bytes normalized apk size
        +1 zip entries file count
      +392 bytes main dex size

Change-Id: Ia465e1ee3a2b9c411feb4265ab18ef05d3674d7f
Reviewed-on: https://chromium-review.googlesource.com/1033453Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554469}