GitLab

Revert of Re-enable key silk case benchmarks on Android (https://codereview.chromium.org/279853002/)

Reason for revert:
Still failing on N5. e.g. 

http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/393/steps/smoothness.fast_path.key_silk_cases/logs/stdio

BUG=355952

Original issue's description:
> Re-enable key silk case benchmarks on Android
> 
> All the known issues with these telemetry benchmarks have been fixed.
> 
> BUG=355952
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270830

TBR=ernstm@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355952

Review URL: https://codereview.chromium.org/292453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270973 0039d316-1c4b-4281-b951-d872f2087c98

Currently we stop the ServiceWorker thread/context when:
1. After all documents that are controlled by the SW are closed, with a delay (5 min)
2. All references to the version are dropped (i.e. in dtor)

In the current impl/codebase a worker is immediately stopped by 2
in most cases.

The same stop timer (ScheduleStopWorker()) could be probably called
each time handling event is finished to stop the worker more 
aggressively, though this patch doesn't do so.

BUG=372673
TEST=tested manually with chrome://serviceworker-internals/

Review URL: https://codereview.chromium.org/272183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270971 0039d316-1c4b-4281-b951-d872f2087c98

The existing test code returns an empty ImageSkiaRep where
bytes are allocated but nothing is initialized. This was okay
because ImageSkiaTest doesn't touch the contents of the image.

Now ImageSkia can rescale the image data and such cases are
tested. So using a dummy ImageSkiaRep wouldn't be helthy.
Rather some data should be drawn.

BUG=373748
R=oshima@chromium.org
TEST=

Review URL: https://codereview.chromium.org/285393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270970 0039d316-1c4b-4281-b951-d872f2087c98

This test is flaky on my machine without this patch.

Separated from issue 270563002.

BUG=
TEST=LoginStateNotificationBlockerChromeOSBrowserTest
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/284323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270969 0039d316-1c4b-4281-b951-d872f2087c98

This prevents RecvMsgWithPid from DCHECK failing under Debug builds
when reading EOF from a broken socket pair.  Noticed while testing
crrev.com/269543014.

Unfortunately, Linux allows sending zero length messages that the
recvmsg() API does not distinguish from reading EOF.  To be
conservative, if we didn't receive any message or control bytes, then
assume we received an EOF and tolerate not knowing the sender's PID.

BUG=357670

Review URL: https://codereview.chromium.org/276593008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270967 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Speculative revert because of failure in desktop_screen_x11_unittest.cc (DesktopScreenX11Test.GetWindowAtScreenPoint).

Original issue's description:
> Fix X11TopmostWindowFinder to take into account
> - Window manager provided window borders
> - Custom shapes specified via views::Widget::SetShape()
> 
> BUG=None
> TEST=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270877

TBR=sadrul@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/291583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270964 0039d316-1c4b-4281-b951-d872f2087c98

After maximizing/restoring the app widnow, the position of gear menu may not be
updated due to crbug.com/374093. This CL adds a workaround for the bug, which
forces to update the gear menu position.

BUG=372380
TEST=manually
R=fukino@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/291583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270963 0039d316-1c4b-4281-b951-d872f2087c98

In tile manager we seem to reach the memory limit early (with the
pending tree). However, when we activate our memory gets released
and we start filling it up again with the now active tree tiles.

The windows bot seems to catch the system at the moment when we're not
using a lot of memory, thus failing the test.

BUG=373098
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/289003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270962 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jyasskin@chromium.org
NOTRY=true
BUG=374105

Review URL: https://codereview.chromium.org/291593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270961 0039d316-1c4b-4281-b951-d872f2087c98

The API is added crrev.com/270720.

BUG=358698
TEST=run the new Gallery.app.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/282523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270960 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/284073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270959 0039d316-1c4b-4281-b951-d872f2087c98

The corresponding dbus level method is already added in
https://chromium-review.googlesource.com/#/c/195111/.
This CL is for adding the method to the wrapper client class.

BUG=356583

Review URL: https://codereview.chromium.org/281063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270958 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270957 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174118:174125&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/286203006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369875
TEST=On a Chromebook, try to save a web page and see the file type selector.

Review URL: https://codereview.chromium.org/287083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270955 0039d316-1c4b-4281-b951-d872f2087c98

Sending a RTCP sender report used to require a couple round trips of
IPCs. This is much simplified in this change. AudioSender or VideoSender
sends the latest known NTP time and corresponding RTP timestamp. Sends
it to CastTransportSender, which appends the current packet ccount and
octet count to form a sender report.

There is no need for AudioSender and VideoSender to know the current
packet count and octet count.

Review URL: https://codereview.chromium.org/281453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275271
TEST=unit_tests

Review URL: https://codereview.chromium.org/285323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270952 0039d316-1c4b-4281-b951-d872f2087c98

> Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME).
> 
> * Fixes GetHomeDir() for multi-profiles case on Chrome OS.
> * Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
> * Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.
> 
> This fix doesn't require checking for --multi-profiles switch
> since user_id hash is known even without it.
> 
> BUG=331530
> TBR=vitalybuka@chromium.org
> 
> Review URL: https://codereview.chromium.org/200473002

This test has caused two tests to start failing on the chromeos valgrind bots:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/25884
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/26990

TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/284333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270951 0039d316-1c4b-4281-b951-d872f2087c98

> Use real PlatformSupport in content unit tests
> 
> Once all pages are force composited by default, this allows these tests
> to not explode when trying to create GraphicsLayers because of a lack of
> Platform::compositorSupport.
> 
> BUG=none
> 
> Review URL: https://codereview.chromium.org/287043002

This test has caused leak errors on the mac valgrind bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/27964

TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/284193006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270950 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:371079
TEST=cros chrome-sdk --internal --board lumpy --version=5854.0.0 now works

Review URL: https://codereview.chromium.org/291483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270948 0039d316-1c4b-4281-b951-d872f2087c98

Previously the gallery's ribbon refers oldUrl property that was replaced with
oldEntry.
This causes a bug to fail update the ribbon's cache.

BUG=373167
TEST=manually
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/287063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270947 0039d316-1c4b-4281-b951-d872f2087c98

It's never set.

BUG=None

Review URL: https://codereview.chromium.org/286233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270946 0039d316-1c4b-4281-b951-d872f2087c98

Authored by davemoore@chromium.org, see https://codereview.chromium.org/275363002/

R=darin@chromium.org
TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/287143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270945 0039d316-1c4b-4281-b951-d872f2087c98

This test fails flakily there.

TBR=perkj@chromium.org
NOTRY=true
BUG=373637

Review URL: https://codereview.chromium.org/292433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270944 0039d316-1c4b-4281-b951-d872f2087c98

This test has been failing frequently on bots and closing the tree.

NOTRY=true
TBR=mtomasz@chromium.org
BUG=374097

Review URL: https://codereview.chromium.org/290613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270943 0039d316-1c4b-4281-b951-d872f2087c98

This is a split of https://codereview.chromium.org/287673004/, to avoid
merging issues.

It is almost impossible to land a CL adding histograms via CQ, without
a merging conflict.

TBR=isherman@chromium.org
TEST=Just histograms, no actual changes.
BUG=248427

Review URL: https://codereview.chromium.org/289063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270942 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/289053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270941 0039d316-1c4b-4281-b951-d872f2087c98

In the beginning there was an app/ directory, which is what ui/ is
today. This was back in 2011.

Ben started moving the pieces of app/ into ui/ in
commit f6767806 - r70743

Looks like we forgot to update this when we moved the code test/data
directory.

BUG=None
TEST=ui_unittests --gtest_filter=DataPackTest.*
R=tony@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/288323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270940 0039d316-1c4b-4281-b951-d872f2087c98

Trying to initialize the UI systems more than once can end up creating the
same subsystem (e.g. surface-factory) multiple times, which is not supported.
So remember whether the UI/GPU parts of the platform has been initialized.

BUG=361137
NOTRY=true
TBR=spang@chromium.org

Review URL: https://codereview.chromium.org/284253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270939 0039d316-1c4b-4281-b951-d872f2087c98

It's not safe for a RefCounted object to PostTask in its constructor.
Refcounts start at zero, so if the task completes before the constructor
returns, the closure will see the refcount going 0->1->0 and think the
object can be deleted.

This change moves the PostTask in ..::EstablishRequest() to a separate
Create() static function so it can be called after assignment into a
scoped_refptr wrapper, which ensures the refcount is incremented before
posting the task.

BUG=116100

Review URL: https://codereview.chromium.org/286983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270938 0039d316-1c4b-4281-b951-d872f2087c98

-The real guts of content_hash_fetcher.cc, which fetches the
 verified_contents.json file from the webstore if needed and also runs
 tasks to compute and cache the block-level hashes of all files in an
 extension.

-The real guts of content_hash_reader.cc, which uses the work done by
 the content_hash_fetcher during validation of extension file content as
 it's read off of disk at time of use.

-Code to avoid verifying transcoded files (images used in browser
 process, and message catalogs).

-Don't allow downgrade of mode via kForceFieldTrials command line switch

-Various bits of plumbing to support all of the above

This is a re-land with fixes; original review was:
  https://codereview.chromium.org/289533003

BUG=369895,373854
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/288273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270937 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270936 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174065:174118&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/282303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270935 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a MainAxisAlignment setting to BoxLayout which functions like the CSS
justify-content property. This property aligns the children items of a view
in the orientation axis of the BoxLayout.

set_spread_blank_space has been removed and replaced with
MAIN_AXIS_ALIGNMENT_FILL.

BUG=None

Review URL: https://codereview.chromium.org/284753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270934 0039d316-1c4b-4281-b951-d872f2087c98

Broke Windows Debug build; see comments in bug 365012 for details.

> Tweaks to ViewManager:
> 
> . OnNodeHierarchyChanged() is only sent for nodes the client cares
>   about (see ShouldNotifyOnHierarchyChange for exact details).
> . OnNodeHierarchyChanged() now includes any nodes not yet known to the
>   client.
> . Added OnServerChangeIdAdvanced, which is sent if the change id
>   advances but the client didn't get a notification (this can happen
>   when hierarchy changes are done in other clients that the client
>   isn't notified about).
> . OnConnectionEstablished now includes the state of the tree.
> 
> BUG=365012
> TEST=covered by tests
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/288313002

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/286973009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270933 0039d316-1c4b-4281-b951-d872f2087c98

The tests are leaking a profile. Suspect this is caused by enabling
multi profile by default on ChromeOS.

NOTRY=true
TBR=nkostylev@chromium.org
BUG=374078

Review URL: https://codereview.chromium.org/284263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270926 0039d316-1c4b-4281-b951-d872f2087c98

. OnNodeHierarchyChanged() is only sent for nodes the client cares
  about (see ShouldNotifyOnHierarchyChange for exact details).
. OnNodeHierarchyChanged() now includes any nodes not yet known to the
  client.
. Added OnServerChangeIdAdvanced, which is sent if the change id
  advances but the client didn't get a notification (this can happen
  when hierarchy changes are done in other clients that the client
  isn't notified about).
. OnConnectionEstablished now includes the state of the tree.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/288313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270925 0039d316-1c4b-4281-b951-d872f2087c98

> Remove knowledge of nacl from content.
> 
> Content should not have knowledge of NaCl. Moving per process NaCl debug
> stub port information to NaClBrowser.
> 
> More explicitly distiquish between the case where the debug port is not yet
> known versus when it is unused.
> 
> Switch debug port to being a per-process value (as it is).
> 
> BUG=None
> TEST=trybots
> R=jam@chromium.org
> 
> Review URL: https://codereview.chromium.org/286993006

This caused the compile to fail on the TSAN v2 bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20%28TSan%20v2%29/builds/19971

TBR=bradnelson@google.com

Review URL: https://codereview.chromium.org/290633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270924 0039d316-1c4b-4281-b951-d872f2087c98