- 09 Sep, 2019 40 commits
-
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types. - Apply pending_receiver to CreateGpuMemoryBufferFactory Bug: 955171 Change-Id: I84cb8e73efcfa2d499bc8f568d5586744e8be7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792023 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#694861}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28d40b2e7ade..3fdfe2823866 git log 28d40b2e7ade..3fdfe2823866 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 brianosman@google.com Simplify GPUSink constructors by just passing the config object Created with: gclient setdep -r src/third_party/skia@3fdfe2823866 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I6a7eacecb9c1ad1cb2cbb0ea95cf1054b34c7fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694860}
-
Saman Sami authored
The tests were disabled due to timeout when native Vulkan is used, so use swiftshader instead. Bug: 940723 Change-Id: Ida3745c7d6d480aebf1a56498b3242a1b77353d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790198 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#694859}
-
Esmael El-Moslimany authored
Bug: 980856 Change-Id: Ia28c8b4fe90b7fdad5c43660e3a4006a8673c321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788225 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#694858}
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/1789532, actually marks the tests as disabled. Bug: 997634 Change-Id: I15918a7ce52be12dcb8a1af2ad20affe28a56f67 Tbr: treib@chromium.org, olka@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793245Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#694857}
-
Derek Beckett authored
There are some device protos which have the same field names (e.g. enabled). Currently the policy_server cannot differentiate between them. This will all setting these by: "groupname.fieldname", e.g: "device_power_peak_shift.enabled". TEST=Locally deployed and tested BUG=TBD Change-Id: I9565f3082ed192e787b2a00efec1ae29ebe195f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790534Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Derek Beckett <dbeckett@chromium.org> Cr-Commit-Position: refs/heads/master@{#694856}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/03038a48..e6d242c0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I25eac74326f61f2d300a55890cd830c925485759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792850Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694855}
-
Brian Sheedy authored
Adds several notes about running swarmed tests with extra arguments in docs/workflow/debugging-with-swarming.md. Change-Id: I751e0237399ff96626ef699b9a66e598eb07ab5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793282 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#694854}
-
Tom Anderson authored
Fixes this error: [ 375s] In file included from ../../base/task/common/intrusive_heap.h:8, [ 375s] from ../../base/task/thread_pool/task_source.h:17, [ 375s] from ../../base/task/thread_pool/task_tracker.h:27, [ 375s] from ./../../base/task/thread_pool/service_thread.cc:14, [ 375s] from gen/base/base_jumbo_28.cc:5: [ 375s] ../../base/containers/intrusive_heap.h:152:36: error: enumerator value '-1' is outside the range of underlying type 'size_t' {aka 'long unsigned int'} [ 375s] 152 | enum : size_t { kInvalidIndex = -1 }; [ 375s] | Change-Id: I6044fb704931b2f8416f6b19a247ae297cd7b0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792763 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694853}
-
Livvie Lin authored
This mode will be triggered from PrepareErrorPage in a follow-up CL. Currently, this new code path doesn't change any behavior because a null callback from AllowCertificateError will follow the usual Show() logic. Bug: 987407 Change-Id: I32c2e1bd0fadb7540204e659b218d0138f168260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769353 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#694852}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c6c057c3feb..ec283489193a git log 3c6c057c3feb..ec283489193a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 simonhatch@chromium.org Pinpoint - Create single set of hidden inputs Created with: gclient setdep -r src/third_party/catapult@ec283489193a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1001757 Change-Id: Iebf26a9847474abb27423e097718f85397738ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791624Reviewed-by:
-
Tommy Li authored
This makes some minor refactors to the usage of AutocompleteController::in_start_. 1. It delays setting it to false until after the UpdateResult call within the synchronous pass. This is more accurate, and also allows in_start_ to be used as a synonoym of in_synchronous_pass_. 2. It also moves in_start_ to be an early exit condition for OnProviderUpdate. It likely doesn't need to be checked there at all, since the comments indicate it's likely ALWAYS false when OnProviderUpdate is called. These refactors help pave the way for the feature to preserve the default match during the asynchronous pass, by clarifying in the code when the synchronous vs. asynchronous pass occurs. Bug: 398135 Change-Id: I8f8c61b8233b1c049338dac448b6ef8f1b0e3b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789823Reviewed-by:Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#694850}
-
Javier Fernandez authored
When calculating the min-content contribution of a grid item of an auto sized grid track we must consider the grid item's margin. When the grid item's area is indefinite, a percent margin is resolved to zero. However, when performing a relayout, the percent margin may be solved against the previously computed grid area, since the grid item has already an OverrideContainingBlockLogicalWidth value. In order to re-compute the percent margin properly, we need to clear the previously override value. It's important be careful of not clearing the override value set during intrinsic size, since we need it for the actual layout phase. Hence, we only reset the 'override' value when we are executing a definite strategy. Bug: 834643 Change-Id: Ib936b26bee1da76afbdc886eb775746e13d40988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782840 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#694849}
-
Adithya Srinivasan authored
Bug: 1001446 Change-Id: Ia2c182bd2f622ccd07196770b443e92c610e3130 Tbr: mlamouri@chromium.org, msramek@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793232Reviewed-by:
-
rbpotter authored
- Autogenerate Polymer 3 cr-expand-button and tests - Add to demo page - Autogenerate modulized focus_without_ink, since the button depends on this file. - Update the js_modulizer script to add a way to ignore some lines Bug: 965770 Change-Id: I08b0613b3140b773039855af0105fecb72860987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788321Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#694847}
-
Henrique Ferreiro authored
Convert the implementation and all users of the ash::mojom::AssistantAlarmTimerController, AssistantNotificationController and AssistantScreenContextController. Bug: 955171 Change-Id: I19142850f1cd445f6d43a4caf4c7bd88415680c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789386Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
Add the checkerboarding metrics in the rendering benchmarks. Adding these extra histograms do not affect the size of the output traces by much. Below are some sample trace-sizes from pinpoint (10 traces for each story): . On windows: - amazon_pinch: 56.32MB -> 56.32MB - twitter_pinch: 58.68MB -> 57.49MB . On pixel 2: - bouncing_balls_shadow: 41.69MB -> 41.74MB - bing_mobile: 57.08MB -> 57.14MB BUG=984592 Change-Id: I3fdb065f8b85814a7b900c46b14f569ec406c243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785418Reviewed-by:Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#694845}
-
Robert Liao authored
BUG=865318 Change-Id: I03ebbfdc95622f986e6271dbede4d1bfa740c5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788198 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694844}
-
Leon Han authored
BUG=520391 Change-Id: I5b9a807081657f2d211575a282ae7fa7f45c71ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791927 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694843}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/44e6523d7ff3..cebb9635a5d5 git log 44e6523d7ff3..cebb9635a5d5 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 jmadill@chromium.org GN: Expose XCB surface extension on Linux. Created with: gclient setdep -r src/third_party/swiftshader@cebb9635a5d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140251624 Change-Id: I90a2718722f7687e3d945c6389a6384ef256edb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792000Reviewed-by:
-
Andrew Grieve authored
.part.end is a new section introduced by "partitioned libraries", a part of DFMS. It's a NOBITS section, so needs to be counted the same as .bss. This fixes some CQ runs failing due to: AssertionError: Padding was: $SOME_SMALL_NEGATIVE_NUMBER Bug: 1002085 Change-Id: I49e892d22f8888fd991202d99bc67e342c06db52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791999 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694841}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/bookmarks. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Revert changes to BookmarkNodeDataTest and BookmarkUtilsTest which rely on base::ThreadPool. R=sky@chromium.org Bug: 891670 Change-Id: I8a37c3ecc469fcbbdc52b80724f5d8b073e30414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786903 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a0b94071e6bd..ac68e9c3dd09 git log a0b94071e6bd..ac68e9c3dd09 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 lalitm@google.com trace_processor: migrate track table to new table macros 2019-09-09 lalitm@google.com trace_processor: make inserting into macro tables more explicit 2019-09-09 lalitm@google.com Merge "trace_processor: refactor Column to reduce boilerplate when adding types" 2019-09-09 hjd@google.com Merge "ui: Show full timestamp" Created with: gclient setdep -r src/third_party/perfetto@ac68e9c3dd09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627,chromium:135177627 Change-Id: If7b064422fdcbcddc16a9798adbc047f3dc9274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792001Reviewed-by:
-
Yun Liu authored
Revert this if capacity is not enough. Bug: 731759 Change-Id: Ia757461849ff14f277b23f3f6869e9d7c4e2bd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790729Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#694838}
-
Mohammad Refaat authored
The problem is the fullscreen VC is presented the ContentView is stashed to another window to keep the renderer from being killed. Then when when that VC is dismissed the contentView is inserted on the top of the container view, and that will cover any other view that was presented on the container view. The solution is to insert the contentView on the back of the container view. Bug: 982845 Change-Id: I65e1cb20cb7cdbb6396678cbc3fc26108a932a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788242Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#694837}
-
Daniel Rubery authored
This CL marks the following histograms as obsolete: SBClientDownload.DownloadFileHasDetachedSignatures SBClientDownload.ZipFileFailureByType SBClientDownload.ZipFileSuccessByTyep Since they are historically stable and not being used It extends the lifetime of: SBClientDownload.ZipFileSuccess Since it shifted dramatically in M75. Bug: 988809 Change-Id: I3add7ec4972d6be4ac0f4492f91cdfb643c88619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784970Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#694836}
-
Brandon Wylie authored
This will be helpful in methods such as typeInOmnibox, which rely on the assumption that the omnibox will have focus. Putting it in its own util file because it seems generally useful. Bug: 1000315 Change-Id: I7cb390046462c584ad48785963941fce133da0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784882 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#694835}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2aaf66e4644a..ddef8d1b6b07 git log 2aaf66e4644a..ddef8d1b6b07 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 titovartem@webrtc.org Add support of displaying video during the PC level test Created with: gclient setdep -r src/third_party/webrtc@ddef8d1b6b07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ib363502b20bc8cf7ee95fb2dea2ec71b7a87cf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792447Reviewed-by:
-
Brett Kilty authored
In cases where kAudioDecoderLimit is > 1, SFX are getting held to the 1 decoder limit. One decoder is really about video, as that is the platform limitation. Multiple sources may attempt to play sound effects at the same time as these are just audio only sources. Bug: b/139941019 Test: Local build, test race condition and SFX. Change-Id: Ieb7ea18674e58e06dc050f7ff2756e14021ab40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792451 Commit-Queue: Brett Kilty <brettk@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#694833}
-
Danan S authored
The Add Supervision dialog was using OnCloseContents() and OnDialogCloseRequested() to catch attempts to close the dialog, for the purpose of showing the signout confirmation dialog. This failed when OnCloseContents() was called, because by the time that callback was called, the web contents were already disposed of, resulting in dialog contents becoming unusable if the user chose to return to the dialog rather than signing out. Instead, capturing the close event in CanCloseDialog() occurs before the contents are invalidated, therefore it is the correct place to stop the closing of the dialog Bug: 1001732 Change-Id: I50262bd4606e3380700c81f98df925ea3a61f87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790130 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694832}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events/ozone. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=spang@chromium.org Bug: 891670 Change-Id: I2d1f3a4f10cf7c57414a04b8a5ebcb9ead9e342a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786939 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694831}
-
vikassoni authored
Enable AImageReader for both MCVD and MediaPlayer video paths on android by default. Bug: 951832,838725 Change-Id: I0efa453a3a9e0212fd9b9d5d55cb928bfa46a9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789755Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694830}
-
Moe Ahmadi authored
- Queries AutocompleteController when the realbox gets focus and is empty. - Stops AutocompleteController and clears Autocomplete results when realbox loses focus. Otherwise previous non-zero-prefix suggestions remain cached. - Displays the clock icon for the personalized zero-prefix suggestions, if applicable. Bug: 996516 Change-Id: Ib821e0f6f0e5b722f60b6388456c673a7b8b450b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786592 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#694829}
-
Ionel Popescu authored
This CL updates the popup UI for the month view of the calendar picker. The current style was extended by using calendar_picker_refresh.css. More tests are going to be added when the new UI will be used as the default view for input type="month". Bug: 1001348 Change-Id: I10ea5fc4403f1290dc803d2bc3f9e1f701b61578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788680 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#694828}
-
Lukasz Anforowicz authored
Desirability of setting |request_initiator| to the website ========================================================== At a high-level, this change means that content script scripts behave more like the webpage that they are injected to. This kind of high-level change is desirable because: 1) the renderer process hosting the webpage is locked to the webpage's origin - anything running in such renderer (including content scripts) should be bound by webpage's capabilities 2) it simplifies reasoning about content scripts for extension authors (after this change content scripts run as webpage's origin [unless allowlisted]; this makes it easier for content scripts to issue SameSite and/or CORS requests on behalf the webpage) At a low-level, this change allows cleaning up some technical debt related to how same-*web*-origin XHRs have to be handled when initiated from content scripts. In particular: A) after this CL, we can remove hacks that OOR-CORS and CORB currently use to (heuristically, inaccurately) attempt to recognize same-origin requests (i.e. we can consider reverting https://crrev.com/c/1642752 and https://crrev.com/c/1394432). For more detailed comparison of how CORB, OOR-CORS and Sec-Fetch-Site behavior is affected by this CL, see the comparison table in https://docs.google.com/document/d/1ENNu-kRSCrgfaqrGO8T-lUqvItnS6VYw-jAdtRVUXic/edit#heading=h.h4a3p9fb5fo6 B) after this CL, requests initiated on behalf of the translate feature will use a request_initiator compatible with request_initiator_site_lock. This means that the translate feature no longer needs to provide a separate URLLoaderFactory (i.e. we can consider reverting https://crrev.com/c/1441277 and follow-ups). C) after this CL, we no longer need to suppress attaching of the Origin header for requests initiated by a content script (i.e. we can consider reverting https://crrev.com/c/1610667). Main change =========== The main change in this CL is in third_party/blink/renderer/core/fetch/request.cc. After this CL, |request->SetOrigin(...)| will be unconditionally called with the main world's origin. Retaining isolated world's origin ================================= The isolated world's origin needs to be retained for 2 reasons: i) For selecting the right URLLoaderFactory in case the extension is allowlisted (see URLLoaderFactoryBundle::GetFactory in //third_party/blink/common/loader/url_loader_factory_bundle.cc). ii) For finding CORS extension policies (see changes related to OriginAccessList) iii) For allowing the content scripts to access blob URLs belonging to *either* of 1) the main world or 2) the extension (see changes related to CanDisplay) Because of the above the CL introduces the new fields: - network::ResourceRequest::isolated_world_origin - blink::WebURLRequest::IsolatedWorldOrigin - blink::ResourceRequest::IsolatedWorldOrigin - blink::FetchRequestData::IsolatedWorldOrigin While it may seem that having two origin fields is more confusing, it is better than the old state because: *) There really *are* two origins associated with each request. Trying to represent this reality with just one origin in code is confusing and error-prone (as evidenced by the technical debt listed above). **) Forgetting to consider the other origin (e.g. isolated world origin) is safe - it might lead to functional bugs but shouldn't lead to security bugs. If code forgets to consider the other origin then it will only consider and/or grant capabilities of the web origin (which should be safe from security perspective). Bug: 940068 Change-Id: I9c3638070861e760227fb62af63f3d8a2c655f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633232Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#694827}
-
Yoichi Osato authored
This is a follow-up patch of previous change: "[WebSocket] Reduce memcpy at websocket_frame_parser.cc" https://chromium-review.googlesource.com/c/chromium/src/+/1774420 Bug: 1001915 Change-Id: Ib13c28038a82b4b6ca0eb53a3e4d56ac5242720c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792030Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694826}
-
Peter Boström authored
Bug: None Change-Id: I9c429945dcbf6b9a84871c1514d02b1d4e810cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790723 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
James Cook authored
The SplitSettings project has migrated Chrome OS settings into their own settings window. We show a dismissable banner in browser settings that directs users to OS settings. We intend to remove this banner in a few milestones, after most users stop clicking it (or have dismissed it), so measure how often we show it, and how users interact with it. The metrics are similar to the ones added for our other promo banner, from OS settings to browser settings, in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1779165 Bug: 999438 Change-Id: I0088d4876e9a89e7b33e71fdcd19462f4118eec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787753Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#694824}
-
Miyoung Shin authored
This CL converts FakeBluetoothRequest and FakeCentralRequest in device to the new Mojo type, and uses pending_remote<FakeCentral> in fake_bluetooth.mojom Bug: 955171 Change-Id: I27a8887f998056f6913b1b53fe50e21165ca1018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788779Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73b8376b302a..28d40b2e7ade git log 73b8376b302a..28d40b2e7ade --date=short --no-merges --format='%ad %ae %s' 2019-09-09 egdaniel@google.com Reland "Add support for direct use of vulkan primary command buffer in render pass." Created with: gclient setdep -r src/third_party/skia@28d40b2e7ade If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I408eae16437f477117f8b5a7d516b04c6a37be4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792010Reviewed-by:
-
