- 02 Aug, 2018 40 commits
-
-
Marc Treib authored
This removes some unnecessary "virtual"s, and adds "Virtual for testing" comments to the remaining ones. (Many of those are questionable, but that's out of scope for this CL.) Bug: none Change-Id: I6b742769ef256416fd737f2c16b0379c359bdd6c Reviewed-on: https://chromium-review.googlesource.com/1148056Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580097}
-
mrefaat authored
AppLauncherAbuseDetector & AppLaunchingState classes were on ios/chrome/browser/web. But they are not related to web. Moving these classes put togather all app launching logic on the same place, and also breaks app_launcher target dependency on ios/chrome/browser/web:web_internal which can be a reason for cyclic dependency for targets that depend on AppLauncherTabHelper. Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I743c9add64b939430c287b6fddd9cd77c082d697 Reviewed-on: https://chromium-review.googlesource.com/1158125 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#580096}
-
Findit authored
This reverts commit 0ea2267a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 580029 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzBlYTIyNjdhN2NlZmE0OWZmZDNmMzA4MGRjZWEyNDFkOWJiY2RmZDcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/9359 Sample Failed Step: not_site_per_process_browser_tests Original change's description: > Fix crash when right clicking link in CastUI > > This CL adds a null check to RenderViewContextMenu::AppendLinkItems() > ensuring we have an associated Browser before attempting to use it. > > Bug: 869280 > Change-Id: Ib1ffecd9dfbe27fb4fc6f6c77762c6337c36d4d4 > Reviewed-on: https://chromium-review.googlesource.com/1158110 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580029} Change-Id: Ie3a0067047c42fc8682ca8663eede8f1195afaed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869280 Reviewed-on: https://chromium-review.googlesource.com/1159804 Cr-Commit-Position: refs/heads/master@{#580095}
-
Joel Hockey authored
Perform sshfs mount to termina/penguin immediately when container starts. Mounting code has moved from the chrome.fileManagerPrivate extension functions into CrostiniManager. This change will make FilesApp more responsive to users who are likely to use terminal or some other crostini app before using FilesApp. Bug: 846917 Change-Id: I9fc246e45e54390e7a75f15a5571a24218cf2d5c Reviewed-on: https://chromium-review.googlesource.com/1158317Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#580094}
-
Sergey Ulanov authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic382e5fc990c6cd94bb43aca18104901ee0595eb Reviewed-on: https://chromium-review.googlesource.com/1158722Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580093}
-
Toshiki Kikuchi authored
In the login or lock screen, the settings and lock buttons are inactive so that we made them invisible to improve UX. In the previous implementation, these buttons are just disabled instead of invisible. TEST=TopShortcutsViewTest BUG=864233 Change-Id: I44b633187b475386732bfa9df5b78e740529d1e7 Reviewed-on: https://chromium-review.googlesource.com/1157666Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Cr-Commit-Position: refs/heads/master@{#580092}
-
Nicholas Verne authored
It uses a blocking PathExists call under the hood, so cannot be called sync on the UI thread. The IsRegistered check now runs when MaybeUpgradeCrostini runs, which is at user session startup time Bug: 870117 Change-Id: I000887e2e76a0cbebfe7c12a37fe1e7d7911e22d Reviewed-on: https://chromium-review.googlesource.com/1159936Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#580091}
-
Jiajia Qin authored
This CL implements MemoryBarrier and MemoryBarrierByRegion APIs for webgl2-compute context. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icfa6a081f09df01ccebbed07cb3cc30f23ca3301 Reviewed-on: https://chromium-review.googlesource.com/1156133Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#580090}
-
Yoichi Osato authored
This is a follow-up from: https://chromium-review.googlesource.com/c/chromium/src/+/583977 which removed unused InlineBox::HasSelectedChildren(). The patch left an unused variable |root_has_selected_children| dangling. This patch removed that. Bug: 789870 Change-Id: I6f5d4cf4f50630e558a314782212949ccd5ad2bc Reviewed-on: https://chromium-review.googlesource.com/1159555Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580089}
-
Tetsui Ohkubo authored
UnifiedSliderBubbleController was not handling events properly when the previous bubble was closing e.g. volume key was pressed during brightness slider is fading out. TEST=manual BUG=866301 Change-Id: I93087c01b38cbd7d5f64f8c99c9e0c539113f8d8 Reviewed-on: https://chromium-review.googlesource.com/1159924Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#580088}
-
Tetsui Ohkubo authored
Rather than closing popups immediately, we should close the popups with animation and let MessagePopupCollection::Update() close them eventually. Ideally MarkAllPopupsShown is problematic and this should be cleaned up along with UiController, but for now the fix should be acceptable as it just replicates the behavior of old MessagePopupCollection. Steps to repro: 1. Create a notification 2. Click on a notification TEST=manual(asan build) BUG=869593,869716 Change-Id: Ifdfc7c2a362727740401e6e16845d8d770877730 Reviewed-on: https://chromium-review.googlesource.com/1158118Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#580087}
-
Ramin Halavati authored
Preferences defined in: 'components/metrics/metrics_pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I3cf9ee5bb0ad248a95fbcbef51cd0c18e5d513be Reviewed-on: https://chromium-review.googlesource.com/1149365 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580086}
-
Tim Song authored
This very basic implementation currently only supports one active advertisement. Future work will add tests and better handle concurrent advertisements. BUG=846881 Reviewed-on: https://chromium-review.googlesource.com/1142294Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576712} Change-Id: Iaca4f7d319ea72fb3fc8915fef2c7cf78f6c9bc8 Reviewed-on: https://chromium-review.googlesource.com/1150843Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580085}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e41c89b3..0283df9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I816128672ee5b8e79dd393d84220a74ed1323a1b Reviewed-on: https://chromium-review.googlesource.com/1159846Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580084}
-
Yuki Yamada authored
Removed V8WorkerOrWorkletEventListener::GetReceiverObject() because its behavior is equivalent to V8AbstractEventListener::getReceiverObject() as commented in FIXME. Bug: 869778 Change-Id: If000f1351ec1ab2d5904c853a1dddc2be9d96648 Reviewed-on: https://chromium-review.googlesource.com/1158318 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#580083}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3fe4043d9320..7d059ce0a2a3 git log 3fe4043d9320..7d059ce0a2a3 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7d059ce0a2a3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifd250cda5cff5391fc9fc8c61e2f3d7f864f0b4e Reviewed-on: https://chromium-review.googlesource.com/1159443Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580082}
-
Ryan Hamilton authored
Change-Id: I488254610602049fc45d6770bb926f8020e29b5d Reviewed-on: https://chromium-review.googlesource.com/1159165 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580081}
-
Dmitry Gozman authored
It does logically belong there, not to random place in platform. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If16882ae3a91b6410c81a02427f332b7373f5b0c Reviewed-on: https://chromium-review.googlesource.com/1157074Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580080}
-
Darren Shen authored
In a previous CL, we made it so that changes to the keyboard window bounds automatically call NotifyKeyboardBoundsChanged. Now we can remove these extraneous calls and make NotifyKeyboardBoundsChanged private. TBR=jamescook@chromium.org Bug: 845780 Change-Id: I191a22fc50e37a3c57552169f05f609f4fba3005 Reviewed-on: https://chromium-review.googlesource.com/1156114 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#580079}
-
Adam Rice authored
If an asynchronous callback is called, it means we must have returned to the start of the event loop. Ensure that any consumed bufferedAmount is reflected in that case. Do not reflect bufferedAmount if the EventQueue is paused, as that means that we may be in a nested event loop. Add a unit test for this case. Also add a unit test for normal bufferedAmount behaviour, as there wasn't one. Add a web platform test for what happens if a sync XHR is performed between calling send() and looking at bufferedAmount. BUG=856651 Change-Id: Iafa2d619a1eb5284b64500ac03d336fb6380193b Reviewed-on: https://chromium-review.googlesource.com/1151086 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#580078}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/def554697b95..e43024a5bab7 git log def554697b95..e43024a5bab7 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 038e725af257..cc73f241145d (11 commits) 2018-08-01 rmistry@google.com Add LICENSE to third_party/vulcan 2018-08-01 herb@google.com Combine the append glyphs 2018-08-01 brianosman@google.com Add color space to SkColorFilter::filterColor4f 2018-08-01 robertphillips@google.com Move GrTextureStripAtlas to its own file 2018-08-01 egdaniel@google.com Reland "Reland "Let client pass in full extension to GrVkBackendContext."" Created with: gclient setdep -r src/third_party/skia@e43024a5bab7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ie253d22357fd78542923399aacf790a058d1b67b Reviewed-on: https://chromium-review.googlesource.com/1159783Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580077}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0562ff4f6e2e..f733d7da42cd git log 0562ff4f6e2e..f733d7da42cd --date=short --no-merges --format='%ad %ae %s' 2018-08-01 tsepez@chromium.org Replace more unchecked casts with type conversion funtions. Created with: gclient setdep -r src/third_party/pdfium@f733d7da42cd The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8a8abc4e0206ae08ab43d2fa55d5763b5ad8e855 Reviewed-on: https://chromium-review.googlesource.com/1159442Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580076}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b64c025. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22249 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ifd5095b169845228050fe304839a09ee6c1dddf4 Reviewed-on: https://chromium-review.googlesource.com/1159844 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580075}
-
Alexey Baskakov authored
We want to erase web_app_extension_helpers.h in favor of web_app_helpers.h. A plan: 1) Make WebAppProvider a single entry point for all external web_appplications/ clients. 2) Introduce enable_web_app_off_extensions command line switch. 3) Create new App Sync Manager component to utilize upcoming Unified Sync and Storage (USS) system. 4) Be able to switch between old extension-based bookmark_apps/ and new off-extensions bookmark_apps2/ implementations inside the WebAppProvider. TBR=sky@chromium.org Bug: 860581 Change-Id: Iab19d936fbcf39c011fc1eff1e29125b5ddb5e16 Reviewed-on: https://chromium-review.googlesource.com/1159925 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580074}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2acd8e0354e2..3a995feda7bb git log 2acd8e0354e2..3a995feda7bb --date=short --no-merges --format='%ad %ae %s' 2018-08-02 jessehall@google.com [systrace] Fix update_systrace_trace_viewer Created with: gclient setdep -r src/third_party/catapult@3a995feda7bb The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ifd1e14836ee9d5a9ea7e6e8bc80c4f987df32d70 Reviewed-on: https://chromium-review.googlesource.com/1159702Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580073}
-
David Staessens authored
- Adapted singletons to follow recommendations: * Added DISALLOW_COPY_AND_ASSIGN * Get method returns (const)& instead of * * Use base::NoDestructor to construct the singletons - Made VASupportedProfiles member functions const Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib9b11bd42d2c7c64ea5c72e649a9504bab8014ba Reviewed-on: https://chromium-review.googlesource.com/1143063Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#580072}
-
Andrew Grieve authored
Bug: 857001 Change-Id: Id4eebe86e34e30edfda8fa5825ceb1e3e303dd95 Reviewed-on: https://chromium-review.googlesource.com/1148929Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#580071}
-
Shakti Sahu authored
Added a setting to enable/disable prefetch in downloads settings. This settings will not be visible if prefetching feature is not enabled. UX: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZa-WKS_VfBWp/files/MCHtA7U1iMGr6yF79JTTnBdio_aEa3M5pNg Bug: 850588 Change-Id: Icb1f4a504c88878ada36c9e642819669e9ee7409 Reviewed-on: https://chromium-review.googlesource.com/1139590 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#580070}
-
Alex Moshchuk authored
RenderProcessWillExit is dispatched to observers from RPHI::ShutdownRequest during renderer-initiated process shutdown, when the renderer process is allowed to continue shutting down but before it does actually shut down. This is routed through SiteInstanceImpl::RenderProcessWillExit, which calls RenderFrameHostManager::RenderProcessGone() to mark all proxies living in that process as non-live. Unfortunately, this might lead to duplicate routing ID crashes if one of these proxies is reused and recreated before the process goes away completely. See https://crbug.com/794625#c14 for full details. This CL fixes these races by completely removing RenderProcessWillExit. The affected RenderFrameProxyHosts will still be marked as non-live later when the process actually goes away, as part of SiteInstanceImpl::RenderProcessExited(), called from either RPHI::Cleanup() or RPHI::ProcessDied(). That is, today we try to mark proxies as non-live twice, and arguably only the second path is really needed. RenderProcessWillExit also used to trigger RenderFrameHostImpl::RenderProcessGone() to perform some navigation cleanup work, but the same cleanup will still happen via the RenderProcessExited path. Bug: 794625, 575400 Change-Id: I6b6c776e179a1048c9634ad323d45302423246f1 Reviewed-on: https://chromium-review.googlesource.com/1155790Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580069}
-
Joel Hockey authored
This will be used in a followup CL for CrostiniManager unit tests. Bug: 846917 Change-Id: I4938a4bf75b986adb4a2dc283ffac7d0509e1c5c Reviewed-on: https://chromium-review.googlesource.com/1158319Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#580068}
-
Kyle Milka authored
Add the selected label to a tile when it is selected. Make the back button usable with the space bar. Bug: 858885 Change-Id: Ib84de79a84034805869e58e1d07c4f7891e8fecd Reviewed-on: https://chromium-review.googlesource.com/1157168 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580067}
-
Christopher Cameron authored
Change zero-copy to specify IOSurface color profiles using SetColorSpaceMetadataCHROMIUM rather than calling SetColorSpace on the GpuMemoryBuffer directly. The SetColorSpaceMetadataCHROMIUM path ends up calling gl::GLImageIOSurface::SetColorSpace, which uses the gfx::DisplayICCProfiles structure to ensure that we use low power profiles when possible. This removes the need for - gfx::ICCProfile::FromCacheMac - Sending gfx::ICCProfiles from the browser to the renderer in the content::ScreenInfo - Note that content::ScreenInfo::icc_profile was not ever actually read - Sending it over IPC would result it being added to the cache read by gfx::ICCProfile::FromCacheMac - mojo and IPC support of gfx::ICCProfile Bug: 869570 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I814496a5fffc8da38b4b59d7d2cc055dc47cd52b Reviewed-on: https://chromium-review.googlesource.com/1159233 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#580066}
-
Antoine Labour authored
This is a servce-side class that can create shared images in the form of mailboxes. This is the service-side implementation of the upcoming SharedImageInterface, which is a stateless and thread-safe API to create such shared images from the client side (introduced in a follow-up). Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id0db4300a57e02ccbd46b5b328b534d8cd3f2dc8 Reviewed-on: https://chromium-review.googlesource.com/1159384Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580065}
-
Johannes Henkel authored
This lets an agent clear all its fields, by calling agent_state_.Clear(); And now all the methods are called just Clear, a bit like STL calls different erase methods (range, iterator, value, ...) just erase. What's being cleared will be distinguished by the context only, e.g. method parameters and the receiver. There's pros / cons to this but it's also kinda neat in a way. I do need to do something about ClearAll either way so that I can have a virtual method, so this choice felt both convenient and principled. Hoping to get away with it. :-) Change-Id: I439b77052e110968f196a21ae63020646a9ba23b Reviewed-on: https://chromium-review.googlesource.com/1159822Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580064}
-
John Abd-El-Malek authored
This adds support for: 1) Safe Search 2) YouTube restricted mode 3) restricting consumer accounts through Group Policy. The other supporting change is to make ThrottlingURLLoader handle a throttle changing the URL in WillStartRequest. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1152507 with a fix for the CFI failure in unit_tests. TBR=kinuko Bug: 841313 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iedb413e4cb2837d71d380e5df74d7f80305181cd Reviewed-on: https://chromium-review.googlesource.com/1159821Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580063}
-
Kinuko Yasuda authored
This reverts commit f61df6f9. Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change. Sample builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235 failures: BluetoothTestWinrtOnly.GattServices_ObserversCalls/0 BluetoothTestWinrt.GetPrimaryServices/1 BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1 BluetoothTestWinrt.GetPrimaryServicesByUUID/1 BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0 BluetoothTestWinrt.GetGattServices_and_GetGattService/1 BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1 BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0 Original change's description: > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors > > This change implements reading and writing of Remote Gatt Descriptors > for WinRT. Furthermore, it enables corresponding tests. > > Bug: 821766 > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe > Reviewed-on: https://chromium-review.googlesource.com/1156703 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579838} TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766 Reviewed-on: https://chromium-review.googlesource.com/1159961Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580062}
-
Nikhil Athreya authored
Recognizes a request for process usage data from ProcessDataCollector when an IPC message from the render (invoked from Javascript) is invoked and passes the information in the ProcessDataCollector::ProcessUsageData struct's to the JS code. requestProcessUsageData from the JS console. BUG: crbug.com/851767 TEST: On a Chrome OS device, go to chrome://power and call Change-Id: Ief597fd97032254c3675371d6a0419cdea0e49f1 Reviewed-on: https://chromium-review.googlesource.com/1157133 Commit-Queue: Nikhil Athreya <nathreya@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#580061}
-
Kinuko Yasuda authored
TBR=jamescook,nick Bug: 671891 Change-Id: Ic0c49bfb7f012fa6f8bd3e5150f57274d439d073 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1159927 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580060}
-
Ken Rockot authored
A few of these tests have some subtle scheduling issues which are hit when we attempt to turn on more granular Mojo bindings message dispatch. This CL adds some synchronization via FlushForTesting calls where appropriate to avoid such issues. TBR=sky@chromium.org Bug: 869553 Change-Id: I8d4d5be6f670db3b3e369f70dfd987dc0b1f1ff2 Reviewed-on: https://chromium-review.googlesource.com/1159591 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580059}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0a1917f0efb7..c99a49a615e8 git log 0a1917f0efb7..c99a49a615e8 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 treehugger-gerrit@google.com Merge "UI: Simplify Animation class" Created with: gclient setdep -r src/third_party/perfetto@c99a49a615e8 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I387c6ace847bcdbf11d722c524ccebff2cfbf351 Reviewed-on: https://chromium-review.googlesource.com/1159881 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580058}
-