GitLab

BUG=354146

Review URL: https://codereview.chromium.org/206023003

git-svn-id: svn://svn.chromium.org/blink/trunk@169634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The format looks like this:

  subtag:byte            // The type of key
  keySpecificProperties  // Block of key specific algorithm info
  usages:uint32          // Bitfield of usages + extractability
  keyDataLength:uint32   // Block of data controlled by embedder
  keyData:byte[keyDataLength]

subtag influences how keySpecificProperties is interpreted:

[If subtag=AesKeyTag]
  keyLengthBytes:uint32  // 16, 24, or 32
  algorithmId:uint32

[If subtag=HmacKeyTag]
  keyLengthBytes:uint32
  hashId:uint32

[If subtag=RsaKeyTag]
  algorithmId:uint32
  type:uint32            // One of {PublicKeyType, PrivateKeyType}
  modulusLengthBits:uint32
  publicExponentLength:uint32
  publicExponent:byte[publicExponentLength]

[If subtag=RsaHashedKeyTag]
  <Same as for RsaKeyTag>
  hashId:uint32

Note that uint32 is encoded as a variable length number. In practice it ends up being a single byte for most of the uses above.

In this design, blink is responsible for serializing all of the key's attributes except for the actual key data which is left to the embedder.

The included tests rely on the chromium side of structured clone landing:
  https://codereview.chromium.org/196513002/

The tests cover serialization of hmac, aes and rsa public keys. I haven't added tests for serialization of rsa private keys yet, since that part is not done on the chromium side.

BUG=245025

Review URL: https://codereview.chromium.org/195543002

git-svn-id: svn://svn.chromium.org/blink/trunk@169633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods from View.

R=lushnikov

Review URL: https://codereview.chromium.org/203603006

git-svn-id: svn://svn.chromium.org/blink/trunk@169632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

addEventListener and removeEventListener should require 2 arguments
(per spec), but legacy content calls these with 0 or 1 arguments.

For background, see this bug:
https://code.google.com/p/chromium/issues/detail?id=249598

This results in a special case in the CG, and an IDL that doesn't reflect
reality.

This updates the IDL to reflect reality, and removes the special-casing
from the CG, removing 3 FIXMEs!

There's now only 1 EventTarget FIXME in the templates, namely
the frame security check (on window).

This changes
addEventListener.length
removeEventListener.length
...from 2 to 0, reflecting reality.

R=haraken
BUG=345503
BUG=249598

Review URL: https://codereview.chromium.org/203603005

git-svn-id: svn://svn.chromium.org/blink/trunk@169631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When MediaQueryParser used valuesList.clear(), clear() cleared the list's values, but not the offset of the current read value.
This fixes that.

BUG=353982

Review URL: https://codereview.chromium.org/204333005

git-svn-id: svn://svn.chromium.org/blink/trunk@169630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Testing IDL files no longer need [NoInterfaceObject],
as we now don't feed them into the list of main interface files
('main_interface_idl_files' in generated_bindings.gyp);
previously it was necessary because we didn't distinguish these files.

This removes the extended attribute, simplifying them.

TBR=haraken
BUG=341748

Review URL: https://codereview.chromium.org/205943003

git-svn-id: svn://svn.chromium.org/blink/trunk@169629 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test was added at r150718.  https://src.chromium.org/viewvc/blink?revision=150718

Currently It doesn't cause a crash even if we revert the change. It means the test is useless to keep stability.
Additionally the test looks less sophisticated and it is hard to get what it does.

BUG=

Review URL: https://codereview.chromium.org/206073002

git-svn-id: svn://svn.chromium.org/blink/trunk@169628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web Animations API: Fix KeyframeEffectModel::PropertySpecificKeyframeGroup::addSyntheticKeyframeIfRequired

Synthetic Keyframes:
For each property declared in a KeyframeEffectModel, addSyntheticKeyframeIfRequired adds
a property specific keyframe at offset: 0 if none exists. Similarly, it adds a keyframe
at offset: 1 if required.

The synthetic keyframes have compositeOperation add, and a neutral value for the property.

Partial Keyframes:
Previously, if an animation was constructed with a partial keyframe (a keyframe list with no 
keyframe at offset zero or no keyframe at offset one for any of the properties it declares) 
the renderer would crash. 

This change detects partial keyframes and throws a NotSupportedError in the JavaScript.

Review URL: https://codereview.chromium.org/203463009

git-svn-id: svn://svn.chromium.org/blink/trunk@169626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169605

BUG=354165
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/196243008

git-svn-id: svn://svn.chromium.org/blink/trunk@169625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hopefully the last in a line of compositing sub-pixel
patches. This correctly pixel snaps the clipping layer
used by composited layers with overflow: clip and
accumulates it into their children.

BUG=347521

Review URL: https://codereview.chromium.org/205213006

git-svn-id: svn://svn.chromium.org/blink/trunk@169624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=347902

Review URL: https://codereview.chromium.org/205853002

git-svn-id: svn://svn.chromium.org/blink/trunk@169623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They are ThreadSafeRefCounted because an object is created in a context thread,
is enqueued into a SQLTransactionBackend, the SQLTransactionBackend is moved to
a database thread, then the database thread takes a SQLStatementBackend in the
queue.
We don't need to care about it in Oilpan. SQLTransactionBackend is correctly
transferred with CrossThreadPersistent.

BUG=347902

Review URL: https://codereview.chromium.org/205823002

git-svn-id: svn://svn.chromium.org/blink/trunk@169622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use new Traversal<*Element> API in svg code for clarity. It results in shorter /
simpler code. It also makes it clearer what type of Element we are actually
interested in.

R=
BUG=346733

Review URL: https://codereview.chromium.org/205983004

git-svn-id: svn://svn.chromium.org/blink/trunk@169621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to check TimelinePresentationRecord.expandable(), but it was accidrently replaced
with hasPresentationChildren(), which is not the same now, since we keep hidden records
in the presentation model.

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/201823003

git-svn-id: svn://svn.chromium.org/blink/trunk@169620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes our usage of the pseudo style cache so that we will
use a cached pseudo style when creating pseudo-elements if possible
and so that we cache pseudo styles even if they don't get a renderer.
We also move the logic for having styles with animations or transitions
be non-sharable from RenderStyle::isSharable to the StyleAdjuster, so
that animated pseudo-elements will have their parent's style correctly
marked as non-sharable.

As a result, a pseudo-element without a renderer (e.g. display:none
or content:none) to will correctly return its computed style to
getComputedStyle. This also fixes a regression where the pseudo style
cache can end up very large when its parent style is shared.

BUG=345653

Review URL: https://codereview.chromium.org/196143004

git-svn-id: svn://svn.chromium.org/blink/trunk@169619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of HTML Imports: Send credentials for same origin requests (https://codereview.chromium.org/196043002/)

Reason for revert:
The following tests crash on all debug bots.
- fast/shapes/shape-inside/shape-inside-image-set.html
- fast/shapes/shape-outside-floats/shape-outside-image-set.html


Original issue's description:
> HTML Imports: Send credentials for same origin requests
> 
> This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
> The essential part of the change is in HTMLImportsController.cpp.
> Anything else is to make it work with redirect.
> 
> The problem here is that allowCredentials flag is held both
> by ResourceLoaderOptions and ResourceRequest and these two
> can go out-of-sync. This change tries to make them in sync.
> 
> Such a state duplication should be resolved eventually, but
> that is another story.
> 
> BUG=348671
> TEST=import-cors-credentials.html
> R=dglazkov@chromium.org, japhet@chromium.org, abarth
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169496
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169578

TBR=abarth@chromium.org,dglazkov@chromium.org,japhet@chromium.org,morrita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=348671

Review URL: https://codereview.chromium.org/199733008

git-svn-id: svn://svn.chromium.org/blink/trunk@169618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In this page,while saving the page if images with load error/decode error are saved,
while rendering the mhtml page the broken images are shown in place of those images.

BUG=346254
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/177243005

git-svn-id: svn://svn.chromium.org/blink/trunk@169616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353233
TEST=fast/dom/shadow/ol-with-distribution-recalc-crash.html

Review URL: https://codereview.chromium.org/204343002

git-svn-id: svn://svn.chromium.org/blink/trunk@169615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes the code more readable as it makes it clear we are only traversing
children. This is also a bit more efficient as nextSiblingChildren() tries to
traverse the ancestors siblings when done with the current siblings.

R=esprehn, adamk

Review URL: https://codereview.chromium.org/196823006

git-svn-id: svn://svn.chromium.org/blink/trunk@169614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This refactors simplifies dependency resolution, and makes it easier to
extend.

Specifically:
* Move file handling into idl_reader
* Move actual definition and interface merging to methods on IdlDefinitions
  and IdlInterface (in idl_definitions)

This also clarifies exactly what's going on specially:
* we tack on some extended attributes to members
* we merge implemented interfaces to the main one

Other changes:
* use next() instead of looping over a one-element list
* remove useless exceptions (specific exception classes are only useful
  if we catch them, otherwise it's no better than a string)

This is to support a separate CL:
Bindings: inherit enums and callbacks from partial interface files.
https://codereview.chromium.org/203193015/

TBR=haraken
BUG=345137

Review URL: https://codereview.chromium.org/205873003

git-svn-id: svn://svn.chromium.org/blink/trunk@169613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes the fast/css/css2-system-fonts.html explicit about the
font styles expected on each platform instead of just Mac.
It also converts the test to be text only as the style information is
now displayed in text format.

This change is in preparation for a refactor of system font handling.

BUG=353932

Review URL: https://codereview.chromium.org/204113007

git-svn-id: svn://svn.chromium.org/blink/trunk@169612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes the promise resolution logic of FontFaceSet#load()
to match the spec [1], in the following ways:

1. Rejects the promise with SyntaxError if the font argument fails to
   parse.
2. Otherwise, the promise should be resolved in the same way as
   Promise.all() called with all of the results of FontFace#load() of
   the matching font faces, i.e.
2.1. Resolves the promise with an array of the matching font faces when
     all the fonts are loaded, or
2.2. Rejects the promise with the rejection value of the first failed
     font face.

The new ScriptPromiseResolver Vector overloads need NoInline version of
v8Array, since existing v8Array() uses toV8 inside and hence requires
generated headers (see crbug.com/321569 for details of a similar issue).

[1] http://dev.w3.org/csswg/css-font-loading/#font-face-set-load

TEST=fast/css/fontfaceset-load.html
BUG=53213

Review URL: https://codereview.chromium.org/196383035

git-svn-id: svn://svn.chromium.org/blink/trunk@169611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This separates the decisions about caching StyleSheetContents for <style> elements
from those related to <link> elements. This makes the code clearer as there are
fewer conditions that could cause uncacheability (for example, the StyleSheetContents
for <style> elements could never be for an @import rule).

And since the <style> cache is per-StyleEngine (and thus per-Document), the
<style> case can now safely cache stylesheets that include @media rules.
This speeds up the included performance test from ~90ms on my Z620 to ~50ms,
and improves the biggest block of chromestatus.com load performance by ~20%.

This patch also cleans up StyleSheetContents a bit, collapsing the maybeCacheable()
method into isCacheable() and making appropriate accessors const.

BUG=342507

Review URL: https://codereview.chromium.org/196133034

git-svn-id: svn://svn.chromium.org/blink/trunk@169610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of keeping a separate hash map we should just store this
information in the ElementRareData. This simplifies the implementation and
in practice will likely reduce memory usage since almost all custom elements
we've seen so far touch something that ends up making them use rare data like
childNodes, attributes, tabIndex, classList or dataset.

Review URL: https://codereview.chromium.org/177063004

git-svn-id: svn://svn.chromium.org/blink/trunk@169609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds test expectation fix.

BUG=

Review URL: https://codereview.chromium.org/204983002

git-svn-id: svn://svn.chromium.org/blink/trunk@169608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a bug where resources in element.animate() calls were
not being fetched. This resulted in StylePendingImages leaking out of
the style resolving stage and into rendering which causes a crash.

This patch fixes the bug by ensuring StylePendingImages introduced in
applyAnimatedProperties() will be resolved as non-pending StyleImages
through an additional call to loadPendingResources().
This patch also modifies AnimatableImage to be a wrapper of CSSValues
instead of StyleImages in order to follow the same resource caching
logic as typical CSS image values.
This patch also updates EffectInput::convert() to pass the document's
StyleSheetContents to MutableStylePropertySet::setProperty() so that
relative URLs are correctly resolved to absolute URLs.

This is a reland of https://codereview.chromium.org/196573030/ with
AnimatableImage::create() rewritten to not require an ASSERT.

BUG=353385

Review URL: https://codereview.chromium.org/196943029

git-svn-id: svn://svn.chromium.org/blink/trunk@169607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because setCanBeDragged(true) is never called, all the rest of the
dragging code becomes unreachable. The feature as such looks useful, but
it would require fixing and above all testing to interact well with text
track rendering.

BUG=341813
TEST=LayoutTests/media/ still passes, i.e. there were none!

Review URL: https://codereview.chromium.org/196533020

git-svn-id: svn://svn.chromium.org/blink/trunk@169606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implement support for computing and populating the GlyphOverflow
structure for the harfbuzz code path. The current implementation is a
straight copy of the current Mac implementation with minor
modifications to use the corresponding harfbuzz APIs.

R=dglazkov@chromium.org,behdad@chromium.org
BUG=354165
TEST=fast/text/international/repaint-glyph-bounds.html

Review URL: https://codereview.chromium.org/205553003

git-svn-id: svn://svn.chromium.org/blink/trunk@169605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Harfbuzz-ng 0.9.27 introduced a HAVE_ICU_BUILTIN define which makes the
hb_buffer_set_unicode_funcs call redundant. Also call
hb_buffer_clear_content instead of hb_buffer_reset which is faster now
that we no longer explicitly set the unicode functions.

BUG=354117
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/197213032

git-svn-id: svn://svn.chromium.org/blink/trunk@169604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=304341

Review URL: https://codereview.chromium.org/204673007

git-svn-id: svn://svn.chromium.org/blink/trunk@169603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Getting/setting these properties can depend on FrameLoaderClient, which
will be null if the frame containing the DOMWindow has already been
detached.

BUG=349956,352048

Review URL: https://codereview.chromium.org/203493005

git-svn-id: svn://svn.chromium.org/blink/trunk@169602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This further simplifies EventTarget bindings generation.

The goal (for now) is to only have a special case for the
{{hidden_dependency_action}}; everything else should be pretty easy
to eliminate (except maybe the ListenerFindOnly case).

The main change in this CL is making the argument handling regular.
(Also correctly handles EventListener as a callback interface.)

This also breaks up the big custom generation into smaller pieces,
so each piece can be eliminated separately.

Followup to:
Simplify EventTarget bindings generation
https://codereview.chromium.org/201603002/

R=haraken
BUG=345503

Review URL: https://codereview.chromium.org/203143002

git-svn-id: svn://svn.chromium.org/blink/trunk@169601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Rewrite platform headers in public/web/ to public/platform/... (https://codereview.chromium.org/189703002/)

Reason for revert:
Broke Windows, Mac, and ChromeOS build.


Original issue's description:
> Rewrite platform headers in public/web/ to public/platform/...
> 
> Includes of this style are more consistent with the rest of the project and
> easier to verify with DEPS. For consistency, includes in public/web/ of other
> headers in public/web/ are rewritten to list the public/web/ portion as well.
> 
> BUG=350097
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169597

TBR=abarth@chromium.org,jamesr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=350097

Review URL: https://codereview.chromium.org/205153006

git-svn-id: svn://svn.chromium.org/blink/trunk@169600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Made tests start failing

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html,inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html

Original issue's description:
> Remove WebInspector.HeapSnapshotArraySlice
> 
> Uin32Array already has subarray method that returns a new view for the same array buffer.
> 
> BUG=None
> R=alph@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169554

TBR=alph@chromium.org,loislo@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/205953002

git-svn-id: svn://svn.chromium.org/blink/trunk@169599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Includes of this style are more consistent with the rest of the project and
easier to verify with DEPS. For consistency, includes in public/web/ of other
headers in public/web/ are rewritten to list the public/web/ portion as well.

BUG=350097

Review URL: https://codereview.chromium.org/189703002

git-svn-id: svn://svn.chromium.org/blink/trunk@169597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Theres no reason to synchronously recalc style whenever you change the
media attribute of a <style>.

Review URL: https://codereview.chromium.org/205463002

git-svn-id: svn://svn.chromium.org/blink/trunk@169596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

StyleSheetContents cache works independent of document's active(),
because StyleElement::process() always invokes StyleEngine::createSheet().

So removeSheetFromCache should also remove 'this' from the cache independent of document's active().

BUG=353894
TEST=fast/dom/move-style-element-to-inactive-document-crash.html

Review URL: https://codereview.chromium.org/204423002

git-svn-id: svn://svn.chromium.org/blink/trunk@169595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=347902

Review URL: https://codereview.chromium.org/201083003

git-svn-id: svn://svn.chromium.org/blink/trunk@169594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS Regions code has been removed in r167275 so these performance tests
do not work anymore.

Review URL: https://codereview.chromium.org/205323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It appears that this never worked correctly. To implement,
I extracted the code we use to set initial value for document and
started using it when applying initial font-family value.

BUG=354110
R=eseidel,eae

Review URL: https://codereview.chromium.org/197213034

git-svn-id: svn://svn.chromium.org/blink/trunk@169592 bbb929c8-8fbe-4397-9dbb-9b2b20218538