- 28 Jul, 2016 2 commits
-
-
dpranke authored
Before r407890, we had no good way to make sure that we were including the .pdb files for executables and shared libraries in the runtime_deps for a target. Now that GN has a `runtime_outputs` option, we can use that and list the PDBs. This should fix issues for debugging and also packaging the NaCl files as part of an official build. R=brettw@chromium.org, sebmarchand@chromium.org BUG=624478, 629709 Review-Url: https://codereview.chromium.org/2192643002 Cr-Commit-Position: refs/heads/master@{#408282}
-
xingliu authored
Previously Blimp code is in blimp/app, this CL port settings UI code to core, and reuse Java resources files in blimp/app.(We can setup new one in core or somewhere if needed) In this way, all UI resources, and code live in Blimp so we don't leak things to Chrome at the moment. For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask Chrome to do things in java. The CL that port UI code and resources into Chrome will be deleted. BUG=624451 Review-Url: https://codereview.chromium.org/2173563003 Cr-Commit-Position: refs/heads/master@{#408281}
-
- 27 Jul, 2016 38 commits
-
-
tedchoc authored
BUG=629642 Review-Url: https://codereview.chromium.org/2180293002 Cr-Commit-Position: refs/heads/master@{#408280}
-
tguilbert authored
This change introduces the StreamTextureWrapper interface and its implementation. It is meant to be used as an alternative way to provide an Android Surface to the upcoming MediaPlayerRenderer (see crbug.com/631199). The main advantage of using a StreamTexture is that it allows non-fullscreen playback, as opposed to the SurfaceView. The actual transfering of the underlying SurfaceTexture accross processes will be covered in crbug.com/627658. The StreamTextureWrapper class encapsulates most of the StreamTexture logic from WMPA. TEST=video works in current MediaPlayerRenderer prototype. Added a simple contruction/destruction UT for STW_Impl. BUG=627632 Review-Url: https://codereview.chromium.org/2136103010 Cr-Commit-Position: refs/heads/master@{#408279}
-
ikilpatrick authored
This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well. The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach. BUG=567358 Review-Url: https://codereview.chromium.org/2171973006 Cr-Commit-Position: refs/heads/master@{#408278}
-
japhet authored
It's possible for it to be checked after the DocumentLoader has finished, at which point it will incorrectly return false. BUG=520389, 331745 TEST=DocumentLoaderTest.isCommittedButEmpty Review-Url: https://codereview.chromium.org/1364863002 Cr-Commit-Position: refs/heads/master@{#408277}
-
baxley authored
BUG= Review-Url: https://codereview.chromium.org/2185693004 Cr-Commit-Position: refs/heads/master@{#408276}
-
mostynb authored
Review-Url: https://codereview.chromium.org/2189523004 Cr-Commit-Position: refs/heads/master@{#408275}
-
rch authored
Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC. These stats are not yet populated. Merge internal change: 128466946 https://codereview.chromium.org/2188663003/ Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals. Merge internal change: 128459519 https://codereview.chromium.org/2192633002/ Add a new flag to require QUIC handshake confirmation, but only for versions before 33 FLAGS_quic_require_handshake_confirmation_pre33. Merge internal change: 128431128 https://codereview.chromium.org/2187463004/ Ignore RTT measurements greater than 30 seconds in QUIC and limit the LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps Merge internal change: 128425078 https://codereview.chromium.org/2185163002/ Change memmove's back into memcpy's. No functional change. Not flag protected. memmove is presently ~2.5x faster than memcpy, however isn't inlined with -minline-all-stringops. It turns out that when these effects combine, the net result is a no-op for performance. So let's switch back to memcpy, because memcpy is likely to be improved in the future, and seeing memmove's where they aren't needed is somewhat surprising. Merge internal change: 128366346 https://codereview.chromium.org/2192623002/ Review-Url: https://codereview.chromium.org/2189763002 Cr-Commit-Position: refs/heads/master@{#408274}
-
bnc authored
Add some heuristics to SetAlternativeServices that prevents a ScheduleUpdatePrefsOnNetworkThread() call after each incoming Alt-Svc header, based on the time of the last update, and the expiration times of the current and new in-memory entries. (Note that the current in-memory entry might be different from the entry last persisted to disk.) Repeated requests to the same server typically result in identical Alt-Svc announcements, which become different when the max-age field (in seconds from now) gets converted into a base::Time expiration time. Alternative services do not need to be persisted to disk with every incoming Alt-Svc header if other fields (scheme, host, port) are identical. BUG=554643 Review-Url: https://codereview.chromium.org/2171743002 Cr-Commit-Position: refs/heads/master@{#408273}
-
mcasas authored
Original CL was reverted because it broke Win Gyp Component-build bot(s). This CL (PS2) defines the geolocation gyp component correctly. Original CL description ------------------------------------------------ Geolocation: move from content/browser to device/ This CL: - moves all of content/browser/geolocation to device/geolocation - the public geolocation files in content/common/{browser, public} are also relocated to device/geolocation - the geolocation-specific unittests are compiled into (already existing) device_unittests - adds new fancy new device/geolocation BUILD.gn and geolocation.gyp as well - makes a component of geolocation (at least for gn) and that forces adding geolocation_export.h (like other //device/ folders). - Java Geolocation files are moved as well, and a new geolocation_jni_registrar is added. - classes are moved to device namespace. All paths and include/call sites updated, DEPS, BUILD.gn files, gypi files etc. Some tricks: - can't use BrowserThread::CurrentlyOn, etc; instead, the task runner is cached on constructor and used for both thread checking and PostTask()ing (a few unittest and wifi_data_provider* needed that substitution). - GeolocationServiceContext is moved to public/cpp so it can be referenced from WebContentsImpl. - MockLocationProvider.java is also moved to device/geolocation. BUG=612334 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=pstew@chromium.org rationale:device/geolocation depends on dbus and this triggers a DEPS presubmit rule -- however, this CL adds no new dependencies, hence moving on in the interest of speed (and avoiding more rebases). Review-Url: https://codereview.chromium.org/2185993003 Cr-Commit-Position: refs/heads/master@{#408272}
-
msw authored
ActivationChangeObserver -> WmActivationObserver. Always create RootWindowControllerObserverImpl. Make RootWindowControllerObserverImpl add/remove itself. Compare display ids instead of root windows. Use wm::GetWindowForFullscreenMode instead of ash::RWC. Use WmLookup instead of WmWindowAura::Get. Use Widget::IsMouseEventsEnabled instead of CursorClient. Fix IWYU issues; remove unused forward decls/friends. BUG=631215 TEST=Automated tests; no behavior changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2187513003 Cr-Commit-Position: refs/heads/master@{#408271}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/757ba0d236e7..8efab958c670 $ git log 757ba0d23..8efab958c --date=short --no-merges --format='%ad %ae %s' BUG=472699 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2191713002 Cr-Commit-Position: refs/heads/master@{#408270}
-
pennymac authored
Part of chrome_elf cleanup. This was never used in the wild, and we won't need it in the foreseeable future. Leaving beacon and emergency disable finch switch for safety. Tests: 1) chrome_elf_unittests, chrome_elf_util_unittest.cc: BlacklistTest* 2) unit_tests, chrome_elf_init_unittest_win.cc: ChromeBlacklistTrialTest* R=robertshield@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng BUG=631771 Review-Url: https://codereview.chromium.org/2163803003 Cr-Commit-Position: refs/heads/master@{#408269}
-
reveman authored
For buffers allocated using CreateGpuMemoryBuffer, avoid creating a second native pixmap for the same buffer as that results in the associated GEM handle being closed twice. BUG=631268 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2188893002 Cr-Commit-Position: refs/heads/master@{#408268}
-
eostroukhov authored
BUG=624494 R=dgozman Review-Url: https://codereview.chromium.org/2186753002 Cr-Commit-Position: refs/heads/master@{#408267}
-
chcunningham authored
SmokeTests are the subset of layout tests run on the android bots. This change adds coverage to several historically problematic config-change scenarios. These tests use a virtual suite that sets the flag "--use-gpu-in-tests". This flag overrides the default test behavior of using MesaGL, which is not capable of creating surfaces to use with gpu accelerated decoding (at least on Android). This change also fixes some test/expectations rot. BUG=555703 TESTS=Config change LayoutTests. Committed: https://crrev.com/b8bf5eba6b6cd3623f16404c746251bf662d141d Review-Url: https://codereview.chromium.org/1644763002 Cr-Original-Commit-Position: refs/heads/master@{#407938} Cr-Commit-Position: refs/heads/master@{#408266}
-
boliu authored
Better matches with native code. Native code turns on DCHECKs with dcheck_always_on. All usage of BuildConfig.IS_DEBUG is really guarding DCHECK equivalents in Java. So rename the variable DCHECK_IS_ON, and make it depend on dcheck_always_on as well. Review-Url: https://codereview.chromium.org/2181053002 Cr-Commit-Position: refs/heads/master@{#408265}
-
sky authored
And updates accelerators appropriately. BUG=612331 TEST=none R=jamescook@chromium.org,stevenjb@chromium.org,reveman@chromium.org TBR=stevenjb@chromium.org,reveman@chromium.org Review-Url: https://codereview.chromium.org/2192613002 Cr-Commit-Position: refs/heads/master@{#408264}
-
gangwu authored
BUG=631288 Review-Url: https://codereview.chromium.org/2179223006 Cr-Commit-Position: refs/heads/master@{#408263}
-
avi authored
It's only used by the task manager, it doesn't help much, it uses NSPointerArray which is a class intended for GC (which is obsolete), and it just complicates the flow. BUG=528486 TEST=none Review-Url: https://codereview.chromium.org/2187993002 Cr-Commit-Position: refs/heads/master@{#408262}
-
jamescook authored
This is a small step toward conversion it to ash common types. BUG=615155 TEST=manual, show context menu and change auto-hide and alignment options, plus ash_unittests Review-Url: https://codereview.chromium.org/2186913003 Cr-Commit-Position: refs/heads/master@{#408261}
-
eugenebut authored
BUG=631235 Review-Url: https://codereview.chromium.org/2183583002 Cr-Commit-Position: refs/heads/master@{#408260}
-
wfh authored
BUG=614440,630472 TEST=go to chrome://memory-exhaust on 64-bit Chrome and verify it gives the OOM sad tab. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2191643002 Cr-Commit-Position: refs/heads/master@{#408259}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b623b2bff836..757ba0d236e7 $ git log b623b2bff..757ba0d23 --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2190743002 Cr-Commit-Position: refs/heads/master@{#408258}
-
allada authored
Added a context menu option which you can get all requests seperated by a semicolon and new lines for users that want to get all or most of the requests as curl commands from devtools BUG=466923 Review-Url: https://codereview.chromium.org/2177383003 Cr-Commit-Position: refs/heads/master@{#408257}
-
allada authored
Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG=none Review-Url: https://codereview.chromium.org/2189733002 Cr-Commit-Position: refs/heads/master@{#408256}
-
estark authored
IsUserClockInThePast/Future no longer exist and have been replaced by GetClockState(). BUG= Review-Url: https://codereview.chromium.org/2184263002 Cr-Commit-Position: refs/heads/master@{#408255}
-
jbauman authored
We've decided to use Microsoft's MFT for now, so remove support for Intel's MFT. BUG=616318 Review-Url: https://codereview.chromium.org/2178203002 Cr-Commit-Position: refs/heads/master@{#408254}
-
cco3 authored
This change initiates a background scan through Nearby on startup so that the Physical Web feature can surface URLs. BUG=623638 Review-Url: https://codereview.chromium.org/2176373007 Cr-Commit-Position: refs/heads/master@{#408253}
-
sky authored
TBR=ben@chromium.org R=ben@chromium.org BUG=none TEST=none Review-Url: https://codereview.chromium.org/2182633011 Cr-Commit-Position: refs/heads/master@{#408252}
-
wangxianzhu authored
- Clear just created flag if the client is used in any display item or chunk. Don't set a chunk client to validly cached status because it doesn't have any validly cached display item (otherwise it should have been marked validly cached in the m_newADisplayItemList loop. - Invalidate the client if it has any display items skipped cache. Review-Url: https://codereview.chromium.org/2185933003 Cr-Commit-Position: refs/heads/master@{#408251}
-
eugenebut authored
1.) Delaying queues flushing is unnecessary because reentrace can't happen with asynchronous JS API. 2.) Check for message object presence is unnecessary because it is injected together with __crWeb object. BUG=402682,628832 Review-Url: https://codereview.chromium.org/2192503002 Cr-Commit-Position: refs/heads/master@{#408250}
-
fs authored
Review-Url: https://codereview.chromium.org/2175123002 Cr-Commit-Position: refs/heads/master@{#408249}
-
juncai authored
This is part 6 of matching WebBluetooth chooser views to mocks. This CL adds test code for spinner, status, and rescan button that was added in the previous patch. BUG=583452 Review-Url: https://codereview.chromium.org/2179193002 Cr-Commit-Position: refs/heads/master@{#408248}
-
juncai authored
This is part 5 of matching WebBluetooth chooser views to mocks. This CL adds test code for spinner, status text and rescan button that was added in previous patches. BUG=583452 Review-Url: https://codereview.chromium.org/2171103002 Cr-Commit-Position: refs/heads/master@{#408247}
-
kmackay authored
When EmbeddedApplicationRunner is destroyed, if the application instance still has any bound connections, those connections must be destroyed on the application task runner. Otherwise there is a DCHECK failure when the binding is destroyed. BUG= Review-Url: https://codereview.chromium.org/2188503003 Cr-Commit-Position: refs/heads/master@{#408246}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2493943b..ff79f437 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2187963002 Cr-Commit-Position: refs/heads/master@{#408245}
-
mdjones authored
If the RenderFrameHost is swapped, it usually means the old host will be destroyed. Manual cleanup of the mojo service should not be necessary since the attached interfaces will be removed during destruction. BUG=624260 Review-Url: https://codereview.chromium.org/2185733002 Cr-Commit-Position: refs/heads/master@{#408244}
-
yuweih authored
This CL refactors the CursorShapeStub being used by JniDisplayHandler into a helper class that forwards cursor shape info from one thread to another. It can be used by JniGlDisplayHandler to update the cursor shape for the remoting Android OpenGL host renderer implementation. BUG=385924 Review-Url: https://codereview.chromium.org/2187723002 Cr-Commit-Position: refs/heads/master@{#408243}
-