Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 10 Feb, 2018 7 commits
    • Pete Williamson's avatar
      [Offline Pages] Adding util method for unique filename generation. · f7aaf359
      Pete Williamson authored 
      Adding a utility method for generating unique filenames for offline page
based on title and url of the page.

(Re-uploading a change by Romax with fixed merge conflicts)

Bug: 757073
Change-Id: I03e8e5cc03a640de2abee8e6e903b6bdce53af24

TBR: dimich@chromium.org, dtrainor@chromium.org
Change-Id: I03e8e5cc03a640de2abee8e6e903b6bdce53af24
Reviewed-on: https://chromium-review.googlesource.com/911837Reviewed-by: default avatarPeter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535898}
      f7aaf359
    • Xunran Ding's avatar
      CacheStorage: Use url::Origin rather than GURL for representing origins · b6a21896
      Xunran Ding authored 
      This just updates the internals of CacheStorage. GURL is still used in
content/public/browser and storage/browser/quota. so there are still
conversions Origin<->GURL conversions on those API boundaries.

Bug: 598424
Change-Id: Ib2ada9245c3d77f9be33217380742e4c00a732af
Reviewed-on: https://chromium-review.googlesource.com/897231Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Reviewed-by: default avatarJoshua Bell <jsbell@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535897}
      b6a21896
    • Sylvain Defresne's avatar
      Fix crash when presenting upgrade infobar · 256e82c1
      Sylvain Defresne authored 
      The BVC may have a nil TabModel. Before https://crrev.com/c/867054
the iteration over the TabModel worked (as sending a message to nil
is well defined in Objective-C) but after the refactor, this lead
to Undefined Behaviour when dereferencing a null pointer.

Add an explicit check that TabModel is non-nil, and early return
if this is not the case to prevent the crash (the infobar will be
presented later to the user in that case).

Bug: 808319
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibc6e603957da108554525ac218c9afaaabb6a62b
Reviewed-on: https://chromium-review.googlesource.com/912508Reviewed-by: default avatarStepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535896}
      256e82c1
    • W. James MacLean's avatar
      Remove event coalescing from RenderWidgetTargeter. · e012089d
      W. James MacLean authored 
      The code removed in this CL is believed to be the root cause of the
crash in the associated bug.

The mechanism is this: when events are coalesced, some event types still
expect all of the original events to be properly acked, and at present
RenderWidgetTargeter doesn't implement this. The crash, in particular,
is the result of touch events being acked in a way that the unique ids
don't line up with the queue in
TouchDispositionGestureFilter::OnTouchEventAck()
because some of the ids are missing after being coalesced.

At present we will only disable coalescing for touch and gesture
events,but that's reasonable since in most cases we only everhit-test
the initial TouchStart and everything else in the sequence latches to
its target.

Further, it's not obvious if there's a significant performance
benefit to the coalescing these events, so for now we remove it.
In any case, implementing proper acking of these events would result
in a patch too big to merge back to M65.

Bug: 807507
Change-Id: I50dbef4f16f4b451321564e1e0c9cfb352aafabd
Reviewed-on: https://chromium-review.googlesource.com/905459
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Reviewed-by: default avatarKevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535895}
      e012089d
    • Vasilii Sukhanov's avatar
      Fix a crash when the password bubble closes. · 8aac555f
      Vasilii Sukhanov authored 
      When a tab is closed from the renderer via window.close(), the password bubble may still be show. When it closes PasswordFormManager may decided to upload some votes. ChromePasswordManagerClient still exists at this point but ContentAutofillDriverFactory can already be deleted. The code should check this condition.

Bug: 807601
Change-Id: If75c1aa5759e07568340d2233b22cc159e8c687e
Reviewed-on: https://chromium-review.googlesource.com/911770Reviewed-by: default avatarStepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535894}
      8aac555f
    • Pete Williamson's avatar
      Publish the Offline Page to a public directory · 4cb14ba3
      Pete Williamson authored 
      This change will move the offline page to a public directory and inform
the system download manager if any (for instance, on Android) of the
location and type of the file.  If both steps succeed, the
offline page item will be written to the offline page model database.

Bug: 758690
Change-Id: Iabba419903849892a947d80bd82c39123e1bc962
Reviewed-on: https://chromium-review.googlesource.com/896555
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: default avatarJian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535893}
      4cb14ba3
    • Tom Anderson's avatar
      Fix gn reference in build.ninja after bootstrapping · 00eba186
      Tom Anderson authored 
      After bootstrapping gn, build.ninja has a reference that looks something like:
command = ../../../../../../../../../../tmp/tmp9Pn0sv/gn --root=../.. -q gen .

This reference will be broken when the OS removes the temporary directory.  This
CL regenerates the build files using the gn executable from the build directory.

This on its own will update the reference to plain "gn", however we need the
reference to be "./gn", because "gn" might not exist in the PATH, or would point
to an old one from depot_tools.

BUG=808829
R=dpranke

Change-Id: I1b156a6af081a35ded152946af13a117563b8c1a
Reviewed-on: https://chromium-review.googlesource.com/905793
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: default avatarBrett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535892}
      00eba186
  3. 09 Feb, 2018 33 commits