- 12 Feb, 2020 40 commits
-
-
Yilong Yao authored
Bug: 32486634 Test: CQ Change-Id: I1418d910625d32ac67d33624c002ca630b1de37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048407 Commit-Queue: Yilong Yao <yilongyao@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#740815}
-
Yue Li authored
Open app queries do not trigger text/html response. We need to handle the case to make it valid for the private API. Bug: 982538 Test: Test with the newly added Assistant Tast test Change-Id: Ib78b6534f973a46b413fd998c0e60ccdd8fd2f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050581Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#740814}
-
Dave Tapuska authored
In preparation for removing the gfx::Size<->blink::WebSize typemapping change WebMediaPlayer to use gfx::Size. This also fixes an issue in change http://crrev.com/e65cabb75f that transposed width and height in the webmediaplayer_ms.cc Change-Id: Ide6243df9ba82043cabb5d69f1d6fd79c832f059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052266Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#740813}
-
Lan Wei authored
There are two ways to trigger fullscreen, either by user activation or by a user generated orientation change. When we enter the fullscreen mode, we should not consume the user activation in the browser side when the fullscreen is triggered by a user generated orientation change, so we need to set the orientation change flag in the browser side when we are calling the mock function setMockScreenOrientation through a mojo message. The CL that consumes the user activation on both the browser and renderer sides when entering fullscreen: https://chromium-review.googlesource.com/c/chromium/src/+/1903675 Bug: 1046933 Change-Id: I1eb86205bc82ac237bc12d63bbdb0c8985c06090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026170Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#740812}
-
Mark Yacoub authored
If the device supports KMS Atomic APIs, Enable CRTC using Atomic Modeset Commit instead of legacy SetCRTC. BUG=987274 TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterModeset Change-Id: I116a2caf8602aa6470c9cf17a65fa12c045f8d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039752 Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#740811}
-
Su Hong Koo authored
Add ash::features::kCornerShortcuts flag to toggle corner shortcuts feature. Bug: 660748 Change-Id: I9d93a8412bc2238fb5bdb49501120b5603976b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044635 Commit-Queue: Su Hong Koo <sukoo@google.com> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740810}
-
Chris Blume authored
CheckerImageTracker::ShouldCheckerImage() has the equivalent of: bool thing = true; if (thing) { thing = should_do_thing(); The branch is always taken and thus doesn't need to be a branch. This CL removes the branch. Change-Id: Ib73170ed3064bfe6ad690fc4377e741e4f595831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047379Reviewed-by:vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#740809}
-
Alex Newcomer authored
Add the metrics reporter to the hotseat widget for all layer animations, but this time initialize the reporters state. TBR=mpearson@chromium.org Bug: 1049385 Change-Id: Ia48ca639aa3a317adf395ba6822b70cfb3008d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047604Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#740808}
-
Jamie Madill authored
conformance/extensions/webgl-compressed-texture-size-limit.html Bug: 1051576 Tbr: ynovikov@chromium.org Change-Id: I697655db44c0111c618f20deafe7e92386305420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051530Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#740807}
-
Mike Wittman authored
Now that per-sample timestamps are provided to the ProfileBuilder we can set the actual profile start time -- the time the first sample is taken -- rather than using the prior approximation of when the CallStackProfileBuilder class was created. This will be used when applying retrospective metadata, to ignore requests on time ranges prior to the profile start time. Bug: 1034758 Change-Id: Idf51c4e40dd853408d5f7baee6e9f657d18aa061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015724 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#740806}
-
Manu Cornet authored
Change-Id: I5bf1f77fc99deb35dfd473aa03689ab023b419eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052221Reviewed-by:
-
Tom Anderson authored
At least with Intel drivers, deepcolor visuals may be of BGR format isntead of RGB like on Nvidia. Skia recently added support for 30bpp BGR formats [1], so use this new format to support this configuration. [1] https://skia.googlesource.com/skia/+/f7eb0544a8853eb087e20a0e5e7bc3597de02074 R=mtklein Bug: 1016383 Change-Id: I22ffd649f7cfd7c6ed132250dee35c7960210fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052206 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740804}
-
kylechar authored
The UMA has expired and hasn't been used lately. Remove it and associated plumbing. The UMA was set across processes so this involves mojo IPC. Also change where the SurfaceSynchronizationEvent traces are collected. Record a trace for all synchronization events, they might be useful and are pretty low volume, with the corresponding SurfaceId. This allows simplification of SurfaceObserver by not plumbing |duration| around. Bug: 1036988 Change-Id: I5661fe56a7c9129de458faf37f1cad6a1c13c6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047451Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#740803}
-
Regan Hsu authored
* Remove dup of syncAdvancedPageTitle * Move strings out of shared string provider to browser and OS, since browser version has a chromeOS browser version and a DICE enabled version of sync sign out dialog strings Bug: 967888 Change-Id: Ia9fbec3d8c26727857ccd083a7d65f25abe01f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048663 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#740802}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/378c0f1b0817..56690232104c git log 378c0f1b0817..56690232104c --date=short --first-parent --format='%ad %ae %s' 2020-02-12 tvanderlippe@chromium.org Migrate coverage/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Add javascript source formatting e2etest 2020-02-12 tvanderlippe@chromium.org Migrate formatter_worker/ to import cross-module 2020-02-12 jacktfranklin@chromium.org Prefer eslint-mocha for linting `.only` in tests 2020-02-12 aerotwist@chromium.org Enable colored output from test subprocesses 2020-02-12 tvanderlippe@chromium.org Migrate performance_monitor/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate perf_ui/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate screencast/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@56690232104c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ab6a43b774bb622d6bde1e4efc789c529fae022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052100Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740801}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGImage> and DynamicTo<SVGImage> as new downcast helper 2. Use IsA<SVGImage>(element) in place of IsSVGImage(element) Bug: 891908 Change-Id: I1d64a5726953fa0d637ce352985ae7f466361b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032450Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#740800}
-
Olle Liljenzin authored
Adds a dedicated fuzzer for LookupStringInFixedSet() as the function is no longer tested by the GetDomainAndRegistry fuzzer. The fuzzer is using a forward generated DAFSA based on the public suffix list and reuses the dictionary from the GetDomainAndRegistry fuzzer. BUG=1048702 Change-Id: If123985c60efab57faddaa934e6674042dd4d07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050498Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Olle Liljenzin <ollel@opera.com> Cr-Commit-Position: refs/heads/master@{#740799}
-
Sigurdur Asgeirsson authored
There is no safe way to allocate a crashpad::Annotation other than in global or static storage. This CL fixes the UAF that occurs if the ActivityTrackerAnnotationTest::RegistersOnFirstSet runs before any other test that calls crash_reporter::ResetCrashKeysForTesting. Bug: 2051194 Change-Id: I140ee80bac6379e181664d9b7db3db3b76854636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051533Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740798}
-
Yicheng Li authored
This change implements the MakeCredential operation in ChromeOS authenticator. The authenticator data is extracted from the dbus response returned by ChromeOS platform daemons. Bug: b:144861739 Change-Id: I4332a973e75aa900e348658bd639c7a78335caa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986976Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#740797}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-4028.0-1580727432-benchmark-81.0.4044.4-r1 to 82-4028.0-1580727110-benchmark-81.0.4044.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifcc2b0c383c85e8e89e18535c6a58febe6fa4e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052192Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/6b138fb083cf..4ab0c36c448d git log 6b138fb083cf..4ab0c36c448d --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jophba@chromium.org Add command line argument to enable trace logging Created with: gclient setdep -r src/third_party/openscreen/src@4ab0c36c448d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I8c2b7dd422b28723140bf80cca5cec6b78300da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051721Reviewed-by:
-
Kristi Park authored
This reverts commit ad16c6ff. Reason for revert: Suspected cause of recent flakes for __main__.ChromeDriverSecureContextTest.testAddCredentialBase64Errors https://ci.chromium.org/p/chromium/builders/try/mac-rel/301082 Original change's description: > [ChromeDriver] After test timeout, trigger crash > > After a test times out during a ChromeDriver command, trigger a Chrome > crash and a minidump collection for troubleshooting. This is not > available on tests connecting to a remote browser, or when running on > Android. > > > Bug: 1045241 > Change-Id: I3cb82d95875d0f58a4acee69d249a92801b8024b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032238 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Tricia Crichton <triciac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740311} TBR=johnchen@chromium.org,triciac@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045241, 1051383 Change-Id: I851c1b636f7ae43a6c23e01f00f3d093b58cc235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050676Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740794}
-
Etienne Bergeron authored
Adding the SQL category to chase bugs from crbug/1051180. R=etiennep@chromium.org, oysteine@chromium.org Bug: 1051180 Change-Id: Ibc6c125bb49c27060fec139fbe53d9fcb89a510c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050751Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740793}
-
Hiroshige Hayashizaki authored
This CL adds HTTPS->HTTP direct cases for mixed-content tests. The requests are rejected not in initial requests, but during redirect handling. The added tests expose the following issues on Chromium: Issue 1048619: - gen/top.http-rp/opt-in/sharedworker-import-data/cross-https.swap-scheme.https.html - gen/top.http-rp/opt-in/sharedworker-import-data/same-https.swap-scheme.https.html Issue 1050826: Requests are blocked as expected but no events are fired, causing test timeout. - gen/top.http-rp/opt-in/object-tag/cross-https.swap-scheme.https.html - gen/top.http-rp/opt-in/object-tag/same-https.swap-scheme.https.html Bug: 1048619, 1050826, 906850 Change-Id: I0aaa88788a28a20cd95b3dbfb078481c20786bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047823Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#740792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16cb8948..f4ae4cac Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2ce695d88e7c5dbd782768c2bd0524f9fe8cfe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051199Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740791}
-
Morten Stenshorne authored
That virtual testsuite already runs with LayoutNGFragmentItem enabled, so it's not useful to run them on the layout-ng-fragment-item bot. Change-Id: Ic83a90c42452501cd004bb974c5538741e84cd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050282Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#740790}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4a19a53d5a89..8930cc96188c git log 4a19a53d5a89..8930cc96188c --date=short --first-parent --format='%ad %ae %s' 2020-02-12 wl@gnu.org * src/sfnt/ttcmap.c (tt_face_build_cmaps): Ignore version (#57708). Created with: gclient setdep -r src/third_party/freetype/src@8930cc96188c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ia60d72bf6ce474bd5b145b43600c47f5ac89005b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051715Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#740789}
-
Lily Chen authored
Bug: None Change-Id: I4ef11b0de0221d0350986b1701d7d841a71593f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051539 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#740788}
-
Philip Rogers authored
When an intersection observation update is required, frames are temporarily un-throttled with a "forced" update until viewport intersections are updated post-lifecycle. These forced updates only need to run to LayoutClean so ShouldThrottleRendering returns true only if the local frame root is in a lifecycle update and is >= LayoutClean. This means that ShouldThrottleRendering returns different values depending on if it is called inside a lifecycle update. A call to LocalFrameView::UpdateAllLifecyclePhases can return true after updating all non-throttled frames but a subsequent loop over non-throttled frames can find frames that are not in the PaintClean lifecycle state. This leads to crashes (e.g., go/crash/dfb200b07b15575b). This patch changes the intersection observer throttling override to only apply during lifecycle updates. Outside of lifecycle updates, frames that did partially-throttled lifecycle updates are still considered throttled. Bug: 1041252 Change-Id: I1219df0dfbf6c3ca575f5ac6bb5214e3bebeb346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045586Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#740787}
-
Reilly Grant authored
This reverts commit 00f576f2. Reason for revert: Failed build was missing the expectation changes from this CL. Original change's description: > Revert "[Shape Detection] Use IDL dictionaries for result types" > > This reverts commit bae2a7ee. > > Reason for revert: Suspect for failing webkit_layout_tests on (none) > GPU on Mac > https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/51385 > > Original change's description: > > [Shape Detection] Use IDL dictionaries for result types > > > > This change updates the DetectedBarcode, DetectedFace and DetectedText > > types to be dictionaries rather than interfaces. This is okay because > > they have only attributes and no methods. This reduces the amount of > > manually written code necessary to implement them. > > > > This enables implementing a new field for issue 1023177 without having > > to update the manual serialization and deserialization routines. > > > > Spec PR: https://github.com/WICG/shape-detection-api/pull/86 > > > > Bug: 1023177 > > Change-Id: I3b93d1869c5457e2ce3da5b5690a5ff968a3c77c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040378 > > Auto-Submit: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Victor Costan <pwnall@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#740356} > > TBR=yukishiino@chromium.org,jbroman@chromium.org,reillyg@chromium.org,haraken@chromium.org,pwnall@chromium.org > > Change-Id: Ib2075266871bdae5651e684ac652617de91e2bb2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1023177 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049945 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740493} TBR=yukishiino@chromium.org,jbroman@chromium.org,reillyg@chromium.org,haraken@chromium.org,pwnall@chromium.org,kristipark@chromium.org Change-Id: Ib66d8b28cff5650c608c4e995fea350cedcf313f Bug: 1023177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049947Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55b137ca7dd9..79f336d0743a git log 55b137ca7dd9..79f336d0743a --date=short --first-parent --format='%ad %ae %s' 2020-02-12 csmartdalton@google.com Remove GrPrimitiveType from GrMesh 2020-02-12 robertphillips@google.com Remove legacy debugging print outs 2020-02-12 egdaniel@google.com Have GrProcessorTestData hold views instead of proxies. 2020-02-12 mtklein@google.com try release MSAN jobs 2020-02-12 mtklein@google.com make SkBBH a public interface 2020-02-12 mtklein@google.com calculate root bounds directly Created with: gclient setdep -r src/third_party/skia@79f336d0743a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: If6f96b15643b75c75f283ddb98b44b168b947465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052189Reviewed-by:
-
John Emau authored
Problem: When an element with aria role "menu" is made a direct child of a shadow root the browser will crash with a DCHECK. Root cause: The FlatTreeTraversal class [asserts shadow roots are not visited during traversal][1]. AxNodeObject::SiblingWithAriaRole passes will pass a shadow root to the FlatTreeTraversal via LayoutTreeBuilderTraversal if the node starting the search as a shadow root for a parent. Solution: Use LayoutTreeBuilderTraversal::Parent(*node) instead of node->parentNode() to get the parent of sibling nodes in AxNodeObject::SiblingWithAriaRole. Additionally this change adds a test to ensure there is no crash when an element with aria-role menu has a shadow root parent. [1]: https://crrev.com/d9756248c2/third_party/blink/renderer/core/dom/flat_tree_traversal.h?#48 Bug: 972755 Change-Id: I5db1ca1cc93bc499d555c9d042a059588f376578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652305Reviewed-by:
John Emau <John.Emau@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740784}
-
Dongheun Kang authored
The existing code had problems when parsing parameter's attribute that included multi-parameters or parameter names. Improved to handle all parameters. Bug: 1041986 Change-Id: I8ddd97e1d53be84b095d9dcdd487cef24000d86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989298 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740783}
-
Kai Ninomiya authored
e.g.: wpt_internal/webgpu/cts.html?worker=0&q=cts:validation/ERROR becomes: wpt_internal/webgpu/cts.html?worker=0&q=cts:validation/createBindGroupLayout: Bug: None Change-Id: I40378b9fa31054b0ce34adba1228482b23d476cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051297 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#740782}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fede4e54026..28b3e362d5ed Created with: gclient setdep -r src-internal@28b3e362d5ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701 Tbr: jbudorick@google.com Change-Id: I31ce35b1ed60c701c0773b7ee5d9f32541d6675c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052186Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740781}
-
Kristi Park authored
Workaround to prevent screenreaders from announcing a useless alert (e.g. "alert Send") when the initial "Send" animation is shown. Bug: 1016787 Change-Id: I62fd2119d56edd86b77729999a38936ee5c509e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049835 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#740780}
-
Rossana Monteriso authored
This CL adds the grid-gutters-and-alignment test to the WPT project, adapted from browser specific tests. The corresponding outdated test is being removed from the fast/css-grid-layout folder. Change-Id: I07acf8ad8ccdd7e2ec8b12e76899e2135b99e068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047031 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#740779}
-
Li Lin authored
Bug: 1050763 Test: unit tests Change-Id: Ib0b2f97ee7233789b4209cc3a72833a5c07ac5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048026Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740778}
-
Daniel Rubery authored
This CL makes two improvements to the CSD model management. First, it allows a customizable threshold in the ClientSideModel, rather than hard-coding 0.5. It also allows the user to run a custom model for testing with the command-line flag: --csd-model-override=/path/to/model Fixed: 1029975, 1030723 Change-Id: I0bd5814ca1c0ba615c292b4566b731629f70bd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040432 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#740777}
-
Kenichi Ishibashi authored
ServiceWorkerDatabase::RegistrationData will become a mojo struct. As a preparation, this CL changes the type of |used_features| from std::set to std::vector as the mojo IDL doesn't provide a set. Bug: 1046335 Change-Id: I6fdcb12e2930f3f74e8b2e4eeae9a52efc072a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040795 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740776}
-
