- 27 Sep, 2020 9 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601143179-1807d013279f571b26d42737d0da6c008dd25766.profdata to chrome-mac-master-1601161893-754a2aafc98ad7a6afd910c0b7dd36e782bfe76d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib976d6e3040067f412fa44b4903e8043f42b968f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811032}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601143179-7e0fff784977a232da08a71c4f8ef38f5aa5597c.profdata to chrome-linux-master-1601161893-c98711c556128fe090127be76465e02b263358c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I452d22410810f73db2b1b1e48dfbeb3348e6723c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433597Reviewed-by:
-
Claude van der Merwe authored
The following changes are made: 1. WifiSyncFeatureManager is injected into FeatureStateManager. 2. PerformSetFeatureEnabledState relies on WifiSyncFeatureManager to set enable/disable Wifi Sync, which acts as a global toggle. 3. GetEnabledOrDisabledState relies on WifiSyncFeatureManager to get the enabled/disabled state for Wifi Sync. 4. Add fakes for WifiSyncFeatureManager to be used in feature_state_manager_impl unittests Bug: 1117619 Change-Id: I68e6cad0e9d878d4029dea9cfeedc52dcee4a4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419451 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#811030}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dff9331631e4..6f521921351e 2020-09-26 syoussefi@chromium.org Vulkan: Use one triangle for full-screen utils 2020-09-26 syoussefi@chromium.org Revert "Add a small unit test that dumps system info." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I62e4b00da2b954fa5539d79b8e5698e9315ccabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433531Reviewed-by:
-
Reilly Grant authored
On systems with both the built-in serial driver and a third-party driver the same port can be enumerated more than once. This difference is visible to the user in the device path shown in the chooser but was previously ignored when constructing a persistent ID for the port. This patch replaces the generic persistent ID field with the individual components that are available on each platform. This should make it easier to modify these rules over time as the components won't be opaque to SerialChooserContext. This is a breaking change which will cause previously granted persistent permissions to be ignored. On macOS the name of the USB driver (the parent of the BSD serial port) is now included in the set of fields used to identify a device in order to differentiate between USB devices with otherwise have the same USB vendor ID, product ID and serial number. Bug: 1127535 Change-Id: If1b06ab82a975976e1e3b7d2075216f11afda5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413176 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811028}
-
Antonio Gomes authored
Some constants in ash_constants.h are used in BrowserNonClientFrameViewAsh. In order to make this class available to lacros, these constants need to be factored out, once lacros chrome can not link to ash symbols. The following constants are moved: ash::kDefaultFrameColor ash::kResizeAreaCornerSize ash::kResizeInsideBoundsSize ash::kResizeOutsideBoundsSize ash::kResizeOutsideBoundsScaleForTouch now under the `chromeos` namespace. Also, CL adds a README.md to chromeos/ui directory. This is phase 2.2 on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org Change-Id: I01cf20ed5a77f752fee2c72df0d5cb0cf42125a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429441Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#811027}
-
Kyle Horimoto authored
Bug: 1132577 Change-Id: I8b74aabd4153f18ad823ac4d5384a2c0d47afa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433063 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811026}
-
Mei Liang authored
crrev.com/c/2399314 uses a focusable PopupWindow for accessibility support. The focusable PopupWindow catches the system back button event and dismisses the PopupWindow directly without going through the TabSelectionEditorMediator#hide, where it updates the TabSelectionEditorProperties#IS_VISIBLE property from true to false. The TabSelectionEditorProperties#IS_VISIBLE remains to be true. Then TabSelectionEditorMediator#show is called again to show the TabSelectionEditor has no effects. Since there is no property change, the binder will not get triggered. This CL fixes the issue by setting the TabSelectionEditorMediator#hide as a Runnable to the TabSelectionEditorProperties, then binding it to the TabSelectionEditorLayout and triggering the Runnable when the PopupWindow is dismissed. Everything introduced in this CL is gated by by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout". Most of the code is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. The changes in following files can't be verified by the tool, but it is expected and no-op without the flags: * The new property in TabSelectionEditorProperties Bug: 1132478 Change-Id: I774d13714445e76da9c9ef4573412b62bf042039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432969 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811025}
-
Claude van der Merwe authored
WifiFeatureManager adds global enable/disable functionality for Wifi Sync V2. WifiFeatureManager asynchronously enables/disables WIFI_SYNC_HOST for a synced device on the back-end, and provides retry logic if the network request fails by storing the last pending request in prefs. Bug: 1117619 Change-Id: Ide945c00e5eb060dd86b11b31e1a830aa1fde3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419332 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
-
- 26 Sep, 2020 31 commits
-
-
Sharon Yang authored
Make sure video decoding is only enabled when the feature flag HARDWARE_VIDEO_DECODER is set. Bug: 1004461 Change-Id: I1fca519539a508c6b59e8997db11d1efe112940e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363174 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811023}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_h8KubnXkcH - Diagnostics Page (after) http://shortn/_PLo7f0AOfM Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I40c8d6cccc9e42457047f9dd79f74ab568e91596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426967 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#811022}
-
Yuly Novikov authored
Cover GTX 1660 in addition to Quadro P400. TBR=bsheedy Bug: 1060024 Change-Id: Ic94428628ec6fa7fc3c53f92651850225626046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433309Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811021}
-
Ben Pastene authored
With crrev.com/c/2432127, every CrOS HW test has the --flash arg embedded into the generated wrapper script. So some tests now have '--flash' show up twice on their cmd line. This'll fix that. This also removes the unrelated but old "--vm-logs-dir" arg that's no longer used. Bug: 1132373 Change-Id: If595fdb4ab4f747c547082d7a210be17c9ecd431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432851 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#811020}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc972dc72cd9..25acdad71bae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Id8c207ce58e07e642f59d0e3ccca91fce3cd323d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811019}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc4e3cf24f9b..dff9331631e4 2020-09-26 jmadill@chromium.org Add Skia Gold CIPD package to DEPS. 2020-09-26 cclao@google.com Vulkan: Move mReadOnlyDepth out of FramebufferDesc 2020-09-26 cclao@google.com Vulkan: Use DepthStencilReadOnly when it is read only. 2020-09-26 jmadill@chromium.org Add a small unit test that dumps system info. 2020-09-25 syoussefi@chromium.org Vulkan: Workaround vkCmdClearAttachment bug on Pixel 2020-09-25 jmadill@chromium.org Enable Vulkan SystemInfo on more platforms. 2020-09-25 syoussefi@chromium.org Vulkan: Make UtilsVk not contribute to occlusion queries 2020-09-25 ynovikov@chromium.org Skip BootAnimationTest.DefaultBootAnimation on Win NVIDIA Vulkan 2020-09-25 timvp@google.com Vulkan: Link PPO during draw validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: dEQP.GLES31/functional_separate_shader_validation_es31_* Change-Id: I018e6f8c72d7ea2ed7890fa76364da281148d9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433508Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5b4d110a2b90..0081a12803bf 2020-09-26 brucedawson@chromium.org Miscellaneous fixes to post_build_ninja_summary.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:941669 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I05b5c2c4f08bfbcda0d48702da2f969ed6307342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433518Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2bf6561211e0ef1be91c8f4a06b2dfcd4505f475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433516Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601120384-3673cc2f8767c2ae76b18a20724f2e99ef5174cb.profdata to chrome-mac-master-1601143179-1807d013279f571b26d42737d0da6c008dd25766.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I70094780c52c621236a5d69dbff41741988413f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433517Reviewed-by:
-
Keishi Hattori authored
NOT_DESTROYED() will be used to ensure LayoutObject is not used after the Destroy() call once LayoutObject is moved to GarbageCollected. NOT_DESTROYED() should be the first statement for all methods on LayoutObject and its subclasses. Bug: 1030176 Change-Id: If20c810b925ed0a9bd6df36ea75dc4bdd3b0b147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426210 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#811014}
-
Xianzhu Wang authored
When we switch on "create layers after paint" and back, the contents of the original GraphicsLayer::CcLayer() and RasterInvalidator which are not used during "create layers after paint" may not be valid. Invalidate them to ensure correct rendering. Bug: 1132218 Change-Id: Ia717e8202e2627cedbc9e5305619223a5a833f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432766Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811013}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601120384-ccbe20c9dce38060cfc0c250cd4b8585e6424eb6.profdata to chrome-linux-master-1601143179-7e0fff784977a232da08a71c4f8ef38f5aa5597c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I346e705ef76f4b574574927890bf4198065442ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433515Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4262.0-1600690455-benchmark-87.0.4274.0-r1 to 87-4262.0-1600690455-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ief8ad06528ef242e6036d32a113faacd2948e691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433514 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie88132967e5eb3e66096ddc99bcc00270167c3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432288Reviewed-by:
-
Tibor Goldschwendt authored
Screenshot: https://screenshot.googleplex.com/8XenkGQNbhfpQKv Fixed: 1130855 Change-Id: Ieb2ab938047b5fcc4fe1bc689661369ec5bf22c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431783 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811009}
-
Caleb Raitto authored
This includes supporting MaybeShared and raw pointers in addition to NotShared, and supporting all view types. Bug: 973801 Change-Id: I6bf50dbda181ee33a47b12618601302eb50dba98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432813 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#811008}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5fadda5c3cf995619bb17aa2da01ca86584724a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432128 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
-
Gayane Petrosyan authored
When TextFragmentFinder finds no match for the provided selector, TextFragmentSelectorGenerator should be notified so that it notifies the user that generation failed. As selector provided by TextFragmentSelectorGenerator is constructed for the selection from the user, this can happen only if selector is incorrectly constructed. Bug: 1129649 Change-Id: I10b5a49602128b532166a66354faa905493fb7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426464 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811006}
-
David Bienvenu authored
This reverts commit 085b583f. Reason for revert: <crbug.com/1132543> Original change's description: > Make Launch.Modes an enum histogram, not sparse. > > In response to comment on crrev.com/c/2384332. > > Per mpearson@: For enums versus sparses, the underlying UMA > data / logs will look the same. It's only the implementation > in Chromium that would be different. > > Change-Id: Ia75d78379977f36ec7873d5fb5d52998e6a366d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429975 > Reviewed-by: Peter Boström <pbos@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810438} TBR=pbos@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia7edc131b855a4ceb384b8e2d76055386d1044c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433060Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811005}
-
Dirk Pranke authored
In an email to a Google-internal group a while ago I talked about the various mechanisms we potentially have for disabling tests and their advantages and disadvantages. This seems like something worth preserving, so I'm moving it into a doc checked into the repo. Change-Id: If8288eac8704354c92ffe12b9e79c930e0738c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419612 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#811004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/766eeb2ac325..eabce08bb2f2 2020-09-26 mtklein@google.com move paint color to Params 2020-09-26 mtklein@google.com Revert "moved SkSL BoolLiteral data into IRNode" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I2bf8276142f973e909b706682182952f1d340f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433509Reviewed-by:
-
Haiyang Pan authored
This reverts commit 57b51303. Reason for revert: Likely the causes of test failures in FileSystemChooserBrowserTest.* and NativeFileSystemDragDropBrowserTest.* in a couple of android builders. Examples are: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/190 * https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27111 * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2737 Original change's description: > [FS] Remove Native File System base::Feature. > > The base::Feature has been enabled by default for many many milestones > now, so it seems unlikely we'd ever want to turn it off again. Remove it > to make code simpler to maintain. > > Embedders can still turn off the API using the blink runtime feature. > > Change-Id: Ifad92d39adac1e656cf75a02918f33409aea44ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427287 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810742} TBR=dcheng@chromium.org,tapted@chromium.org,michaelpg@chromium.org,mek@chromium.org,pwnall@chromium.org,lucmult@chromium.org Change-Id: I70017eb9fe7c77e84d04341a061e0fa4fa22305e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433308Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#811002}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600681610-benchmark-87.0.4274.0-r1 to 87-4247.0-1600681610-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5cf1e4a4778d7ddbb09630d52ff742666eaf6543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433511Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bacaef3237c5..1815d86a224b 2020-09-26 cstout@chromium.org [Wconversion] Suppress glslang issue (#2404) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I73671d6a27099470855c55dcf2f63346ae3d394b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433544Reviewed-by:
-
Jordan Bayles authored
This patch rolls JsonCpp to HEAD. Bug: 989851 Change-Id: I062f7d398190b61a66d48952b7504848ab1d75ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433107Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#810999}
-
Fredrik Söderqvist authored
Tbr: schenney@chromium.org Bug: 1128962 Change-Id: If37cdb8571920fa42844d50455451f0f7d4dfdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431969Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#810998}
-
Roman Arora authored
Updated screenshots: Default view: https://drive.google.com/file/d/1KLzsAnrQa4UomlH4HtWpUeRyhZzo315E/view FixedEntrypoint view (guarded by chrome UI flag): https://drive.google.com/file/d/1nHTx-GdNtOJBN6Zxp-YMh3E6zPYnXSYE/view Bug: 1128599 Change-Id: I0db6a5400ff0cd8e5558576ec59537e0288d2b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427103Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#810997}
-
Asanka Herath authored
There's a few more on the way so let's move them into a separate directory. Bug: 973801 Change-Id: I94b638b7d6bae045502fc2265fd644a567416cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432863 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Dylan Cutler <dylancutler@google.com> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#810996}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/2be1c17fda0d..a5548b3d5782 $ git log 2be1c17fd..a5548b3d5 --date=short --no-merges --format='%ad %ae %s' 2020-09-25 junyer Point to the official Python wrapper. 2020-09-25 junyer Disable fail-fast in GitHub Actions. 2020-09-25 junyer Fix a template that will break with GCC 11.x. 2020-09-22 junyer Try to use the Clang packages instead. 2020-09-22 junyer Try to make the Clang containers work. 2020-09-22 junyer Configure a build matrix for Clang using containers. 2020-09-22 junyer Address `-Wclass-memaccess' warnings from GCC 10.x. 2020-09-22 junyer Configure a build matrix for GCC using containers. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I79a4dafa2eba5e18966dd637ca5b5b144bcc56e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433249 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810995}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a8e978ac76a8..7950eb55c076 2020-09-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba8f3a94a5f6ff76b06d8cf1adb48c99e1072e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432213Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4258.0-1600689257-benchmark-87.0.4265.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iec678436180a1e4281e17421a6b06a3cdd0f174c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432221Reviewed-by:
-
